)]}'
{"deployment/puppet/osnailyfacter/lib/puppet/parser/functions/get_ssl_property.rb":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"aedd88f13662a02e716e139b6dec7bc8c3123825","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Return:"},{"line_number":13,"context_line":" value for resource type you asked"},{"line_number":14,"context_line":"EOS"},{"line_number":15,"context_line":"  ) do |args|"},{"line_number":16,"context_line":"    use_ssl_hash \u003d args[0]"},{"line_number":17,"context_line":"    public_ssl_hash \u003d args[1]"},{"line_number":18,"context_line":"    service_name \u003d args[2]"}],"source_content_type":"text/x-ruby","patch_set":22,"id":"9a8ffd7b_e62e28a4","line":15,"updated":"2015-11-27 15:12:40.000000000","message":"use_ssl_hash, public_ssl_hash, service_name, service_type, resource_type, default_value \u003d *args\n\nfail if args.length !\u003d 5","commit_id":"438004895b04b2b84cc907bc5de57b62269560d5"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"592bce9945069a392a7bd2ac163d493fb29d129e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Return:"},{"line_number":13,"context_line":" value for resource type you asked"},{"line_number":14,"context_line":"EOS"},{"line_number":15,"context_line":"  ) do |args|"},{"line_number":16,"context_line":"    use_ssl_hash \u003d args[0]"},{"line_number":17,"context_line":"    public_ssl_hash \u003d args[1]"},{"line_number":18,"context_line":"    service_name \u003d args[2]"}],"source_content_type":"text/x-ruby","patch_set":22,"id":"9a8ffd7b_8c5adbf0","line":15,"in_reply_to":"9a8ffd7b_e62e28a4","updated":"2015-11-27 15:26:48.000000000","message":"Done","commit_id":"438004895b04b2b84cc907bc5de57b62269560d5"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"aedd88f13662a02e716e139b6dec7bc8c3123825","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    default_value \u003d args[5]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    rval \u003d false"},{"line_number":24,"context_line":"    fail \"You should provide hash as a first argument!\" if not use_ssl_hash.kind_of?(Hash)"},{"line_number":25,"context_line":"    fail \"You should provide hash as a second argument!\" if not public_ssl_hash.kind_of?(Hash)"},{"line_number":26,"context_line":"    fail \"You should provide \u0027name\u0027 for service as a third argument!\" if service_name.empty?"},{"line_number":27,"context_line":"    fail \"You should provide \u0027type\u0027 for service as a fourth argument!\" if service_type.empty?"}],"source_content_type":"text/x-ruby","patch_set":22,"id":"9a8ffd7b_716d10cb","line":24,"updated":"2015-11-27 15:12:40.000000000","message":"I would use is_a Hash\n\nMore details can be obtained here\n\nhttp://stackoverflow.com/questions/3893278/ruby-kind-of-vs-instance-of-vs-is-a\n\nDo we need to verify if Hash is empty {}?","commit_id":"438004895b04b2b84cc907bc5de57b62269560d5"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"592bce9945069a392a7bd2ac163d493fb29d129e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    default_value \u003d args[5]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    rval \u003d false"},{"line_number":24,"context_line":"    fail \"You should provide hash as a first argument!\" if not use_ssl_hash.kind_of?(Hash)"},{"line_number":25,"context_line":"    fail \"You should provide hash as a second argument!\" if not public_ssl_hash.kind_of?(Hash)"},{"line_number":26,"context_line":"    fail \"You should provide \u0027name\u0027 for service as a third argument!\" if service_name.empty?"},{"line_number":27,"context_line":"    fail \"You should provide \u0027type\u0027 for service as a fourth argument!\" if service_type.empty?"}],"source_content_type":"text/x-ruby","patch_set":22,"id":"9a8ffd7b_8c117b06","line":24,"in_reply_to":"9a8ffd7b_716d10cb","updated":"2015-11-27 15:26:48.000000000","message":"Done","commit_id":"438004895b04b2b84cc907bc5de57b62269560d5"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"aedd88f13662a02e716e139b6dec7bc8c3123825","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    rval \u003d false"},{"line_number":24,"context_line":"    fail \"You should provide hash as a first argument!\" if not use_ssl_hash.kind_of?(Hash)"},{"line_number":25,"context_line":"    fail \"You should provide hash as a second argument!\" if not public_ssl_hash.kind_of?(Hash)"},{"line_number":26,"context_line":"    fail \"You should provide \u0027name\u0027 for service as a third argument!\" if service_name.empty?"},{"line_number":27,"context_line":"    fail \"You should provide \u0027type\u0027 for service as a fourth argument!\" if service_type.empty?"},{"line_number":28,"context_line":"    fail \"You should provide \u0027type\u0027 for resource as a fifth argument!\" if resource_type.empty?"}],"source_content_type":"text/x-ruby","patch_set":22,"id":"9a8ffd7b_f1b8202c","line":25,"updated":"2015-11-27 15:12:40.000000000","message":"ditto","commit_id":"438004895b04b2b84cc907bc5de57b62269560d5"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"592bce9945069a392a7bd2ac163d493fb29d129e","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    rval \u003d false"},{"line_number":24,"context_line":"    fail \"You should provide hash as a first argument!\" if not use_ssl_hash.kind_of?(Hash)"},{"line_number":25,"context_line":"    fail \"You should provide hash as a second argument!\" if not public_ssl_hash.kind_of?(Hash)"},{"line_number":26,"context_line":"    fail \"You should provide \u0027name\u0027 for service as a third argument!\" if service_name.empty?"},{"line_number":27,"context_line":"    fail \"You should provide \u0027type\u0027 for service as a fourth argument!\" if service_type.empty?"},{"line_number":28,"context_line":"    fail \"You should provide \u0027type\u0027 for resource as a fifth argument!\" if resource_type.empty?"}],"source_content_type":"text/x-ruby","patch_set":22,"id":"9a8ffd7b_2cfdefb3","line":25,"in_reply_to":"9a8ffd7b_f1b8202c","updated":"2015-11-27 15:26:48.000000000","message":"Done","commit_id":"438004895b04b2b84cc907bc5de57b62269560d5"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"6fd0d796569fea2e684d8962de6f653199bf7644","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        get_variables \u003d function_try_get_value([use_ssl_hash, \"#{service_name}_#{service_type}_#{resource_type}\", \u0027\u0027])"},{"line_number":51,"context_line":"        rval \u003d function_pick([get_variables, *default_value])"},{"line_number":52,"context_line":"      else"},{"line_number":53,"context_line":"        rval \u003d function_pick(default_value)"},{"line_number":54,"context_line":"      end"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    when \u0027usage\u0027"}],"source_content_type":"text/x-ruby","patch_set":22,"id":"9a8ffd7b_f19260f5","line":53,"range":{"start_line":53,"start_character":29,"end_line":53,"end_character":42},"updated":"2015-11-27 15:20:06.000000000","message":"function_pick(default_value, false)","commit_id":"438004895b04b2b84cc907bc5de57b62269560d5"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"592bce9945069a392a7bd2ac163d493fb29d129e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        get_variables \u003d function_try_get_value([use_ssl_hash, \"#{service_name}_#{service_type}_#{resource_type}\", \u0027\u0027])"},{"line_number":51,"context_line":"        rval \u003d function_pick([get_variables, *default_value])"},{"line_number":52,"context_line":"      else"},{"line_number":53,"context_line":"        rval \u003d function_pick(default_value)"},{"line_number":54,"context_line":"      end"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    when \u0027usage\u0027"}],"source_content_type":"text/x-ruby","patch_set":22,"id":"9a8ffd7b_0cfeebad","line":53,"in_reply_to":"9a8ffd7b_f19260f5","updated":"2015-11-27 15:26:48.000000000","message":"Done","commit_id":"438004895b04b2b84cc907bc5de57b62269560d5"}],"deployment/puppet/osnailyfacter/lib/puppet/parser/functions/ssl.rb":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Puppet::Parser::Functions"},{"line_number":2,"context_line":"  newfunction(:ssl, :type \u003d\u003e :rvalue, :doc \u003d\u003e \u003c\u003c-EOS"},{"line_number":3,"context_line":"Get hashes with SSL data and returns values based on keys"},{"line_number":4,"context_line":"Parameters:"},{"line_number":5,"context_line":" use_ssl_hash - hash with data for all TLS settings of all services"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_4765c01b","line":2,"updated":"2015-11-27 11:15:32.000000000","message":"get_ssl_property is a better function name","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Puppet::Parser::Functions"},{"line_number":2,"context_line":"  newfunction(:ssl, :type \u003d\u003e :rvalue, :doc \u003d\u003e \u003c\u003c-EOS"},{"line_number":3,"context_line":"Get hashes with SSL data and returns values based on keys"},{"line_number":4,"context_line":"Parameters:"},{"line_number":5,"context_line":" use_ssl_hash - hash with data for all TLS settings of all services"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_3901bc05","line":2,"in_reply_to":"9a8ffd7b_4765c01b","updated":"2015-11-27 12:20:04.000000000","message":"Done","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Puppet::Parser::Functions"},{"line_number":2,"context_line":"  newfunction(:ssl, :type \u003d\u003e :rvalue, :doc \u003d\u003e \u003c\u003c-EOS"},{"line_number":3,"context_line":"Get hashes with SSL data and returns values based on keys"},{"line_number":4,"context_line":"Parameters:"},{"line_number":5,"context_line":" use_ssl_hash - hash with data for all TLS settings of all services"},{"line_number":6,"context_line":" public_ssl_hash - auxiliary hash with data for public TLS settings"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_87a88821","line":3,"updated":"2015-11-27 11:15:32.000000000","message":"Get SSL properties for services based on SSL hashes","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Puppet::Parser::Functions"},{"line_number":2,"context_line":"  newfunction(:ssl, :type \u003d\u003e :rvalue, :doc \u003d\u003e \u003c\u003c-EOS"},{"line_number":3,"context_line":"Get hashes with SSL data and returns values based on keys"},{"line_number":4,"context_line":"Parameters:"},{"line_number":5,"context_line":" use_ssl_hash - hash with data for all TLS settings of all services"},{"line_number":6,"context_line":" public_ssl_hash - auxiliary hash with data for public TLS settings"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_598040c0","line":3,"in_reply_to":"9a8ffd7b_87a88821","updated":"2015-11-27 12:20:04.000000000","message":"Done","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":6,"context_line":" public_ssl_hash - auxiliary hash with data for public TLS settings"},{"line_number":7,"context_line":" service_name - name of service for which data should be returned"},{"line_number":8,"context_line":" service_type - type of endpoint"},{"line_number":9,"context_line":" resource_type - type of data needed to be got"},{"line_number":10,"context_line":" default_value - array with potentially default values to pick"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Return:"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_a7b90c17","line":9,"updated":"2015-11-27 11:15:32.000000000","message":"got -\u003e retrieved","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":6,"context_line":" public_ssl_hash - auxiliary hash with data for public TLS settings"},{"line_number":7,"context_line":" service_name - name of service for which data should be returned"},{"line_number":8,"context_line":" service_type - type of endpoint"},{"line_number":9,"context_line":" resource_type - type of data needed to be got"},{"line_number":10,"context_line":" default_value - array with potentially default values to pick"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Return:"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_99722810","line":9,"in_reply_to":"9a8ffd7b_a7b90c17","updated":"2015-11-27 12:20:04.000000000","message":"Done","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":7,"context_line":" service_name - name of service for which data should be returned"},{"line_number":8,"context_line":" service_type - type of endpoint"},{"line_number":9,"context_line":" resource_type - type of data needed to be got"},{"line_number":10,"context_line":" default_value - array with potentially default values to pick"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Return:"},{"line_number":13,"context_line":" value for resource type you asked"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_471aa07e","line":10,"updated":"2015-11-27 11:15:32.000000000","message":"Mark this as optional","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":7,"context_line":" service_name - name of service for which data should be returned"},{"line_number":8,"context_line":" service_type - type of endpoint"},{"line_number":9,"context_line":" resource_type - type of data needed to be got"},{"line_number":10,"context_line":" default_value - array with potentially default values to pick"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Return:"},{"line_number":13,"context_line":" value for resource type you asked"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_d953d069","line":10,"in_reply_to":"9a8ffd7b_471aa07e","updated":"2015-11-27 12:20:04.000000000","message":"I make it not optional instead.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    rval \u003d false"},{"line_number":24,"context_line":"    fail \"You should provide hash as a first argument!\" if not use_ssl_hash.kind_of?(Hash)"},{"line_number":25,"context_line":"    fail \"You should provide hash as a second argument!\" if not public_ssl_hash.kind_of?(Hash)"},{"line_number":26,"context_line":"    fail \"You should provide \u0027name\u0027 for service!\" if service_name.empty?"},{"line_number":27,"context_line":"    fail \"You should provide \u0027type\u0027 for service!\" if service_type.empty?"},{"line_number":28,"context_line":"    fail \"You should provide \u0027type\u0027 for resource!\" if resource_type.empty?"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_625472fe","line":26,"updated":"2015-11-27 11:15:32.000000000","message":"include \"third argument\"","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    rval \u003d false"},{"line_number":24,"context_line":"    fail \"You should provide hash as a first argument!\" if not use_ssl_hash.kind_of?(Hash)"},{"line_number":25,"context_line":"    fail \"You should provide hash as a second argument!\" if not public_ssl_hash.kind_of?(Hash)"},{"line_number":26,"context_line":"    fail \"You should provide \u0027name\u0027 for service!\" if service_name.empty?"},{"line_number":27,"context_line":"    fail \"You should provide \u0027type\u0027 for service!\" if service_type.empty?"},{"line_number":28,"context_line":"    fail \"You should provide \u0027type\u0027 for resource!\" if resource_type.empty?"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_39f0dc66","line":26,"in_reply_to":"9a8ffd7b_625472fe","updated":"2015-11-27 12:20:04.000000000","message":"Done","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    fail \"You should provide hash as a first argument!\" if not use_ssl_hash.kind_of?(Hash)"},{"line_number":25,"context_line":"    fail \"You should provide hash as a second argument!\" if not public_ssl_hash.kind_of?(Hash)"},{"line_number":26,"context_line":"    fail \"You should provide \u0027name\u0027 for service!\" if service_name.empty?"},{"line_number":27,"context_line":"    fail \"You should provide \u0027type\u0027 for service!\" if service_type.empty?"},{"line_number":28,"context_line":"    fail \"You should provide \u0027type\u0027 for resource!\" if resource_type.empty?"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    check_ns_public \u003d service_type.to_s \u003d\u003d \u0027public\u0027"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_025566f8","line":27,"updated":"2015-11-27 11:15:32.000000000","message":"include \"fourth argument\"","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    fail \"You should provide hash as a first argument!\" if not use_ssl_hash.kind_of?(Hash)"},{"line_number":25,"context_line":"    fail \"You should provide hash as a second argument!\" if not public_ssl_hash.kind_of?(Hash)"},{"line_number":26,"context_line":"    fail \"You should provide \u0027name\u0027 for service!\" if service_name.empty?"},{"line_number":27,"context_line":"    fail \"You should provide \u0027type\u0027 for service!\" if service_type.empty?"},{"line_number":28,"context_line":"    fail \"You should provide \u0027type\u0027 for resource!\" if resource_type.empty?"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    check_ns_public \u003d service_type.to_s \u003d\u003d \u0027public\u0027"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_f9e574a3","line":27,"in_reply_to":"9a8ffd7b_025566f8","updated":"2015-11-27 12:20:04.000000000","message":"Done","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    fail \"You should provide hash as a second argument!\" if not public_ssl_hash.kind_of?(Hash)"},{"line_number":26,"context_line":"    fail \"You should provide \u0027name\u0027 for service!\" if service_name.empty?"},{"line_number":27,"context_line":"    fail \"You should provide \u0027type\u0027 for service!\" if service_type.empty?"},{"line_number":28,"context_line":"    fail \"You should provide \u0027type\u0027 for resource!\" if resource_type.empty?"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    check_ns_public \u003d service_type.to_s \u003d\u003d \u0027public\u0027"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_021ec65e","line":28,"updated":"2015-11-27 11:15:32.000000000","message":"Include \"fifth argument\"\n\nLet\u0027s validate num params \u003c7. It looks like you validate the first 5 and the 6th is optional","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    fail \"You should provide hash as a second argument!\" if not public_ssl_hash.kind_of?(Hash)"},{"line_number":26,"context_line":"    fail \"You should provide \u0027name\u0027 for service!\" if service_name.empty?"},{"line_number":27,"context_line":"    fail \"You should provide \u0027type\u0027 for service!\" if service_type.empty?"},{"line_number":28,"context_line":"    fail \"You should provide \u0027type\u0027 for resource!\" if resource_type.empty?"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    check_ns_public \u003d service_type.to_s \u003d\u003d \u0027public\u0027"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_19eb9879","line":28,"in_reply_to":"9a8ffd7b_021ec65e","updated":"2015-11-27 12:20:04.000000000","message":"Done","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/ceilometer/compute.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"$ssl_hash                   \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$keystone_protocol          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":34,"context_line":"$keystone_endpoint          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if ($ceilometer_enabled) {"},{"line_number":37,"context_line":"  class { \u0027openstack::ceilometer\u0027:"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_227f4a67","line":34,"updated":"2015-11-27 11:15:32.000000000","message":"service endpoint already defaults to management_vip. When are we using keystone_endpoint anywhere? It shouldn\u0027t be in our manifests either.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"5113a0b7aa054f54d5315c9ce5970a6f8deb3745","unresolved":false,"context_lines":[{"line_number":31,"context_line":"$ssl_hash                   \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$keystone_protocol          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":34,"context_line":"$keystone_endpoint          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if ($ceilometer_enabled) {"},{"line_number":37,"context_line":"  class { \u0027openstack::ceilometer\u0027:"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_e5adc784","line":34,"in_reply_to":"9a8ffd7b_19471878","updated":"2015-11-27 12:54:38.000000000","message":"It does: https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/modular/globals/globals.pp#L158-L165","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":31,"context_line":"$ssl_hash                   \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$keystone_protocol          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":34,"context_line":"$keystone_endpoint          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if ($ceilometer_enabled) {"},{"line_number":37,"context_line":"  class { \u0027openstack::ceilometer\u0027:"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_19471878","line":34,"in_reply_to":"9a8ffd7b_227f4a67","updated":"2015-11-27 12:20:04.000000000","message":"removed keystone_endpoint. But service_endpoint by default not point to management_vip, it\u0027s another statement.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"b30962e0f7907c385cbd57c5921e6ab8fb527625","unresolved":false,"context_lines":[{"line_number":31,"context_line":"$ssl_hash                   \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$keystone_protocol          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":34,"context_line":"$keystone_endpoint          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if ($ceilometer_enabled) {"},{"line_number":37,"context_line":"  class { \u0027openstack::ceilometer\u0027:"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_4006011e","line":34,"in_reply_to":"9a8ffd7b_e5adc784","updated":"2015-11-27 13:00:14.000000000","message":"It is now. But I don\u0027t want to rely on globals. If someone set service_endpoint to false, I want to have good default.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/ceilometer/controller.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"$api_bind_address           \u003d get_network_role_property(\u0027ceilometer/api\u0027, \u0027ipaddr\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"$keystone_protocol \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":65,"context_line":"$keystone_endpoint \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"if $ceilometer_hash[\u0027enabled\u0027] {"},{"line_number":68,"context_line":"  if $external_mongo {"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_42eb6e13","line":65,"updated":"2015-11-27 11:15:32.000000000","message":"same as deployment/puppet/osnailyfacter/modular/ceilometer/compute.pp","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":62,"context_line":"$api_bind_address           \u003d get_network_role_property(\u0027ceilometer/api\u0027, \u0027ipaddr\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"$keystone_protocol \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":65,"context_line":"$keystone_endpoint \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"if $ceilometer_hash[\u0027enabled\u0027] {"},{"line_number":68,"context_line":"  if $external_mongo {"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_f93814f0","line":65,"in_reply_to":"9a8ffd7b_42eb6e13","updated":"2015-11-27 12:20:04.000000000","message":"Done the same.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/glance/glance.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"$ssl_hash                       \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":56,"context_line":"$keystone_protocol              \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":57,"context_line":"$internal_ssl                   \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027usage\u0027, false)"},{"line_number":58,"context_line":"$keystone_endpoint              \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":59,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$management_vip])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"$auth_uri          \u003d \"${keystone_protocol}://${keystone_endpoint}:5000/\""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_42392ea3","line":58,"updated":"2015-11-27 11:15:32.000000000","message":"same as deployment/puppet/osnailyfacter/modular/ceilometer/compute.pp","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":55,"context_line":"$ssl_hash                       \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":56,"context_line":"$keystone_protocol              \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":57,"context_line":"$internal_ssl                   \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027usage\u0027, false)"},{"line_number":58,"context_line":"$keystone_endpoint              \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":59,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$management_vip])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"$auth_uri          \u003d \"${keystone_protocol}://${keystone_endpoint}:5000/\""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_f90fb436","line":58,"in_reply_to":"9a8ffd7b_42392ea3","updated":"2015-11-27 12:20:04.000000000","message":"Done the same.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/heat/heat.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"$public_auth_protocol     \u003d ssl($ssl_hash, $public_ssl_hash, \u0027keystone\u0027, \u0027public\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":17,"context_line":"$public_auth_address      \u003d ssl($ssl_hash, $public_ssl_hash, \u0027keystone\u0027, \u0027public\u0027, \u0027hostname\u0027, [$public_vip])"},{"line_number":18,"context_line":"$internal_auth_protocol   \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":19,"context_line":"$internal_auth_address    \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":20,"context_line":"$admin_auth_protocol      \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":21,"context_line":"$admin_auth_address       \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_62da324e","line":19,"updated":"2015-11-27 11:15:32.000000000","message":"why add a field \"address\"? It is clearly just a hostname, not a full address with protocol, port and path? Let\u0027s not make a synonym for hostname","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":16,"context_line":"$public_auth_protocol     \u003d ssl($ssl_hash, $public_ssl_hash, \u0027keystone\u0027, \u0027public\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":17,"context_line":"$public_auth_address      \u003d ssl($ssl_hash, $public_ssl_hash, \u0027keystone\u0027, \u0027public\u0027, \u0027hostname\u0027, [$public_vip])"},{"line_number":18,"context_line":"$internal_auth_protocol   \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":19,"context_line":"$internal_auth_address    \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":20,"context_line":"$admin_auth_protocol      \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":21,"context_line":"$admin_auth_address       \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_0c0cb839","line":19,"in_reply_to":"9a8ffd7b_62da324e","updated":"2015-11-27 12:20:04.000000000","message":"it actually can be an IP address. RFC doesn\u0027t forbid you to use SSL this way. So it just a matter of using this variable name.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"$internal_auth_protocol   \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":19,"context_line":"$internal_auth_address    \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":20,"context_line":"$admin_auth_protocol      \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":21,"context_line":"$admin_auth_address       \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"$heat_protocol            \u003d ssl($ssl_hash, {}, \u0027heat\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":24,"context_line":"$heat_endpoint            \u003d ssl($ssl_hash, {}, \u0027heat\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027heat_endpoint\u0027, \u0027\u0027), $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_22442a19","line":21,"updated":"2015-11-27 11:15:32.000000000","message":"same as deployment/puppet/osnailyfacter/modular/ceilometer/compute.pp","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":18,"context_line":"$internal_auth_protocol   \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":19,"context_line":"$internal_auth_address    \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":20,"context_line":"$admin_auth_protocol      \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":21,"context_line":"$admin_auth_address       \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"$heat_protocol            \u003d ssl($ssl_hash, {}, \u0027heat\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":24,"context_line":"$heat_endpoint            \u003d ssl($ssl_hash, {}, \u0027heat\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027heat_endpoint\u0027, \u0027\u0027), $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_ec1db462","line":21,"in_reply_to":"9a8ffd7b_22442a19","updated":"2015-11-27 12:20:04.000000000","message":"Done the same.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/openstack-controller/openstack-controller.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"$ssl_hash                       \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"$internal_auth_protocol         \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":39,"context_line":"$internal_auth_address          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"$glance_protocol                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":42,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027glance_endpoint\u0027, \u0027\u0027), $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_62c312ee","line":39,"updated":"2015-11-27 11:15:32.000000000","message":"same comment as deployment/puppet/osnailyfacter/modular/ceilometer/compute.pp","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":36,"context_line":"$ssl_hash                       \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"$internal_auth_protocol         \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":39,"context_line":"$internal_auth_address          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"$glance_protocol                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":42,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027glance_endpoint\u0027, \u0027\u0027), $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_cc40f036","line":39,"in_reply_to":"9a8ffd7b_62c312ee","updated":"2015-11-27 12:20:04.000000000","message":"Done the same.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027glance_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":43,"context_line":"$glance_ssl                     \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027usage\u0027, false)"},{"line_number":44,"context_line":"if $glance_ssl {"},{"line_number":45,"context_line":"  $glance_api_servers \u003d \"${glance_protocol}://${glance_endpoint}:9292\""},{"line_number":46,"context_line":"} else {"},{"line_number":47,"context_line":"  $glance_api_servers \u003d hiera(\u0027glance_api_servers\u0027, \"${management_vip}:9292\")"},{"line_number":48,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_a271fa45","line":45,"updated":"2015-11-27 11:15:32.000000000","message":"This breaks our override behavior. If glance_api_servers is present in hiera, it won\u0027t be used if glance_ssl is enabled. A plugin developer would have to disable glance_ssl in order to use custom glance_api_servers.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":42,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027glance_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":43,"context_line":"$glance_ssl                     \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027usage\u0027, false)"},{"line_number":44,"context_line":"if $glance_ssl {"},{"line_number":45,"context_line":"  $glance_api_servers \u003d \"${glance_protocol}://${glance_endpoint}:9292\""},{"line_number":46,"context_line":"} else {"},{"line_number":47,"context_line":"  $glance_api_servers \u003d hiera(\u0027glance_api_servers\u0027, \"${management_vip}:9292\")"},{"line_number":48,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_0cf6f8f8","line":45,"in_reply_to":"9a8ffd7b_a271fa45","updated":"2015-11-27 12:20:04.000000000","message":"Let\u0027s look on it from another side. If glance plugin developer don\u0027t use ssl plugin, it will work. If he will, he must change his glance endpoint address in ssl plugin too. It is right way for me. Why SSL should depend on glance?","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/openstack-network/compute-nova.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  $ssl_hash                   \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  $admin_identity_protocol    \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":22,"context_line":"  $admin_identity_address     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  $neutron_internal_protocol  \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":25,"context_line":"  $neutron_endpoint           \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027neutron_endpoint\u0027, \u0027\u0027), $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_82a87621","line":22,"updated":"2015-11-27 11:15:32.000000000","message":"same comment as deployment/puppet/osnailyfacter/modular/ceilometer/compute.pp","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  $ssl_hash                   \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  $admin_identity_protocol    \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":22,"context_line":"  $admin_identity_address     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  $neutron_internal_protocol  \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":25,"context_line":"  $neutron_endpoint           \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027neutron_endpoint\u0027, \u0027\u0027), $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_0c44b818","line":22,"in_reply_to":"9a8ffd7b_82a87621","updated":"2015-11-27 12:20:04.000000000","message":"Done the same.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/openstack-network/server-config.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  $ssl_hash                \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  $internal_auth_protocol  \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":35,"context_line":"  $internal_auth_endpoint  \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  $admin_auth_protocol     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":38,"context_line":"  $admin_auth_endpoint     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_02424668","line":35,"updated":"2015-11-27 11:15:32.000000000","message":"same comment as deployment/puppet/osnailyfacter/modular/ceilometer/compute.pp","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  $ssl_hash                \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  $internal_auth_protocol  \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":35,"context_line":"  $internal_auth_endpoint  \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  $admin_auth_protocol     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":38,"context_line":"  $admin_auth_endpoint     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_cc4a3026","line":35,"in_reply_to":"9a8ffd7b_02424668","updated":"2015-11-27 12:20:04.000000000","message":"Done the same.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  $internal_auth_endpoint  \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  $admin_auth_protocol     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":38,"context_line":"  $admin_auth_endpoint     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  $nova_internal_protocol  \u003d ssl($ssl_hash, {}, \u0027nova\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":41,"context_line":"  $nova_internal_endpoint  \u003d ssl($ssl_hash, {}, \u0027nova\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$nova_endpoint, $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_6251d235","line":38,"updated":"2015-11-27 11:15:32.000000000","message":"same comment as deployment/puppet/osnailyfacter/modular/ceilometer/compute.pp","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  $internal_auth_endpoint  \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  $admin_auth_protocol     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":38,"context_line":"  $admin_auth_endpoint     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  $nova_internal_protocol  \u003d ssl($ssl_hash, {}, \u0027nova\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":41,"context_line":"  $nova_internal_endpoint  \u003d ssl($ssl_hash, {}, \u0027nova\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$nova_endpoint, $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_8c50a8d5","line":38,"in_reply_to":"9a8ffd7b_6251d235","updated":"2015-11-27 12:20:04.000000000","message":"Done the same.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $admin_auth_endpoint     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  $nova_internal_protocol  \u003d ssl($ssl_hash, {}, \u0027nova\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":41,"context_line":"  $nova_internal_endpoint  \u003d ssl($ssl_hash, {}, \u0027nova\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$nova_endpoint, $management_vip])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  $auth_api_version        \u003d \u0027v2.0\u0027"},{"line_number":44,"context_line":"  $identity_uri            \u003d \"${internal_auth_protocol}://${internal_auth_endpoint}:5000/\""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_0239e6f1","line":41,"updated":"2015-11-27 11:15:32.000000000","message":"line 15 already does this selection for nova_endpoint or management_vip. No need to specify $management_vip","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $admin_auth_endpoint     \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  $nova_internal_protocol  \u003d ssl($ssl_hash, {}, \u0027nova\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":41,"context_line":"  $nova_internal_endpoint  \u003d ssl($ssl_hash, {}, \u0027nova\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$nova_endpoint, $management_vip])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  $auth_api_version        \u003d \u0027v2.0\u0027"},{"line_number":44,"context_line":"  $identity_uri            \u003d \"${internal_auth_protocol}://${internal_auth_endpoint}:5000/\""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_8c6748b6","line":41,"in_reply_to":"9a8ffd7b_0239e6f1","updated":"2015-11-27 12:20:04.000000000","message":"Done.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/openstack-network/server-nova.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  $ssl_hash                  \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  $admin_auth_protocol       \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":18,"context_line":"  $admin_auth_endpoint       \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $neutron_internal_protocol \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":21,"context_line":"  $neutron_internal_endpoint \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$neutron_endpoint, $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_223e6ada","line":18,"updated":"2015-11-27 11:15:32.000000000","message":"same comment as deployment/puppet/osnailyfacter/modular/ceilometer/compute.pp","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  $ssl_hash                  \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  $admin_auth_protocol       \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":18,"context_line":"  $admin_auth_endpoint       \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $neutron_internal_protocol \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":21,"context_line":"  $neutron_internal_endpoint \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$neutron_endpoint, $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_cce6b014","line":18,"in_reply_to":"9a8ffd7b_223e6ada","updated":"2015-11-27 12:20:04.000000000","message":"Done the same.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  $admin_auth_endpoint       \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $neutron_internal_protocol \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":21,"context_line":"  $neutron_internal_endpoint \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$neutron_endpoint, $management_vip])"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  $admin_identity_uri        \u003d \"${admin_auth_protocol}://${admin_auth_endpoint}:35357\""},{"line_number":24,"context_line":"  $admin_auth_url            \u003d \"${admin_identity_uri}/${auth_api_version}\""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_5606cf1d","line":21,"updated":"2015-11-27 11:15:32.000000000","message":"line 9 already picks neutron_endpoint","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  $admin_auth_endpoint       \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027admin\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $neutron_internal_protocol \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":21,"context_line":"  $neutron_internal_endpoint \u003d ssl($ssl_hash, {}, \u0027neutron\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$neutron_endpoint, $management_vip])"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  $admin_identity_uri        \u003d \"${admin_auth_protocol}://${admin_auth_endpoint}:35357\""},{"line_number":24,"context_line":"  $admin_auth_url            \u003d \"${admin_identity_uri}/${auth_api_version}\""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_6cef84e9","line":21,"in_reply_to":"9a8ffd7b_5606cf1d","updated":"2015-11-27 12:20:04.000000000","message":"Done","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/roles/cinder.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"$service_endpoint               \u003d hiera(\u0027service_endpoint\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"$keystone_auth_protocol         \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":52,"context_line":"$keystone_auth_host             \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"$glance_protocol                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":55,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_7632f3f3","line":52,"updated":"2015-11-27 11:15:32.000000000","message":"same comment as deployment/puppet/osnailyfacter/modular/ceilometer/compute.pp","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":49,"context_line":"$service_endpoint               \u003d hiera(\u0027service_endpoint\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"$keystone_auth_protocol         \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":52,"context_line":"$keystone_auth_host             \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), $service_endpoint, $management_vip])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"$glance_protocol                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":55,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_6cc6a469","line":52,"in_reply_to":"9a8ffd7b_7632f3f3","updated":"2015-11-27 12:20:04.000000000","message":"Done the same.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"$glance_protocol                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":55,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$management_vip])"},{"line_number":56,"context_line":"$glance_internal_ssl            \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027usage\u0027, false)"},{"line_number":57,"context_line":"if $glance_internal_ssl {"},{"line_number":58,"context_line":"  $glance_api_servers \u003d \"${glance_protocol}://${glance_endpoint}:9292\""},{"line_number":59,"context_line":"} else {"},{"line_number":60,"context_line":"  $glance_api_servers \u003d hiera(\u0027glance_api_servers\u0027, \"http://${management_vip}:9292\")"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_364f8b6c","line":57,"updated":"2015-11-27 11:15:32.000000000","message":"this breaks glance_api_servers override","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":54,"context_line":"$glance_protocol                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":55,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$management_vip])"},{"line_number":56,"context_line":"$glance_internal_ssl            \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027usage\u0027, false)"},{"line_number":57,"context_line":"if $glance_internal_ssl {"},{"line_number":58,"context_line":"  $glance_api_servers \u003d \"${glance_protocol}://${glance_endpoint}:9292\""},{"line_number":59,"context_line":"} else {"},{"line_number":60,"context_line":"  $glance_api_servers \u003d hiera(\u0027glance_api_servers\u0027, \"http://${management_vip}:9292\")"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_4ca8808d","line":57,"in_reply_to":"9a8ffd7b_364f8b6c","updated":"2015-11-27 12:20:04.000000000","message":"I already answered on this.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/roles/compute.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"$ssl_hash                       \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"$glance_protocol                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":58,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027glance_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":59,"context_line":"$glance_internal_ssl            \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027usage\u0027, false)"},{"line_number":60,"context_line":"if $glance_internal_ssl {"},{"line_number":61,"context_line":"  $glance_api_servers \u003d \"${glance_protocol}://${glance_endpoint}:9292\""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_b6985bc1","line":58,"updated":"2015-11-27 11:15:32.000000000","message":"you can shorten this to \n\n...\u0027hostname\u0027, hiera(\u0027glance_endpoint\u0027, $management_vip))","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":55,"context_line":"$ssl_hash                       \u003d hiera_hash(\u0027use_ssl\u0027, {})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"$glance_protocol                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":58,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027glance_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":59,"context_line":"$glance_internal_ssl            \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027usage\u0027, false)"},{"line_number":60,"context_line":"if $glance_internal_ssl {"},{"line_number":61,"context_line":"  $glance_api_servers \u003d \"${glance_protocol}://${glance_endpoint}:9292\""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_8c9ae86c","line":58,"in_reply_to":"9a8ffd7b_b6985bc1","updated":"2015-11-27 12:20:04.000000000","message":"Done","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"405658759cd264f9bb28406c0261625cbb11d75a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"$glance_protocol                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":58,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027glance_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":59,"context_line":"$glance_internal_ssl            \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027usage\u0027, false)"},{"line_number":60,"context_line":"if $glance_internal_ssl {"},{"line_number":61,"context_line":"  $glance_api_servers \u003d \"${glance_protocol}://${glance_endpoint}:9292\""},{"line_number":62,"context_line":"} else {"},{"line_number":63,"context_line":"  $glance_api_servers \u003d hiera(\u0027glance_api_servers\u0027, \"${management_vip}:9292\")"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_165a872a","line":60,"updated":"2015-11-27 11:15:32.000000000","message":"this breaks glance api servers override","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":57,"context_line":"$glance_protocol                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":58,"context_line":"$glance_endpoint                \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027glance_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":59,"context_line":"$glance_internal_ssl            \u003d ssl($ssl_hash, {}, \u0027glance\u0027, \u0027internal\u0027, \u0027usage\u0027, false)"},{"line_number":60,"context_line":"if $glance_internal_ssl {"},{"line_number":61,"context_line":"  $glance_api_servers \u003d \"${glance_protocol}://${glance_endpoint}:9292\""},{"line_number":62,"context_line":"} else {"},{"line_number":63,"context_line":"  $glance_api_servers \u003d hiera(\u0027glance_api_servers\u0027, \"${management_vip}:9292\")"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_cc7b1027","line":60,"in_reply_to":"9a8ffd7b_165a872a","updated":"2015-11-27 12:20:04.000000000","message":"I already answered to this.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/ssl/ssl_add_trust_chain.pp":[{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"c7685fd1958e208aefd73d89e2e6fd3280052149","unresolved":false,"context_lines":[{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if !empty($ssl_hash) {"},{"line_number":17,"context_line":"  $services \u003d [ \u0027horizon\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027heat\u0027, \u0027glance\u0027, \u0027cinder\u0027, \u0027neutron\u0027, \u0027swift\u0027, \u0027sahara\u0027, \u0027murano\u0027, \u0027ceilometer\u0027, \u0027radosgw\u0027]"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  file_link { $services: }"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a8ffd7b_4dba5ee3","line":17,"updated":"2015-11-24 17:21:55.000000000","message":"I think service list shouldn\u0027t be hardcoded. Can it be passed via hiera or something?","commit_id":"e96cd8e89c5ad1fc9affef0cb8bf03c8ae9500be"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"a2496de5825289c6c9643dc1a41236379662cccb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if !empty($ssl_hash) {"},{"line_number":17,"context_line":"  $services \u003d [ \u0027horizon\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027heat\u0027, \u0027glance\u0027, \u0027cinder\u0027, \u0027neutron\u0027, \u0027swift\u0027, \u0027sahara\u0027, \u0027murano\u0027, \u0027ceilometer\u0027, \u0027radosgw\u0027]"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  file_link { $services: }"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a8ffd7b_0939f3d6","line":17,"in_reply_to":"9a8ffd7b_4dba5ee3","updated":"2015-11-27 18:46:54.000000000","message":"As I know - there is no source like this now.","commit_id":"e96cd8e89c5ad1fc9affef0cb8bf03c8ae9500be"}],"deployment/puppet/osnailyfacter/modular/ssl/ssl_dns_setup.pp":[{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"c7685fd1958e208aefd73d89e2e6fd3280052149","unresolved":false,"context_lines":[{"line_number":6,"context_line":"$management_vip \u003d hiera(\u0027management_vip\u0027)"},{"line_number":7,"context_line":"$openstack_service_endpoints \u003d hiera_hash(\u0027openstack_service_endpoints\u0027, {})"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"$services \u003d [ \u0027horizon\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027heat\u0027, \u0027glance\u0027, \u0027cinder\u0027, \u0027neutron\u0027, \u0027swift\u0027, \u0027sahara\u0027, \u0027murano\u0027, \u0027ceilometer\u0027, \u0027radosgw\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"define hosts ("},{"line_number":12,"context_line":"  $ssl_hash,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a8ffd7b_cd95ee40","line":9,"updated":"2015-11-24 17:21:55.000000000","message":"See my comment to ssl_add_trust_chain.pp","commit_id":"e96cd8e89c5ad1fc9affef0cb8bf03c8ae9500be"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"a2496de5825289c6c9643dc1a41236379662cccb","unresolved":false,"context_lines":[{"line_number":6,"context_line":"$management_vip \u003d hiera(\u0027management_vip\u0027)"},{"line_number":7,"context_line":"$openstack_service_endpoints \u003d hiera_hash(\u0027openstack_service_endpoints\u0027, {})"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"$services \u003d [ \u0027horizon\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027heat\u0027, \u0027glance\u0027, \u0027cinder\u0027, \u0027neutron\u0027, \u0027swift\u0027, \u0027sahara\u0027, \u0027murano\u0027, \u0027ceilometer\u0027, \u0027radosgw\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"define hosts ("},{"line_number":12,"context_line":"  $ssl_hash,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a8ffd7b_a93307f5","line":9,"in_reply_to":"9a8ffd7b_cd95ee40","updated":"2015-11-27 18:46:54.000000000","message":"As I know - there is no source like this now.","commit_id":"e96cd8e89c5ad1fc9affef0cb8bf03c8ae9500be"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"fccb87c9191b7bf950fb6d23b51adc289eee4c17","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"$services \u003d [ \u0027horizon\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027heat\u0027, \u0027glance\u0027, \u0027cinder\u0027, \u0027neutron\u0027, \u0027swift\u0027, \u0027sahara\u0027, \u0027murano\u0027, \u0027ceilometer\u0027, \u0027radosgw\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"define hosts ("},{"line_number":12,"context_line":"  $ssl_hash,"},{"line_number":13,"context_line":"  ){"},{"line_number":14,"context_line":"  $service \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_ef0cc6ed","line":11,"updated":"2015-11-27 12:13:56.000000000","message":"After discussing with Stanislaw, we should mark this with a #TODO: Move to each block which can be used in Puppet 4.X instead of defining a type.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"da6b57eba2e4c529e5baecdf37fcb499643df1fc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"$services \u003d [ \u0027horizon\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027heat\u0027, \u0027glance\u0027, \u0027cinder\u0027, \u0027neutron\u0027, \u0027swift\u0027, \u0027sahara\u0027, \u0027murano\u0027, \u0027ceilometer\u0027, \u0027radosgw\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"define hosts ("},{"line_number":12,"context_line":"  $ssl_hash,"},{"line_number":13,"context_line":"  ){"},{"line_number":14,"context_line":"  $service \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_96d677ef","line":11,"updated":"2015-11-27 12:06:27.000000000","message":"a define in a top level puppet file... I\u0027m not sure if it\u0027s a good idea :(","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"$services \u003d [ \u0027horizon\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027heat\u0027, \u0027glance\u0027, \u0027cinder\u0027, \u0027neutron\u0027, \u0027swift\u0027, \u0027sahara\u0027, \u0027murano\u0027, \u0027ceilometer\u0027, \u0027radosgw\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"define hosts ("},{"line_number":12,"context_line":"  $ssl_hash,"},{"line_number":13,"context_line":"  ){"},{"line_number":14,"context_line":"  $service \u003d $name"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_6f01b6ae","line":11,"in_reply_to":"9a8ffd7b_96d677ef","updated":"2015-11-27 12:20:04.000000000","message":"I done a TODO about it, cause it looks MUCH better to convert this to .each syntax in puppet 4 when we will switch to it instead of moving 95% of this file to other file.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/ssl/ssl_keys_saving.pp":[{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"c7685fd1958e208aefd73d89e2e6fd3280052149","unresolved":false,"context_lines":[{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"if !empty($ssl_hash) {"},{"line_number":60,"context_line":"  $services \u003d [ \u0027horizon\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027heat\u0027, \u0027glance\u0027, \u0027cinder\u0027, \u0027neutron\u0027, \u0027swift\u0027, \u0027sahara\u0027, \u0027murano\u0027, \u0027ceilometer\u0027, \u0027radosgw\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  cert_file { $services:"},{"line_number":63,"context_line":"    ssl_hash \u003d\u003e $ssl_hash,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a8ffd7b_8dada68a","line":60,"updated":"2015-11-24 17:21:55.000000000","message":"See comment to ssl_add_trust_chain.pp","commit_id":"e96cd8e89c5ad1fc9affef0cb8bf03c8ae9500be"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"a2496de5825289c6c9643dc1a41236379662cccb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"if !empty($ssl_hash) {"},{"line_number":60,"context_line":"  $services \u003d [ \u0027horizon\u0027, \u0027keystone\u0027, \u0027nova\u0027, \u0027heat\u0027, \u0027glance\u0027, \u0027cinder\u0027, \u0027neutron\u0027, \u0027swift\u0027, \u0027sahara\u0027, \u0027murano\u0027, \u0027ceilometer\u0027, \u0027radosgw\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  cert_file { $services:"},{"line_number":63,"context_line":"    ssl_hash \u003d\u003e $ssl_hash,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a8ffd7b_6950bf0b","line":60,"in_reply_to":"9a8ffd7b_8dada68a","updated":"2015-11-27 18:46:54.000000000","message":"As I know - there is no source like this now.","commit_id":"e96cd8e89c5ad1fc9affef0cb8bf03c8ae9500be"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"da6b57eba2e4c529e5baecdf37fcb499643df1fc","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  ensure \u003d\u003e directory,"},{"line_number":18,"context_line":"}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"define cert_file ("},{"line_number":21,"context_line":"  $ssl_hash,"},{"line_number":22,"context_line":"  $base_path,"},{"line_number":23,"context_line":"  $astute_base_path,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_ec96143d","line":20,"updated":"2015-11-27 12:06:27.000000000","message":"top level define not in its own class...","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  ensure \u003d\u003e directory,"},{"line_number":18,"context_line":"}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"define cert_file ("},{"line_number":21,"context_line":"  $ssl_hash,"},{"line_number":22,"context_line":"  $base_path,"},{"line_number":23,"context_line":"  $astute_base_path,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_afcc7e6a","line":20,"in_reply_to":"9a8ffd7b_ec96143d","updated":"2015-11-27 12:20:04.000000000","message":"I leave a TODO here also.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"deployment/puppet/osnailyfacter/modular/swift/swift.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"da6b57eba2e4c529e5baecdf37fcb499643df1fc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"$region                     \u003d hiera(\u0027region\u0027, \u0027RegionOne\u0027)"},{"line_number":37,"context_line":"$service_workers            \u003d pick($swift_hash[\u0027workers\u0027],"},{"line_number":38,"context_line":"                                min(max($::processorcount, 2), 16))"},{"line_number":39,"context_line":"$ssl_hash                   \u003d hiera(\u0027use_ssl\u0027, {})"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"$keystone_internal_protocol \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":42,"context_line":"$keystone_endpoint          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_0c0fd888","line":39,"updated":"2015-11-27 12:06:27.000000000","message":"hiera -\u003e hiera_hash","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"69d2052f50e65d5896fc6aabaf7fa721f739f319","unresolved":false,"context_lines":[{"line_number":36,"context_line":"$region                     \u003d hiera(\u0027region\u0027, \u0027RegionOne\u0027)"},{"line_number":37,"context_line":"$service_workers            \u003d pick($swift_hash[\u0027workers\u0027],"},{"line_number":38,"context_line":"                                min(max($::processorcount, 2), 16))"},{"line_number":39,"context_line":"$ssl_hash                   \u003d hiera(\u0027use_ssl\u0027, {})"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"$keystone_internal_protocol \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":42,"context_line":"$keystone_endpoint          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_4fce322f","line":39,"in_reply_to":"9a8ffd7b_0c0fd888","updated":"2015-11-27 12:21:10.000000000","message":"Done","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"da6b57eba2e4c529e5baecdf37fcb499643df1fc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"$keystone_endpoint          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"$swift_internal_protocol    \u003d ssl($ssl_hash, {}, \u0027swift\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":45,"context_line":"$swift_internal_endpoint    \u003d ssl($ssl_hash, {}, \u0027swift\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$swift_api_ipaddr, $management_vip])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Use Swift if it isn\u0027t replaced by vCenter, Ceph for BOTH images and objects"},{"line_number":48,"context_line":"if !($storage_hash[\u0027images_ceph\u0027] and $storage_hash[\u0027objects_ceph\u0027]) and !$storage_hash[\u0027images_vcenter\u0027] {"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_8ce0a897","line":45,"updated":"2015-11-27 12:06:27.000000000","message":"we want to default to management vip internally, not to a reference back to itself","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":42,"context_line":"$keystone_endpoint          \u003d ssl($ssl_hash, {}, \u0027keystone\u0027, \u0027internal\u0027, \u0027hostname\u0027, [hiera(\u0027keystone_endpoint\u0027, \u0027\u0027), hiera(\u0027service_endpoint\u0027, \u0027\u0027), $management_vip])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"$swift_internal_protocol    \u003d ssl($ssl_hash, {}, \u0027swift\u0027, \u0027internal\u0027, \u0027protocol\u0027, \u0027http\u0027)"},{"line_number":45,"context_line":"$swift_internal_endpoint    \u003d ssl($ssl_hash, {}, \u0027swift\u0027, \u0027internal\u0027, \u0027hostname\u0027, [$swift_api_ipaddr, $management_vip])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Use Swift if it isn\u0027t replaced by vCenter, Ceph for BOTH images and objects"},{"line_number":48,"context_line":"if !($storage_hash[\u0027images_ceph\u0027] and $storage_hash[\u0027objects_ceph\u0027]) and !$storage_hash[\u0027images_vcenter\u0027] {"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9a8ffd7b_afd31e03","line":45,"in_reply_to":"9a8ffd7b_8ce0a897","updated":"2015-11-27 12:20:04.000000000","message":"Done","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}],"tests/noop/spec/hosts/murano/keystone_spec.rb":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"da6b57eba2e4c529e5baecdf37fcb499643df1fc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    admin_protocol \u003d \u0027http\u0027"},{"line_number":15,"context_line":"    admin_address \u003d internal_address"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    if Noop.hiera_structure(\u0027use_ssl\u0027, false)"},{"line_number":18,"context_line":"      public_protocol \u003d \u0027https\u0027"},{"line_number":19,"context_line":"      public_address \u003d Noop.hiera_structure(\u0027use_ssl/murano_public_hostname\u0027)"},{"line_number":20,"context_line":"      internal_protocol \u003d \u0027https\u0027"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_6c91c4f0","line":17,"updated":"2015-11-27 12:06:27.000000000","message":"Noop.hiera_hash not hiera_structure.. but maybe your lookup is okay to return a false value","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"82018b2a5bfa2a182e71b9e0a2caa0d044660705","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    admin_protocol \u003d \u0027http\u0027"},{"line_number":15,"context_line":"    admin_address \u003d internal_address"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    if Noop.hiera_structure(\u0027use_ssl\u0027, false)"},{"line_number":18,"context_line":"      public_protocol \u003d \u0027https\u0027"},{"line_number":19,"context_line":"      public_address \u003d Noop.hiera_structure(\u0027use_ssl/murano_public_hostname\u0027)"},{"line_number":20,"context_line":"      internal_protocol \u003d \u0027https\u0027"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9a8ffd7b_effb6679","line":17,"in_reply_to":"9a8ffd7b_6c91c4f0","updated":"2015-11-27 12:20:04.000000000","message":"It works for hashes too.","commit_id":"3a9e34e6f96419cfd370ae5283f877f8af62526a"}]}