)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"6418871b9952515e53cae04d8fa387e727b0f790","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitry Nikishov \u003cdnikishov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-02 06:00:02 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"xCreate additional openrc for a non-root accounts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Blueprint: fuel-nonroot-openstack-nodes"},{"line_number":10,"context_line":"Depends-On: I69831fe0327ef9ac55bed99301d2c3732b87ed88"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a5de9d1_3cc39e3a","line":7,"updated":"2016-02-02 12:55:24.000000000","message":"xCreate?","commit_id":"35094d8b3c26811766247147f723e69749980cf9"}],"deployment/puppet/openstack/manifests/auth_file.pp":[{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"dbee85d9ed7b3089af381a4a6bffa75fd658d5c9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $cacert                   \u003d undef,"},{"line_number":58,"context_line":"  $owner                    \u003d \u0027root\u0027,"},{"line_number":59,"context_line":"  $group                    \u003d \u0027root\u0027,"},{"line_number":60,"context_line":"  $path                     \u003d \u0027/root\u0027,"},{"line_number":61,"context_line":") {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  file { \"${path}/openrc\":"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bae84128_00e72dac","line":60,"updated":"2016-02-24 16:16:14.000000000","message":"It would be nice to rewrite this as\n\n $path \u003d $title\n\nand then define resources as\n\n openstack::auth_file { \u0027/root/openrc\u0027: }\n openstack::auth_file { \u0027/home/fueladmin/openrc\u0027: }\n\nIt is straightforward and will allow us to redefine not only path but also filename.","commit_id":"ed08ffdb62ed017ffcd125b1c2a8cb02320f2114"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"dbee85d9ed7b3089af381a4a6bffa75fd658d5c9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  $path                     \u003d \u0027/root\u0027,"},{"line_number":61,"context_line":") {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  file { \"${path}/openrc\":"},{"line_number":64,"context_line":"    owner   \u003d\u003e $owner,"},{"line_number":65,"context_line":"    group   \u003d\u003e $group,"},{"line_number":66,"context_line":"    mode    \u003d\u003e \u00270700\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bae84128_133825d2","line":63,"updated":"2016-02-24 16:16:14.000000000","message":"And there we will just say\n\n file { $path:\n   blahblahblah,\n }","commit_id":"ed08ffdb62ed017ffcd125b1c2a8cb02320f2114"},{"author":{"_account_id":11827,"name":"Stanislaw Bogatkin","email":"regs+ubuntu.com@sbog.ru","username":"sbogatkin"},"change_message_id":"612e1eb1d941241cd8ba1abb6ae49a8bdf2b535e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#   Defaults to undef."},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"define openstack::auth_file("},{"line_number":48,"context_line":"  $path                     \u003d $title,"},{"line_number":49,"context_line":"  $admin_password,"},{"line_number":50,"context_line":"  $controller_node          \u003d \u0027127.0.0.1\u0027,"},{"line_number":51,"context_line":"  $auth_url                 \u003d \u0027http://127.0.0.1:5000/v2.0\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7af24918_8de83f12","line":48,"updated":"2016-03-02 11:41:38.000000000","message":"Change order if these lines, please. I am asking this because of https://docs.puppetlabs.com/guides/style_guide.html#display-order-of-parameters","commit_id":"0c7566aea9367455f306eef87660c2a32ade99cd"}],"deployment/puppet/openstack_tasks/manifests/keystone/keystone.pp":[{"author":{"_account_id":10489,"name":"Bartosz Kupidura","email":"bkupidura@mirantis.com","username":"bkupidura"},"change_message_id":"8f6304545df4f185f2c4e43c8f2c8d4aafef2ec8","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    murano_repo_url     \u003d\u003e $murano_repo_url,"},{"line_number":190,"context_line":"    murano_glare_plugin \u003d\u003e $murano_glare_plugin,"},{"line_number":191,"context_line":"  }"},{"line_number":192,"context_line":"  "},{"line_number":193,"context_line":"  osnailyfacter::credentials_file { \"${operator_user_homedir}/openrc\":"},{"line_number":194,"context_line":"    admin_user          \u003d\u003e $admin_user,"},{"line_number":195,"context_line":"    admin_password      \u003d\u003e $admin_password,"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"da0c15f0_781161ac","line":192,"updated":"2016-03-25 10:46:13.000000000","message":"Remove spaces","commit_id":"8145bbd5eae1dba9b6d143a9fc12a4844bda0dc8"},{"author":{"_account_id":10489,"name":"Bartosz Kupidura","email":"bkupidura@mirantis.com","username":"bkupidura"},"change_message_id":"8f6304545df4f185f2c4e43c8f2c8d4aafef2ec8","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    owner               \u003d\u003e $operator_user_name,"},{"line_number":202,"context_line":"    group               \u003d\u003e $operator_user_name,"},{"line_number":203,"context_line":"  }"},{"line_number":204,"context_line":"  "},{"line_number":205,"context_line":"  osnailyfacter::credentials_file { \"${service_user_homedir}/openrc\":"},{"line_number":206,"context_line":"    admin_user          \u003d\u003e $admin_user,"},{"line_number":207,"context_line":"    admin_password      \u003d\u003e $admin_password,"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"da0c15f0_387ec9e4","line":204,"updated":"2016-03-25 10:46:13.000000000","message":"remove spaces","commit_id":"8145bbd5eae1dba9b6d143a9fc12a4844bda0dc8"}],"deployment/puppet/osnailyfacter/manifests/auth_file.pp":[{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"5e4ff7176428f2b9230a57ab440e214a97076796","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#   (optional) Murano Glance Artifacts Plugin."},{"line_number":45,"context_line":"#   Defaults to undef."},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"define osnailyfacter::auth_file("},{"line_number":48,"context_line":"  $admin_password,"},{"line_number":49,"context_line":"  $path                     \u003d $title,"},{"line_number":50,"context_line":"  $controller_node          \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"fa0719c6_0b745f9a","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":31},"updated":"2016-03-21 08:51:12.000000000","message":"#minor: there are no tests for define.","commit_id":"eee8cd77869020b1f9a4ed2c323efb18c6ac2692"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6eec719af78a24b4469818e1b070d194daed0bc2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#   (optional) Murano Glance Artifacts Plugin."},{"line_number":45,"context_line":"#   Defaults to undef."},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"define osnailyfacter::auth_file("},{"line_number":48,"context_line":"  $admin_password,"},{"line_number":49,"context_line":"  $path                     \u003d $title,"},{"line_number":50,"context_line":"  $controller_node          \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"fa0719c6_6bd87bf0","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":31},"in_reply_to":"fa0719c6_0b745f9a","updated":"2016-03-21 09:03:53.000000000","message":"yes please rework the related rspec as well","commit_id":"eee8cd77869020b1f9a4ed2c323efb18c6ac2692"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9bbeace495a8fcbe9335b50ec891291b54d09a14","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#   (optional) Murano Glance Artifacts Plugin."},{"line_number":45,"context_line":"#   Defaults to undef."},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"define osnailyfacter::auth_file("},{"line_number":48,"context_line":"  $admin_password,"},{"line_number":49,"context_line":"  $path                     \u003d $title,"},{"line_number":50,"context_line":"  $controller_node          \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"fa0719c6_53171751","line":47,"updated":"2016-03-21 16:08:33.000000000","message":"switching from a class to a define will break any plugins leveraging this.","commit_id":"ba9266a61c9967d69c10a1fad4155348598f09eb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"72da1862cb04fa510e82e33b720b5e6e9f51498b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#   (optional) Murano Glance Artifacts Plugin."},{"line_number":45,"context_line":"#   Defaults to undef."},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"define osnailyfacter::auth_file("},{"line_number":48,"context_line":"  $admin_password,"},{"line_number":49,"context_line":"  $path                     \u003d $title,"},{"line_number":50,"context_line":"  $controller_node          \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"fa0719c6_31041b14","line":47,"in_reply_to":"fa0719c6_36889122","updated":"2016-03-21 16:24:19.000000000","message":"Don\u0027t need an elegant way, we need a backwards compatible way.  We should probably create a new resource and move to that while deprecating this one","commit_id":"ba9266a61c9967d69c10a1fad4155348598f09eb"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"4793dd1019e674835e2d6698b2b8d1ac6f782f34","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#   (optional) Murano Glance Artifacts Plugin."},{"line_number":45,"context_line":"#   Defaults to undef."},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"define osnailyfacter::auth_file("},{"line_number":48,"context_line":"  $admin_password,"},{"line_number":49,"context_line":"  $path                     \u003d $title,"},{"line_number":50,"context_line":"  $controller_node          \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"fa0719c6_36889122","line":47,"in_reply_to":"fa0719c6_53171751","updated":"2016-03-21 16:15:42.000000000","message":"The change would be trivial. I do not see an elegant way to extend auth_file to be able to create openrc for multiple users other than converting it into a defined resource.","commit_id":"ba9266a61c9967d69c10a1fad4155348598f09eb"}],"deployment/puppet/osnailyfacter/modular/keystone/keystone.pp":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"98a58ef38955ce0d1be60a46f047a1ba41f4fd21","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"$operator_user_name     \u003d hiera(\u0027operator_user_name\u0027, \u0027fueladmin\u0027)"},{"line_number":133,"context_line":"$operator_user_homedir  \u003d hiera(\u0027operator_user_homedir\u0027, \u0027/home/fueladmin\u0027)"},{"line_number":134,"context_line":"$service_user_name    \u003d hiera(\u0027service_user_name\u0027, \u0027fuel\u0027)"},{"line_number":135,"context_line":"$service_user_homedir \u003d hiera(\u0027service_user_homedir\u0027, \u0027/var/lib/fuel\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"###############################################################################"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"7af24918_ff47e274","line":135,"range":{"start_line":134,"start_character":0,"end_line":135,"end_character":70},"updated":"2016-03-02 14:03:17.000000000","message":"indent these lines with two above","commit_id":"e636b02657ac948145c064ea5dd7e2fae92c3dda"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"581a60bb6bd5c51ec65299cc0f67923202a4e7e7","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"$operator_user_name     \u003d hiera(\u0027operator_user_name\u0027, \u0027fueladmin\u0027)"},{"line_number":133,"context_line":"$operator_user_homedir  \u003d hiera(\u0027operator_user_homedir\u0027, \u0027/home/fueladmin\u0027)"},{"line_number":134,"context_line":"$service_user_name    \u003d hiera(\u0027service_user_name\u0027, \u0027fuel\u0027)"},{"line_number":135,"context_line":"$service_user_homedir \u003d hiera(\u0027service_user_homedir\u0027, \u0027/var/lib/fuel\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"###############################################################################"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"7af24918_c43ccbe4","line":135,"range":{"start_line":134,"start_character":0,"end_line":135,"end_character":70},"in_reply_to":"7af24918_ff47e274","updated":"2016-03-02 16:29:24.000000000","message":"+1 to aligning variable assignment in consecutive lines","commit_id":"e636b02657ac948145c064ea5dd7e2fae92c3dda"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"98a58ef38955ce0d1be60a46f047a1ba41f4fd21","unresolved":false,"context_lines":[{"line_number":221,"context_line":"  admin_tenant \u003d\u003e $admin_tenant,"},{"line_number":222,"context_line":"}"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"openstack::auth_file { \"/root/openrc\":"},{"line_number":225,"context_line":"  admin_user          \u003d\u003e $admin_user,"},{"line_number":226,"context_line":"  admin_password      \u003d\u003e $admin_password,"},{"line_number":227,"context_line":"  admin_tenant        \u003d\u003e $admin_tenant,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"7af24918_ff3ec2d8","line":224,"range":{"start_line":224,"start_character":23,"end_line":224,"end_character":37},"updated":"2016-03-02 14:03:17.000000000","message":"single quotes\nor this should be\n\"${operator_user_homedir}/openrc\" ?","commit_id":"e636b02657ac948145c064ea5dd7e2fae92c3dda"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"581a60bb6bd5c51ec65299cc0f67923202a4e7e7","unresolved":false,"context_lines":[{"line_number":221,"context_line":"  admin_tenant \u003d\u003e $admin_tenant,"},{"line_number":222,"context_line":"}"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"openstack::auth_file { \"/root/openrc\":"},{"line_number":225,"context_line":"  admin_user          \u003d\u003e $admin_user,"},{"line_number":226,"context_line":"  admin_password      \u003d\u003e $admin_password,"},{"line_number":227,"context_line":"  admin_tenant        \u003d\u003e $admin_tenant,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"7af24918_77000b02","line":224,"range":{"start_line":224,"start_character":23,"end_line":224,"end_character":37},"in_reply_to":"7af24918_ff3ec2d8","updated":"2016-03-02 16:29:24.000000000","message":"single quotes. The operator user homedir is line 234.","commit_id":"e636b02657ac948145c064ea5dd7e2fae92c3dda"}],"deployment/puppet/osnailyfacter/spec/defines/osnailyfacter_credentials_file.rb":[{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"e249e3798f46ee76f67b8cef2dd6f37499a553de","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    let (:title) { \u0027/root/openrc\u0027 }"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    it \u0027should include openrc file\u0027 do"},{"line_number":9,"context_line":"      should contain_file(\u0027/root/openrc\u0027)"},{"line_number":10,"context_line":"    end"},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":26,"id":"fa0719c6_38197e89","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":12},"updated":"2016-03-22 10:18:00.000000000","message":"#minor: is_expected.to","commit_id":"ab99d7f8abf214305b4ef2a014253f32f0836788"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"e249e3798f46ee76f67b8cef2dd6f37499a553de","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  context \u0027with non-root user\u0027 do"},{"line_number":14,"context_line":"    let (:title) { \u0027/home/fueladmin/openrc\u0027 }"},{"line_number":15,"context_line":"    let (:owner) { \u0027fueladmin\u0027 }"},{"line_number":16,"context_line":"    let (:group) { \u0027fueladmin\u0027 }"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    it \u0027should include openrc file for a non-root user with correct permissions\u0027 do"},{"line_number":19,"context_line":"      is_expected.to contain_file(\u0027/home/fueladmin/openrc\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":26,"id":"fa0719c6_1309fbdd","line":16,"range":{"start_line":15,"start_character":4,"end_line":16,"end_character":32},"updated":"2016-03-22 10:18:00.000000000","message":"let :params do\n  :owner \u003d\u003e \u0027fueladmin\u0027,\n  :group \u003d\u003e \u0027fueladmin\u0027,\nend","commit_id":"ab99d7f8abf214305b4ef2a014253f32f0836788"}]}
