)]}'
{"deployment/puppet/l23network/lib/puppet/provider/l2_bridge/ovs.rb":[{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"e85bed3d97876629e5268f682824cb03256fe63b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  end"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  def flush"},{"line_number":41,"context_line":"    unless @property_flush.empty?"},{"line_number":42,"context_line":"      debug(\"FLUSH properties: #{@property_flush}\")"},{"line_number":43,"context_line":"      #"},{"line_number":44,"context_line":"      # FLUSH changed properties"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aed3d3a_525d0278","line":41,"updated":"2016-02-29 02:04:08.000000000","message":"please do not use \"unless\" !!!","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"ef5a28072c38931e870b97cf92de4a145eed88df","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  end"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  def flush"},{"line_number":41,"context_line":"    unless @property_flush.empty?"},{"line_number":42,"context_line":"      debug(\"FLUSH properties: #{@property_flush}\")"},{"line_number":43,"context_line":"      #"},{"line_number":44,"context_line":"      # FLUSH changed properties"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aed3d3a_618f882a","line":41,"in_reply_to":"9aed3d3a_525d0278","updated":"2016-02-29 12:18:18.000000000","message":"Done","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"e85bed3d97876629e5268f682824cb03256fe63b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        new_ids \u003d @property_flush[:external_ids]"},{"line_number":51,"context_line":"        #todo(sv): calculate deltas and remove unnided."},{"line_number":52,"context_line":"        new_ids.each_pair do |k,v|"},{"line_number":53,"context_line":"          unless old_ids.has_key?(k)"},{"line_number":54,"context_line":"            vsctl(\"br-set-external-id\", @resource[:bridge], k, v)"},{"line_number":55,"context_line":"          end"},{"line_number":56,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aed3d3a_b2560e5a","line":53,"updated":"2016-02-29 02:04:08.000000000","message":"please do not use \"unless\" !!!","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"ef5a28072c38931e870b97cf92de4a145eed88df","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        new_ids \u003d @property_flush[:external_ids]"},{"line_number":51,"context_line":"        #todo(sv): calculate deltas and remove unnided."},{"line_number":52,"context_line":"        new_ids.each_pair do |k,v|"},{"line_number":53,"context_line":"          unless old_ids.has_key?(k)"},{"line_number":54,"context_line":"            vsctl(\"br-set-external-id\", @resource[:bridge], k, v)"},{"line_number":55,"context_line":"          end"},{"line_number":56,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aed3d3a_c18014fa","line":53,"in_reply_to":"9aed3d3a_b2560e5a","updated":"2016-02-29 12:18:18.000000000","message":"Done","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"}],"deployment/puppet/l23network/manifests/init.pp":[{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"e85bed3d97876629e5268f682824cb03256fe63b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $network_manager              \u003d false,"},{"line_number":65,"context_line":"  $ovs_core_mask                \u003d undef,"},{"line_number":66,"context_line":"  $ovs_pmd_core_mask            \u003d undef,"},{"line_number":67,"context_line":"  $ovs_socket_mem               \u003d undef,"},{"line_number":68,"context_line":"){"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  include ::stdlib"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9aed3d3a_32979eed","line":67,"updated":"2016-02-29 02:04:08.000000000","message":"Please describe this options at the top of file and into README.\nIf they are dpdk-specific options -- please wrap they into hash (something like dpdk_options).","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"ef5a28072c38931e870b97cf92de4a145eed88df","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $network_manager              \u003d false,"},{"line_number":65,"context_line":"  $ovs_core_mask                \u003d undef,"},{"line_number":66,"context_line":"  $ovs_pmd_core_mask            \u003d undef,"},{"line_number":67,"context_line":"  $ovs_socket_mem               \u003d undef,"},{"line_number":68,"context_line":"){"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  include ::stdlib"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9aed3d3a_d501ea39","line":67,"in_reply_to":"9aed3d3a_32979eed","updated":"2016-02-29 12:18:18.000000000","message":"Done","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"}],"deployment/puppet/l23network/manifests/l2.pp":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a407a5ebc599f4b3325da70963c4f699c4913102","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    class { \u0027::l23network::l2::dpdk\u0027:"},{"line_number":71,"context_line":"      use_dpdk                     \u003d\u003e $use_dpdk,"},{"line_number":72,"context_line":"      ovs_core_mask                \u003d\u003e $ovs_core_mask,"},{"line_number":73,"context_line":"      ovs_pmd_core_mask            \u003d\u003e $ovs_pmd_core_mask,"},{"line_number":74,"context_line":"      ovs_socket_mem               \u003d\u003e $ovs_socket_mem,"},{"line_number":75,"context_line":"      install_ovs                  \u003d\u003e $install_ovs,"},{"line_number":76,"context_line":"      ensure_package               \u003d\u003e $ensure_package,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9aed3d3a_ff4cf643","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":35},"updated":"2016-02-27 10:25:47.000000000","message":"extra whitespaces on the every line in the block","commit_id":"43b5177643d820570fa80875cb6b31bf09d38d87"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"e85bed3d97876629e5268f682824cb03256fe63b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $ovs_common_package_name      \u003d $::l23network::params::ovs_common_package_name,"},{"line_number":41,"context_line":"  $ovs_core_mask                \u003d undef,"},{"line_number":42,"context_line":"  $ovs_pmd_core_mask            \u003d undef,"},{"line_number":43,"context_line":"  $ovs_socket_mem               \u003d undef,"},{"line_number":44,"context_line":"){"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  include ::stdlib"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9aed3d3a_b28baec2","line":43,"updated":"2016-02-29 02:04:08.000000000","message":"same as in comments for init.pp","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"ef5a28072c38931e870b97cf92de4a145eed88df","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $ovs_common_package_name      \u003d $::l23network::params::ovs_common_package_name,"},{"line_number":41,"context_line":"  $ovs_core_mask                \u003d undef,"},{"line_number":42,"context_line":"  $ovs_pmd_core_mask            \u003d undef,"},{"line_number":43,"context_line":"  $ovs_socket_mem               \u003d undef,"},{"line_number":44,"context_line":"){"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  include ::stdlib"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9aed3d3a_15f87248","line":43,"in_reply_to":"9aed3d3a_b28baec2","updated":"2016-02-29 12:18:18.000000000","message":"Done","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"}],"deployment/puppet/l23network/manifests/l2/dpdk.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"079836f71ae6de1efd40e6644abd0c3845834a43","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class l23network::l2::dpdk ("},{"line_number":2,"context_line":"  $ensure_package               \u003d \u0027present\u0027,"},{"line_number":3,"context_line":"  $use_dpdk                     \u003d false,"},{"line_number":4,"context_line":"  $install_ovs                  \u003d $use_ovs,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bae84128_6aa2489c","line":1,"updated":"2016-02-24 20:07:19.000000000","message":"Please comment the params of this class","commit_id":"0ce94418a7372aaec2ec38939b43ff6de3fd3a1b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"079836f71ae6de1efd40e6644abd0c3845834a43","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  include ::stdlib"},{"line_number":18,"context_line":"  include ::l23network::params"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  if $use_dpdk {"},{"line_number":21,"context_line":"    service {\u0027dpdk\u0027:"},{"line_number":22,"context_line":"      ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":23,"context_line":"      name      \u003d\u003e \u0027dpdk\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bae84128_0a873cd8","line":20,"updated":"2016-02-24 20:07:19.000000000","message":"From a configuration standpoint, this class seems very complex and doesn\u0027t have a good way to undo the dpdk configuration after it\u0027s been configured. As we work on LCM or being able to reconfigure an environment after deployment this is going to cause some issues if someone wishes to disable dpdk after it\u0027s been installed.","commit_id":"0ce94418a7372aaec2ec38939b43ff6de3fd3a1b"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"6cff3ab3ceabb5ee58523299b9209e79c0ab7b53","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  include ::stdlib"},{"line_number":18,"context_line":"  include ::l23network::params"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  if $use_dpdk {"},{"line_number":21,"context_line":"    service {\u0027dpdk\u0027:"},{"line_number":22,"context_line":"      ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":23,"context_line":"      name      \u003d\u003e \u0027dpdk\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bae84128_36db6c1d","line":20,"in_reply_to":"bae84128_0a873cd8","updated":"2016-02-25 10:46:56.000000000","message":"Unfortunately DPDK itself is very complex and there\u0027s no way for us to make it look simple/pretty/undoable in Fuel. As for LCM: Fuel should not allow to disable DPDK after deployment, only via full reset/redeploy or via deleting/re-adding DPDK enabled nodes.","commit_id":"0ce94418a7372aaec2ec38939b43ff6de3fd3a1b"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"f7ae4adaed1abb82612e68f0afc8b028e93dd128","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  include ::stdlib"},{"line_number":18,"context_line":"  include ::l23network::params"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  if $use_dpdk {"},{"line_number":21,"context_line":"    service {\u0027dpdk\u0027:"},{"line_number":22,"context_line":"      ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":23,"context_line":"      name      \u003d\u003e \u0027dpdk\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bae84128_c0b9b3cd","line":20,"in_reply_to":"bae84128_0a873cd8","updated":"2016-02-24 20:36:55.000000000","message":"what do you mean by complexity: deps? number of entities?\nundo could be a tricky task.","commit_id":"0ce94418a7372aaec2ec38939b43ff6de3fd3a1b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"152830ef2ba09306a6e81ef483f52fb94dc188bd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  include ::stdlib"},{"line_number":18,"context_line":"  include ::l23network::params"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  if $use_dpdk {"},{"line_number":21,"context_line":"    service {\u0027dpdk\u0027:"},{"line_number":22,"context_line":"      ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":23,"context_line":"      name      \u003d\u003e \u0027dpdk\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bae84128_69a504b4","line":20,"in_reply_to":"bae84128_36db6c1d","updated":"2016-02-25 14:42:00.000000000","message":"Yea i had a chat about that and yes it seems that we might not be able to remove it cleanly. That being said, we need to cover this class with better tests since it has a bunch of various if clauses so we need to make sure it works as expected for the various values of use_dpdk, install_dpdk, install_ovs, ovs_dpdk_dkms_package_name, etc","commit_id":"0ce94418a7372aaec2ec38939b43ff6de3fd3a1b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a407a5ebc599f4b3325da70963c4f699c4913102","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        source \u003d\u003e \u0027puppet:///modules/l23network/dpdk.conf\u0027,"},{"line_number":53,"context_line":"      } -\u003e"},{"line_number":54,"context_line":"      file {$dpdk_interfaces_file:"},{"line_number":55,"context_line":"        ensure \u003d\u003e present,"},{"line_number":56,"context_line":"        content \u003d\u003e template(\u0027l23network/dpdk_interfaces.erb\u0027),"},{"line_number":57,"context_line":"      }"},{"line_number":58,"context_line":"      File[$dpdk_interfaces_file] ~\u003e Service[\u0027dpdk\u0027]"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9aed3d3a_ff73567e","line":55,"range":{"start_line":55,"start_character":14,"end_line":55,"end_character":15},"updated":"2016-02-27 10:25:47.000000000","message":"fix indent","commit_id":"43b5177643d820570fa80875cb6b31bf09d38d87"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a407a5ebc599f4b3325da70963c4f699c4913102","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    # Configure OpenVSwitch to use DPDK"},{"line_number":84,"context_line":"    if $ovs_default_file {"},{"line_number":85,"context_line":"      file {$ovs_default_file:"},{"line_number":86,"context_line":"        ensure \u003d\u003e present,"},{"line_number":87,"context_line":"        content \u003d\u003e template(\u0027l23network/openvswitch_default_Debian.erb\u0027),"},{"line_number":88,"context_line":"      } ~\u003e Service[\u0027openvswitch-service\u0027]"},{"line_number":89,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9aed3d3a_9f132a0d","line":86,"range":{"start_line":86,"start_character":14,"end_line":86,"end_character":15},"updated":"2016-02-27 10:25:47.000000000","message":"ditto","commit_id":"43b5177643d820570fa80875cb6b31bf09d38d87"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a407a5ebc599f4b3325da70963c4f699c4913102","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    if $ovs_pmd_core_mask {"},{"line_number":105,"context_line":"      $ovs_pmd_core_mask_cmd \u003d \"ovs-vsctl set Open_vSwitch . other_config:pmd-cpu-mask\u003d${$ovs_pmd_core_mask}\""},{"line_number":106,"context_line":"    } else {"},{"line_number":107,"context_line":"      $ovs_pmd_core_mask_cmd \u003d \"ovs-vsctl remove Open_vSwitch . other_config pmd-cpu-mask\""},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"    exec { \u0027ovs_pmd_core_mask\u0027:"},{"line_number":110,"context_line":"      command \u003d\u003e \"$ovs_pmd_core_mask_cmd\","}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9aed3d3a_7f2d8645","line":107,"range":{"start_line":107,"start_character":31,"end_line":107,"end_character":90},"updated":"2016-02-27 10:25:47.000000000","message":"should be in the single quotes","commit_id":"43b5177643d820570fa80875cb6b31bf09d38d87"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a407a5ebc599f4b3325da70963c4f699c4913102","unresolved":false,"context_lines":[{"line_number":107,"context_line":"      $ovs_pmd_core_mask_cmd \u003d \"ovs-vsctl remove Open_vSwitch . other_config pmd-cpu-mask\""},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"    exec { \u0027ovs_pmd_core_mask\u0027:"},{"line_number":110,"context_line":"      command \u003d\u003e \"$ovs_pmd_core_mask_cmd\","},{"line_number":111,"context_line":"      path    \u003d\u003e \u0027/bin:/usr/bin:/usr/local/bin\u0027,"},{"line_number":112,"context_line":"      require \u003d\u003e Service[\u0027openvswitch-service\u0027],"},{"line_number":113,"context_line":"    } -\u003e Anchor[\u0027l23network::l2::dpdk\u0027]"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9aed3d3a_3f1c9e11","line":110,"range":{"start_line":110,"start_character":17,"end_line":110,"end_character":41},"updated":"2016-02-27 10:25:47.000000000","message":"remove double quotes","commit_id":"43b5177643d820570fa80875cb6b31bf09d38d87"}],"deployment/puppet/l23network/manifests/params.pp":[{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"e85bed3d97876629e5268f682824cb03256fe63b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      $extra_tools                \u003d \u0027iputils-arping\u0027"},{"line_number":27,"context_line":"      $ovs_core_mask              \u003d 0x1"},{"line_number":28,"context_line":"      $ovs_socket_mem             \u003d 256"},{"line_number":29,"context_line":"      $ovs_memory_channels        \u003d 2"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"    /(?i)redhat|centos/: {"},{"line_number":32,"context_line":"      $interfaces_dir            \u003d \u0027/etc/sysconfig/network-scripts\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9aed3d3a_d253d237","line":29,"updated":"2016-02-29 02:04:08.000000000","message":"please add each of new parameters as undef into a sections below.\nPlease handle such undefs into manifest as warning about unsupported feature.","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"ef5a28072c38931e870b97cf92de4a145eed88df","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      $extra_tools                \u003d \u0027iputils-arping\u0027"},{"line_number":27,"context_line":"      $ovs_core_mask              \u003d 0x1"},{"line_number":28,"context_line":"      $ovs_socket_mem             \u003d 256"},{"line_number":29,"context_line":"      $ovs_memory_channels        \u003d 2"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"    /(?i)redhat|centos/: {"},{"line_number":32,"context_line":"      $interfaces_dir            \u003d \u0027/etc/sysconfig/network-scripts\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9aed3d3a_245e2e12","line":29,"in_reply_to":"9aed3d3a_d253d237","updated":"2016-02-29 12:18:18.000000000","message":"Done","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"}],"deployment/puppet/l23network/templates/openvswitch_default_Debian.erb":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a407a5ebc599f4b3325da70963c4f699c4913102","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/etc/init.d/dpdk start"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export DPDK_OPTS\u003d\"--dpdk -c \u003c%\u003d @ovs_core_mask %\u003e -n \u003c%\u003d @ovs_memory_channels %\u003e --socket-mem \u003c%\u003d @ovs_socket_mem %\u003e\""},{"line_number":4,"context_line":"umask 0000"}],"source_content_type":"application/x-erb","patch_set":6,"id":"9aed3d3a_ff96b64a","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":10},"updated":"2016-02-27 10:25:47.000000000","message":"is this really needed? this can lead to the security flaws. all files will be created world-writable.","commit_id":"43b5177643d820570fa80875cb6b31bf09d38d87"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"6bcaaa45e0faa8ba1c51f087e08a43d24479b695","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/etc/init.d/dpdk start"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export DPDK_OPTS\u003d\"--dpdk -c \u003c%\u003d @ovs_core_mask %\u003e -n \u003c%\u003d @ovs_memory_channels %\u003e --socket-mem \u003c%\u003d @ovs_socket_mem %\u003e\""},{"line_number":4,"context_line":"umask 0000"}],"source_content_type":"application/x-erb","patch_set":6,"id":"9aed3d3a_1f1d5abd","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":10},"in_reply_to":"9aed3d3a_ff96b64a","updated":"2016-02-27 10:43:01.000000000","message":"I\u0027m still thinking about 0002, but with OVS 2.4.0 we have no variants right now.","commit_id":"43b5177643d820570fa80875cb6b31bf09d38d87"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"e85bed3d97876629e5268f682824cb03256fe63b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"umask 0002"},{"line_number":7,"context_line":"mkdir -p /var/run/openvswitch"},{"line_number":8,"context_line":"chgrp libvirt-qemu /var/run/openvswitch || true"},{"line_number":9,"context_line":"chmod g+s /var/run/openvswitch"}],"source_content_type":"application/x-erb","patch_set":7,"id":"9aed3d3a_157b648d","line":9,"updated":"2016-02-29 02:04:08.000000000","message":"path and group name should be configured from params.pp","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"ef5a28072c38931e870b97cf92de4a145eed88df","unresolved":false,"context_lines":[{"line_number":6,"context_line":"umask 0002"},{"line_number":7,"context_line":"mkdir -p /var/run/openvswitch"},{"line_number":8,"context_line":"chgrp libvirt-qemu /var/run/openvswitch || true"},{"line_number":9,"context_line":"chmod g+s /var/run/openvswitch"}],"source_content_type":"application/x-erb","patch_set":7,"id":"9aed3d3a_c4a302ff","line":9,"in_reply_to":"9aed3d3a_157b648d","updated":"2016-02-29 12:18:18.000000000","message":"Done","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b307c042fa5b7c7020188c919ea8e206f6133fd8","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export DPDK_OPTS\u003d\"--dpdk -c \u003c%\u003d @ovs_core_mask %\u003e -n \u003c%\u003d @ovs_memory_channels %\u003e --socket-mem \u003c%\u003d @ovs_socket_mem %\u003e\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# LP 1546565"},{"line_number":6,"context_line":"umask 0002"},{"line_number":7,"context_line":"mkdir -p \"\u003c%\u003d @ovs_socket_dir %\u003e\""},{"line_number":8,"context_line":"chgrp \"\u003c%\u003d @ovs_socket_dir_group %\u003e\" \"\u003c%\u003d @ovs_socket_dir %\u003e\" || true"},{"line_number":9,"context_line":"chmod g+s \"\u003c%\u003d @ovs_socket_dir %\u003e\""}],"source_content_type":"application/x-erb","patch_set":8,"id":"9aed3d3a_c3191d8a","line":9,"range":{"start_line":5,"start_character":0,"end_line":9,"end_character":34},"updated":"2016-02-29 18:03:37.000000000","message":"wrap with if block to check $ovs_socket_dir and $ovs_socket_dir_group\nor add validate_() these parameters to deployment/puppet/l23network/manifests/l2/dpdk.pp","commit_id":"86ade08e0849b1a15f07ef119cfeb9b869d00d36"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"b178b19baa307328117350a4aaf0bbdf575f5ce7","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export DPDK_OPTS\u003d\"--dpdk -c \u003c%\u003d @ovs_core_mask %\u003e -n \u003c%\u003d @ovs_memory_channels %\u003e --socket-mem \u003c%\u003d @ovs_socket_mem %\u003e\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# LP 1546565"},{"line_number":6,"context_line":"umask 0002"},{"line_number":7,"context_line":"mkdir -p \"\u003c%\u003d @ovs_socket_dir %\u003e\""},{"line_number":8,"context_line":"chgrp \"\u003c%\u003d @ovs_socket_dir_group %\u003e\" \"\u003c%\u003d @ovs_socket_dir %\u003e\" || true"},{"line_number":9,"context_line":"chmod g+s \"\u003c%\u003d @ovs_socket_dir %\u003e\""}],"source_content_type":"application/x-erb","patch_set":8,"id":"9aed3d3a_9964a2b9","line":9,"range":{"start_line":5,"start_character":0,"end_line":9,"end_character":34},"in_reply_to":"9aed3d3a_c3191d8a","updated":"2016-02-29 18:26:50.000000000","message":"Done","commit_id":"86ade08e0849b1a15f07ef119cfeb9b869d00d36"}],"deployment/puppet/osnailyfacter/modular/netconfig/netconfig.pp":[{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"e85bed3d97876629e5268f682824cb03256fe63b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  use_dpdk                     \u003d\u003e pick($dpdk_config[\u0027enabled\u0027], false),"},{"line_number":20,"context_line":"  ovs_core_mask                \u003d\u003e $dpdk_config[\u0027ovs_core_mask\u0027],"},{"line_number":21,"context_line":"  ovs_pmd_core_mask            \u003d\u003e $dpdk_config[\u0027ovs_pmd_core_mask\u0027],"},{"line_number":22,"context_line":"  ovs_socket_mem               \u003d\u003e $dpdk_config[\u0027ovs_socket_mem\u0027],"},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":"$sdn \u003d generate_network_config()"},{"line_number":25,"context_line":"notify {\u0027SDN\u0027: message \u003d\u003e $sdn }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9aed3d3a_d55d7c16","line":22,"updated":"2016-02-29 02:04:08.000000000","message":"see my comments for init.pp","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"}],"tests/noop/spec/hosts/netconfig/netconfig_spec.rb":[{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"e85bed3d97876629e5268f682824cb03256fe63b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      it \u0027should skip dpdk-specific options for OVS\u0027 do"},{"line_number":56,"context_line":"        should contain_class(\u0027l23network::l2::dpdk\u0027).with(\u0027use_dpdk\u0027 \u003d\u003e false)"},{"line_number":57,"context_line":"      end"},{"line_number":58,"context_line":"    end"},{"line_number":59,"context_line":"  end"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  test_ubuntu_and_centos manifest"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aed3d3a_75c8f0a8","line":58,"updated":"2016-02-29 02:04:08.000000000","message":"this is a internal l23network kitchen.\nwill be better move such tests into l23network\u0027s test\u0027s modules.\nchecking of use_dpdk  for l23network init is enough here.","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"b7da1ec02cdc1cdd1fe3e10ac834f2f2303f3bbf","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      it \u0027should skip dpdk-specific options for OVS\u0027 do"},{"line_number":56,"context_line":"        should contain_class(\u0027l23network::l2::dpdk\u0027).with(\u0027use_dpdk\u0027 \u003d\u003e false)"},{"line_number":57,"context_line":"      end"},{"line_number":58,"context_line":"    end"},{"line_number":59,"context_line":"  end"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  test_ubuntu_and_centos manifest"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9aed3d3a_bb39c2d9","line":58,"in_reply_to":"9aed3d3a_75c8f0a8","updated":"2016-02-29 07:49:31.000000000","message":"As I\u0027ve understand these tests, it\u0027s about hiera to l23network parameter assing check. I change class there","commit_id":"01f0a2e0651aa0d25f0815738816ec1a7524c380"}]}