)]}'
{"deployment/puppet/openstack_tasks/manifests/roles/cinder.pp":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"b44a18d03a00acdc03b864c7ff0e56d5649482da","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  if pick($ceilometer_hash[\u0027enabled\u0027], false) {"},{"line_number":306,"context_line":"    class { \u0027cinder::ceilometer\u0027:"},{"line_number":307,"context_line":"      notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":308,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_0fc74b13","line":305,"range":{"start_line":305,"start_character":39,"end_line":305,"end_character":44},"updated":"2016-04-04 13:31:23.000000000","message":"It should be true","commit_id":"4c1ea5ba7c6c59b154a60651ed7c857dc00c46d9"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"85edb320f72e84c24c5e258698047951867bea43","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  if pick($ceilometer_hash[\u0027enabled\u0027], false) {"},{"line_number":306,"context_line":"    class { \u0027cinder::ceilometer\u0027:"},{"line_number":307,"context_line":"      notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":308,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_f29f5cb2","line":305,"range":{"start_line":305,"start_character":39,"end_line":305,"end_character":44},"in_reply_to":"9a061dce_0fc74b13","updated":"2016-04-04 13:36:45.000000000","message":"No, if ceilometer_hash in undefined or does not have key \u0027enabled\u0027 we should NOT configure ceilometer.","commit_id":"4c1ea5ba7c6c59b154a60651ed7c857dc00c46d9"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"38091735a73f013fae22fe5fde5b8c46fc7c159f","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  if pick($ceilometer_hash[\u0027enabled\u0027], false) {"},{"line_number":306,"context_line":"    class { \u0027cinder::ceilometer\u0027:"},{"line_number":307,"context_line":"      notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_ccf1e1cf","line":307,"range":{"start_line":307,"start_character":29,"end_line":307,"end_character":68},"updated":"2016-04-04 13:15:24.000000000","message":"This param could safely passed w/o checks since $ceilometer_hash[\u0027notification_driver\u0027] there already has right value.","commit_id":"4c1ea5ba7c6c59b154a60651ed7c857dc00c46d9"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"83483c495056adce850e7ab6942deb532000d275","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  if pick($ceilometer_hash[\u0027enabled\u0027], false) {"},{"line_number":306,"context_line":"    class { \u0027cinder::ceilometer\u0027:"},{"line_number":307,"context_line":"      notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_72d86cf0","line":307,"range":{"start_line":307,"start_character":29,"end_line":307,"end_character":68},"in_reply_to":"9a061dce_4fb023de","updated":"2016-04-04 13:45:51.000000000","message":"not exactly, \u003cSERVICE DEFAULT\u003e is defined in https://github.com/openstack/puppet-cinder/blob/master/lib/puppet/type/cinder_config.rb#L44-L47\nand handled by openstack_config provider https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack_config/ini_setting.rb#L7-L9","commit_id":"4c1ea5ba7c6c59b154a60651ed7c857dc00c46d9"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"a5660063228b722a440c80b7c14a49252ea554e6","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  if pick($ceilometer_hash[\u0027enabled\u0027], false) {"},{"line_number":306,"context_line":"    class { \u0027cinder::ceilometer\u0027:"},{"line_number":307,"context_line":"      notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_1d3ae136","line":307,"range":{"start_line":307,"start_character":29,"end_line":307,"end_character":68},"in_reply_to":"9a061dce_72d86cf0","updated":"2016-04-04 13:58:26.000000000","message":"Thanks, then it\u0027s better to use this behaviour.","commit_id":"4c1ea5ba7c6c59b154a60651ed7c857dc00c46d9"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"85edb320f72e84c24c5e258698047951867bea43","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  if pick($ceilometer_hash[\u0027enabled\u0027], false) {"},{"line_number":306,"context_line":"    class { \u0027cinder::ceilometer\u0027:"},{"line_number":307,"context_line":"      notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_4fb023de","line":307,"range":{"start_line":307,"start_character":29,"end_line":307,"end_character":68},"in_reply_to":"9a061dce_ccf1e1cf","updated":"2016-04-04 13:36:45.000000000","message":"If ceilometer is not enabled then $ceilometer_hash[\u0027notification_driver\u0027] is equal to \"\u003cSERVICE DEFAULT\u003e\" so cinder::ceilometer class will configure this in cinder.conf:\n\n [DEFAULT]\n notification_drive \u003d \u003cSERVICE DEFAULT\u003e\n\nIs it ok?","commit_id":"4c1ea5ba7c6c59b154a60651ed7c857dc00c46d9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ac7ed653a02fee40a171a11721f5bd216e1c6876","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  class { \u0027cinder::ceilometer\u0027:"},{"line_number":306,"context_line":"    notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":307,"context_line":"  }"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a061dce_be9f6b5e","line":305,"updated":"2016-04-04 14:46:58.000000000","message":"I\u0027m pretty sure we only want to include this if ceilometer is enabled, so shouldn\u0027t we wrap this in an if $ceilometer_hash[\u0027enabled\u0027]?","commit_id":"1e2fcf3215d6516a2df815748651f99280629207"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bbe65cd1097b735cf3faf78192317ae487226ddf","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  class { \u0027cinder::ceilometer\u0027:"},{"line_number":306,"context_line":"    notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":307,"context_line":"  }"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a061dce_68a51803","line":305,"in_reply_to":"9a061dce_520e0335","updated":"2016-04-04 15:26:19.000000000","message":"Ah you\u0027re right, but that\u0027s totally not obvious behavior.  So with the noop test update we should catch if someone breaks the stuff in globals","commit_id":"1e2fcf3215d6516a2df815748651f99280629207"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"bf6579c7fed3f2ef4ab97b04898b1c2e5d021f75","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  class { \u0027cinder::ceilometer\u0027:"},{"line_number":306,"context_line":"    notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":307,"context_line":"  }"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a061dce_123c8b92","line":305,"in_reply_to":"9a061dce_520e0335","updated":"2016-04-04 14:57:00.000000000","message":"Also this code covers LCM workflow.","commit_id":"1e2fcf3215d6516a2df815748651f99280629207"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"66fda04ba6e51621d459f0c3ba8c79afa824e328","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  class { \u0027cinder::ceilometer\u0027:"},{"line_number":306,"context_line":"    notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":307,"context_line":"  }"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a061dce_520e0335","line":305,"in_reply_to":"9a061dce_be9f6b5e","updated":"2016-04-04 14:55:14.000000000","message":"$ceilometer_hash[\u0027enabled\u0027] is already checked in globals. There is no need to do it twice.","commit_id":"1e2fcf3215d6516a2df815748651f99280629207"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"6b7228881a629ecd30336572ddc2eda668b2b238","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    }"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  class { \u0027cinder::ceilometer\u0027:"},{"line_number":306,"context_line":"    notification_driver \u003d\u003e $ceilometer_hash[\u0027notification_driver\u0027],"},{"line_number":307,"context_line":"  }"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a061dce_1e1137ad","line":305,"in_reply_to":"9a061dce_be9f6b5e","updated":"2016-04-04 14:49:21.000000000","message":"Alex, please read comments in the patch set #1","commit_id":"1e2fcf3215d6516a2df815748651f99280629207"}]}
