)]}'
{"deployment/puppet/osnailyfacter/manifests/netconfig/hiera_default_route.pp":[{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"509a792e29b070a41421255fbc02a5e799ca6493","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  $loaded_network_scheme  \u003d hiera_hash(\u0027network_scheme\u0027, {})"},{"line_number":6,"context_line":"  $management_vrouter_vip \u003d hiera(\u0027management_vrouter_vip\u0027)"},{"line_number":7,"context_line":"  $management_role        \u003d \u0027management\u0027"},{"line_number":8,"context_line":"  $admin_role             \u003d \u0027fw-admin\u0027"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # We can safely prepare_network_config for $loaded_network_scheme here"},{"line_number":11,"context_line":"  # because all we need is network roles and their mapping to interfaces."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_ad88cac7","line":8,"updated":"2016-06-02 14:48:14.000000000","message":"mgmt/vip and admin/pxe should be here","commit_id":"68c91db5a85e97352b7d414f3c65d3f1bb1e3e2e"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fe026c90109951b9fac94dd8999c62e471a87c00","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  $loaded_network_scheme  \u003d hiera_hash(\u0027network_scheme\u0027, {})"},{"line_number":6,"context_line":"  $management_vrouter_vip \u003d hiera(\u0027management_vrouter_vip\u0027)"},{"line_number":7,"context_line":"  $management_role        \u003d \u0027management\u0027"},{"line_number":8,"context_line":"  $admin_role             \u003d \u0027fw-admin\u0027"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # We can safely prepare_network_config for $loaded_network_scheme here"},{"line_number":11,"context_line":"  # because all we need is network roles and their mapping to interfaces."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_ca1a2b7c","line":8,"in_reply_to":"9abb7d3a_ad88cac7","updated":"2016-06-03 06:25:29.000000000","message":"It\u0027s a copy from configure_default_route.pp task. But I\u0027ll give it a try, thx","commit_id":"68c91db5a85e97352b7d414f3c65d3f1bb1e3e2e"}],"deployment/puppet/osnailyfacter/modular/netconfig/tasks.yaml":[{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"7faee5837f6f12a70ae6d8664e8c4782ade357e6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    yaql_exp: \u003e"},{"line_number":71,"context_line":"      switch("},{"line_number":72,"context_line":"        ("},{"line_number":73,"context_line":"          (\u0027controller\u0027 in $.roles) or (\u0027primary-controller\u0027 in $.roles)"},{"line_number":74,"context_line":"          or (\u0027mongo\u0027 in $.roles) or (\u0027primary-mongo\u0027 in $.roles)"},{"line_number":75,"context_line":"          or ($.network_metadata.get(\u0027vips\u0027,{}).get(\u0027management\u0027) \u003d null)"},{"line_number":76,"context_line":"        ) \u003d\u003e [],"},{"line_number":77,"context_line":"        true \u003d\u003e [{name \u003d\u003e\u0027virtual_ips\u0027}]"},{"line_number":78,"context_line":"      )"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aa08908_3b8d2732","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":73},"updated":"2016-06-06 08:57:55.000000000","message":"I think using set operations may bring more readability. Example:\n\n    $.roles.intersect(\n        \u0027primary-controller\u0027, \u0027controller\u0027,\n        \u0027primary-mongo\u0027, \u0027mongo\u0027)\n    or ($.network_metadata.get(\u0027vips\u0027,{}).get(\u0027management\u0027) \u003d null)","commit_id":"2cb6691e684b34aedd40425949c9e4d6a80cff78"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"db05fefab8fcb49cf81bb256b1b435c8944d1687","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    yaql_exp: \u003e"},{"line_number":71,"context_line":"      switch("},{"line_number":72,"context_line":"        ("},{"line_number":73,"context_line":"          (\u0027controller\u0027 in $.roles) or (\u0027primary-controller\u0027 in $.roles)"},{"line_number":74,"context_line":"          or (\u0027mongo\u0027 in $.roles) or (\u0027primary-mongo\u0027 in $.roles)"},{"line_number":75,"context_line":"          or ($.network_metadata.get(\u0027vips\u0027,{}).get(\u0027management\u0027) \u003d null)"},{"line_number":76,"context_line":"        ) \u003d\u003e [],"},{"line_number":77,"context_line":"        true \u003d\u003e [{name \u003d\u003e\u0027virtual_ips\u0027}]"},{"line_number":78,"context_line":"      )"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aa08908_7b884fe8","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":73},"in_reply_to":"7aa08908_3b8d2732","updated":"2016-06-06 09:04:45.000000000","message":"+1\nor smth like that $.roles.any($.matches(\u0027(primary-)?(controller|mongo)\u0027)","commit_id":"2cb6691e684b34aedd40425949c9e4d6a80cff78"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"d0c0a127eb53dc1abecfcef752870e0898ed4aed","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    yaql_exp: \u003e"},{"line_number":71,"context_line":"      switch("},{"line_number":72,"context_line":"        ("},{"line_number":73,"context_line":"          (\u0027controller\u0027 in $.roles) or (\u0027primary-controller\u0027 in $.roles)"},{"line_number":74,"context_line":"          or (\u0027mongo\u0027 in $.roles) or (\u0027primary-mongo\u0027 in $.roles)"},{"line_number":75,"context_line":"          or ($.network_metadata.get(\u0027vips\u0027,{}).get(\u0027management\u0027) \u003d null)"},{"line_number":76,"context_line":"        ) \u003d\u003e [],"},{"line_number":77,"context_line":"        true \u003d\u003e [{name \u003d\u003e\u0027virtual_ips\u0027}]"},{"line_number":78,"context_line":"      )"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aa08908_41c120e4","line":75,"range":{"start_line":73,"start_character":0,"end_line":75,"end_character":73},"in_reply_to":"7aa08908_7b884fe8","updated":"2016-06-06 09:43:46.000000000","message":"Intersect gives errors, and as for regexp - I don\u0027t want to re-run all the 3 custom system tests jobs due to this. If I had to change anything in this patch, I\u0027ll update this part to regexp. Thanks!","commit_id":"2cb6691e684b34aedd40425949c9e4d6a80cff78"}],"tests/noop/spec/hosts/netconfig/hiera_default_route_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"432a4264d9721cf7e09598d328afe7d96f85a90d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# ROLE: virt"},{"line_number":2,"context_line":"# ROLE: primary-mongo"},{"line_number":3,"context_line":"# ROLE: primary-controller"},{"line_number":4,"context_line":"# ROLE: mongo"},{"line_number":5,"context_line":"# ROLE: ironic"},{"line_number":6,"context_line":"# ROLE: controller"},{"line_number":7,"context_line":"# ROLE: compute"},{"line_number":8,"context_line":"# ROLE: compute-vmware"},{"line_number":9,"context_line":"# ROLE: cinder-vmware"},{"line_number":10,"context_line":"# ROLE: cinder-block-device"},{"line_number":11,"context_line":"# ROLE: cinder"},{"line_number":12,"context_line":"# ROLE: ceph-osd"},{"line_number":13,"context_line":"require \u0027spec_helper\u0027"},{"line_number":14,"context_line":"require \u0027shared-examples\u0027"},{"line_number":15,"context_line":"manifest \u003d \u0027netconfig/hiera_default_route.pp\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"7aa08908_48b65cdd","line":12,"range":{"start_line":1,"start_character":0,"end_line":12,"end_character":16},"updated":"2016-06-06 11:58:30.000000000","message":"you removed all roles from modular task except mongo roles. should we update this file too or some mistake in modular task file?","commit_id":"975ea0b90fa5dd909f9b7a1db9ab96d33f3542fb"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"434b19e028c053a7cfdc0913f0460f80c3fa6e0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# ROLE: virt"},{"line_number":2,"context_line":"# ROLE: primary-mongo"},{"line_number":3,"context_line":"# ROLE: primary-controller"},{"line_number":4,"context_line":"# ROLE: mongo"},{"line_number":5,"context_line":"# ROLE: ironic"},{"line_number":6,"context_line":"# ROLE: controller"},{"line_number":7,"context_line":"# ROLE: compute"},{"line_number":8,"context_line":"# ROLE: compute-vmware"},{"line_number":9,"context_line":"# ROLE: cinder-vmware"},{"line_number":10,"context_line":"# ROLE: cinder-block-device"},{"line_number":11,"context_line":"# ROLE: cinder"},{"line_number":12,"context_line":"# ROLE: ceph-osd"},{"line_number":13,"context_line":"require \u0027spec_helper\u0027"},{"line_number":14,"context_line":"require \u0027shared-examples\u0027"},{"line_number":15,"context_line":"manifest \u003d \u0027netconfig/hiera_default_route.pp\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"7aa08908_6ae222d7","line":12,"range":{"start_line":1,"start_character":0,"end_line":12,"end_character":16},"in_reply_to":"7aa08908_48b65cdd","updated":"2016-06-06 14:48:24.000000000","message":"this task is enabled for all roles","commit_id":"975ea0b90fa5dd909f9b7a1db9ab96d33f3542fb"}]}
