)]}'
{"deployment/puppet/ceph/manifests/ephemeral.pp":[{"author":{"_account_id":8865,"name":"Andrey Korolyov","email":"akorolev@mirantis.com","username":"xdel"},"change_message_id":"ee8ca6c0ba2a2a77962d98b5676d392065324720","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u0027DEFAULT/libvirt_images_type\u0027:      value \u003d\u003e $libvirt_images_type;"},{"line_number":16,"context_line":"    \u0027DEFAULT/libvirt_inject_key\u0027:       value \u003d\u003e false;"},{"line_number":17,"context_line":"    \u0027DEFAULT/libvirt_images_rbd_pool\u0027:  value \u003d\u003e $pool;"},{"line_number":18,"context_line":"    \u0027DEFAULT/live_migration_flag\u0027:      value \u003d\u003e \u0027VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE\u0027;"},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9VWY%3D","line":18,"updated":"2013-12-12 15:16:39.000000000","message":"set persist-on-destination, remove peer2peer","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8865,"name":"Andrey Korolyov","email":"akorolev@mirantis.com","username":"xdel"},"change_message_id":"9e3f54da4a224341316dbbae10ae82098679b2d4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u0027DEFAULT/libvirt_images_type\u0027:      value \u003d\u003e $libvirt_images_type;"},{"line_number":16,"context_line":"    \u0027DEFAULT/libvirt_inject_key\u0027:       value \u003d\u003e false;"},{"line_number":17,"context_line":"    \u0027DEFAULT/libvirt_images_rbd_pool\u0027:  value \u003d\u003e $pool;"},{"line_number":18,"context_line":"    \u0027DEFAULT/live_migration_flag\u0027:      value \u003d\u003e \u0027VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE\u0027;"},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9Ty4%3D","line":18,"in_reply_to":"AAAATn%2F9T6s%3D","updated":"2013-12-12 19:33:33.000000000","message":"Persistence on destination is needed to ensure that the VM will be defined for sure, not for default behavior. P2P is not needed generally because libvirt sets appropriate migration flag automatically and it may not work in case of Xen(if its support eventually be in place). The same, question is about defaults and about future changes.","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8865,"name":"Andrey Korolyov","email":"akorolev@mirantis.com","username":"xdel"},"change_message_id":"77ae49bcf88d18c9e3f167c28df58c75cef787d6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u0027DEFAULT/libvirt_images_type\u0027:      value \u003d\u003e $libvirt_images_type;"},{"line_number":16,"context_line":"    \u0027DEFAULT/libvirt_inject_key\u0027:       value \u003d\u003e false;"},{"line_number":17,"context_line":"    \u0027DEFAULT/libvirt_images_rbd_pool\u0027:  value \u003d\u003e $pool;"},{"line_number":18,"context_line":"    \u0027DEFAULT/live_migration_flag\u0027:      value \u003d\u003e \u0027VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE\u0027;"},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9TsA%3D","line":18,"in_reply_to":"AAAATn%2F9TwU%3D","updated":"2013-12-12 19:53:35.000000000","message":"Done","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8829,"name":"Ryan Moe","email":"rmoe@mirantis.com","username":"rmoe"},"change_message_id":"33723bd262bc84a4387c403899401d02971e93cd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u0027DEFAULT/libvirt_images_type\u0027:      value \u003d\u003e $libvirt_images_type;"},{"line_number":16,"context_line":"    \u0027DEFAULT/libvirt_inject_key\u0027:       value \u003d\u003e false;"},{"line_number":17,"context_line":"    \u0027DEFAULT/libvirt_images_rbd_pool\u0027:  value \u003d\u003e $pool;"},{"line_number":18,"context_line":"    \u0027DEFAULT/live_migration_flag\u0027:      value \u003d\u003e \u0027VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE\u0027;"},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9TwU%3D","line":18,"in_reply_to":"AAAATn%2F9Ty4%3D","updated":"2013-12-12 19:43:57.000000000","message":"Fair enough, I\u0027ll add the flag for persist on destination.\n\nWithout the p2p flag live migration fails. From the nova log:\n\nERROR: Live Migration failure: Requested operation is not valid: direct migration is not supported by the connection driver","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8829,"name":"Ryan Moe","email":"rmoe@mirantis.com","username":"rmoe"},"change_message_id":"17dcd7380613abe7ba4a9ee4bc4cb8e1cb2bd5d4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u0027DEFAULT/libvirt_images_type\u0027:      value \u003d\u003e $libvirt_images_type;"},{"line_number":16,"context_line":"    \u0027DEFAULT/libvirt_inject_key\u0027:       value \u003d\u003e false;"},{"line_number":17,"context_line":"    \u0027DEFAULT/libvirt_images_rbd_pool\u0027:  value \u003d\u003e $pool;"},{"line_number":18,"context_line":"    \u0027DEFAULT/live_migration_flag\u0027:      value \u003d\u003e \u0027VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE\u0027;"},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9T6s%3D","line":18,"in_reply_to":"AAAATn%2F9Ugc%3D","updated":"2013-12-12 19:09:33.000000000","message":"Without VIR_MIGRATE_PERSIST_DEST I am able to stop and start migrated VMs and they also persist after rebooting the compute nodes. Is there some other scenario I\u0027m missing where we would lose migrated VMs?\n\nThe p2p flag is required because QEMU doesn\u0027t support direct migration.","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8865,"name":"Andrey Korolyov","email":"akorolev@mirantis.com","username":"xdel"},"change_message_id":"e10cc7ec8d0ed54840458e3ccddbb9c25d054caf","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u0027DEFAULT/libvirt_images_type\u0027:      value \u003d\u003e $libvirt_images_type;"},{"line_number":16,"context_line":"    \u0027DEFAULT/libvirt_inject_key\u0027:       value \u003d\u003e false;"},{"line_number":17,"context_line":"    \u0027DEFAULT/libvirt_images_rbd_pool\u0027:  value \u003d\u003e $pool;"},{"line_number":18,"context_line":"    \u0027DEFAULT/live_migration_flag\u0027:      value \u003d\u003e \u0027VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE\u0027;"},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9Ugc%3D","line":18,"in_reply_to":"AAAATn%2F9UmQ%3D","updated":"2013-12-12 17:31:28.000000000","message":"vir_migrate_persist_dest should be set for sure, else you will lose vm after poweroff.\npeer2peer completely unneeded here. Openstackers may put it by some other means or just by lack of exact knowledge.","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"329df8d5a729b8d493b82b2c64cdc4bc71b17442","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u0027DEFAULT/libvirt_images_type\u0027:      value \u003d\u003e $libvirt_images_type;"},{"line_number":16,"context_line":"    \u0027DEFAULT/libvirt_inject_key\u0027:       value \u003d\u003e false;"},{"line_number":17,"context_line":"    \u0027DEFAULT/libvirt_images_rbd_pool\u0027:  value \u003d\u003e $pool;"},{"line_number":18,"context_line":"    \u0027DEFAULT/live_migration_flag\u0027:      value \u003d\u003e \u0027VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE\u0027;"},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9UmQ%3D","line":18,"in_reply_to":"AAAATn%2F9VWY%3D","updated":"2013-12-12 17:22:56.000000000","message":"Why? These are the flags that we have confirmed to work and that are recommended in OpenStack documentation:\nhttp://docs.openstack.org/havana/config-reference/content/configuring-openstack-compute-basics.html#section_configuring-compute-migrations\nWhat are the use cases that would break without the change you are proposing?","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8865,"name":"Andrey Korolyov","email":"akorolev@mirantis.com","username":"xdel"},"change_message_id":"6472bee3a79188520328434998b202c449a2d47c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  $pool                \u003d $::ceph::compute_pool,"},{"line_number":6,"context_line":") {"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  firewall {\u0027117 libvirt ephemeral allow\u0027:"},{"line_number":9,"context_line":"    chain   \u003d\u003e \u0027INPUT\u0027,"},{"line_number":10,"context_line":"    dport   \u003d\u003e \u002749152-49215\u0027,"},{"line_number":11,"context_line":"    proto   \u003d\u003e \u0027tcp\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"AAAATn%2F9S5s%3D","line":8,"updated":"2013-12-12 22:52:47.000000000","message":"comment should look like \u0027allow tcp port range for migrations\u0027","commit_id":"eb1f721d38d2d3e43571b07ba7dd17b70c16e40b"}],"deployment/puppet/ceph/manifests/init.pp":[{"author":{"_account_id":8865,"name":"Andrey Korolyov","email":"akorolev@mirantis.com","username":"xdel"},"change_message_id":"ee8ca6c0ba2a2a77962d98b5676d392065324720","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      $show_image_direct_url \u003d \u0027True\u0027,"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      # Compute settings"},{"line_number":61,"context_line":"      $compute_user          \u003d \u0027compute\u0027,"},{"line_number":62,"context_line":"      $compute_pool          \u003d \u0027compute\u0027,"},{"line_number":63,"context_line":"      $libvirt_images_type   \u003d \u0027rbd\u0027,"},{"line_number":64,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9VV0%3D","line":61,"updated":"2013-12-12 15:16:39.000000000","message":"name after emulator or tenant id not service type","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"329df8d5a729b8d493b82b2c64cdc4bc71b17442","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      $show_image_direct_url \u003d \u0027True\u0027,"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      # Compute settings"},{"line_number":61,"context_line":"      $compute_user          \u003d \u0027compute\u0027,"},{"line_number":62,"context_line":"      $compute_pool          \u003d \u0027compute\u0027,"},{"line_number":63,"context_line":"      $libvirt_images_type   \u003d \u0027rbd\u0027,"},{"line_number":64,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9UlU%3D","line":61,"in_reply_to":"AAAATn%2F9VV0%3D","updated":"2013-12-12 17:22:56.000000000","message":"No. Changing access control model for Ceph is not in scope of this change, and our current access control model has roles assigned to service types: images, volumes, and compute. If you want to have a finer grained cephx users, the right place to start is create a blueprint and have it scheduled into a later release of Fuel.","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"}],"deployment/puppet/ceph/manifests/nova_compute.pp":[{"author":{"_account_id":8786,"name":"Vladimir Kuklin","email":"aglarendil@gmail.com","username":"aglarendil"},"change_message_id":"245e6233d5fd67885d556b413f28dacc71ceafca","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      } -\u003e"},{"line_number":40,"context_line":"      file_line {\u0027nova-compute env\u0027:"},{"line_number":41,"context_line":"        path \u003d\u003e $::ceph::params::compute_opts_file,"},{"line_number":42,"context_line":"        line \u003d\u003e \"env CEPH_ARGS\u003d\u0027--id ${compute_pool}\u0027\","},{"line_number":43,"context_line":"      }"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9V0s%3D","line":42,"updated":"2013-12-12 13:53:35.000000000","message":"are you sure you should put this data to /etc/init/compute.override. Why ain\u0027t you using /etc/default/\u003cappname\u003e","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"329df8d5a729b8d493b82b2c64cdc4bc71b17442","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      } -\u003e"},{"line_number":40,"context_line":"      file_line {\u0027nova-compute env\u0027:"},{"line_number":41,"context_line":"        path \u003d\u003e $::ceph::params::compute_opts_file,"},{"line_number":42,"context_line":"        line \u003d\u003e \"env CEPH_ARGS\u003d\u0027--id ${compute_pool}\u0027\","},{"line_number":43,"context_line":"      }"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9Uh8%3D","line":42,"in_reply_to":"AAAATn%2F9V0s%3D","updated":"2013-12-12 17:22:56.000000000","message":"$ cat /etc/default/cron \n# This file has been deprecated. Please add custom options for cron to\n# /etc/init/cron.conf and/or /etc/init/cron.override directly. See\n# the init(5) man page for more information.","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"}],"deployment/puppet/ceph/manifests/params.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"a2eb1e0db60a31f779efd628a36859661d828f75","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      $package_radosgw            \u003d \u0027radosgw\u0027"},{"line_number":39,"context_line":"      $package_fastcgi            \u003d \u0027libapache2-mod-fastcgi\u0027"},{"line_number":40,"context_line":"      $package_modssl             \u003d undef"},{"line_number":41,"context_line":"      $compute_opts_file          \u003d \u0027/etc/init/nova-compute.conf\u0027"},{"line_number":42,"context_line":"      $dir_httpd_conf             \u003d \u0027/etc/httpd/conf/\u0027"},{"line_number":43,"context_line":"      $dir_httpd_sites            \u003d \u0027/etc/apache2/sites-available/\u0027"},{"line_number":44,"context_line":"      $dir_httpd_ssl              \u003d \u0027/etc/apache2/ssl/\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"AAAATn%2F9gN0%3D","line":41,"updated":"2013-12-10 21:10:23.000000000","message":"Please use this format https://github.com/stackforge/puppet-cinder/blob/master/manifests/params.pp#L21 so that we don\u0027t have to worry about wrecking the file","commit_id":"33ded5ba0e3e07df7e12ecf73d8b43766b1d8160"}],"deployment/puppet/osnailyfacter/manifests/cluster_ha.pp":[{"author":{"_account_id":8865,"name":"Andrey Korolyov","email":"akorolev@mirantis.com","username":"xdel"},"change_message_id":"ee8ca6c0ba2a2a77962d98b5676d392065324720","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        auto_assign_floating_ip \u003d\u003e $::fuel_settings[\u0027auto_assign_floating_ip\u0027],"},{"line_number":470,"context_line":"        glance_api_servers     \u003d\u003e \"${::fuel_settings[\u0027management_vip\u0027]}:9292\","},{"line_number":471,"context_line":"        vncproxy_host          \u003d\u003e $::fuel_settings[\u0027public_vip\u0027],"},{"line_number":472,"context_line":"        vncserver_listen       \u003d\u003e $storage_hash[\u0027ephemeral_ceph\u0027] ? { true \u003d\u003e \"0.0.0.0\", default \u003d\u003e $internal_address },"},{"line_number":473,"context_line":"        debug                  \u003d\u003e $debug ? { \u0027true\u0027 \u003d\u003e true, true \u003d\u003e true, default\u003d\u003e false },"},{"line_number":474,"context_line":"        verbose                \u003d\u003e $verbose ? { \u0027true\u0027 \u003d\u003e true, true \u003d\u003e true, default\u003d\u003e false },"},{"line_number":475,"context_line":"        cinder_volume_group    \u003d\u003e \"cinder\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9VVM%3D","line":472,"updated":"2013-12-12 15:16:39.000000000","message":"+1 wtf","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8786,"name":"Vladimir Kuklin","email":"aglarendil@gmail.com","username":"aglarendil"},"change_message_id":"245e6233d5fd67885d556b413f28dacc71ceafca","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        auto_assign_floating_ip \u003d\u003e $::fuel_settings[\u0027auto_assign_floating_ip\u0027],"},{"line_number":470,"context_line":"        glance_api_servers     \u003d\u003e \"${::fuel_settings[\u0027management_vip\u0027]}:9292\","},{"line_number":471,"context_line":"        vncproxy_host          \u003d\u003e $::fuel_settings[\u0027public_vip\u0027],"},{"line_number":472,"context_line":"        vncserver_listen       \u003d\u003e $storage_hash[\u0027ephemeral_ceph\u0027] ? { true \u003d\u003e \"0.0.0.0\", default \u003d\u003e $internal_address },"},{"line_number":473,"context_line":"        debug                  \u003d\u003e $debug ? { \u0027true\u0027 \u003d\u003e true, true \u003d\u003e true, default\u003d\u003e false },"},{"line_number":474,"context_line":"        verbose                \u003d\u003e $verbose ? { \u0027true\u0027 \u003d\u003e true, true \u003d\u003e true, default\u003d\u003e false },"},{"line_number":475,"context_line":"        cinder_volume_group    \u003d\u003e \"cinder\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9V1U%3D","line":472,"updated":"2013-12-12 13:53:35.000000000","message":"Why are you doing this? How ephemeral ceph affects vnc server bind address?","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8865,"name":"Andrey Korolyov","email":"akorolev@mirantis.com","username":"xdel"},"change_message_id":"e10cc7ec8d0ed54840458e3ccddbb9c25d054caf","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        auto_assign_floating_ip \u003d\u003e $::fuel_settings[\u0027auto_assign_floating_ip\u0027],"},{"line_number":470,"context_line":"        glance_api_servers     \u003d\u003e \"${::fuel_settings[\u0027management_vip\u0027]}:9292\","},{"line_number":471,"context_line":"        vncproxy_host          \u003d\u003e $::fuel_settings[\u0027public_vip\u0027],"},{"line_number":472,"context_line":"        vncserver_listen       \u003d\u003e $storage_hash[\u0027ephemeral_ceph\u0027] ? { true \u003d\u003e \"0.0.0.0\", default \u003d\u003e $internal_address },"},{"line_number":473,"context_line":"        debug                  \u003d\u003e $debug ? { \u0027true\u0027 \u003d\u003e true, true \u003d\u003e true, default\u003d\u003e false },"},{"line_number":474,"context_line":"        verbose                \u003d\u003e $verbose ? { \u0027true\u0027 \u003d\u003e true, true \u003d\u003e true, default\u003d\u003e false },"},{"line_number":475,"context_line":"        cinder_volume_group    \u003d\u003e \"cinder\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9Ufw%3D","line":472,"in_reply_to":"AAAATn%2F9Uiw%3D","updated":"2013-12-12 17:31:28.000000000","message":"Since we`ve adding plain tcp transport w/o auth, is there a way to set listen to the 127.0.0.1 and point vncproxy to it using nc? Or it is OutOfScope for now?","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"329df8d5a729b8d493b82b2c64cdc4bc71b17442","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        auto_assign_floating_ip \u003d\u003e $::fuel_settings[\u0027auto_assign_floating_ip\u0027],"},{"line_number":470,"context_line":"        glance_api_servers     \u003d\u003e \"${::fuel_settings[\u0027management_vip\u0027]}:9292\","},{"line_number":471,"context_line":"        vncproxy_host          \u003d\u003e $::fuel_settings[\u0027public_vip\u0027],"},{"line_number":472,"context_line":"        vncserver_listen       \u003d\u003e $storage_hash[\u0027ephemeral_ceph\u0027] ? { true \u003d\u003e \"0.0.0.0\", default \u003d\u003e $internal_address },"},{"line_number":473,"context_line":"        debug                  \u003d\u003e $debug ? { \u0027true\u0027 \u003d\u003e true, true \u003d\u003e true, default\u003d\u003e false },"},{"line_number":474,"context_line":"        verbose                \u003d\u003e $verbose ? { \u0027true\u0027 \u003d\u003e true, true \u003d\u003e true, default\u003d\u003e false },"},{"line_number":475,"context_line":"        cinder_volume_group    \u003d\u003e \"cinder\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9Uiw%3D","line":472,"in_reply_to":"AAAATn%2F9VVM%3D","updated":"2013-12-12 17:22:56.000000000","message":"If the vnc bind address is set to specific address, this address setting will be moved along with the rest of libvirt xml to the new node during migration, and the instance will no longer be accessible via vnc. This is conditionalized to prevent this change from impacting other configurations. In order to unconditionally set this to 0.0.0.0 we should first modify the iptables rule to accept connections only from the internal network, I\u0027m not sure it\u0027s something we should do this close to release.","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"}],"deployment/puppet/osnailyfacter/manifests/cluster_simple.pp":[{"author":{"_account_id":8786,"name":"Vladimir Kuklin","email":"aglarendil@gmail.com","username":"aglarendil"},"change_message_id":"245e6233d5fd67885d556b413f28dacc71ceafca","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        qpid_user              \u003d\u003e $rabbit_user,"},{"line_number":350,"context_line":"        glance_api_servers     \u003d\u003e \"${controller_node_address}:9292\","},{"line_number":351,"context_line":"        vncproxy_host          \u003d\u003e $controller_node_public,"},{"line_number":352,"context_line":"        vncserver_listen       \u003d\u003e $storage_hash[\u0027ephemeral_ceph\u0027] ? { true \u003d\u003e \"0.0.0.0\", default \u003d\u003e $internal_address },"},{"line_number":353,"context_line":"        vnc_enabled            \u003d\u003e true,"},{"line_number":354,"context_line":"        quantum                 \u003d\u003e $::use_quantum,"},{"line_number":355,"context_line":"        quantum_config          \u003d\u003e $quantum_config,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9V1I%3D","line":352,"updated":"2013-12-12 13:53:35.000000000","message":"Why are you doing this? How ephemeral ceph affects vnc server bind address?","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8865,"name":"Andrey Korolyov","email":"akorolev@mirantis.com","username":"xdel"},"change_message_id":"e10cc7ec8d0ed54840458e3ccddbb9c25d054caf","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        qpid_user              \u003d\u003e $rabbit_user,"},{"line_number":350,"context_line":"        glance_api_servers     \u003d\u003e \"${controller_node_address}:9292\","},{"line_number":351,"context_line":"        vncproxy_host          \u003d\u003e $controller_node_public,"},{"line_number":352,"context_line":"        vncserver_listen       \u003d\u003e $storage_hash[\u0027ephemeral_ceph\u0027] ? { true \u003d\u003e \"0.0.0.0\", default \u003d\u003e $internal_address },"},{"line_number":353,"context_line":"        vnc_enabled            \u003d\u003e true,"},{"line_number":354,"context_line":"        quantum                 \u003d\u003e $::use_quantum,"},{"line_number":355,"context_line":"        quantum_config          \u003d\u003e $quantum_config,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9Ufk%3D","line":352,"in_reply_to":"AAAATn%2F9UiY%3D","updated":"2013-12-12 17:31:28.000000000","message":"Done","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"329df8d5a729b8d493b82b2c64cdc4bc71b17442","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        qpid_user              \u003d\u003e $rabbit_user,"},{"line_number":350,"context_line":"        glance_api_servers     \u003d\u003e \"${controller_node_address}:9292\","},{"line_number":351,"context_line":"        vncproxy_host          \u003d\u003e $controller_node_public,"},{"line_number":352,"context_line":"        vncserver_listen       \u003d\u003e $storage_hash[\u0027ephemeral_ceph\u0027] ? { true \u003d\u003e \"0.0.0.0\", default \u003d\u003e $internal_address },"},{"line_number":353,"context_line":"        vnc_enabled            \u003d\u003e true,"},{"line_number":354,"context_line":"        quantum                 \u003d\u003e $::use_quantum,"},{"line_number":355,"context_line":"        quantum_config          \u003d\u003e $quantum_config,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"AAAATn%2F9UiY%3D","line":352,"in_reply_to":"AAAATn%2F9V1I%3D","updated":"2013-12-12 17:22:56.000000000","message":"See my reply on cluster_ha.pp.","commit_id":"304c2484c78d0825d0ff120e3def832fd2fe7fec"}]}