)]}'
{"deployment/puppet/ceph/manifests/init.pp":[{"author":{"_account_id":8786,"name":"Vladimir Kuklin","email":"aglarendil@gmail.com","username":"aglarendil"},"change_message_id":"29f20bc9a8103fa802beacf031b53ff7a9731a86","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        keyring_owner \u003d\u003e \u0027cinder\u0027,"},{"line_number":102,"context_line":"      }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"      Class[\u0027ceph::conf\u0027] -\u003e Class[\u0027ceph::mon\u0027] -\u003e Class[\u0027ceph::ha\u0027] -\u003e"},{"line_number":105,"context_line":"      Ceph::Pool[$glance_pool] -\u003e Ceph::Pool[$cinder_pool] -\u003e"},{"line_number":106,"context_line":"      Service[\u0027ceph\u0027]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"AAAAUX%2F%2FEn4%3D","line":104,"updated":"2014-02-17 10:09:05.000000000","message":"You should probably do more strict ordering as puppet ordering of classes does not imply ordering of subclasses. Thus, you should add ordering of corresponding actions explicitly, e.g.: ceph_conf \u003c| [some_condition_here] |\u003e -\u003e Service[\u0027ceph-mon\u0027], Service[\u0027ceph-mon\u0027]-\u003e...","commit_id":"293017c1650306f85481ffaff1a84211930f9290"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"7cb3d9c834f22c51a2aa695cb2d59e04fde1e355","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        keyring_owner \u003d\u003e \u0027cinder\u0027,"},{"line_number":102,"context_line":"      }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"      Class[\u0027ceph::conf\u0027] -\u003e Class[\u0027ceph::mon\u0027] -\u003e Class[\u0027ceph::ha\u0027] -\u003e"},{"line_number":105,"context_line":"      Ceph::Pool[$glance_pool] -\u003e Ceph::Pool[$cinder_pool] -\u003e"},{"line_number":106,"context_line":"      Service[\u0027ceph\u0027]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"AAAAUX%2F%2B7TA%3D","line":104,"in_reply_to":"AAAAUX%2F%2FEn4%3D","updated":"2014-02-18 17:52:18.000000000","message":"No, that\u0027s not true: http://docs.puppetlabs.com/puppet/2.7/reference/lang_containment.html . Classes *contain* the resources they declare, the problem is only that they do not contain the resources that are declared in the classes they *include*. Like most classes in ceph module, ceph::ha doesn\u0027t include any classes, so straight class to class ordering relations work fine.","commit_id":"293017c1650306f85481ffaff1a84211930f9290"}],"deployment/puppet/ceph/manifests/mon.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"3d700d37546115d92315c9f0218c34fe3d73674f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    # Has to be an exec: Puppet can\u0027t reload a service without declaring"},{"line_number":54,"context_line":"    # an ordering relationship."},{"line_number":55,"context_line":"    exec {\u0027reload Ceph for HA\u0027:"},{"line_number":56,"context_line":"      command   \u003d\u003e \u0027service ceph reload\u0027,"},{"line_number":57,"context_line":"      subscribe \u003d\u003e [Ceph_conf[\u0027global/mon_host\u0027], Ceph_conf[\u0027global/mon_initial_members\u0027]]"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"AAAAUX%2F%2ByJI%3D","line":56,"updated":"2014-02-19 03:48:34.000000000","message":"We don\u0027t have to reload the ceph service as the monitors don\u0027t need the reload to know there are new members","commit_id":"f769f20a287a2f6a438f12015b295ee8f94d2f35"}]}