)]}'
{"deployment/puppet/zabbix/manifests/init.pp":[{"author":{"_account_id":8786,"name":"Vladimir Kuklin","email":"aglarendil@gmail.com","username":"aglarendil"},"change_message_id":"b7233da534bec9ce5078871e2c4a29bba3ace371","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    if $::zabbix::params::enabled {"},{"line_number":5,"context_line":"      if $::zabbix::params::server {"},{"line_number":6,"context_line":"        class {\u0027zabbix::server\u0027: }"},{"line_number":7,"context_line":"        class {\u0027zabbix::server::config\u0027:"},{"line_number":8,"context_line":"          require \u003d\u003e Class[\u0027zabbix::server\u0027],"},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"AAAAWH%2F%2Be7A%3D","line":7,"updated":"2014-03-26 14:07:54.000000000","message":"This will not work well. Look into puppet containment document here: http://docs.mirantis.com/fuel-dev/develop/puppet_tips.html#puppet-module-containment . You would better specify something like Service[\u0027zabbix\u0027] in the requirement.","commit_id":"fb8f6bce947ad99b31487c234ddc18d73849be8b"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"af0a2f69bc9c4a0be6e5a2cda1750fa7fdc764b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    if $::zabbix::params::enabled {"},{"line_number":5,"context_line":"      if $::zabbix::params::server {"},{"line_number":6,"context_line":"        class {\u0027zabbix::server\u0027: }"},{"line_number":7,"context_line":"        class {\u0027zabbix::server::config\u0027:"},{"line_number":8,"context_line":"          require \u003d\u003e Class[\u0027zabbix::server\u0027],"},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"AAAAWH%2F%2BXw0%3D","line":7,"in_reply_to":"AAAAWH%2F%2Be7A%3D","updated":"2014-03-27 09:48:54.000000000","message":"According to this document, containment will break if any of these two classes include others. However, zabbix::server has other classes (zabbix::db and zabbix::frontend) surrounded with anchors. And zabbix::server::config does not include any classes. I\u0027ve tested it and that should be fine, or am I missing something?","commit_id":"fb8f6bce947ad99b31487c234ddc18d73849be8b"}]}
