)]}'
{"deployment/puppet/neutron/files/ocf/neutron-agent-dhcp":[{"author":{"_account_id":8786,"name":"Vladimir Kuklin","email":"aglarendil@gmail.com","username":"aglarendil"},"change_message_id":"8c29241bdac995ab0f6d29a38f51bf51c639036c","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    # kill processes inside network namespaces"},{"line_number":388,"context_line":"    ns_list\u003d`ip netns list | grep -Ee \"^qdhcp-.*\"`"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    # kill all proceses from all dhcp-agent\u0027s net.namespaces, that using ip"},{"line_number":391,"context_line":"    count\u003d3  # we will try kill process 3 times"},{"line_number":392,"context_line":"    while [ $count -gt 0 ]; do"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"AAAAXH%2F%2FN%2Fg%3D","line":389,"updated":"2014-04-23 08:46:41.000000000","message":"use check_binary function to check for lsof existence if you are using lsof","commit_id":"a23b59e6f8d75d1115386689a849a983f386b47e"},{"author":{"_account_id":8786,"name":"Vladimir Kuklin","email":"aglarendil@gmail.com","username":"aglarendil"},"change_message_id":"8c29241bdac995ab0f6d29a38f51bf51c639036c","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    # kill all proceses from all dhcp-agent\u0027s net.namespaces, that using ip"},{"line_number":391,"context_line":"    count\u003d3  # we will try kill process 3 times"},{"line_number":392,"context_line":"    while [ $count -gt 0 ]; do"},{"line_number":393,"context_line":"        inside_ns_pids\u003d`for netns in $ns_list ; do ip netns exec $netns lsof -n -i -t ; done`"},{"line_number":394,"context_line":"        if [ -z \"$inside_ns_pids\" ] ; then"},{"line_number":395,"context_line":"            break"},{"line_number":396,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"AAAAXH%2F%2FOXM%3D","line":393,"updated":"2014-04-23 08:46:41.000000000","message":"what is the benefit of using lsof instead of ps ?","commit_id":"a23b59e6f8d75d1115386689a849a983f386b47e"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"1cf53264b18bda67ba0819fff27b32a27b653c6a","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    # kill all proceses from all dhcp-agent\u0027s net.namespaces, that using ip"},{"line_number":391,"context_line":"    count\u003d3  # we will try kill process 3 times"},{"line_number":392,"context_line":"    while [ $count -gt 0 ]; do"},{"line_number":393,"context_line":"        inside_ns_pids\u003d`for netns in $ns_list ; do ip netns exec $netns lsof -n -i -t ; done`"},{"line_number":394,"context_line":"        if [ -z \"$inside_ns_pids\" ] ; then"},{"line_number":395,"context_line":"            break"},{"line_number":396,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"AAAAXH%2F%2FNxM%3D","line":393,"in_reply_to":"AAAAXH%2F%2FOXM%3D","updated":"2014-04-23 09:15:26.000000000","message":"in the Centos 6.5 ps inside network namespace show all processes in base system. lsof -i show only processes, that have been listening network sockets in this net.namespace.","commit_id":"a23b59e6f8d75d1115386689a849a983f386b47e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9f48bf04a37da8b693d3377b8b89039e725775c0","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    inside_ns_pids\u003d`for netns in $ns_list ; do ip netns exec $netns lsof -n -i -t ; done`"},{"line_number":404,"context_line":"    if [ ! -z \"$inside_ns_pids\" ] ; then"},{"line_number":405,"context_line":"        for ns_pid in $inside_ns_pids ; do kill -9 $ns_pid ; done"},{"line_number":406,"context_line":"    fi"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    return $OCF_SUCCESS"},{"line_number":409,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"AAAAXH%2F%2FOdA%3D","line":406,"updated":"2014-04-23 07:56:02.000000000","message":"should we add some graceful exit state checks and alarm if defuncts  were detected?","commit_id":"a23b59e6f8d75d1115386689a849a983f386b47e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3f11d35709ca27288264d17da36dbfd36cdb8ba3","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    inside_ns_pids\u003d`for netns in $ns_list ; do ip netns exec $netns lsof -n -i -t ; done`"},{"line_number":404,"context_line":"    if [ ! -z \"$inside_ns_pids\" ] ; then"},{"line_number":405,"context_line":"        for ns_pid in $inside_ns_pids ; do kill -9 $ns_pid ; done"},{"line_number":406,"context_line":"    fi"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    return $OCF_SUCCESS"},{"line_number":409,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"AAAAXH%2F%2FN94%3D","line":406,"in_reply_to":"AAAAXH%2F%2FOPY%3D","updated":"2014-04-23 08:51:21.000000000","message":"yes","commit_id":"a23b59e6f8d75d1115386689a849a983f386b47e"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"4231c0b7e6e8dbec9f5d4d9ec67babb5dc2758b4","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    inside_ns_pids\u003d`for netns in $ns_list ; do ip netns exec $netns lsof -n -i -t ; done`"},{"line_number":404,"context_line":"    if [ ! -z \"$inside_ns_pids\" ] ; then"},{"line_number":405,"context_line":"        for ns_pid in $inside_ns_pids ; do kill -9 $ns_pid ; done"},{"line_number":406,"context_line":"    fi"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    return $OCF_SUCCESS"},{"line_number":409,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"AAAAXH%2F%2FOPY%3D","line":406,"in_reply_to":"AAAAXH%2F%2FOdA%3D","updated":"2014-04-23 08:27:06.000000000","message":"Do you mean processes, that didn\u0027t died after kill -9 ?","commit_id":"a23b59e6f8d75d1115386689a849a983f386b47e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a17296c74744cc3b619fd5bdeb07b71ace1e9af7","unresolved":false,"context_lines":[{"line_number":335,"context_line":"neutron_dhcp_agent_monitor() {"},{"line_number":336,"context_line":"    neutron_dhcp_agent_status"},{"line_number":337,"context_line":"    rc\u003d$?"},{"line_number":338,"context_line":"    return $rc"},{"line_number":339,"context_line":"}"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"AAAAXH%2F%2FFFs%3D","line":338,"updated":"2014-04-24 07:16:07.000000000","message":"Please add TODO for detecting zombi / defunct processes here...","commit_id":"07cf85f983da00390f4ff994e66ece8c20186e24"}]}