)]}'
{"deployment/puppet/osnailyfacter/manifests/cluster_ha.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dd1148d7decb5a4205763db39b02276c5ff52953","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  # AMQP client configuration"},{"line_number":141,"context_line":"  if $::internal_address in $controller_nodes {"},{"line_number":142,"context_line":"    # prefer local MQ broker if it exists on this node"},{"line_number":143,"context_line":"    $amqp_nodes \u003d concat([\u0027127.0.0.1\u0027], delete($controller_nodes, $::internal_address))"},{"line_number":144,"context_line":"  } else {"},{"line_number":145,"context_line":"    $amqp_nodes \u003d fqdn_rotate($controller_nodes, size($controller_nodes))"},{"line_number":146,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7adec928_ba488ccd","line":143,"updated":"2014-05-22 08:47:49.000000000","message":"please use a temp var to assign it $controller_nodes before to issue delete().\n\nThere is a strange behavior with delete:\nsee $foo\u003d[\u0027bar\u0027, \u0027baz\u0027]\n$qux\u003ddelete($foo, \u0027bar\u0027)\nnotify { \"${foo}\" : }\nwould return Notice: /Stage[main]/Main/Notify[baz]/message: defined \u0027message\u0027 as \u0027baz\u0027\n\nhence, the code you submit would remove one member from the controller_nodes array. But we use it later for configuring some other stuff as well (galera hosts for example) ... So, that would be quite a destructive ;)","commit_id":"3e697e84ddbd3bdefa19c55244a391b027cc8d6d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4b530025c15bd7da35905a83f589682fdb90786a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  # AMQP client configuration"},{"line_number":141,"context_line":"  if $::internal_address in $controller_nodes {"},{"line_number":142,"context_line":"    # prefer local MQ broker if it exists on this node"},{"line_number":143,"context_line":"    $amqp_nodes \u003d concat([\u0027127.0.0.1\u0027], delete($controller_nodes, $::internal_address))"},{"line_number":144,"context_line":"  } else {"},{"line_number":145,"context_line":"    $amqp_nodes \u003d fqdn_rotate($controller_nodes, size($controller_nodes))"},{"line_number":146,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7adec928_6ddc8c75","line":143,"in_reply_to":"7adec928_ba488ccd","updated":"2014-05-22 09:32:22.000000000","message":"Well, I mean perhaps, we don\u0027t want to modify $controller_nodes here. See https://bugs.launchpad.net/fuel/+bug/1322107 for further explanation...","commit_id":"3e697e84ddbd3bdefa19c55244a391b027cc8d6d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4b530025c15bd7da35905a83f589682fdb90786a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    # prefer local MQ broker if it exists on this node"},{"line_number":143,"context_line":"    $amqp_nodes \u003d concat([\u0027127.0.0.1\u0027], delete($controller_nodes, $::internal_address))"},{"line_number":144,"context_line":"  } else {"},{"line_number":145,"context_line":"    $amqp_nodes \u003d fqdn_rotate($controller_nodes, size($controller_nodes))"},{"line_number":146,"context_line":"  }"},{"line_number":147,"context_line":"  $amqp_port \u003d \u00275673\u0027"},{"line_number":148,"context_line":"  $amqp_hosts \u003d inline_template(\"\u003c%\u003d @amqp_nodes.map {|x| x + \u0027:\u0027 + @amqp_port}.join \u0027,\u0027 %\u003e\")"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7adec928_adda1415","line":145,"updated":"2014-05-22 09:32:22.000000000","message":"and please use the same temp var here as well ...","commit_id":"3e697e84ddbd3bdefa19c55244a391b027cc8d6d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4b6dd911e85ad5d99f6233152edc7c1e859b814c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  # AMQP client configuration"},{"line_number":141,"context_line":"  if $::internal_address in $controller_nodes {"},{"line_number":142,"context_line":"    # prefer local MQ broker if it exists on this node"},{"line_number":143,"context_line":"    $amqp_nodes \u003d concat([\u0027127.0.0.1\u0027], fqdn_rotate(delete($controller_nodes, $::internal_address)))"},{"line_number":144,"context_line":"  } else {"},{"line_number":145,"context_line":"    $amqp_nodes \u003d fqdn_rotate($amqp_all_nodes)"},{"line_number":146,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"7adec928_505d9c14","line":143,"updated":"2014-05-22 14:49:14.000000000","message":"now it should be ok once you\u0027ve synced fixed delete() from stdlib upstream","commit_id":"db4ea68fa8135ad965f80a127a729d518d34765c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4b6dd911e85ad5d99f6233152edc7c1e859b814c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    # prefer local MQ broker if it exists on this node"},{"line_number":143,"context_line":"    $amqp_nodes \u003d concat([\u0027127.0.0.1\u0027], fqdn_rotate(delete($controller_nodes, $::internal_address)))"},{"line_number":144,"context_line":"  } else {"},{"line_number":145,"context_line":"    $amqp_nodes \u003d fqdn_rotate($amqp_all_nodes)"},{"line_number":146,"context_line":"  }"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  $amqp_port \u003d \u00275673\u0027"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"7adec928_30b9f02e","line":145,"updated":"2014-05-22 14:49:14.000000000","message":"it\u0027s not defined?..","commit_id":"db4ea68fa8135ad965f80a127a729d518d34765c"}]}