)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"change_message_id":"fb0995f18d3d80659645f5177df373576a7c647d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Abramov \u003csabramov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-22 15:31:06 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add cobbler profile and distros backup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id9323cbd5f5b73451e5d97ffd4191155c5f5dd5f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a122d0e_52b9c72d","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":19},"updated":"2016-04-22 12:46:41.000000000","message":"profiles","commit_id":"b1b16d98b4e4465703333d58b626506b44ca9eaf"},{"author":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"change_message_id":"fb0995f18d3d80659645f5177df373576a7c647d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-04-22 15:31:06 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add cobbler profile and distros backup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id9323cbd5f5b73451e5d97ffd4191155c5f5dd5f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a122d0e_526267d9","line":8,"updated":"2016-04-22 12:46:41.000000000","message":"Please, provide more descriptive explanation what was done in this change request and also add why some files are excluded from backup.","commit_id":"b1b16d98b4e4465703333d58b626506b44ca9eaf"}],"octane/handlers/backup_restore/cobbler.py":[{"author":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"change_message_id":"edcb8d659ee7ba9853ab074ccc6adc2c82704f24","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    archivators_classes \u003d ["},{"line_number":41,"context_line":"        CobblerSystemArchivator,"},{"line_number":42,"context_line":"        CobblerProfileArchivator,"},{"line_number":43,"context_line":"        CobblerDistroArchivator]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def restore(self):"},{"line_number":46,"context_line":"        super(CobblerArchivator, self).restore()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_4348e05b","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":32},"updated":"2016-04-22 12:20:14.000000000","message":"It would be more usable to have the closing bracket on a separate line, like this:\n\n    a \u003d [\n       item1,\n       item2,\n    ]","commit_id":"e8c470dece201183ee180aa6e6cbaa5315db2353"},{"author":{"_account_id":19157,"name":"Sergey Abramov","email":"sabramov@mirantis.com","username":"sabramov"},"change_message_id":"f269b1af5857c830d51d7b0f6812da9154dfacba","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    archivators_classes \u003d ["},{"line_number":41,"context_line":"        CobblerSystemArchivator,"},{"line_number":42,"context_line":"        CobblerProfileArchivator,"},{"line_number":43,"context_line":"        CobblerDistroArchivator]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def restore(self):"},{"line_number":46,"context_line":"        super(CobblerArchivator, self).restore()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_fef53fcb","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":32},"in_reply_to":"1a122d0e_4348e05b","updated":"2016-04-22 12:31:23.000000000","message":"Done","commit_id":"e8c470dece201183ee180aa6e6cbaa5315db2353"}],"octane/tests/test_archivators.py":[{"author":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"change_message_id":"edcb8d659ee7ba9853ab074ccc6adc2c82704f24","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        mocker, cls, banned_files, backup_directory, allowed_files, container,"},{"line_number":76,"context_line":"        backup_name):"},{"line_number":77,"context_line":"    test_archive \u003d mocker.Mock()"},{"line_number":78,"context_line":"    data_lst \u003d (banned_files or []) + (allowed_files or []) + [\"tmp1\", \"tmp2\"]"},{"line_number":79,"context_line":"    stdout_data_lst \u003d [os.path.join(backup_directory, f) for f in data_lst]"},{"line_number":80,"context_line":"    data \u003d \" \".join(stdout_data_lst)"},{"line_number":81,"context_line":"    docker_mock \u003d mocker.patch("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_03926857","line":78,"range":{"start_line":78,"start_character":15,"end_line":78,"end_character":35},"updated":"2016-04-22 12:20:14.000000000","message":"banned_files is an empty list by default and you should not use logic like this.","commit_id":"e8c470dece201183ee180aa6e6cbaa5315db2353"},{"author":{"_account_id":19157,"name":"Sergey Abramov","email":"sabramov@mirantis.com","username":"sabramov"},"change_message_id":"f269b1af5857c830d51d7b0f6812da9154dfacba","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        mocker, cls, banned_files, backup_directory, allowed_files, container,"},{"line_number":76,"context_line":"        backup_name):"},{"line_number":77,"context_line":"    test_archive \u003d mocker.Mock()"},{"line_number":78,"context_line":"    data_lst \u003d (banned_files or []) + (allowed_files or []) + [\"tmp1\", \"tmp2\"]"},{"line_number":79,"context_line":"    stdout_data_lst \u003d [os.path.join(backup_directory, f) for f in data_lst]"},{"line_number":80,"context_line":"    data \u003d \" \".join(stdout_data_lst)"},{"line_number":81,"context_line":"    docker_mock \u003d mocker.patch("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_de40430a","line":78,"range":{"start_line":78,"start_character":15,"end_line":78,"end_character":35},"in_reply_to":"1a122d0e_03926857","updated":"2016-04-22 12:31:23.000000000","message":"Done","commit_id":"e8c470dece201183ee180aa6e6cbaa5315db2353"},{"author":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"change_message_id":"edcb8d659ee7ba9853ab074ccc6adc2c82704f24","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    files_to_archive \u003d data_lst"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    files_to_archive \u003d [d for d in files_to_archive"},{"line_number":102,"context_line":"                        if d in (allowed_files or [])]"},{"line_number":103,"context_line":"    files_to_archive \u003d [d for d in files_to_archive"},{"line_number":104,"context_line":"                        if d not in (banned_files or [])]"},{"line_number":105,"context_line":"    backuped_files \u003d set()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_03c70846","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":54},"updated":"2016-04-22 12:20:14.000000000","message":"You have a broken logic here, files_to_archivate will be empty if allowed_files is None and it means that nothing will be checked in the 112-113 lines.\n\n    if allowed_files is not None:\n        files_to_archive \u003d [d for d in files_to_archive\n                            if d in allowed_files]\n\nAnd this check should go after filtering by banned_files in 103-104.","commit_id":"e8c470dece201183ee180aa6e6cbaa5315db2353"},{"author":{"_account_id":19157,"name":"Sergey Abramov","email":"sabramov@mirantis.com","username":"sabramov"},"change_message_id":"f269b1af5857c830d51d7b0f6812da9154dfacba","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    files_to_archive \u003d data_lst"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    files_to_archive \u003d [d for d in files_to_archive"},{"line_number":102,"context_line":"                        if d in (allowed_files or [])]"},{"line_number":103,"context_line":"    files_to_archive \u003d [d for d in files_to_archive"},{"line_number":104,"context_line":"                        if d not in (banned_files or [])]"},{"line_number":105,"context_line":"    backuped_files \u003d set()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_7e62cfae","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":54},"in_reply_to":"1a122d0e_03c70846","updated":"2016-04-22 12:31:23.000000000","message":"Done","commit_id":"e8c470dece201183ee180aa6e6cbaa5315db2353"},{"author":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"change_message_id":"edcb8d659ee7ba9853ab074ccc6adc2c82704f24","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    files_to_archive \u003d [d for d in files_to_archive"},{"line_number":102,"context_line":"                        if d in (allowed_files or [])]"},{"line_number":103,"context_line":"    files_to_archive \u003d [d for d in files_to_archive"},{"line_number":104,"context_line":"                        if d not in (banned_files or [])]"},{"line_number":105,"context_line":"    backuped_files \u003d set()"},{"line_number":106,"context_line":"    cls(test_archive).backup()"},{"line_number":107,"context_line":"    docker_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_838cb836","line":104,"range":{"start_line":104,"start_character":36,"end_line":104,"end_character":56},"updated":"2016-04-22 12:20:14.000000000","message":"The same about the default value.","commit_id":"e8c470dece201183ee180aa6e6cbaa5315db2353"},{"author":{"_account_id":19157,"name":"Sergey Abramov","email":"sabramov@mirantis.com","username":"sabramov"},"change_message_id":"f269b1af5857c830d51d7b0f6812da9154dfacba","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    files_to_archive \u003d [d for d in files_to_archive"},{"line_number":102,"context_line":"                        if d in (allowed_files or [])]"},{"line_number":103,"context_line":"    files_to_archive \u003d [d for d in files_to_archive"},{"line_number":104,"context_line":"                        if d not in (banned_files or [])]"},{"line_number":105,"context_line":"    backuped_files \u003d set()"},{"line_number":106,"context_line":"    cls(test_archive).backup()"},{"line_number":107,"context_line":"    docker_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_de57a3c8","line":104,"range":{"start_line":104,"start_character":36,"end_line":104,"end_character":56},"in_reply_to":"1a122d0e_838cb836","updated":"2016-04-22 12:31:23.000000000","message":"Done","commit_id":"e8c470dece201183ee180aa6e6cbaa5315db2353"},{"author":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"change_message_id":"edcb8d659ee7ba9853ab074ccc6adc2c82704f24","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        [\"find\", backup_directory, \"-type\", \"f\"],"},{"line_number":110,"context_line":"        stdout\u003dsubprocess.PIPE"},{"line_number":111,"context_line":"    )"},{"line_number":112,"context_line":"    for filename in files_to_archive:"},{"line_number":113,"context_line":"        assert filename in backuped_files"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"@pytest.mark.parametrize(\"cls,db\", ["}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_c387d0d5","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":41},"updated":"2016-04-22 12:20:14.000000000","message":"This loop checks only positive cases and what about checking banned files that should not be presented in the backuped_files?","commit_id":"e8c470dece201183ee180aa6e6cbaa5315db2353"},{"author":{"_account_id":19157,"name":"Sergey Abramov","email":"sabramov@mirantis.com","username":"sabramov"},"change_message_id":"f269b1af5857c830d51d7b0f6812da9154dfacba","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        [\"find\", backup_directory, \"-type\", \"f\"],"},{"line_number":110,"context_line":"        stdout\u003dsubprocess.PIPE"},{"line_number":111,"context_line":"    )"},{"line_number":112,"context_line":"    for filename in files_to_archive:"},{"line_number":113,"context_line":"        assert filename in backuped_files"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"@pytest.mark.parametrize(\"cls,db\", ["}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_be5c67ee","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":41},"in_reply_to":"1a122d0e_c387d0d5","updated":"2016-04-22 12:31:23.000000000","message":"Done","commit_id":"e8c470dece201183ee180aa6e6cbaa5315db2353"}]}
