)]}'
{"fuel_health/tests/tests_platform/test_heat.py":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"95811099d88d0653d7cc9ae3e19a95d26d86cd57","unresolved":false,"context_lines":[{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        self.check_image_exists()"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        vms_count \u003d self.get_info_about_available_resources("},{"line_number":833,"context_line":"            self.min_required_ram_mb, 40, 2)"},{"line_number":834,"context_line":"        if vms_count \u003c 1:"},{"line_number":835,"context_line":"            msg \u003d (\u0027This test requires more hardware resources of your \u0027"},{"line_number":836,"context_line":"                   \u0027OpenStack cluster: your cloud should allow to create \u0027"},{"line_number":837,"context_line":"                   \u0027at least 1 VM with {0} MB of RAM, {1} HDD and {2} vCPUs. \u0027"},{"line_number":838,"context_line":"                   \u0027You need to remove some resources or add compute nodes \u0027"},{"line_number":839,"context_line":"                   \u0027to have an ability to run this OSTF test.\u0027"},{"line_number":840,"context_line":"                   .format(self.min_required_ram_mb, 40, 2))"},{"line_number":841,"context_line":"            LOG.debug(msg)"},{"line_number":842,"context_line":"            self.skipTest(msg)"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        # creation of test flavor"},{"line_number":845,"context_line":"        heat_flavor \u003d self.verify("}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_57e67d44","line":842,"range":{"start_line":832,"start_character":0,"end_line":842,"end_character":30},"updated":"2016-03-03 09:06:19.000000000","message":"how about moving this part of code to separate functions for easy re-using in future or may be moving it to some common class?","commit_id":"b2236b314cdb8a32d72709b41d24abd785bef417"},{"author":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"change_message_id":"e3139b253069c49c02ccc498df27c73c5f7b22da","unresolved":false,"context_lines":[{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        self.check_image_exists()"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        vms_count \u003d self.get_info_about_available_resources("},{"line_number":833,"context_line":"            self.min_required_ram_mb, 40, 2)"},{"line_number":834,"context_line":"        if vms_count \u003c 1:"},{"line_number":835,"context_line":"            msg \u003d (\u0027This test requires more hardware resources of your \u0027"},{"line_number":836,"context_line":"                   \u0027OpenStack cluster: your cloud should allow to create \u0027"},{"line_number":837,"context_line":"                   \u0027at least 1 VM with {0} MB of RAM, {1} HDD and {2} vCPUs. \u0027"},{"line_number":838,"context_line":"                   \u0027You need to remove some resources or add compute nodes \u0027"},{"line_number":839,"context_line":"                   \u0027to have an ability to run this OSTF test.\u0027"},{"line_number":840,"context_line":"                   .format(self.min_required_ram_mb, 40, 2))"},{"line_number":841,"context_line":"            LOG.debug(msg)"},{"line_number":842,"context_line":"            self.skipTest(msg)"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        # creation of test flavor"},{"line_number":845,"context_line":"        heat_flavor \u003d self.verify("}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_de65331e","line":842,"range":{"start_line":832,"start_character":0,"end_line":842,"end_character":30},"in_reply_to":"7af24918_57e67d44","updated":"2016-03-04 13:57:15.000000000","message":"Agreed, I would prefer to create separate method in heatmanager, let\u0027s called it something like \u0027check_required_resources\u0027, here we can just call it","commit_id":"b2236b314cdb8a32d72709b41d24abd785bef417"}]}
