)]}'
{"fuelweb_test/helpers/ssh_manager.py":[{"author":{"_account_id":10136,"name":"Andrey Sledzinskiy","email":"asledzinskiy@mirantis.com","username":"asledzinskiy"},"change_message_id":"de037453669ecb0231c7fba3ae088c186a1c8ef7","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def initialize(self, admin_ip,"},{"line_number":51,"context_line":"                   admin_login\u003dSSH_FUEL_CREDENTIALS[\u0027login\u0027],"},{"line_number":52,"context_line":"                   admin_password\u003dSSH_SLAVE_CREDENTIALS[\u0027password\u0027],"},{"line_number":53,"context_line":"                   slave_login\u003dSSH_SLAVE_CREDENTIALS[\u0027login\u0027],"},{"line_number":54,"context_line":"                   slave_password\u003dSSH_SLAVE_CREDENTIALS[\u0027password\u0027]):"},{"line_number":55,"context_line":"        \"\"\" It will be moved to __init__"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_9f0ca93c","line":52,"updated":"2016-04-06 14:25:24.000000000","message":"should be SSH_FUEL_CREDENTIALS","commit_id":"4b0f9dfa3662cd271f4ab2f8e99d4adbe5ddc46a"}],"fuelweb_test/models/environment.py":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"60fabec04324c0d6d21cb0431166cace2f05e9e4","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                          password\u003dSSH_SLAVE_CREDENTIALS[\u0027password\u0027]):"},{"line_number":815,"context_line":"        return self.d_env.get_ssh_to_remote(ip,"},{"line_number":816,"context_line":"                                            login\u003dlogin,"},{"line_number":817,"context_line":"                                            password\u003dpassword).sudo"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_6291a299","line":817,"updated":"2016-02-26 12:24:06.000000000","message":"maybe we should pass special options like -s or -i to the sudo to avoid possible problems in the feature?","commit_id":"6d1c1e65a14d29dc3eebf6e541f2ea9bdbeb061a"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"189faadb6efc021f985cd3ad85455c776e6b7c58","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                          password\u003dSSH_SLAVE_CREDENTIALS[\u0027password\u0027]):"},{"line_number":815,"context_line":"        return self.d_env.get_ssh_to_remote(ip,"},{"line_number":816,"context_line":"                                            login\u003dlogin,"},{"line_number":817,"context_line":"                                            password\u003dpassword).sudo"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_76f32374","line":817,"in_reply_to":"9aed3d3a_6291a299","updated":"2016-02-26 12:45:55.000000000","message":"I think, adding -i would be enough. However, this needs to be done on the devops side.","commit_id":"6d1c1e65a14d29dc3eebf6e541f2ea9bdbeb061a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c383821c285ffc9c730e1fb91623f8a3640605ab","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                          password\u003dSSH_SLAVE_CREDENTIALS[\u0027password\u0027]):"},{"line_number":815,"context_line":"        return self.d_env.get_ssh_to_remote(ip,"},{"line_number":816,"context_line":"                                            login\u003dlogin,"},{"line_number":817,"context_line":"                                            password\u003dpassword).sudo"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_40e8d110","line":817,"in_reply_to":"9aed3d3a_76f32374","updated":"2016-02-26 14:05:51.000000000","message":"ok","commit_id":"6d1c1e65a14d29dc3eebf6e541f2ea9bdbeb061a"},{"author":{"_account_id":11969,"name":"Dennis Dmitriev","email":"dis.xcom@gmail.com","username":"ddmitriev"},"change_message_id":"02778c7948cdc0ebe8138e4c6d76401c0399aea2","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            query\u003d\"select master_node_uid from master_node_settings limit 1;\")"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    @logwrap"},{"line_number":862,"context_line":"    def get_ssh_to_remote(self, ip,"},{"line_number":863,"context_line":"                          login\u003dSSH_SLAVE_CREDENTIALS[\u0027login\u0027],"},{"line_number":864,"context_line":"                          password\u003dSSH_SLAVE_CREDENTIALS[\u0027password\u0027]):"},{"line_number":865,"context_line":"        return self.d_env.get_ssh_to_remote(ip,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_398cb434","line":862,"updated":"2016-04-06 06:59:47.000000000","message":"Please do not move environment-related methods from fuel-devops to fuel-qa.\nThis class (Environment) will be removed completely, and will be splitted on the environment-related stuff (for fuel-devops), checkers/helpers, and test cases extensions.\n\nPlease extend get_ssh_to_remote() in fuel-devops in that way (branch release/2.9 , current version 2.9.20)","commit_id":"4b0f9dfa3662cd271f4ab2f8e99d4adbe5ddc46a"},{"author":{"_account_id":11969,"name":"Dennis Dmitriev","email":"dis.xcom@gmail.com","username":"ddmitriev"},"change_message_id":"5ee3d2b7699b890491abd3b92247df794cfade68","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            query\u003d\"select master_node_uid from master_node_settings limit 1;\")"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    @logwrap"},{"line_number":862,"context_line":"    def get_ssh_to_remote(self, ip,"},{"line_number":863,"context_line":"                          login\u003dSSH_SLAVE_CREDENTIALS[\u0027login\u0027],"},{"line_number":864,"context_line":"                          password\u003dSSH_SLAVE_CREDENTIALS[\u0027password\u0027]):"},{"line_number":865,"context_line":"        return self.d_env.get_ssh_to_remote(ip,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_563313f6","line":862,"in_reply_to":"9a061dce_26ce432e","updated":"2016-04-06 16:04:34.000000000","message":"It would make sense if we wanted to leave the context managers for SSHClient like you used in the next patch:\n\nwith self.env.get_ssh_to_remote(node[\u0027ip\u0027]) as remote:\n\nBut we get rid from this way and switch to use ssh_manager that expects login and password:\nhttps://github.com/openstack/fuel-qa/blob/master/fuelweb_test/helpers/ssh_manager.py#L56-L57\n\nSo, actually the task is to provide correct credentials into SSHManager in *each* particular case, and rewrite tests to use \u0027ssh_manager\u0027 instead of \u0027remote\u0027.\n\nFor example, we could use some additional argument here to pass slave credentials: https://github.com/openstack/fuel-qa/blob/master/fuelweb_test/models/fuel_web_client.py#L384-L385\n\n, something like:\nself.ssh_manager.execute_on_remote(\n            ip, cmd, creds \u003d settings.SSH_FUEL_CREDENTIALS, ...)\n\nand pass it inside ssh_manager to https://github.com/openstack/fuel-qa/blob/master/fuelweb_test/helpers/ssh_manager.py#L99-L100  (using SSH_FUEL_CREDENTIALS as a default)","commit_id":"4b0f9dfa3662cd271f4ab2f8e99d4adbe5ddc46a"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"b5aaedbd6da1ca0790fcc1957cf08562e69eda53","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            query\u003d\"select master_node_uid from master_node_settings limit 1;\")"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    @logwrap"},{"line_number":862,"context_line":"    def get_ssh_to_remote(self, ip,"},{"line_number":863,"context_line":"                          login\u003dSSH_SLAVE_CREDENTIALS[\u0027login\u0027],"},{"line_number":864,"context_line":"                          password\u003dSSH_SLAVE_CREDENTIALS[\u0027password\u0027]):"},{"line_number":865,"context_line":"        return self.d_env.get_ssh_to_remote(ip,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_26ce432e","line":862,"in_reply_to":"9a061dce_398cb434","updated":"2016-04-06 12:31:59.000000000","message":"Login/password specification has already been implemented in devops. The problem is that devops doesn\u0027t know anything about slave node specific credentials. So this is actually a way to pass default slave login/password to devops.","commit_id":"4b0f9dfa3662cd271f4ab2f8e99d4adbe5ddc46a"},{"author":{"_account_id":11969,"name":"Dennis Dmitriev","email":"dis.xcom@gmail.com","username":"ddmitriev"},"change_message_id":"a0388aee60bea62326856a3d10536929158522a7","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            query\u003d\"select master_node_uid from master_node_settings limit 1;\")"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    @logwrap"},{"line_number":862,"context_line":"    def get_ssh_to_remote(self, ip,"},{"line_number":863,"context_line":"                          login\u003dSSH_SLAVE_CREDENTIALS[\u0027login\u0027],"},{"line_number":864,"context_line":"                          password\u003dSSH_SLAVE_CREDENTIALS[\u0027password\u0027]):"},{"line_number":865,"context_line":"        return self.d_env.get_ssh_to_remote(ip,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_b6b38fe8","line":862,"in_reply_to":"9a061dce_563313f6","updated":"2016-04-06 16:10:03.000000000","message":"Looks like you already implemented changes for slave nodes in\nhttps://review.openstack.org/#/c/281776/4/fuelweb_test/helpers/ssh_manager.py\n\nSo there is no need in this method get_ssh_to_remote() at all: just make a patch that will use ssh_manager in the system tests (https://blueprints.launchpad.net/fuel/+spec/sshmanager-integration).","commit_id":"4b0f9dfa3662cd271f4ab2f8e99d4adbe5ddc46a"}]}
