)]}'
{"specs/9.0/refactor-osnailyfacter-to-be-compatible-with-puppet-master.rst":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a3f000ca9e0379463f20111e072911cf0fec56e9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"--------------------"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Specifically, the module has many manifests located inside of"},{"line_number":25,"context_line":"\u0027osnailyfacter/modular\u0027 rather than \u0027osnailyfacter/manifests\u0027.  This poses"},{"line_number":26,"context_line":"a problem and is incompatible with Puppet Master as autolookup will fail,"},{"line_number":27,"context_line":"since Puppet Master expects manifests to be located within a directory named"},{"line_number":28,"context_line":"\u0027manifests\u0027.  If the classes inside of these manifests are attempted to be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aed3d3a_2883d805","line":25,"updated":"2016-02-26 22:06:49.000000000","message":"Where will the task.yamls be moved to? Or is this just moving the configuration logic into actual puppet classes?","commit_id":"0966d4a45aa531a4d4c887574f4e6df0ab5b56d6"},{"author":{"_account_id":18948,"name":"Scott Brimhall","email":"sbrimhall@mirantis.com","username":"sbrimhall"},"change_message_id":"af2132109dfdc8f0f5fd1ff270e6610cf27f6ac2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"--------------------"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Specifically, the module has many manifests located inside of"},{"line_number":25,"context_line":"\u0027osnailyfacter/modular\u0027 rather than \u0027osnailyfacter/manifests\u0027.  This poses"},{"line_number":26,"context_line":"a problem and is incompatible with Puppet Master as autolookup will fail,"},{"line_number":27,"context_line":"since Puppet Master expects manifests to be located within a directory named"},{"line_number":28,"context_line":"\u0027manifests\u0027.  If the classes inside of these manifests are attempted to be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aed3d3a_8be3fe32","line":25,"in_reply_to":"9aed3d3a_2883d805","updated":"2016-02-26 23:02:06.000000000","message":"This is just moving the configuration logic into actual puppet classes.  The tasks files would just move with the files in question as well.","commit_id":"0966d4a45aa531a4d4c887574f4e6df0ab5b56d6"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"9fc503c99e05c6989af80b4cf8069a7fa227563f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  reference the new osnailyfacter::ceph::ceph_pools class as to continue to"},{"line_number":73,"context_line":"  support the task based deployment methodology."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"For masterless Puppet/puppet apply tasks, each task would also need to be"},{"line_number":76,"context_line":"updated to include the new \u0027osnailyfacter/manifests\u0027 location for the"},{"line_number":77,"context_line":"manifest being applied."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Web UI"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_86a299fb","line":77,"range":{"start_line":75,"start_character":0,"end_line":77,"end_character":23},"updated":"2016-03-03 07:58:25.000000000","message":"According to the discussion, this part needs to be updated.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"5268a995988f24badc01cc4bba2e6aba85e5c9a4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"For masterless Puppet/puppet apply tasks, each task would also need to be"},{"line_number":76,"context_line":"updated to include the new \u0027osnailyfacter/manifests\u0027 location for the"},{"line_number":77,"context_line":"manifest being applied."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Web UI"},{"line_number":81,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_a0fa6bbb","line":78,"updated":"2016-03-02 08:58:43.000000000","message":"How would site.pp look for Puppet Master setup?","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"9fc503c99e05c6989af80b4cf8069a7fa227563f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"For masterless Puppet/puppet apply tasks, each task would also need to be"},{"line_number":76,"context_line":"updated to include the new \u0027osnailyfacter/manifests\u0027 location for the"},{"line_number":77,"context_line":"manifest being applied."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Web UI"},{"line_number":81,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_230f3738","line":78,"in_reply_to":"7af24918_12c0a77a","updated":"2016-03-03 07:58:25.000000000","message":"I understand that master configuration is out of scope. But I wanted to take a look at the expected result of node classification process in order to understand how things are supposed to work together (compile one huge catalog or separate catalog for each task).\nI would also like to see how Fuel plugins are going to be addressed in Puppet Master setup. But if it\u0027s out of scope, that\u0027s fine by me, let\u0027s forget about it and move one.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6babe909c43a46c6930336f5885dc6f84067b146","unresolved":false,"context_lines":[{"line_number":75,"context_line":"For masterless Puppet/puppet apply tasks, each task would also need to be"},{"line_number":76,"context_line":"updated to include the new \u0027osnailyfacter/manifests\u0027 location for the"},{"line_number":77,"context_line":"manifest being applied."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Web UI"},{"line_number":81,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_12c0a77a","line":78,"in_reply_to":"7af24918_733ddfba","updated":"2016-03-02 19:32:34.000000000","message":"So the configuring of a puppet master is not part of this spec. The main goal of this spec is to get the modular tasks (and service configurations) into a format that can be consumed by a puppet master. That part of the work is to be handled by a plugin and is up to the end user. What we\u0027re proposing is the restructuring of the tasks in to proper puppet classes that can be consumed by a puppet master. Currently the tasks today are nothing more than freeform puppet and cannot be consumed via a normal puppet deployment. If we restructure the tasks into specific chunks of configurations, they can be reused by an end user to ensure configurations are in place correctly.\n\nFor example if I have a compute node and I want to just ensure the nova configurations, being able to do a simple include osnailyfacter::nova::compute to ensure configs \u0026 services are running and properly configured is what is being requested.\n\nThe primary scope of this work is to reorganize the existing code into a structure that can be consumed by a puppet master. This is not to actually provide a configured puppet master in or with fuel.\n\nAs part of this restructuring we may end up in a better spot with testing because we could do proper beaker/acceptance testing around the modular tasks because we could leverage them like actual classes.  This is similar to what the puppet openstack upstream does with the puppet-openstack-integration module to do a simple deploy leveraging the puppet modules.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9a96284bdfc27284d7a63bba9ff16e5ac0283d98","unresolved":false,"context_lines":[{"line_number":75,"context_line":"For masterless Puppet/puppet apply tasks, each task would also need to be"},{"line_number":76,"context_line":"updated to include the new \u0027osnailyfacter/manifests\u0027 location for the"},{"line_number":77,"context_line":"manifest being applied."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Web UI"},{"line_number":81,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_733ddfba","line":78,"in_reply_to":"7af24918_a0fa6bbb","updated":"2016-03-02 09:11:46.000000000","message":"This raised alarm for me as well. Will we try to compose a giant manifest to combine all modular task into it? Note, the very idea of granular deployment is doing otherwise. Will we have to support modular and monolithic site.pp code in two places?\n\nIf no, please clarify the final solution. Perhaps puppet environments, or tags will be used instead of a single site.pp? For example, a single modular task may be executed as a single site.pp within a single puppet env scope.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"5268a995988f24badc01cc4bba2e6aba85e5c9a4","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Each manifest contained inside of \u0027deployment/puppet/osnailyfacter/modular\u0027"},{"line_number":120,"context_line":"will need to be moved inside of \u0027deployment/puppet/osnailyfacter/manifests\u0027"},{"line_number":121,"context_line":"and each corresponding task.yaml needs to be updated to reflect the directory"},{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_3d484887","line":122,"range":{"start_line":121,"start_character":5,"end_line":122,"end_character":6},"updated":"2016-03-02 08:58:43.000000000","message":"But above you said that modular manifests are still needed and they will contain code like \u0027include ::osnailyfacter::ceph::ceph_pools\u0027. So what exactly is going to be changed in tasks.yaml?","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6babe909c43a46c6930336f5885dc6f84067b146","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Each manifest contained inside of \u0027deployment/puppet/osnailyfacter/modular\u0027"},{"line_number":120,"context_line":"will need to be moved inside of \u0027deployment/puppet/osnailyfacter/manifests\u0027"},{"line_number":121,"context_line":"and each corresponding task.yaml needs to be updated to reflect the directory"},{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_92103703","line":122,"range":{"start_line":121,"start_character":0,"end_line":122,"end_character":6},"updated":"2016-03-02 19:32:34.000000000","message":"This part should probably be removed as it\u0027s not required for this effort.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"0f53e86e56a27a3547d4a40f13391e2deb719286","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Each manifest contained inside of \u0027deployment/puppet/osnailyfacter/modular\u0027"},{"line_number":120,"context_line":"will need to be moved inside of \u0027deployment/puppet/osnailyfacter/manifests\u0027"},{"line_number":121,"context_line":"and each corresponding task.yaml needs to be updated to reflect the directory"},{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_9db16de4","line":122,"range":{"start_line":121,"start_character":5,"end_line":122,"end_character":6},"in_reply_to":"7af24918_3d484887","updated":"2016-03-02 19:03:06.000000000","message":"Please add an example of change in tasks.yaml.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":20106,"name":"Alexander Noskov","email":"anoskov@mirantis.com","username":"alexander_noskov"},"change_message_id":"19014af57b3c629decced75b65367b8f0eff6118","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Each manifest contained inside of \u0027deployment/puppet/osnailyfacter/modular\u0027"},{"line_number":120,"context_line":"will need to be moved inside of \u0027deployment/puppet/osnailyfacter/manifests\u0027"},{"line_number":121,"context_line":"and each corresponding task.yaml needs to be updated to reflect the directory"},{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_11f5d7eb","line":122,"range":{"start_line":121,"start_character":0,"end_line":122,"end_character":6},"in_reply_to":"7af24918_92103703","updated":"2016-03-04 10:48:28.000000000","message":"It would be effective to MOVE each task from\ndeployment/puppet/osnailyfacter/modular/\u003ctasks_dir\u003e/*.pp\ninto\ndeployment/puppet/osnailyfacter/manifests/\u003ctasks_dir\u003e/\nwrap each manifest, to become a class and update tasks.yaml like this:\ntasks.yaml\n...\npuppet_manifest: /etc/puppet/modules/osnailyfacter/manifests/ceph/mon.pp\n...\nTo call this tasks directly and avoid unnecessary \u0027include\u0027 and unnecessary *.pp files in ../osnailyfacter/modular/\u003ctasks_dir\u003e/","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"5268a995988f24badc01cc4bba2e6aba85e5c9a4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Each manifest contained inside of \u0027deployment/puppet/osnailyfacter/modular\u0027"},{"line_number":120,"context_line":"will need to be moved inside of \u0027deployment/puppet/osnailyfacter/manifests\u0027"},{"line_number":121,"context_line":"and each corresponding task.yaml needs to be updated to reflect the directory"},{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."},{"line_number":126,"context_line":"Fuel Library\u0027s Puppetfile should be updated to include the new repo and ref for"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_40456715","line":123,"range":{"start_line":122,"start_character":9,"end_line":123,"end_character":26},"updated":"2016-03-02 08:58:43.000000000","message":"What about double resource declarations and dependencies? If you try to include all the current modular manifests into single catalog that would cause a ton of catalog compilation errors related to double declarations and dependency issues. If you try to resolve them for Puppet Master you will break granular deployment. Putting every resource into \"if !defined\" would be a nightmare.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6babe909c43a46c6930336f5885dc6f84067b146","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Each manifest contained inside of \u0027deployment/puppet/osnailyfacter/modular\u0027"},{"line_number":120,"context_line":"will need to be moved inside of \u0027deployment/puppet/osnailyfacter/manifests\u0027"},{"line_number":121,"context_line":"and each corresponding task.yaml needs to be updated to reflect the directory"},{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."},{"line_number":126,"context_line":"Fuel Library\u0027s Puppetfile should be updated to include the new repo and ref for"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_d2cf5f7d","line":123,"range":{"start_line":122,"start_character":9,"end_line":123,"end_character":26},"in_reply_to":"7af24918_403f27d6","updated":"2016-03-02 19:32:34.000000000","message":"This is up to the end user to resolve and not necessarily something that needs to be taken into account by fuel library itself. It would be up to the end user to include the required modular code (in the puppet master environment) in such a way that it does not conflict.  That being there are tasks that will have this issue so it would be good to explain how this will be worked around.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9a96284bdfc27284d7a63bba9ff16e5ac0283d98","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Each manifest contained inside of \u0027deployment/puppet/osnailyfacter/modular\u0027"},{"line_number":120,"context_line":"will need to be moved inside of \u0027deployment/puppet/osnailyfacter/manifests\u0027"},{"line_number":121,"context_line":"and each corresponding task.yaml needs to be updated to reflect the directory"},{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."},{"line_number":126,"context_line":"Fuel Library\u0027s Puppetfile should be updated to include the new repo and ref for"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_403f27d6","line":123,"range":{"start_line":122,"start_character":9,"end_line":123,"end_character":26},"in_reply_to":"7af24918_40456715","updated":"2016-03-02 09:11:46.000000000","message":"Yes, a good concern, please illustrate this by PoC patches, if there are any.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"9fc503c99e05c6989af80b4cf8069a7fa227563f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Each manifest contained inside of \u0027deployment/puppet/osnailyfacter/modular\u0027"},{"line_number":120,"context_line":"will need to be moved inside of \u0027deployment/puppet/osnailyfacter/manifests\u0027"},{"line_number":121,"context_line":"and each corresponding task.yaml needs to be updated to reflect the directory"},{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."},{"line_number":126,"context_line":"Fuel Library\u0027s Puppetfile should be updated to include the new repo and ref for"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_c65ae129","line":123,"range":{"start_line":122,"start_character":9,"end_line":123,"end_character":26},"in_reply_to":"7af24918_d2cf5f7d","updated":"2016-03-03 07:58:25.000000000","message":"\u003e This is up to the end user to resolve\n\nOK, lgtm, let\u0027s specify this in the spec please.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"5268a995988f24badc01cc4bba2e6aba85e5c9a4","unresolved":false,"context_lines":[{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."},{"line_number":126,"context_line":"Fuel Library\u0027s Puppetfile should be updated to include the new repo and ref for"},{"line_number":127,"context_line":"osnailyfacter."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_405ba72e","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":70},"updated":"2016-03-02 08:58:43.000000000","message":"Please note that we also want to move other modules from library to their own repos. So what will remain in fuel-library in the end? Only Puppetfile and jenkins scripts?","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":6677,"name":"Oleg Gelbukh","email":"ogelbukh@mirantis.com","username":"gelbuhos"},"change_message_id":"f5ed130addb8207ecabb3a9246c94f0585b3ac5b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."},{"line_number":126,"context_line":"Fuel Library\u0027s Puppetfile should be updated to include the new repo and ref for"},{"line_number":127,"context_line":"osnailyfacter."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_acb0a444","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":70},"in_reply_to":"7af24918_405ba72e","updated":"2016-03-02 10:01:52.000000000","message":"And RPM/DEB build specs.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6babe909c43a46c6930336f5885dc6f84067b146","unresolved":false,"context_lines":[{"line_number":122,"context_line":"change.  This will make osnailyfacter compatible with either master or"},{"line_number":123,"context_line":"masterless Puppet approach."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"osnailyfacter module should also be moved into its own git repository."},{"line_number":126,"context_line":"Fuel Library\u0027s Puppetfile should be updated to include the new repo and ref for"},{"line_number":127,"context_line":"osnailyfacter."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_72864b14","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":70},"in_reply_to":"7af24918_acb0a444","updated":"2016-03-02 19:32:34.000000000","message":"I don\u0027t think we should split out osnailyfacter and based on conversations I\u0027ve had around this I think this is no longer required.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"0f53e86e56a27a3547d4a40f13391e2deb719286","unresolved":false,"context_lines":[{"line_number":205,"context_line":"Implementation"},{"line_number":206,"context_line":"--------------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"The re-factoring work has already been completed by AT\u0026T and is intended"},{"line_number":209,"context_line":"to be upstreamed/merged with Fuel Library.  Any gaps between when the work was"},{"line_number":210,"context_line":"completed and any changes that have occurred to osnailyfacter between that time"},{"line_number":211,"context_line":"and the time of implementation will be addresssed by AT\u0026T at the time of"},{"line_number":212,"context_line":"implementation to ensure that all code is accounted for."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Assignee(s)"},{"line_number":215,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_3d0939de","line":212,"range":{"start_line":208,"start_character":0,"end_line":212,"end_character":56},"updated":"2016-03-02 19:03:06.000000000","message":"This information does not look useful for spec reviewers and/or community. Please remove.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"0f53e86e56a27a3547d4a40f13391e2deb719286","unresolved":false,"context_lines":[{"line_number":214,"context_line":"Assignee(s)"},{"line_number":215,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Who is leading the writing of the code? Or is this a blueprint where you\u0027re"},{"line_number":218,"context_line":"throwing it out there to see who picks it up?"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":221,"context_line":"primary author and contact."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Primary assignee:"},{"line_number":224,"context_line":"  Scott Brimhall (sbrimhall)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_dd4c9544","line":221,"range":{"start_line":217,"start_character":0,"end_line":221,"end_character":27},"updated":"2016-03-02 19:03:06.000000000","message":"Does not seem valid here.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"0f53e86e56a27a3547d4a40f13391e2deb719286","unresolved":false,"context_lines":[{"line_number":233,"context_line":"Work Items"},{"line_number":234,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* identify any changes in osnailyfacter manifests that have occurred since"},{"line_number":237,"context_line":"  re-factoring was done and the time of merging of code."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* ensure all code is accounted for and merge code to move manifests in"},{"line_number":240,"context_line":"  osnailyfacter/modular to osnailyfacter/manifests."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_1dca7d6d","line":240,"range":{"start_line":236,"start_character":0,"end_line":240,"end_character":51},"updated":"2016-03-02 19:03:06.000000000","message":"It looks like this info is meaningful only for engineers who are working on it, but not for external reviewers. Could you please provide work items you are going to implement for fuel-library not for your internal repo?","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"0f53e86e56a27a3547d4a40f13391e2deb719286","unresolved":false,"context_lines":[{"line_number":257,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"* All classes inside of osnailyfacter/manifests can be included via \u0027include\u0027"},{"line_number":260,"context_line":"  puppet function while only specifying either the location of \u0027osnailyfacter\u0027"},{"line_number":261,"context_line":"  or \u0027modules\u0027 directory as the module path."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"* All tasks using osnailyfacter/modular are updated to osnailyfacter/manifests"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7af24918_bd9f094f","line":261,"range":{"start_line":260,"start_character":18,"end_line":261,"end_character":43},"updated":"2016-03-02 19:03:06.000000000","message":"Could you please clarfy this part.","commit_id":"515bc2a5659ae3f80dc6a26edea5c1595b9dd2aa"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"08ffe9d713a52e3830aa8a91e32136d1ea6e91d2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"--------------------"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The modular manifests contained inside of \u0027osnailyfacter/modular\u0027 are"},{"line_number":23,"context_line":"inaccessible to a 3rd party service, such as Puppet Master, as they are"},{"line_number":24,"context_line":"located inside of \u0027osnailyfacter/modular\u0027.  Under the Modular Fundamentals"},{"line_number":25,"context_line":"guidelines outlined by Puppetlabs, Puppet\u0027s autoinclude looks in \u0027manifests\u0027"},{"line_number":26,"context_line":"for Puppet manifests.  It does not know anything about any directory named"},{"line_number":27,"context_line":"\u0027modular\u0027.  This means that the top-scope modular manifests located inside"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_6eac228c","line":24,"range":{"start_line":23,"start_character":60,"end_line":24,"end_character":41},"updated":"2016-03-04 16:37:09.000000000","message":"Not exactly. They are not accessible by puppet master because they were designed to be top scope manifests for masterless puppet apply. And of course they should be anywhere but not in MODULE_NAME/manifests. So it\u0027s not a mistake, it was designed this way.","commit_id":"7b3dce63b7e388136595fb0bca17c4cd53e9308c"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"08ffe9d713a52e3830aa8a91e32136d1ea6e91d2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u0027modular\u0027.  This means that the top-scope modular manifests located inside"},{"line_number":28,"context_line":"of \u0027osnailyfacter/modular\u0027 are not consumable by a 3rd party plugin"},{"line_number":29,"context_line":"integration."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"----------------"},{"line_number":32,"context_line":"Proposed changes"},{"line_number":33,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7af24918_ae658a1e","line":30,"updated":"2016-03-04 16:37:09.000000000","message":"Can we please rewrite the problem description to something like:\n\nCurrently Fuel uses a set of top-scope manifests contained inside of \u0027osnailyfacter/modular\u0027 directory for masterless puppet apply. This means that those composition layer manifests are not consumable by a 3rd party plugin integration, such as using Puppet Master.","commit_id":"7b3dce63b7e388136595fb0bca17c4cd53e9308c"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"4410edf7722983066ff60097bdb415b9d1f304a3","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The Fuel Library module `deployment/puppet/osnailyfacter` is Fuel Library\u0027s"},{"line_number":14,"context_line":"composition layer module.  In order to be able to use an LCM plugin to Fuel"},{"line_number":15,"context_line":"\u0026 use a 3rd party service, such as Puppet Master, I need the modular manifests"},{"line_number":16,"context_line":"contained in this module to be accessible by a 3rd party service."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_66e71f13","line":15,"range":{"start_line":15,"start_character":50,"end_line":15,"end_character":51},"updated":"2016-03-07 10:31:44.000000000","message":"whoami?","commit_id":"f536948e9b009a7455ca42776f82c33fa107682e"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"4142501751be686468ccee9c18da4f8b0beaff78","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed changes"},{"line_number":33,"context_line":"----------------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"I would like to leave the contents of these modular manifests"},{"line_number":36,"context_line":"alone but I would like to reorganize them into profile classes inside of"},{"line_number":37,"context_line":"the \u0027osnailyfacter/manifests\u0027 directory."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"We will re-factor and move the configuration logic from the the manifests in"},{"line_number":40,"context_line":"\u0027osnailyfacter/modular\u0027 into consumable profile classes by copying their"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_7274fefc","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":40},"updated":"2016-03-07 09:58:32.000000000","message":"Shouldn\u0027t spec be more impersonal?","commit_id":"f536948e9b009a7455ca42776f82c33fa107682e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"4410edf7722983066ff60097bdb415b9d1f304a3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"alone but I would like to reorganize them into profile classes inside of"},{"line_number":37,"context_line":"the \u0027osnailyfacter/manifests\u0027 directory."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"We will re-factor and move the configuration logic from the the manifests in"},{"line_number":40,"context_line":"\u0027osnailyfacter/modular\u0027 into consumable profile classes by copying their"},{"line_number":41,"context_line":"contents to a file of the same name, but located in the"},{"line_number":42,"context_line":"\u0027osnailyfacter/manifests\u0027 directory.  We will also wrap them in a class"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_a69f675e","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":2},"updated":"2016-03-07 10:31:44.000000000","message":"who are we?","commit_id":"f536948e9b009a7455ca42776f82c33fa107682e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"4410edf7722983066ff60097bdb415b9d1f304a3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  \u0027osnailyfacter/manifests\u0027 directory, integration of a 3rd party plugin to"},{"line_number":58,"context_line":"  consume the class is now possible."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The tasks.yaml file can still reference the same \u0027modular/\u003cname\u003e.pp\u0027 manifest."},{"line_number":61,"context_line":"By applying the include statement shown above, the manifest will still apply"},{"line_number":62,"context_line":"the same configuration logic as it did before.  The location of the code has"},{"line_number":63,"context_line":"just been reorganized into the \u0027manifests\u0027 directory.  No new feature is added"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_a9c8d875","line":60,"updated":"2016-03-07 10:31:44.000000000","message":"As part of redesign \u0027osnailyfacter/modular\u0027 I would like to move task.yaml outside of \u0027\ndeployment/puppet\u0027 to leave manifests only in \u0027deployment/puppet\u0027","commit_id":"f536948e9b009a7455ca42776f82c33fa107682e"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"4142501751be686468ccee9c18da4f8b0beaff78","unresolved":false,"context_lines":[{"line_number":201,"context_line":"Assignee(s)"},{"line_number":202,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Who is leading the writing of the code? Or is this a blueprint where you\u0027re"},{"line_number":205,"context_line":"throwing it out there to see who picks it up?"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":208,"context_line":"primary author and contact."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Primary assignee:"},{"line_number":211,"context_line":"  Scott Brimhall (grimlock86)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_32cb9674","line":208,"range":{"start_line":204,"start_character":0,"end_line":208,"end_character":27},"updated":"2016-03-07 09:58:32.000000000","message":"This does not make much sense.","commit_id":"f536948e9b009a7455ca42776f82c33fa107682e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"4410edf7722983066ff60097bdb415b9d1f304a3","unresolved":false,"context_lines":[{"line_number":201,"context_line":"Assignee(s)"},{"line_number":202,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Who is leading the writing of the code? Or is this a blueprint where you\u0027re"},{"line_number":205,"context_line":"throwing it out there to see who picks it up?"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":208,"context_line":"primary author and contact."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Primary assignee:"},{"line_number":211,"context_line":"  Scott Brimhall (grimlock86)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_e98e6026","line":208,"range":{"start_line":204,"start_character":0,"end_line":208,"end_character":27},"in_reply_to":"5aef4532_32cb9674","updated":"2016-03-07 10:31:44.000000000","message":"+1","commit_id":"f536948e9b009a7455ca42776f82c33fa107682e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"4410edf7722983066ff60097bdb415b9d1f304a3","unresolved":false,"context_lines":[{"line_number":214,"context_line":"  Andrew Woodward (xarses)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Mandatory design review:"},{"line_number":217,"context_line":"  Andrew Woodward (xarses)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_49a03491","line":217,"updated":"2016-03-07 10:31:44.000000000","message":"Please add me and A. Didenko as Mandatory Reviewers","commit_id":"f536948e9b009a7455ca42776f82c33fa107682e"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"4142501751be686468ccee9c18da4f8b0beaff78","unresolved":false,"context_lines":[{"line_number":223,"context_line":"* Identify changes dependent on https://review.openstack.org/#/c/281557/"},{"line_number":224,"context_line":"  \u0026 https://blueprints.launchpad.net/fuel/+spec/fuel-remove-conflict-openstack"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"* Re-base commits of each directory and merge during an identified quiet period"},{"line_number":227,"context_line":"  after all other FFE work concerning Fuel Library has been completed"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_b2996622","line":226,"range":{"start_line":226,"start_character":10,"end_line":226,"end_character":17},"updated":"2016-03-07 09:58:32.000000000","message":"What commits?","commit_id":"f536948e9b009a7455ca42776f82c33fa107682e"}]}
