)]}'
{"specs/5.1/ml2-neutron.rst":[{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"db3a1004b1c7213b1895051e1e6d29317abec752","unresolved":false,"context_lines":[{"line_number":194,"context_line":"          physnet: physnet2"},{"line_number":195,"context_line":"          router_ext: false"},{"line_number":196,"context_line":"        tenant: admin"},{"line_number":197,"context_line":"    L2:"},{"line_number":198,"context_line":"      phys_nets:"},{"line_number":199,"context_line":"        physnet1:"},{"line_number":200,"context_line":"          bridge: br-ex"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_369d9c67","line":197,"updated":"2014-06-16 15:47:36.000000000","message":"I think we should add keyword \u0027provider\u0027 to this section. for example \u0027provider: ovs\u0027 will call old handler for L2 section, \u0027provider: ml2\u0027 -- new handler","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"caca5199fa92c9753eae2dcccf39638a5646d4b9","unresolved":false,"context_lines":[{"line_number":194,"context_line":"          physnet: physnet2"},{"line_number":195,"context_line":"          router_ext: false"},{"line_number":196,"context_line":"        tenant: admin"},{"line_number":197,"context_line":"    L2:"},{"line_number":198,"context_line":"      phys_nets:"},{"line_number":199,"context_line":"        physnet1:"},{"line_number":200,"context_line":"          bridge: br-ex"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_17879e13","line":197,"in_reply_to":"1ae5cdf2_369d9c67","updated":"2014-06-17 01:14:50.000000000","message":"Done","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"d1fed67c33f48bc9f1f24861bf9a7b1b41fbb89d","unresolved":false,"context_lines":[{"line_number":213,"context_line":"Items to discuss:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":216,"context_line":"  testing in NeutronDeploymentSerlializer."},{"line_number":217,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":218,"context_line":"* create_predefined_networks_and_routers: there are now separate handlers for"},{"line_number":219,"context_line":"  these, we should use them instead."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_33f04e91","line":216,"updated":"2014-06-16 10:46:47.000000000","message":"please explain, what is the NeutronDeploymentSerlializer?","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"d28f03a93d9ce9b635b9f28efbd75ae1b38f7f32","unresolved":false,"context_lines":[{"line_number":213,"context_line":"Items to discuss:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":216,"context_line":"  testing in NeutronDeploymentSerlializer."},{"line_number":217,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":218,"context_line":"* create_predefined_networks_and_routers: there are now separate handlers for"},{"line_number":219,"context_line":"  these, we should use them instead."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_9f8bd767","line":216,"in_reply_to":"1ae5cdf2_33f04e91","updated":"2014-06-16 15:38:55.000000000","message":"It\u0027s a method in Nailgun which generates an Astute.yaml content.\n\nhttps://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/orchestrator/deployment_serializers.py#L657","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"edd7ae7a19ecce50c1b4b8b25d19980fde8cfb42","unresolved":false,"context_lines":[{"line_number":213,"context_line":"Items to discuss:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":216,"context_line":"  testing in NeutronDeploymentSerlializer."},{"line_number":217,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":218,"context_line":"* create_predefined_networks_and_routers: there are now separate handlers for"},{"line_number":219,"context_line":"  these, we should use them instead."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_65467e23","line":216,"in_reply_to":"1ae5cdf2_3fd9e3f4","updated":"2014-06-16 16:21:35.000000000","message":"No, that\u0027s exactly why it should go away. We have configuration that only exists at run-time, and overwrites the defaults provided by both upstream puppet and neutron. This makes it nearly impossible to maintain, the ruby handlers should not be making assumptions like these. Every one expects these kinds of things to be done in the puppet manifests or in the data we send them.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"6aacaab7fd0540e254970783fb02fbb5af0d3ea1","unresolved":false,"context_lines":[{"line_number":213,"context_line":"Items to discuss:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":216,"context_line":"  testing in NeutronDeploymentSerlializer."},{"line_number":217,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":218,"context_line":"* create_predefined_networks_and_routers: there are now separate handlers for"},{"line_number":219,"context_line":"  these, we should use them instead."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_6132e9f3","line":216,"in_reply_to":"1ae5cdf2_481ef70e","updated":"2014-06-16 20:19:39.000000000","message":"1. This defaults allow make working quantum_settings section without many lines, that  duplicate another lines from astute.yaml. Peoples from service team shouldn\u0027t write many lines of yaml for get working config. All defaults may be documented.\n\n2. now all parts of code for neutron deployment stored in one place. now we have parser functions, puppet modules, etc... in one project. We can easy fill it by unit tests. If we move sanitizing of config to nailgun we make developers workflow worse.\n\n3. IMHO we shouldn\u0027t pray to upstream manifests. And to its defaults.  We can use good stuff from it -- it\u0027s good idea, but using all from its leads to the set of warkarounds.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"651d662a0470c56b1f37176b8feccc960e2c2405","unresolved":false,"context_lines":[{"line_number":213,"context_line":"Items to discuss:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":216,"context_line":"  testing in NeutronDeploymentSerlializer."},{"line_number":217,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":218,"context_line":"* create_predefined_networks_and_routers: there are now separate handlers for"},{"line_number":219,"context_line":"  these, we should use them instead."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_e197d938","line":216,"in_reply_to":"1ae5cdf2_6132e9f3","updated":"2014-06-16 20:33:55.000000000","message":"IMHO, we should refactoring sanitize procedure, make it pluggable and more clean, but leave in a puppet side.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8829,"name":"Ryan Moe","email":"rmoe@mirantis.com","username":"rmoe"},"change_message_id":"1836d62b1d0bdd20ae89539a41507cf046b0ab2c","unresolved":false,"context_lines":[{"line_number":213,"context_line":"Items to discuss:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":216,"context_line":"  testing in NeutronDeploymentSerlializer."},{"line_number":217,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":218,"context_line":"* create_predefined_networks_and_routers: there are now separate handlers for"},{"line_number":219,"context_line":"  these, we should use them instead."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_481ef70e","line":216,"in_reply_to":"1ae5cdf2_65467e23","updated":"2014-06-16 16:43:52.000000000","message":"+1 to Andrew. People don\u0027t expect the documented defaults to be overridden at deployment time with no chance to modify them. The effort for us to maintain these default values in some ruby function is not worth it (and in fact has not been done, our \"defaults\" don\u0027t match upstream neutron defaults).","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"db3a1004b1c7213b1895051e1e6d29317abec752","unresolved":false,"context_lines":[{"line_number":213,"context_line":"Items to discuss:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":216,"context_line":"  testing in NeutronDeploymentSerlializer."},{"line_number":217,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":218,"context_line":"* create_predefined_networks_and_routers: there are now separate handlers for"},{"line_number":219,"context_line":"  these, we should use them instead."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_3fd9e3f4","line":216,"in_reply_to":"1ae5cdf2_9f8bd767","updated":"2014-06-16 15:47:36.000000000","message":"I think is not good idea. Sanitize_network_config gives neutron config with default values, and allow put to the astute.yaml only minimal set of variables. It allows make cli-configuration of Neutron more simple.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"dd986773682d9b570fa7fea788f6e8b00aeeab46","unresolved":false,"context_lines":[{"line_number":213,"context_line":"Items to discuss:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":216,"context_line":"  testing in NeutronDeploymentSerlializer."},{"line_number":217,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":218,"context_line":"* create_predefined_networks_and_routers: there are now separate handlers for"},{"line_number":219,"context_line":"  these, we should use them instead."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_31baeac0","line":216,"in_reply_to":"1ae5cdf2_e197d938","updated":"2014-06-16 23:58:49.000000000","message":"1. No, the defaults generated by sanitize_network_config do much more than that: they override _all_ neutron settings, including those that Fuel doesn\u0027t have a good reason to override. What they don\u0027t do, as Ryan has pointed out above, is track changes in upstream defaults, which did cause bugs in Fuel when upstream default was changed to address a problem and that fix was ignored in sanitize_network_config.\n\n2. Doing everything in one place is not necessarily a good thing (http://www.laputan.org/mud/mud.html). Computer scientists invented all sorts of ways to modularize code so that you wouldn\u0027t have to do everything in one place. Upstream puppet-neutron already has a pretty comprehensive set of spec tests, all we really need on top of that is additional tests for our own additions (and it would help to test them if they\u0027re modularized and not in the same place as everything else), not replacing all those (which, as past experience shows, we\u0027re never going to have enough time for).\n\n3. Nobody\u0027s suggesting to take _all_ upstream defaults and never override _any_ of them. But overriding _all_ of them makes even less sense: for every variable you do have a reason to change, there\u0027s 10 that you don\u0027t, and most of these we\u0027re actually setting to a value that is or at some point in the past used to be the upstream default.\n\n4. No. Neutron is not that special, and neither is puppet-neutron. We have an architecture that we follow throughout Fuel for all services we deploy, and sanitize_network_config is a major deviation from that architecture. The burden of proof is on proving that there are good reasons to keep it, not on going with upstream and being consistent with the rest of Fuel.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"d1fed67c33f48bc9f1f24861bf9a7b1b41fbb89d","unresolved":false,"context_lines":[{"line_number":223,"context_line":"* possibly clean up q-agent-cleanup.py, there is open bug about time it"},{"line_number":224,"context_line":"  takes to run"},{"line_number":225,"context_line":"* Its not necessary to run DHCP agent in HA, we can run more than one per"},{"line_number":226,"context_line":"  network as HA solution."},{"line_number":227,"context_line":"* need to support linuxbridge, this should be simply allowing network_scheme"},{"line_number":228,"context_line":"  in astute.yaml to have less data, and passing slightly different data to"},{"line_number":229,"context_line":"  quantum_settings."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_f310a651","line":226,"updated":"2014-06-16 10:46:47.000000000","message":"But we shouldn\u0027t do this if we want for our HA wil really HA.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"d1fed67c33f48bc9f1f24861bf9a7b1b41fbb89d","unresolved":false,"context_lines":[{"line_number":226,"context_line":"  network as HA solution."},{"line_number":227,"context_line":"* need to support linuxbridge, this should be simply allowing network_scheme"},{"line_number":228,"context_line":"  in astute.yaml to have less data, and passing slightly different data to"},{"line_number":229,"context_line":"  quantum_settings."},{"line_number":230,"context_line":"* ml2-plugin supports multiple type_drivers at a time, nailgun and UI should"},{"line_number":231,"context_line":"  be updated to allow for this as well."},{"line_number":232,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_53d6baf2","line":229,"updated":"2014-06-16 10:46:47.000000000","message":"This task should be divided to independed task/blueprint, because it leads to huge changes in nailgun, l23network, the current network schema.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"edd7ae7a19ecce50c1b4b8b25d19980fde8cfb42","unresolved":false,"context_lines":[{"line_number":226,"context_line":"  network as HA solution."},{"line_number":227,"context_line":"* need to support linuxbridge, this should be simply allowing network_scheme"},{"line_number":228,"context_line":"  in astute.yaml to have less data, and passing slightly different data to"},{"line_number":229,"context_line":"  quantum_settings."},{"line_number":230,"context_line":"* ml2-plugin supports multiple type_drivers at a time, nailgun and UI should"},{"line_number":231,"context_line":"  be updated to allow for this as well."},{"line_number":232,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_a515e6e6","line":229,"in_reply_to":"1ae5cdf2_1fec278f","updated":"2014-06-16 16:21:35.000000000","message":"The changes to nailgun appear to be very minor, l23netwrok/network schema barely needs to be involved. Setting up linuxbridge appears to be as simple just setting the interfaces to use.\n\nRegardless this is an action to take after this BP is implemented and is outside of scope.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"d28f03a93d9ce9b635b9f28efbd75ae1b38f7f32","unresolved":false,"context_lines":[{"line_number":226,"context_line":"  network as HA solution."},{"line_number":227,"context_line":"* need to support linuxbridge, this should be simply allowing network_scheme"},{"line_number":228,"context_line":"  in astute.yaml to have less data, and passing slightly different data to"},{"line_number":229,"context_line":"  quantum_settings."},{"line_number":230,"context_line":"* ml2-plugin supports multiple type_drivers at a time, nailgun and UI should"},{"line_number":231,"context_line":"  be updated to allow for this as well."},{"line_number":232,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_9fecb7f5","line":229,"in_reply_to":"1ae5cdf2_53d6baf2","updated":"2014-06-16 15:38:55.000000000","message":"Mostly in l23network module. Nailgun can be altered easily as soon as we argee about network architecture with linuxbridges.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"db3a1004b1c7213b1895051e1e6d29317abec752","unresolved":false,"context_lines":[{"line_number":226,"context_line":"  network as HA solution."},{"line_number":227,"context_line":"* need to support linuxbridge, this should be simply allowing network_scheme"},{"line_number":228,"context_line":"  in astute.yaml to have less data, and passing slightly different data to"},{"line_number":229,"context_line":"  quantum_settings."},{"line_number":230,"context_line":"* ml2-plugin supports multiple type_drivers at a time, nailgun and UI should"},{"line_number":231,"context_line":"  be updated to allow for this as well."},{"line_number":232,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_1fec278f","line":229,"in_reply_to":"1ae5cdf2_9fecb7f5","updated":"2014-06-16 15:47:36.000000000","message":"not only. Mostly -- network schema topology and nailgun logic.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":406,"name":"Mike Scherbakov","email":"mihgen@gmail.com","username":"mihgen"},"change_message_id":"bc4d0a70ebf9c1104e8627ecf27b902665723619","unresolved":false,"context_lines":[{"line_number":277,"context_line":"New code should reduce dependancy complexity and hopefully improve deployment"},{"line_number":278,"context_line":"performance."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Other deployer impact"},{"line_number":281,"context_line":"---------------------"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"quantum_settings should be further re-factored to more closely resemble the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_5891b7ef","line":280,"updated":"2014-06-13 04:03:57.000000000","message":"please add upgrades impact","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"caca5199fa92c9753eae2dcccf39638a5646d4b9","unresolved":false,"context_lines":[{"line_number":277,"context_line":"New code should reduce dependancy complexity and hopefully improve deployment"},{"line_number":278,"context_line":"performance."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Other deployer impact"},{"line_number":281,"context_line":"---------------------"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"quantum_settings should be further re-factored to more closely resemble the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_f7bf92a8","line":280,"in_reply_to":"1ae5cdf2_11e88e15","updated":"2014-06-17 01:14:50.000000000","message":"do we care about transforms for astute.yaml between versions, that\u0027s the only thing that I can think may be an issue.","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"f3b7ef1583fe57ee5876bc357aed52383e4cdcdb","unresolved":false,"context_lines":[{"line_number":277,"context_line":"New code should reduce dependancy complexity and hopefully improve deployment"},{"line_number":278,"context_line":"performance."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Other deployer impact"},{"line_number":281,"context_line":"---------------------"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"quantum_settings should be further re-factored to more closely resemble the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_73c9e478","line":280,"in_reply_to":"1ae5cdf2_5891b7ef","updated":"2014-06-16 21:00:22.000000000","message":"Mike, please expand on what you mean by \"add upgrades impact\"","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"dd986773682d9b570fa7fea788f6e8b00aeeab46","unresolved":false,"context_lines":[{"line_number":277,"context_line":"New code should reduce dependancy complexity and hopefully improve deployment"},{"line_number":278,"context_line":"performance."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Other deployer impact"},{"line_number":281,"context_line":"---------------------"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"quantum_settings should be further re-factored to more closely resemble the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_11e88e15","line":280,"in_reply_to":"1ae5cdf2_73c9e478","updated":"2014-06-16 23:58:49.000000000","message":"Mike means, how will upgrades from Fuel 5.0 to 5.1 be impacted by this change? Will it be fully transparent or is there special code that needs to be written to handle upgrades?","commit_id":"daa8b6df5244814042fd230b2bd9445ecbc895b8"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"d0a5336a8b19d17c48127ab1e92719b3a5ad036b","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"Items to discuss:"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":372,"context_line":"  in NeutronNetworkDeploymentSerializer"},{"line_number":373,"context_line":"  or rely on the defaults in the puppet manifest."},{"line_number":374,"context_line":"* waistline: appears to be un-necessary and should be removed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_ad8dc02c","line":371,"updated":"2014-06-16 22:45:21.000000000","message":"any -\u003e all?","commit_id":"0110f97dd5810c7383919ac2697d08dab37c420a"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"56a698dfa2b59d4eedfa49cf9569ba3619eb0bde","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"Items to discuss:"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":372,"context_line":"  in NeutronNetworkDeploymentSerializer"},{"line_number":373,"context_line":"  or rely on the defaults in the puppet manifest."},{"line_number":374,"context_line":"* waistline: appears to be un-necessary and should be removed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_3793ba50","line":371,"in_reply_to":"1ae5cdf2_ad8dc02c","updated":"2014-06-17 01:14:14.000000000","message":"Done","commit_id":"0110f97dd5810c7383919ac2697d08dab37c420a"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"d0a5336a8b19d17c48127ab1e92719b3a5ad036b","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":372,"context_line":"  in NeutronNetworkDeploymentSerializer"},{"line_number":373,"context_line":"  or rely on the defaults in the puppet manifest."},{"line_number":374,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":375,"context_line":"* create_predefined_networks_and_routers: This will need to be abstracted into"},{"line_number":376,"context_line":"  a method that can be consumed by the manifests or carried forward in the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_0d9dd459","line":373,"updated":"2014-06-16 22:45:21.000000000","message":"and neutron\u0027s own defaults, of course.","commit_id":"0110f97dd5810c7383919ac2697d08dab37c420a"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"56a698dfa2b59d4eedfa49cf9569ba3619eb0bde","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"* sanitize_network_config: should be removed, we should be doing any of this"},{"line_number":372,"context_line":"  in NeutronNetworkDeploymentSerializer"},{"line_number":373,"context_line":"  or rely on the defaults in the puppet manifest."},{"line_number":374,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":375,"context_line":"* create_predefined_networks_and_routers: This will need to be abstracted into"},{"line_number":376,"context_line":"  a method that can be consumed by the manifests or carried forward in the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_5798466a","line":373,"in_reply_to":"1ae5cdf2_0d9dd459","updated":"2014-06-17 01:14:14.000000000","message":"Done","commit_id":"0110f97dd5810c7383919ac2697d08dab37c420a"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"d0a5336a8b19d17c48127ab1e92719b3a5ad036b","unresolved":false,"context_lines":[{"line_number":489,"context_line":"* Compare current neutron plugin with upstream 1d (DONE)"},{"line_number":490,"context_line":"* Model changes to pull down upstream 2d (WIP)"},{"line_number":491,"context_line":"* Produce working prototype 2d (TODO)"},{"line_number":492,"context_line":"* Submit for review and testing 2d (TODO)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_ede508dd","line":492,"updated":"2014-06-16 22:45:21.000000000","message":"Spec is not the right place to track generic work items (such as poc, review, and testing) and their statuses. It should be only about decomposition of proposed changes as described above into smaller trackable bits.","commit_id":"0110f97dd5810c7383919ac2697d08dab37c420a"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"56a698dfa2b59d4eedfa49cf9569ba3619eb0bde","unresolved":false,"context_lines":[{"line_number":489,"context_line":"* Compare current neutron plugin with upstream 1d (DONE)"},{"line_number":490,"context_line":"* Model changes to pull down upstream 2d (WIP)"},{"line_number":491,"context_line":"* Produce working prototype 2d (TODO)"},{"line_number":492,"context_line":"* Submit for review and testing 2d (TODO)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_d7ab7673","line":492,"in_reply_to":"1ae5cdf2_ede508dd","updated":"2014-06-17 01:14:14.000000000","message":"Done","commit_id":"0110f97dd5810c7383919ac2697d08dab37c420a"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"d8156c3b0b30f3cc331910a5bd1ec63c077c2c3b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"+     - vlan"},{"line_number":174,"context_line":"+    l2_population: true"},{"line_number":175,"context_line":"+    arp_responder: true"},{"line_number":176,"context_line":"    database:"},{"line_number":177,"context_line":"      passwd: lVnpS5Qd"},{"line_number":178,"context_line":"    metadata:"},{"line_number":179,"context_line":"      metadata_proxy_shared_secret: VBqWVGHn"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_4487a9d7","line":176,"updated":"2014-06-17 10:07:29.000000000","message":"IMHO, lines 170-175 should be relocated to \u0027L2\u0027 section.","commit_id":"6c01cbbcccc04de1cc92da411484354c8e2298b5"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"d8156c3b0b30f3cc331910a5bd1ec63c077c2c3b","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"* sanitize_network_config: should be removed, we should be doing all of this"},{"line_number":372,"context_line":"  in NeutronNetworkDeploymentSerializer or rely on the defaults in the puppet"},{"line_number":373,"context_line":"  manifests and neutron."},{"line_number":374,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":375,"context_line":"* create_predefined_networks_and_routers: This will need to be abstracted into"},{"line_number":376,"context_line":"  a method that can be consumed by the manifests or carried forward in the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_44ba496f","line":373,"updated":"2014-06-17 10:07:29.000000000","message":"Defaults from the upstream Neutron puppet manifests do not fit us. \nWe shouldn\u0027t remove sanitize procedure to another project (Nailgun).\nThis moving makes development workflow as hell. If we move it to the Nailgun, any minor changes in Neutron subsystem will leads to making changes in two projects, reassembling ISO, or making changes on master nod?,  make more difficult writing unit-tests for Neutron-HA puppet module.\n\nSanitize_network_config should be refactored for pluggable architecture, but leave on puppet-side.","commit_id":"6c01cbbcccc04de1cc92da411484354c8e2298b5"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"a8ee85121f958202bfd972f5213ab328204853a7","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"* sanitize_network_config: should be removed, we should be doing all of this"},{"line_number":372,"context_line":"  in NeutronNetworkDeploymentSerializer or rely on the defaults in the puppet"},{"line_number":373,"context_line":"  manifests and neutron."},{"line_number":374,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":375,"context_line":"* create_predefined_networks_and_routers: This will need to be abstracted into"},{"line_number":376,"context_line":"  a method that can be consumed by the manifests or carried forward in the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_54b5807c","line":373,"in_reply_to":"1ae5cdf2_44ba496f","updated":"2014-06-17 17:12:19.000000000","message":"All these arguments were already covered in the discussion of this item in patch set 1. This does not make unit tests for puppet modules any more difficult, and outside of unit tests updating /etc/puppet on a Fuel master node and running a deployment is exactly the development workflow you\u0027re supposed to use. Anything less than that isn\u0027t any better than just running unit tests.","commit_id":"6c01cbbcccc04de1cc92da411484354c8e2298b5"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"204ccad004602d019afbe70982e6dfa7f93cf1f5","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"* sanitize_network_config: should be removed, we should be doing all of this"},{"line_number":372,"context_line":"  in NeutronNetworkDeploymentSerializer or rely on the defaults in the puppet"},{"line_number":373,"context_line":"  manifests and neutron."},{"line_number":374,"context_line":"* waistline: appears to be un-necessary and should be removed."},{"line_number":375,"context_line":"* create_predefined_networks_and_routers: This will need to be abstracted into"},{"line_number":376,"context_line":"  a method that can be consumed by the manifests or carried forward in the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_479a2fc6","line":373,"in_reply_to":"1ae5cdf2_44ba496f","updated":"2014-06-17 18:27:49.000000000","message":"I am I no way in favor of stuffing every value here into nailgun. However we must put all configuration relevant to this deployment up into nailgun. This is going to become more necessary as we start to support plugins. The default values should always come from the manifest when the components [like neutron] defaults are not useful.\n\nItems like cluster addresses most of the L2 section are already defined from nailgun except possibly in a different layout. moving up the couple of missing ones like predefined-routers is needed\n\nsections like amqp, server, database, metadata should see a greater return to defaults in the manifests or neutron its self.\n\nThe L2 and L3 section needs to be discussed items like lease_duration are seriously different from upstream puppet / neutron. while enable_isolated_metadata is set to the default. Either way, these should be expressed in the manifests\n\nRegardless of where the data is moved to, having a dynamic configuration builder that only has state at run-time isn\u0027t easy for anyone to pick up and work on and likely un-usable as we move to granular roles deployment and fuel-plugins. \n\nre: splitting config between nailgun -\u003e puppet: This is already done for neutron, we have nailgun -\u003e astute.yaml -\u003e sanitize_network_config -\u003e puppet -\u003e neutron. How is moving parts of sanitize into nailgun and parts back into puppet any more complicated than it already is? This should make it much simpler to work on. Also, this is already necessary for nearly every other component.\n\nre: repacking the ISO: it is not necessary to repack the ISO to test changes to nailgun or puppet (as long as you don\u0027t want to run the system-test suite)\n\nre: testing Nuetron-HA: We don\u0027t have any unit-testing for neutron HA. There are some unit-tests for sanitize, but they don\u0027t exercise HA. We have some system tests for Neutron and HA but they are all located in the fuel-main which won\u0027t be affected by any of these changes.","commit_id":"6c01cbbcccc04de1cc92da411484354c8e2298b5"}]}
