)]}'
{"static/models.js":[{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"9be3d0f673b912433b98ed78a7dec68038d5f648","unresolved":false,"context_lines":[{"line_number":946,"context_line":"    if (untaggedNetworks.length \u003e maxUntaggedNetworksCount) {"},{"line_number":947,"context_line":"      errors.push(i18n(ns + \u0027too_many_untagged_networks\u0027));"},{"line_number":948,"context_line":"    }"},{"line_number":949,"context_line":"    var interfaceProperties \u003d this.get(\u0027interface_properties\u0027);"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    if (interfaceProperties) {"},{"line_number":952,"context_line":"      var ifcPropertiesErrors \u003d"}],"source_content_type":"text/javascript","patch_set":6,"id":"3afc51ec_78bbdae5","line":949,"updated":"2016-03-14 18:06:28.000000000","message":"I would leave _.extend(errors, this.validateInterfaceProperties(attrs)); in this main model validation method.\n\nAnd make all the ifc properties checks in the separate validateProperties method (Interface can be removed from the method\u0027s title because it is a method of Interface model).","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":9091,"name":"Alexandra Morozova","email":"astepanchuk@mirantis.com","username":"astepanchuk"},"change_message_id":"c8ac93bd77320a555c80ee95ce889fed9055368b","unresolved":false,"context_lines":[{"line_number":946,"context_line":"    if (untaggedNetworks.length \u003e maxUntaggedNetworksCount) {"},{"line_number":947,"context_line":"      errors.push(i18n(ns + \u0027too_many_untagged_networks\u0027));"},{"line_number":948,"context_line":"    }"},{"line_number":949,"context_line":"    var interfaceProperties \u003d this.get(\u0027interface_properties\u0027);"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    if (interfaceProperties) {"},{"line_number":952,"context_line":"      var ifcPropertiesErrors \u003d"}],"source_content_type":"text/javascript","patch_set":6,"id":"1af94dfe_16457216","line":949,"in_reply_to":"3afc51ec_78bbdae5","updated":"2016-03-16 11:55:11.000000000","message":"Done","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"9be3d0f673b912433b98ed78a7dec68038d5f648","unresolved":false,"context_lines":[{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    if (interfaceProperties) {"},{"line_number":952,"context_line":"      var ifcPropertiesErrors \u003d"},{"line_number":953,"context_line":"        this.validateInterfaceProperties(interfaceProperties, attrs);"},{"line_number":954,"context_line":"      if (!_.isEmpty(ifcPropertiesErrors)) {"},{"line_number":955,"context_line":"        errors.push({"},{"line_number":956,"context_line":"          interface_properties: ifcPropertiesErrors"}],"source_content_type":"text/javascript","patch_set":6,"id":"3afc51ec_d8caee6d","line":953,"range":{"start_line":953,"start_character":41,"end_line":953,"end_character":60},"updated":"2016-03-14 18:06:28.000000000","message":"At least, this argument is not needed. Ifc properties are avilable from the all model\u0027s methods.","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":9091,"name":"Alexandra Morozova","email":"astepanchuk@mirantis.com","username":"astepanchuk"},"change_message_id":"c8ac93bd77320a555c80ee95ce889fed9055368b","unresolved":false,"context_lines":[{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    if (interfaceProperties) {"},{"line_number":952,"context_line":"      var ifcPropertiesErrors \u003d"},{"line_number":953,"context_line":"        this.validateInterfaceProperties(interfaceProperties, attrs);"},{"line_number":954,"context_line":"      if (!_.isEmpty(ifcPropertiesErrors)) {"},{"line_number":955,"context_line":"        errors.push({"},{"line_number":956,"context_line":"          interface_properties: ifcPropertiesErrors"}],"source_content_type":"text/javascript","patch_set":6,"id":"1af94dfe_764cb642","line":953,"range":{"start_line":953,"start_character":41,"end_line":953,"end_character":60},"in_reply_to":"3afc51ec_d8caee6d","updated":"2016-03-16 11:55:11.000000000","message":"Done","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"9be3d0f673b912433b98ed78a7dec68038d5f648","unresolved":false,"context_lines":[{"line_number":979,"context_line":"  },"},{"line_number":980,"context_line":"  validateInterfaceProperties(interfaceProperties, attrs) {"},{"line_number":981,"context_line":"    var errors \u003d {};"},{"line_number":982,"context_line":"    var networks \u003d new models.Networks(this.get(\u0027assigned_networks\u0027)"},{"line_number":983,"context_line":"      .invoke(\u0027getFullNetwork\u0027, attrs.networks));"},{"line_number":984,"context_line":"    var ns \u003d \u0027cluster_page.nodes_tab.configure_interfaces.validation.\u0027;"},{"line_number":985,"context_line":"    var mtuValue \u003d interfaceProperties.mtu;"}],"source_content_type":"text/javascript","patch_set":6,"id":"3afc51ec_f87d2a1d","line":982,"updated":"2016-03-14 18:06:28.000000000","message":"Let\u0027s put this into L991 \u0027if\u0027 block? Networks are needed for interface with dpdk property only.","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":9091,"name":"Alexandra Morozova","email":"astepanchuk@mirantis.com","username":"astepanchuk"},"change_message_id":"c8ac93bd77320a555c80ee95ce889fed9055368b","unresolved":false,"context_lines":[{"line_number":979,"context_line":"  },"},{"line_number":980,"context_line":"  validateInterfaceProperties(interfaceProperties, attrs) {"},{"line_number":981,"context_line":"    var errors \u003d {};"},{"line_number":982,"context_line":"    var networks \u003d new models.Networks(this.get(\u0027assigned_networks\u0027)"},{"line_number":983,"context_line":"      .invoke(\u0027getFullNetwork\u0027, attrs.networks));"},{"line_number":984,"context_line":"    var ns \u003d \u0027cluster_page.nodes_tab.configure_interfaces.validation.\u0027;"},{"line_number":985,"context_line":"    var mtuValue \u003d interfaceProperties.mtu;"}],"source_content_type":"text/javascript","patch_set":6,"id":"1af94dfe_965182db","line":982,"in_reply_to":"3afc51ec_f87d2a1d","updated":"2016-03-16 11:55:11.000000000","message":"Done","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"6364b1e6e83780dfb0112c2ae8a158b3df7b7cef","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"    }"},{"line_number":1035,"context_line":"    return _.isEmpty(errors) ? null : {sriov: errors};"},{"line_number":1036,"context_line":"  },"},{"line_number":1037,"context_line":"  isDPDKAvailable() {"},{"line_number":1038,"context_line":"    return ((this.get(\u0027interface_properties\u0027) || {}).dpdk || {}).available;"},{"line_number":1039,"context_line":"  },"},{"line_number":1040,"context_line":"  isDPDKEnabled() {"},{"line_number":1041,"context_line":"    return ((this.get(\u0027interface_properties\u0027) || {}).dpdk || {}).enabled;"},{"line_number":1042,"context_line":"  }"},{"line_number":1043,"context_line":"});"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"models.Interfaces \u003d BaseCollection.extend({"}],"source_content_type":"text/javascript","patch_set":15,"id":"fa0719c6_246abeee","line":1042,"range":{"start_line":1037,"start_character":2,"end_line":1042,"end_character":3},"updated":"2016-03-23 08:39:13.000000000","message":"See no usages of these new methods.","commit_id":"1ad467eec612b598ea53c296f0d5c12808fdafa0"},{"author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"change_message_id":"41999a1c2220f838d68c5389c0febb112558f423","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"    }"},{"line_number":1035,"context_line":"    return _.isEmpty(errors) ? null : {sriov: errors};"},{"line_number":1036,"context_line":"  },"},{"line_number":1037,"context_line":"  isDPDKAvailable() {"},{"line_number":1038,"context_line":"    return ((this.get(\u0027interface_properties\u0027) || {}).dpdk || {}).available;"},{"line_number":1039,"context_line":"  },"},{"line_number":1040,"context_line":"  isDPDKEnabled() {"},{"line_number":1041,"context_line":"    return ((this.get(\u0027interface_properties\u0027) || {}).dpdk || {}).enabled;"},{"line_number":1042,"context_line":"  }"},{"line_number":1043,"context_line":"});"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"models.Interfaces \u003d BaseCollection.extend({"}],"source_content_type":"text/javascript","patch_set":15,"id":"fa0719c6_4a06d886","line":1042,"range":{"start_line":1037,"start_character":2,"end_line":1042,"end_character":3},"in_reply_to":"fa0719c6_246abeee","updated":"2016-03-23 09:55:48.000000000","message":"Done","commit_id":"1ad467eec612b598ea53c296f0d5c12808fdafa0"}],"static/styles/main.less":[{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"9be3d0f673b912433b98ed78a7dec68038d5f648","unresolved":false,"context_lines":[{"line_number":3615,"context_line":"          text-align: left;"},{"line_number":3616,"context_line":"          \u0026.has-error {"},{"line_number":3617,"context_line":"            .help-block {"},{"line_number":3618,"context_line":"              color: @red;"},{"line_number":3619,"context_line":"              display: inline;"},{"line_number":3620,"context_line":"            }"},{"line_number":3621,"context_line":"          }"}],"source_content_type":"text/x-less","patch_set":6,"id":"3afc51ec_d8f4ae88","line":3618,"updated":"2016-03-14 18:06:28.000000000","message":"Why do you need to describe this? Why doesn\u0027t it work by default?","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":9091,"name":"Alexandra Morozova","email":"astepanchuk@mirantis.com","username":"astepanchuk"},"change_message_id":"c8ac93bd77320a555c80ee95ce889fed9055368b","unresolved":false,"context_lines":[{"line_number":3615,"context_line":"          text-align: left;"},{"line_number":3616,"context_line":"          \u0026.has-error {"},{"line_number":3617,"context_line":"            .help-block {"},{"line_number":3618,"context_line":"              color: @red;"},{"line_number":3619,"context_line":"              display: inline;"},{"line_number":3620,"context_line":"            }"},{"line_number":3621,"context_line":"          }"}],"source_content_type":"text/x-less","patch_set":6,"id":"1af94dfe_96f8624b","line":3618,"in_reply_to":"3afc51ec_d8f4ae88","updated":"2016-03-16 11:55:11.000000000","message":"not needed  now","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"}],"static/tests/functional/test_node_interfaces.js":[{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"8fa25dffe72d7aac661217526ae5da38f9a2f937","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      \u0027Test DPDK panel\u0027: function() {"},{"line_number":94,"context_line":"        return this.remote"},{"line_number":95,"context_line":"          .clickByCssSelector(\u0027.dpdk .btn-link\u0027)"},{"line_number":96,"context_line":"          .waitForCssSelector(\u0027.dpdk-panel\u0027, 1000)"},{"line_number":97,"context_line":"          .assertElementExists("},{"line_number":98,"context_line":"            \u0027.sriov-control input[type\u003dcheckbox]\u0027,"},{"line_number":99,"context_line":"            \u0027Enable SRIOV input appears\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"1af94dfe_191003a8","line":96,"updated":"2016-03-16 12:16:17.000000000","message":"I don\u0027t think we need a timeout here.","commit_id":"4e4c6a89d2ca81b4c1cc63ff6d67cefc2ad336fb"},{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"8fa25dffe72d7aac661217526ae5da38f9a2f937","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return this.remote"},{"line_number":95,"context_line":"          .clickByCssSelector(\u0027.dpdk .btn-link\u0027)"},{"line_number":96,"context_line":"          .waitForCssSelector(\u0027.dpdk-panel\u0027, 1000)"},{"line_number":97,"context_line":"          .assertElementExists("},{"line_number":98,"context_line":"            \u0027.sriov-control input[type\u003dcheckbox]\u0027,"},{"line_number":99,"context_line":"            \u0027Enable SRIOV input appears\u0027"},{"line_number":100,"context_line":"          )"}],"source_content_type":"text/javascript","patch_set":7,"id":"1af94dfe_d97cdbed","line":97,"updated":"2016-03-16 12:16:17.000000000","message":"L101 makes this check redundant.","commit_id":"4e4c6a89d2ca81b4c1cc63ff6d67cefc2ad336fb"},{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"8fa25dffe72d7aac661217526ae5da38f9a2f937","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \u0027Enable SRIOV input appears\u0027"},{"line_number":100,"context_line":"          )"},{"line_number":101,"context_line":"          .clickByCssSelector(\u0027.sriov-control input[type\u003dcheckbox]\u0027)"},{"line_number":102,"context_line":"          .assertElementExists("},{"line_number":103,"context_line":"            \u0027.text-danger.sriov\u0027,"},{"line_number":104,"context_line":"            \u0027Error style is applied if there are networks assigned to the interface\u0027"},{"line_number":105,"context_line":"          )"}],"source_content_type":"text/javascript","patch_set":7,"id":"1af94dfe_d9633b40","line":102,"updated":"2016-03-16 12:16:17.000000000","message":"But this behaviour was changed, wasn\u0027t it?","commit_id":"4e4c6a89d2ca81b4c1cc63ff6d67cefc2ad336fb"},{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"8fa25dffe72d7aac661217526ae5da38f9a2f937","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            \u0027.text-danger.sriov\u0027,"},{"line_number":104,"context_line":"            \u0027Error style is applied if there are networks assigned to the interface\u0027"},{"line_number":105,"context_line":"          )"},{"line_number":106,"context_line":"          .setInputValue(\u0027.sriov-virtual-functions input\u0027, \u0027bla\u0027)"},{"line_number":107,"context_line":"          .assertElementExists("},{"line_number":108,"context_line":"            \u0027.has-error.sriov-virtual-functions\u0027,"},{"line_number":109,"context_line":"            \u0027Error style is applied when inputting incorrect value to Virtual Functions control\u0027"},{"line_number":110,"context_line":"          )"},{"line_number":111,"context_line":"          .setInputValue(\u0027.physnet input\u0027, \u0027!!!\u0027)"},{"line_number":112,"context_line":"          .assertElementExists("},{"line_number":113,"context_line":"            \u0027.has-error.physnet\u0027,"},{"line_number":114,"context_line":"            \u0027Error style is applied when inputting incorrect value to Physnet control\u0027"},{"line_number":115,"context_line":"          );"},{"line_number":116,"context_line":"      },"},{"line_number":117,"context_line":"      \u0027Untagged networks error\u0027: function() {"},{"line_number":118,"context_line":"        return this.remote"}],"source_content_type":"text/javascript","patch_set":7,"id":"1af94dfe_b9e62fb2","line":115,"range":{"start_line":106,"start_character":10,"end_line":115,"end_character":11},"updated":"2016-03-16 12:16:17.000000000","message":"This should be validated by unit tests for ifc model validation.\n\nPlease check cases when DPDK fields are locked and successfully saved in the func tests.\nI also think that you can change sriov, dpdk, offloading mode and then save the changes not to duplicate checks for each ifc property.","commit_id":"4e4c6a89d2ca81b4c1cc63ff6d67cefc2ad336fb"}],"static/translations/core.json":[{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"9be3d0f673b912433b98ed78a7dec68038d5f648","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                            \"invalid_mtu\": \"Invalid MTU value\","},{"line_number":426,"context_line":"                            \"networks_with_the_same_vlan\": \"Networks with the same VLAN ID cannot be assigned to the same interface.\","},{"line_number":427,"context_line":"                            \"vlan_range_intersection\": \"The network VLAN ID range should not include VLAN IDs of other networks assigned to the interface.\","},{"line_number":428,"context_line":"                            \"dpdk_placement_error\": \"Only Private network with VLAN segmentation could be placed on DPDK enabled interface\""},{"line_number":429,"context_line":"                        },"},{"line_number":430,"context_line":"                        \"disable_offloading\": \"Offloading Disabled\","},{"line_number":431,"context_line":"                        \"default_offloading\": \"Default Offloading\","}],"source_content_type":"application/json","patch_set":6,"id":"3afc51ec_184bb6b1","line":428,"range":{"start_line":428,"start_character":66,"end_line":428,"end_character":95},"updated":"2016-03-14 18:06:28.000000000","message":"Does segmentation term refer to network? I thought it is a property of the entire cluster or cluster\u0027s network configuration (network type).","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":9091,"name":"Alexandra Morozova","email":"astepanchuk@mirantis.com","username":"astepanchuk"},"change_message_id":"c8ac93bd77320a555c80ee95ce889fed9055368b","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                            \"invalid_mtu\": \"Invalid MTU value\","},{"line_number":426,"context_line":"                            \"networks_with_the_same_vlan\": \"Networks with the same VLAN ID cannot be assigned to the same interface.\","},{"line_number":427,"context_line":"                            \"vlan_range_intersection\": \"The network VLAN ID range should not include VLAN IDs of other networks assigned to the interface.\","},{"line_number":428,"context_line":"                            \"dpdk_placement_error\": \"Only Private network with VLAN segmentation could be placed on DPDK enabled interface\""},{"line_number":429,"context_line":"                        },"},{"line_number":430,"context_line":"                        \"disable_offloading\": \"Offloading Disabled\","},{"line_number":431,"context_line":"                        \"default_offloading\": \"Default Offloading\","}],"source_content_type":"application/json","patch_set":6,"id":"1af94dfe_36b7ce87","line":428,"range":{"start_line":428,"start_character":66,"end_line":428,"end_character":95},"in_reply_to":"3afc51ec_184bb6b1","updated":"2016-03-16 11:55:11.000000000","message":"do you suggest having several error messages here?","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"8fa25dffe72d7aac661217526ae5da38f9a2f937","unresolved":false,"context_lines":[{"line_number":447,"context_line":"                        \"virtual_functions\": \"Number of Virtual Functions\","},{"line_number":448,"context_line":"                        \"physical_network\": \"Physical Network Name\","},{"line_number":449,"context_line":"                        \"dpdk\": \"DPDK\","},{"line_number":450,"context_line":"                        \"dpdk_enabled\": \"Enabled\","},{"line_number":451,"context_line":"                        \"dpdk_disabled\": \"Disabled\","},{"line_number":452,"context_line":"                        \"dpdk_description\": \"Data Plane Development Kit is a set of data plane libraries and network interface controller drivers for fast packet processing\""},{"line_number":453,"context_line":"                    },"},{"line_number":454,"context_line":"                    \"configure_disks\": {"}],"source_content_type":"application/json","patch_set":7,"id":"1af94dfe_19164355","line":451,"range":{"start_line":450,"start_character":24,"end_line":451,"end_character":52},"updated":"2016-03-16 12:16:17.000000000","message":"I would combine offloading_enabled, sriov_enabled dpdk_enabled into a common \u0027enabled\u0027 translation. The same for \u0027*_disabled\u0027","commit_id":"4e4c6a89d2ca81b4c1cc63ff6d67cefc2ad336fb"}],"static/views/cluster_page_tabs/nodes_tab_screens/edit_node_interfaces_screen.js":[{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"9be3d0f673b912433b98ed78a7dec68038d5f648","unresolved":false,"context_lines":[{"line_number":726,"context_line":"      value \u003d convertToNullIfNaN(value);"},{"line_number":727,"context_line":"    }"},{"line_number":728,"context_line":"    var interfaceProperties \u003d _.cloneDeep(this.props.interface.get(\u0027interface_properties\u0027) || {});"},{"line_number":729,"context_line":"    if (_.contains(name, \u0027.\u0027)) {"},{"line_number":730,"context_line":"      _.set(interfaceProperties, name, value);"},{"line_number":731,"context_line":"    } else {"},{"line_number":732,"context_line":"      interfaceProperties[name] \u003d value;"}],"source_content_type":"text/javascript","patch_set":6,"id":"3afc51ec_987186e3","line":729,"updated":"2016-03-14 18:06:28.000000000","message":"Can we use _.set in every cases to avoid this if-else ?","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":9091,"name":"Alexandra Morozova","email":"astepanchuk@mirantis.com","username":"astepanchuk"},"change_message_id":"c8ac93bd77320a555c80ee95ce889fed9055368b","unresolved":false,"context_lines":[{"line_number":726,"context_line":"      value \u003d convertToNullIfNaN(value);"},{"line_number":727,"context_line":"    }"},{"line_number":728,"context_line":"    var interfaceProperties \u003d _.cloneDeep(this.props.interface.get(\u0027interface_properties\u0027) || {});"},{"line_number":729,"context_line":"    if (_.contains(name, \u0027.\u0027)) {"},{"line_number":730,"context_line":"      _.set(interfaceProperties, name, value);"},{"line_number":731,"context_line":"    } else {"},{"line_number":732,"context_line":"      interfaceProperties[name] \u003d value;"}],"source_content_type":"text/javascript","patch_set":6,"id":"1af94dfe_76b1568f","line":729,"in_reply_to":"3afc51ec_987186e3","updated":"2016-03-16 11:55:11.000000000","message":"Done","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"9be3d0f673b912433b98ed78a7dec68038d5f648","unresolved":false,"context_lines":[{"line_number":852,"context_line":"    var locked \u003d this.props.locked || !interfaceProperties.dpdk.available;"},{"line_number":853,"context_line":"    return ("},{"line_number":854,"context_line":"      \u003cdiv className\u003d\u0027dpdk-panel\u0027\u003e"},{"line_number":855,"context_line":"        \u003cp\u003e{i18n(ns + \u0027dpdk_description\u0027)}\u003c/p\u003e"},{"line_number":856,"context_line":"        \u003cInput"},{"line_number":857,"context_line":"          type\u003d\u0027checkbox\u0027"},{"line_number":858,"context_line":"          label\u003d{i18n(\u0027common.enable\u0027)}"}],"source_content_type":"text/javascript","patch_set":6,"id":"3afc51ec_b35c63ee","line":855,"range":{"start_line":855,"start_character":8,"end_line":855,"end_character":46},"updated":"2016-03-14 18:06:28.000000000","message":"Why did you not send this as the input\u0027s label prop?","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":9091,"name":"Alexandra Morozova","email":"astepanchuk@mirantis.com","username":"astepanchuk"},"change_message_id":"c8ac93bd77320a555c80ee95ce889fed9055368b","unresolved":false,"context_lines":[{"line_number":852,"context_line":"    var locked \u003d this.props.locked || !interfaceProperties.dpdk.available;"},{"line_number":853,"context_line":"    return ("},{"line_number":854,"context_line":"      \u003cdiv className\u003d\u0027dpdk-panel\u0027\u003e"},{"line_number":855,"context_line":"        \u003cp\u003e{i18n(ns + \u0027dpdk_description\u0027)}\u003c/p\u003e"},{"line_number":856,"context_line":"        \u003cInput"},{"line_number":857,"context_line":"          type\u003d\u0027checkbox\u0027"},{"line_number":858,"context_line":"          label\u003d{i18n(\u0027common.enable\u0027)}"}],"source_content_type":"text/javascript","patch_set":6,"id":"1af94dfe_366eae01","line":855,"range":{"start_line":855,"start_character":8,"end_line":855,"end_character":46},"in_reply_to":"3afc51ec_b35c63ee","updated":"2016-03-16 11:55:11.000000000","message":"because, it\u0027s not a label, but description","commit_id":"3b050de4fd7698cac461c675b18656f024c40489"},{"author":{"_account_id":8766,"name":"Julia Aranovich","email":"jkirnosova@mirantis.com","username":"CesarSar"},"change_message_id":"8fa25dffe72d7aac661217526ae5da38f9a2f937","unresolved":false,"context_lines":[{"line_number":777,"context_line":"                    {i18n(ns + propertyName) + \u0027:\u0027}"},{"line_number":778,"context_line":"                    \u003cbutton {...commonButtonProps}\u003e"},{"line_number":779,"context_line":"                      {propertyValue.enabled ?"},{"line_number":780,"context_line":"                        i18n(ns + \u0027dpdk_enabled\u0027)"},{"line_number":781,"context_line":"                        :"},{"line_number":782,"context_line":"                        i18n(ns + \u0027dpdk_disabled\u0027)"},{"line_number":783,"context_line":"                      }"}],"source_content_type":"text/javascript","patch_set":7,"id":"1af94dfe_dc29698b","line":780,"range":{"start_line":780,"start_character":35,"end_line":780,"end_character":47},"updated":"2016-03-16 12:16:17.000000000","message":"If you move \u0027dpdk_enabled\u0027 to \u0027enabled\u0027, the code for sriov and dpdk will be the same","commit_id":"4e4c6a89d2ca81b4c1cc63ff6d67cefc2ad336fb"}]}