)]}'
{"nailgun/nailgun/orchestrator/deployment_serializers.py":[{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"8140a0c717f883a07811d50093f4a87fbf4260af","unresolved":false,"context_lines":[{"line_number":689,"context_line":"        # Get Mellanox data"},{"line_number":690,"context_line":"        neutron_mellanox_data \u003d  \\"},{"line_number":691,"context_line":"            node.cluster.attributes.editable\\"},{"line_number":692,"context_line":"            .get(\u0027neutron_mellanox\u0027, {})"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # Get storage data"},{"line_number":695,"context_line":"        storage_data \u003d node.cluster.attributes.editable.get(\u0027storage\u0027, {})"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_31ca0d6f","line":692,"updated":"2014-07-08 20:56:52.000000000","message":"should probably return node_attrs right here if neutron_mellanox_data is empty at this point.","commit_id":"4b7664291e554c5b20f6548b3bc823afbe15fc4f"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"8140a0c717f883a07811d50093f4a87fbf4260af","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        node_attrs[\u0027neutron_mellanox\u0027] \u003d {}"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        # Find Physical port for VFs generation"},{"line_number":704,"context_line":"        if neutron_mellanox_data[\u0027plugin\u0027][\u0027value\u0027] \u003d\u003d \u0027ethernet\u0027:"},{"line_number":705,"context_line":"            node_attrs[\u0027neutron_mellanox\u0027][\u0027physical_port\u0027] \u003d \\"},{"line_number":706,"context_line":"                nm.get_node_network_by_netname(node.id, \"private\")[\u0027dev\u0027]"},{"line_number":707,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_91b919ef","line":704,"updated":"2014-07-08 20:56:52.000000000","message":"neutron_mellanox_data[\u0027plugin\u0027] will raise a KeyError if neutron_mellanox_data \u003d\u003d {}, and it\u0027s the default set on line 692.","commit_id":"4b7664291e554c5b20f6548b3bc823afbe15fc4f"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"18b5452fad8b2687704f352b50de6fdc6d5e1694","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        node_attrs[\u0027neutron_mellanox\u0027] \u003d {}"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        # Find Physical port for VFs generation"},{"line_number":704,"context_line":"        if neutron_mellanox_data[\u0027plugin\u0027][\u0027value\u0027] \u003d\u003d \u0027ethernet\u0027:"},{"line_number":705,"context_line":"            node_attrs[\u0027neutron_mellanox\u0027][\u0027physical_port\u0027] \u003d \\"},{"line_number":706,"context_line":"                nm.get_node_network_by_netname(node.id, \"private\")[\u0027dev\u0027]"},{"line_number":707,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_0926b568","line":704,"in_reply_to":"baada198_91b919ef","updated":"2014-07-09 08:42:30.000000000","message":"This commit is dependent on the UI changes https://review.openstack.org/#/c/103425/4 in openstack.yaml, so there will always be plugin key (default to disabled), but I agree it is safer to return at 692 in case of empty dict.","commit_id":"4b7664291e554c5b20f6548b3bc823afbe15fc4f"},{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"fe1e8403ffa89dad3aff7204a5661167a18e7988","unresolved":false,"context_lines":[{"line_number":704,"context_line":"            .get(\u0027neutron_mellanox\u0027, {})"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        # Get storage data"},{"line_number":707,"context_line":"        storage_data \u003d node.cluster.attributes.editable.get(\u0027storage\u0027, {})"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"        # Get network manager"},{"line_number":710,"context_line":"        nm \u003d objects.Node.get_network_manager(node)"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_77f7c38c","line":707,"updated":"2014-07-17 19:01:34.000000000","message":"It\u0027s better to use object Cluster here:\nCluster.get_attributes(node.cluster).editable","commit_id":"a9446e97aa98d48aa42bfff0b6c0e8556c92e7e0"},{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"fe1e8403ffa89dad3aff7204a5661167a18e7988","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            nm.get_node_network_by_netname(node, \u0027storage\u0027).get(\u0027vlan\u0027)"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"        if storage_vlan:"},{"line_number":758,"context_line":"            vlan_name \u003d \"vlan%s\" % storage_vlan"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"            # Set storage rule to iSER interface vlan interface"},{"line_number":761,"context_line":"            node_attrs[\u0027network_scheme\u0027][\u0027roles\u0027][\u0027storage\u0027] \u003d vlan_name"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_1763e741","line":758,"updated":"2014-07-17 19:01:34.000000000","message":"Use .format() please.","commit_id":"a9446e97aa98d48aa42bfff0b6c0e8556c92e7e0"}]}
