)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"1eb96f3177a051dc14c5a01841c2df2290683e3b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Network verification for DPDK enabled interfaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Skip \"Private\" network in network verification after deployment"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements blueprint network-verification-dpdk"},{"line_number":12,"context_line":"Change-Id: I318cf470d80a4e363316f966050e27240408560d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa0719c6_7305beba","line":9,"updated":"2016-03-22 16:46:52.000000000","message":"Please write more rich commit messages. It\u0027s not clear why do you want to skip \"Private\" network. I saw your comment in the code, but commit messages must explain motivation behind the change anyway.","commit_id":"280feef280490b1cd73a791ab58d3cfed785af45"},{"author":{"_account_id":8392,"name":"Aleksey Kasatkin","email":"akasatkin@mirantis.com","username":"aleksey"},"change_message_id":"9b4efe2cf3cc6cc5d54f97d59604b4883e860505","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Network verification for DPDK enabled interfaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Skip \"Private\" network in network verification after deployment"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements blueprint network-verification-dpdk"},{"line_number":12,"context_line":"Change-Id: I318cf470d80a4e363316f966050e27240408560d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa0719c6_f54c0844","line":9,"in_reply_to":"fa0719c6_7305beba","updated":"2016-03-22 20:40:21.000000000","message":"it is in BP description actually. but yes, it could be here as well.","commit_id":"280feef280490b1cd73a791ab58d3cfed785af45"}],"nailgun/nailgun/task/task.py":[{"author":{"_account_id":10488,"name":"Artur Svechnikov","email":"asvechnikov@mirantis.com","username":"asvechnikov"},"change_message_id":"44997763dcade10de7b9f9549d312a2e75884ed9","unresolved":false,"context_lines":[{"line_number":880,"context_line":"                # interface since it\u0027s no longer visible in the system. So we"},{"line_number":881,"context_line":"                # should skip \"Private\" network from network verification"},{"line_number":882,"context_line":"                # after deployment."},{"line_number":883,"context_line":"                if ng.name \u003d\u003d consts.NETWORKS.private and \\"},{"line_number":884,"context_line":"                        iface.interface_properties[\u0027dpdk\u0027][\u0027enabled\u0027]:"},{"line_number":885,"context_line":"                    continue"},{"line_number":886,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_977410fe","line":883,"range":{"start_line":883,"start_character":58,"end_line":883,"end_character":59},"updated":"2016-03-21 10:32:10.000000000","message":"also please try to don\u0027t  use backslash, instead wrap condition into brackets","commit_id":"041e8f370770bface9ee9f5c9bffed89df347a0e"},{"author":{"_account_id":10488,"name":"Artur Svechnikov","email":"asvechnikov@mirantis.com","username":"asvechnikov"},"change_message_id":"44997763dcade10de7b9f9549d312a2e75884ed9","unresolved":false,"context_lines":[{"line_number":881,"context_line":"                # should skip \"Private\" network from network verification"},{"line_number":882,"context_line":"                # after deployment."},{"line_number":883,"context_line":"                if ng.name \u003d\u003d consts.NETWORKS.private and \\"},{"line_number":884,"context_line":"                        iface.interface_properties[\u0027dpdk\u0027][\u0027enabled\u0027]:"},{"line_number":885,"context_line":"                    continue"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"                data_ng \u003d filter(lambda i: i[\u0027name\u0027] \u003d\u003d ng.name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_173ac036","line":884,"updated":"2016-03-21 10:32:10.000000000","message":"it\u0027s possible that there are no \u0027dpdk\u0027 or \u0027enabled\u0027 keys","commit_id":"041e8f370770bface9ee9f5c9bffed89df347a0e"},{"author":{"_account_id":8392,"name":"Aleksey Kasatkin","email":"akasatkin@mirantis.com","username":"aleksey"},"change_message_id":"e4adfa889f677a0e63bc93a88e597d551b1a27d0","unresolved":false,"context_lines":[{"line_number":881,"context_line":"                # should skip \"Private\" network from network verification"},{"line_number":882,"context_line":"                # after deployment."},{"line_number":883,"context_line":"                if ng.name \u003d\u003d consts.NETWORKS.private and \\"},{"line_number":884,"context_line":"                        iface.interface_properties[\u0027dpdk\u0027][\u0027enabled\u0027]:"},{"line_number":885,"context_line":"                    continue"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"                data_ng \u003d filter(lambda i: i[\u0027name\u0027] \u003d\u003d ng.name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_623c1830","line":884,"in_reply_to":"fa0719c6_173ac036","updated":"2016-03-21 10:41:26.000000000","message":"agree. for old environments.","commit_id":"041e8f370770bface9ee9f5c9bffed89df347a0e"},{"author":{"_account_id":10488,"name":"Artur Svechnikov","email":"asvechnikov@mirantis.com","username":"asvechnikov"},"change_message_id":"44997763dcade10de7b9f9549d312a2e75884ed9","unresolved":false,"context_lines":[{"line_number":1023,"context_line":"                    # After deployment we can\u0027t check traffic on DPDK enabled"},{"line_number":1024,"context_line":"                    # interface since it\u0027s not visible in the system. So we"},{"line_number":1025,"context_line":"                    # should skip \"Private\" network from network verification."},{"line_number":1026,"context_line":"                    if transformation.get(\u0027provider\u0027, \u0027\u0027) \u003d\u003d \u0027dpdkovs\u0027 and \\"},{"line_number":1027,"context_line":"                            node.status \u003d\u003d consts.NODE_STATUSES.ready and \\"},{"line_number":1028,"context_line":"                            transformation.get(\u0027bridge\u0027, \u0027\u0027) \u003d\u003d \\"},{"line_number":1029,"context_line":"                            consts.DEFAULT_BRIDGES_NAMES.br_prv:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_37b6e48a","line":1026,"range":{"start_line":1026,"start_character":75,"end_line":1026,"end_character":76},"updated":"2016-03-21 10:32:10.000000000","message":"ditto","commit_id":"041e8f370770bface9ee9f5c9bffed89df347a0e"},{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"1eb96f3177a051dc14c5a01841c2df2290683e3b","unresolved":false,"context_lines":[{"line_number":881,"context_line":"                # should skip \"Private\" network from network verification"},{"line_number":882,"context_line":"                # after deployment."},{"line_number":883,"context_line":"                if (ng.name \u003d\u003d consts.NETWORKS.private and"},{"line_number":884,"context_line":"                        objects.NIC.dpdk_enabled(iface)):"},{"line_number":885,"context_line":"                    continue"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"                data_ng \u003d filter(lambda i: i[\u0027name\u0027] \u003d\u003d ng.name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_13928257","line":884,"updated":"2016-03-22 16:46:52.000000000","message":"dpdk_enabled alue may be calculated only once in outer loop.","commit_id":"280feef280490b1cd73a791ab58d3cfed785af45"},{"author":{"_account_id":8392,"name":"Aleksey Kasatkin","email":"akasatkin@mirantis.com","username":"aleksey"},"change_message_id":"9b4efe2cf3cc6cc5d54f97d59604b4883e860505","unresolved":false,"context_lines":[{"line_number":881,"context_line":"                # should skip \"Private\" network from network verification"},{"line_number":882,"context_line":"                # after deployment."},{"line_number":883,"context_line":"                if (ng.name \u003d\u003d consts.NETWORKS.private and"},{"line_number":884,"context_line":"                        objects.NIC.dpdk_enabled(iface)):"},{"line_number":885,"context_line":"                    continue"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"                data_ng \u003d filter(lambda i: i[\u0027name\u0027] \u003d\u003d ng.name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_945f95e4","line":884,"in_reply_to":"fa0719c6_13928257","updated":"2016-03-22 20:40:21.000000000","message":"it is calculated once here because we have just one \u0027private\u0027 network (as any other) per node","commit_id":"280feef280490b1cd73a791ab58d3cfed785af45"},{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"1eb96f3177a051dc14c5a01841c2df2290683e3b","unresolved":false,"context_lines":[{"line_number":1023,"context_line":"                    # After deployment we can\u0027t check traffic on DPDK enabled"},{"line_number":1024,"context_line":"                    # interface since it\u0027s not visible in the system. So we"},{"line_number":1025,"context_line":"                    # should skip \"Private\" network from network verification."},{"line_number":1026,"context_line":"                    if (transformation.get(\u0027provider\u0027, \u0027\u0027) \u003d\u003d \u0027dpdkovs\u0027 and"},{"line_number":1027,"context_line":"                            node.status \u003d\u003d consts.NODE_STATUSES.ready and"},{"line_number":1028,"context_line":"                            transformation.get(\u0027bridge\u0027, \u0027\u0027) \u003d\u003d"},{"line_number":1029,"context_line":"                            consts.DEFAULT_BRIDGES_NAMES.br_prv):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_13da8278","line":1026,"updated":"2016-03-22 16:46:52.000000000","message":"There\u0027s a const for \u0027dpdkovs\u0027. Better to use it here.","commit_id":"280feef280490b1cd73a791ab58d3cfed785af45"},{"author":{"_account_id":8392,"name":"Aleksey Kasatkin","email":"akasatkin@mirantis.com","username":"aleksey"},"change_message_id":"9b4efe2cf3cc6cc5d54f97d59604b4883e860505","unresolved":false,"context_lines":[{"line_number":1023,"context_line":"                    # After deployment we can\u0027t check traffic on DPDK enabled"},{"line_number":1024,"context_line":"                    # interface since it\u0027s not visible in the system. So we"},{"line_number":1025,"context_line":"                    # should skip \"Private\" network from network verification."},{"line_number":1026,"context_line":"                    if (transformation.get(\u0027provider\u0027, \u0027\u0027) \u003d\u003d \u0027dpdkovs\u0027 and"},{"line_number":1027,"context_line":"                            node.status \u003d\u003d consts.NODE_STATUSES.ready and"},{"line_number":1028,"context_line":"                            transformation.get(\u0027bridge\u0027, \u0027\u0027) \u003d\u003d"},{"line_number":1029,"context_line":"                            consts.DEFAULT_BRIDGES_NAMES.br_prv):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_942dd548","line":1026,"in_reply_to":"fa0719c6_13da8278","updated":"2016-03-22 20:40:21.000000000","message":"agree. let\u0027s change it in separate request.","commit_id":"280feef280490b1cd73a791ab58d3cfed785af45"}]}