)]}'
{"bin/agent":[{"author":{"_account_id":8954,"name":"Lukasz Oles","email":"loles@mirantis.com","username":"loles"},"change_message_id":"96774fdda174106634e9b602e74dafea9573d239","unresolved":false,"context_lines":[{"line_number":68,"context_line":"end"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def createsig(body)"},{"line_number":71,"context_line":"  Digest::SHA1.hexdigest( sigflat body )"},{"line_number":72,"context_line":"end"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class McollectiveConfig"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAVX%2F%2F4CE%3D","line":71,"updated":"2014-02-27 16:46:26.000000000","message":"You are missing:\nrequire \u0027digest\u0027\n\nSome unit tests also would be good","commit_id":"895002b0b09be9e1a7c00e5abe905e0aaf4c122e"},{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"5d5411860cf42e206088e0452bd8f016fd6d5baa","unresolved":false,"context_lines":[{"line_number":68,"context_line":"end"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def createsig(body)"},{"line_number":71,"context_line":"  Digest::SHA1.hexdigest( sigflat body )"},{"line_number":72,"context_line":"end"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class McollectiveConfig"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAVX%2F%2Fy6c%3D","line":71,"in_reply_to":"AAAAVX%2F%2F4CE%3D","updated":"2014-02-28 08:13:23.000000000","message":"Hello Lukasz, right now we don\u0027t have required infrastructure to test ruby code in fuel-web repo, it will be done as separate task.","commit_id":"895002b0b09be9e1a7c00e5abe905e0aaf4c122e"},{"author":{"_account_id":8776,"name":"Vladimir Sharshov","email":"vsharshov@mirantis.com","username":"warpc"},"change_message_id":"ca1da45706be5a4354396d600a1bbf8862e7028d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    body \u003d body.to_s \u003c\u003c body.class.to_s"},{"line_number":67,"context_line":"  end"},{"line_number":68,"context_line":"  body"},{"line_number":69,"context_line":"end"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def createsig(body)"},{"line_number":72,"context_line":"  Digest::SHA1.hexdigest( sigflat body )"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAVX%2F%2Fubo%3D","line":69,"updated":"2014-02-28 18:45:34.000000000","message":"Alternative code\n\ndef digest(body)\n  if body.is_a? Hash\n    digest body.map { |k,v| [digest(k), digest(v)].join(\"\u003d\u003e\") }\n  elsif body.is_a? Array\n    body.map{ |v| digest(v) }.sort.join(\u0027|\u0027)\n  else\n    [body.class.to_s, body.to_s].join(\":\")\n  end\nend\n\nThis also respect complicated case:\n* [\"a\", \"b\", \"c\"] !\u003d [\"abc\"]\n* {:a \u003d\u003e \u0027a\u0027}  !\u003d  {\u0027a\u0027 \u003d\u003e :a}\n* {\u00271\u0027 \u003d\u003e \u00272\u0027, \u00272\u0027 \u003d\u003e \u00271\u0027} \u003d\u003d {\u00272\u0027 \u003d\u003e \u00271\u0027, \u00271\u0027 \u003d\u003e \u00272\u0027}\n* Respect multi class inheritance (superclass or mixin modules) (Class which can be present like Hash or Array, will be handled appropriately)\n* Do not change original object! (Original method change the original object). Example:\n\n1.8.7 :981 \u003e body\n \u003d\u003e {:d\u003d\u003e\"d\", :a\u003d\u003e[{:c\u003d\u003e\"c\"}]} \n1.8.7 :982 \u003e sigflat body\n \u003d\u003e \"aSymbol\u003d\u003ecSymbol\u003d\u003ecArrayArraydSymbol\u003d\u003edArray\" \n1.8.7 :983 \u003e body\n \u003d\u003e {:d\u003d\u003e\"d\", :a\u003d\u003e[\"cSymbol\u003d\u003ecArray\"]} \n\nThis is unexpected behavior, i think, already affect us and damage data!","commit_id":"3c656e328a30a90c8eac63ea70a78b68635eead5"},{"author":{"_account_id":10212,"name":"Dmitry Sokolov","email":"dsokolov@mirantis.com","username":"demon.mhm"},"change_message_id":"bd745de6491c3b1acc77ff7d3eb3e731574af457","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    body \u003d body.to_s \u003c\u003c body.class.to_s"},{"line_number":67,"context_line":"  end"},{"line_number":68,"context_line":"  body"},{"line_number":69,"context_line":"end"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def createsig(body)"},{"line_number":72,"context_line":"  Digest::SHA1.hexdigest( sigflat body )"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAVn%2F%2F768%3D","line":69,"in_reply_to":"AAAAVX%2F%2Fq%2Bk%3D","updated":"2014-03-03 10:04:01.000000000","message":"Thanx Vladimir. I will use your version in next patch.","commit_id":"3c656e328a30a90c8eac63ea70a78b68635eead5"},{"author":{"_account_id":8776,"name":"Vladimir Sharshov","email":"vsharshov@mirantis.com","username":"warpc"},"change_message_id":"16995e5c242b127079bd59b958904ebaa7fc3ecd","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    body \u003d body.to_s \u003c\u003c body.class.to_s"},{"line_number":67,"context_line":"  end"},{"line_number":68,"context_line":"  body"},{"line_number":69,"context_line":"end"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def createsig(body)"},{"line_number":72,"context_line":"  Digest::SHA1.hexdigest( sigflat body )"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAVX%2F%2Fq%2Bk%3D","line":69,"in_reply_to":"AAAAVX%2F%2Fubo%3D","updated":"2014-03-01 09:43:34.000000000","message":"New version:\n\ndef digest(body)\n  if body.is_a? Hash\n    digest body.map { |k,v| [digest(k),digest(v)].join(\"\u003d\u003e\") }.sort\n  elsif body.is_a? Array\n    body.map{ |v| digest v }.join(\u0027|\u0027)\n  else\n    [body.class.to_s, body.to_s].join(\":\")\n  end\nend\n\nThis version also respect order in Array, which is important. (unlike sigflat).\n\nTest example (should return true):\ndigest({:d \u003d\u003e true, :a \u003d\u003e {:c \u003d\u003e \u0027c\u0027, :b \u003d\u003e \u0027b\u0027, \u0027c\u0027 \u003d\u003e [{\u0027d\u0027 \u003d\u003e \u0027e\u0027, \u0027v\u0027 \u003d\u003e \u0027f\u0027}, 2]}}) \u003d\u003d  \ndigest({:a \u003d\u003e {:c \u003d\u003e \u0027c\u0027, \u0027c\u0027 \u003d\u003e [{\u0027v\u0027 \u003d\u003e \u0027f\u0027, \u0027d\u0027 \u003d\u003e \u0027e\u0027}, 2], :d \u003d\u003e true, :b \u003d\u003e \u0027b\u0027}})\n\nMinus: digest\u0027s method return much less readability result for human than sigflat.","commit_id":"3c656e328a30a90c8eac63ea70a78b68635eead5"},{"author":{"_account_id":8776,"name":"Vladimir Sharshov","email":"vsharshov@mirantis.com","username":"warpc"},"change_message_id":"ca1da45706be5a4354396d600a1bbf8862e7028d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"  end"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  def put"},{"line_number":162,"context_line":"    headers \u003d {\"Content-Type\" \u003d\u003e \"application/json\"}"},{"line_number":163,"context_line":"    @logger.debug(\"Trying to put host info into #{@api_url}\")"},{"line_number":164,"context_line":"    @logger.debug(\"Headers: #{headers}\")"},{"line_number":165,"context_line":"    @logger.debug(\"Data: #{[_data].to_json}\")"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAVX%2F%2FvBw%3D","line":162,"updated":"2014-02-28 18:45:34.000000000","message":"I suggest put sha hash in headers as etag. It will be useful to not parse big json if no new data purpose.","commit_id":"3c656e328a30a90c8eac63ea70a78b68635eead5"},{"author":{"_account_id":10212,"name":"Dmitry Sokolov","email":"dsokolov@mirantis.com","username":"demon.mhm"},"change_message_id":"bd745de6491c3b1acc77ff7d3eb3e731574af457","unresolved":false,"context_lines":[{"line_number":159,"context_line":"  end"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  def put"},{"line_number":162,"context_line":"    headers \u003d {\"Content-Type\" \u003d\u003e \"application/json\"}"},{"line_number":163,"context_line":"    @logger.debug(\"Trying to put host info into #{@api_url}\")"},{"line_number":164,"context_line":"    @logger.debug(\"Headers: #{headers}\")"},{"line_number":165,"context_line":"    @logger.debug(\"Data: #{[_data].to_json}\")"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAVn%2F%2F78k%3D","line":162,"in_reply_to":"AAAAVX%2F%2FvBw%3D","updated":"2014-03-03 10:04:01.000000000","message":"This is not usefull. We have to find node in db first by id or mac(by ambiguous logic) passed in json to compare hashes. Or reconsider mechanics of node request identification.","commit_id":"3c656e328a30a90c8eac63ea70a78b68635eead5"},{"author":{"_account_id":8882,"name":"Nastya Urlapova","email":"aurlapova@mirantis.com","username":"NastyaUrlapova"},"change_message_id":"c3fb9f863293d39c4d88bd63e1108e6446b54097","unresolved":false,"context_lines":[{"line_number":566,"context_line":"      logger.error post_res.body"},{"line_number":567,"context_line":"      exit 1"},{"line_number":568,"context_line":"    end"},{"line_number":569,"context_line":"  elsif put_res.status \u003d\u003d 304"},{"line_number":570,"context_line":"    exit 1"},{"line_number":571,"context_line":"  elsif put_res.status \u003d\u003d 200"},{"line_number":572,"context_line":"    new_id \u003d JSON.parse(post_res.body)[0][\u0027id\u0027]"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAWH%2F%2F8mY%3D","line":569,"updated":"2014-03-12 18:50:26.000000000","message":"in this case we didn\u0027t use:\nwrite_data_to_file(logger, \u0027/etc/nailgun_uid\u0027, new_id.to_s)","commit_id":"509b1eee8816964e25ce4e6d8af7d498b57f2782"}],"nailgun/nailgun/api/handlers/node.py":[{"author":{"_account_id":8930,"name":"Alexandr Notchenko","email":"anotchenko@mirantis.com","username":"anotchenko"},"change_message_id":"416351131301f913e7ffa237a01f612c43f91c06","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        )[0]"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        q \u003d db().query(Node)"},{"line_number":443,"context_line":"        node \u003d None"},{"line_number":444,"context_line":"        if nd.get(\"mac\"):"},{"line_number":445,"context_line":"            node \u003d ("},{"line_number":446,"context_line":"                q.filter_by(mac\u003dnd[\"mac\"]).first()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F5UM%3D","line":443,"updated":"2014-02-27 14:54:37.000000000","message":"What is the reason to have it here? Pycharm lint says it\u0027s not used anywhere.","commit_id":"58494efb90f73dd2f0eba16e0674d74162537361"},{"author":{"_account_id":10212,"name":"Dmitry Sokolov","email":"dsokolov@mirantis.com","username":"demon.mhm"},"change_message_id":"1c08dcb3c1328d7cf88e1354c2065757d83ce64e","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        )[0]"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        q \u003d db().query(Node)"},{"line_number":443,"context_line":"        node \u003d None"},{"line_number":444,"context_line":"        if nd.get(\"mac\"):"},{"line_number":445,"context_line":"            node \u003d ("},{"line_number":446,"context_line":"                q.filter_by(mac\u003dnd[\"mac\"]).first()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F5NM%3D","line":443,"in_reply_to":"AAAAVX%2F%2F5UM%3D","updated":"2014-02-27 15:01:50.000000000","message":"#L452 causes NameError without this.","commit_id":"58494efb90f73dd2f0eba16e0674d74162537361"},{"author":{"_account_id":8930,"name":"Alexandr Notchenko","email":"anotchenko@mirantis.com","username":"anotchenko"},"change_message_id":"416351131301f913e7ffa237a01f612c43f91c06","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        db().commit()"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        # caching raw data to avoid useless db updates"},{"line_number":464,"context_line":"        agent_checksum \u003d hashlib.sha1(str(make_hash(web.data()))).hexdigest()"},{"line_number":465,"context_line":"        if node.agent_checksum \u003d\u003d agent_checksum:"},{"line_number":466,"context_line":"            raise web.notmodified()"},{"line_number":467,"context_line":"        node.agent_checksum \u003d agent_checksum"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F5TQ%3D","line":464,"updated":"2014-02-27 14:54:37.000000000","message":"Maybe it\u0027s more useful to create separate function for creating request body hash?","commit_id":"58494efb90f73dd2f0eba16e0674d74162537361"},{"author":{"_account_id":10212,"name":"Dmitry Sokolov","email":"dsokolov@mirantis.com","username":"demon.mhm"},"change_message_id":"1c08dcb3c1328d7cf88e1354c2065757d83ce64e","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        db().commit()"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        # caching raw data to avoid useless db updates"},{"line_number":464,"context_line":"        agent_checksum \u003d hashlib.sha1(str(make_hash(web.data()))).hexdigest()"},{"line_number":465,"context_line":"        if node.agent_checksum \u003d\u003d agent_checksum:"},{"line_number":466,"context_line":"            raise web.notmodified()"},{"line_number":467,"context_line":"        node.agent_checksum \u003d agent_checksum"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F5Lk%3D","line":464,"in_reply_to":"AAAAVX%2F%2F5TQ%3D","updated":"2014-02-27 15:01:50.000000000","message":"We\u0027ve already have make_hash common method in utils for making python hash from dict. Here we transform this value to sha1 string - as it stores.","commit_id":"58494efb90f73dd2f0eba16e0674d74162537361"},{"author":{"_account_id":8930,"name":"Alexandr Notchenko","email":"anotchenko@mirantis.com","username":"anotchenko"},"change_message_id":"416351131301f913e7ffa237a01f612c43f91c06","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        if not node.attributes.volumes:"},{"line_number":490,"context_line":"            node.attributes.volumes \u003d node.volume_manager.gen_volumes_info()"},{"line_number":491,"context_line":"            db().commit()"},{"line_number":492,"context_line":"        if not node.status in (\u0027provisioning\u0027, \u0027deploying\u0027):"},{"line_number":493,"context_line":"            variants \u003d ("},{"line_number":494,"context_line":"                \"disks\" in node.meta and len(node.meta[\"disks\"]) !\u003d len("},{"line_number":495,"context_line":"                    filter("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F5Q4%3D","line":492,"updated":"2014-02-27 14:54:37.000000000","message":"It\u0027s better to write as in english \" if \u003csomething\u003e not in \u003csomewhere\u003e:","commit_id":"58494efb90f73dd2f0eba16e0674d74162537361"},{"author":{"_account_id":10212,"name":"Dmitry Sokolov","email":"dsokolov@mirantis.com","username":"demon.mhm"},"change_message_id":"1c08dcb3c1328d7cf88e1354c2065757d83ce64e","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        if not node.attributes.volumes:"},{"line_number":490,"context_line":"            node.attributes.volumes \u003d node.volume_manager.gen_volumes_info()"},{"line_number":491,"context_line":"            db().commit()"},{"line_number":492,"context_line":"        if not node.status in (\u0027provisioning\u0027, \u0027deploying\u0027):"},{"line_number":493,"context_line":"            variants \u003d ("},{"line_number":494,"context_line":"                \"disks\" in node.meta and len(node.meta[\"disks\"]) !\u003d len("},{"line_number":495,"context_line":"                    filter("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F5K8%3D","line":492,"in_reply_to":"AAAAVX%2F%2F5Q4%3D","updated":"2014-02-27 15:01:50.000000000","message":"copypaste. will fix it","commit_id":"58494efb90f73dd2f0eba16e0674d74162537361"},{"author":{"_account_id":8053,"name":"Nikolay Markov","email":"nmarkov@mirantis.com","username":"NikolayMarkov"},"change_message_id":"1f2afea565b1799541db303eff7ab6693365a5fb","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        \"\"\""},{"line_number":435,"context_line":"        nd \u003d self.checked_data("},{"line_number":436,"context_line":"            self.validator.validate_collection_update,"},{"line_number":437,"context_line":"            data\u003d\u0027[{0}]\u0027.format(web.data())"},{"line_number":438,"context_line":"        )[0]"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        q \u003d db().query(Node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVX%2F%2FxsQ%3D","line":437,"updated":"2014-02-28 11:39:47.000000000","message":"u","commit_id":"ba2e425221439fbec16c8fbea69c5f3bbc8cbdfe"},{"author":{"_account_id":8053,"name":"Nikolay Markov","email":"nmarkov@mirantis.com","username":"NikolayMarkov"},"change_message_id":"1f2afea565b1799541db303eff7ab6693365a5fb","unresolved":false,"context_lines":[{"line_number":470,"context_line":"                # We don\u0027t update provisioning and error back to discover"},{"line_number":471,"context_line":"                logger.debug("},{"line_number":472,"context_line":"                    \"Node has provisioning or error status - \""},{"line_number":473,"context_line":"                    \"status not updated by agent\")"},{"line_number":474,"context_line":"                continue"},{"line_number":475,"context_line":"            if key \u003d\u003d \"meta\":"},{"line_number":476,"context_line":"                node.update_meta(value)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVX%2F%2Fxrs%3D","line":473,"updated":"2014-02-28 11:39:47.000000000","message":"Please specify node name or id here.","commit_id":"ba2e425221439fbec16c8fbea69c5f3bbc8cbdfe"}],"nailgun/nailgun/test/unit/test_node_nic_handler.py":[{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"7ae4e616944ddca0bb0554704f758942db20ab5c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            node_data \u003d {\u0027mac\u0027: node[\u0027mac\u0027], \u0027is_agent\u0027: True,"},{"line_number":75,"context_line":"                         \u0027meta\u0027: meta}"},{"line_number":76,"context_line":"            resp \u003d self.app.put("},{"line_number":77,"context_line":"                reverse(\u0027NodeCollectionHandler\u0027),"},{"line_number":78,"context_line":"                json.dumps([node_data]),"},{"line_number":79,"context_line":"                expect_errors\u003dTrue,"},{"line_number":80,"context_line":"                headers\u003dself.default_headers"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2F2Nk%3D","side":"PARENT","line":77,"updated":"2014-03-03 20:20:44.000000000","message":"Why these tests were used NodeCollectionHandler? Why the handler modifies meta? How it has worked at all?","commit_id":"5d80a6b871e32891679d927edeee46600be458c9"},{"author":{"_account_id":10212,"name":"Dmitry Sokolov","email":"dsokolov@mirantis.com","username":"demon.mhm"},"change_message_id":"3eebda6891554b7f37b3a3278b17034d4eadf738","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            node_data \u003d {\u0027mac\u0027: node[\u0027mac\u0027], \u0027is_agent\u0027: True,"},{"line_number":75,"context_line":"                         \u0027meta\u0027: meta}"},{"line_number":76,"context_line":"            resp \u003d self.app.put("},{"line_number":77,"context_line":"                reverse(\u0027NodeCollectionHandler\u0027),"},{"line_number":78,"context_line":"                json.dumps([node_data]),"},{"line_number":79,"context_line":"                expect_errors\u003dTrue,"},{"line_number":80,"context_line":"                headers\u003dself.default_headers"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2Fw2g%3D","side":"PARENT","line":77,"in_reply_to":"AAAAVn%2F%2F2Nk%3D","updated":"2014-03-04 08:21:15.000000000","message":"Because NodeCollection handler where used for processing agents requests. I\u0027ve changed this behavior by this patch. Handler doesnt modify meta. Here meta changed manually to model agent behavior.","commit_id":"5d80a6b871e32891679d927edeee46600be458c9"}]}
