)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a6d8f6a9edfd6cac625af14f927c5bffdbcee103","unresolved":false,"context_lines":[{"line_number":14,"context_line":"situation happens we need to shift forward to the"},{"line_number":15,"context_line":"next multiple and use that instead."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"So this adds a new strategy that does just that."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Idc065484fe58a2ac419a83fc73228d9305ef15f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_e649e331","line":17,"updated":"2018-06-11 17:20:39.000000000","message":"Why not fix the existing one? It seems like a bug that we can run more often than requested..","commit_id":"221efc141b5203401fbcbad1df1d8c6c59f9bbf2"}],"futurist/periodics.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a6d8f6a9edfd6cac625af14f927c5bffdbcee103","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    return aligned_finished_at + how_often"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"def _aligned_last_finished_fast_forward_strategy(cb, started_at,"},{"line_number":222,"context_line":"                                                 finished_at, metrics):"},{"line_number":223,"context_line":"    # Determine when the callback should next run based on when it was"},{"line_number":224,"context_line":"    # last finished **only** where the last finished time is first aligned to"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_06473f1f","line":221,"updated":"2018-06-11 17:20:39.000000000","message":"I don\u0027t like \"fast_forward\" here, it\u0027s not quite \"fast\". one may argue it\u0027s slower, I\u0027d call the previous variant \"fast_forward\" instead. Something like \"ensure_minimum_spacing\"?\n\nAnyway, I\u0027d just fix the existing one..","commit_id":"221efc141b5203401fbcbad1df1d8c6c59f9bbf2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a16c37ea0b870584c5c64a4d46490c393eadfd8e","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        # than we really want to; for example, let\u0027s assume that it finished"},{"line_number":235,"context_line":"        # at 1.0 and it is scheduled to run every 3.0 seconds, well we don\u0027t"},{"line_number":236,"context_line":"        # want to run it in 2.0 seconds, but we want to run it instead at"},{"line_number":237,"context_line":"        # the next aligned offset, which in this case would be 6.0"},{"line_number":238,"context_line":"        finished_at \u003d ((finished_at / how_often) + 1) * how_often"},{"line_number":239,"context_line":"        next_up \u003d finished_at - math.fmod(finished_at, how_often)"},{"line_number":240,"context_line":"        next_up +\u003d how_often"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_a668cb87","line":237,"updated":"2018-06-11 17:21:21.000000000","message":"Yeah, this sounds like a bug in the old variant to me.","commit_id":"221efc141b5203401fbcbad1df1d8c6c59f9bbf2"}]}