)]}'
{"futurist/_futures.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"49057ccc3465ff3700da1baf62e841dcd9873650","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        \"\"\"The current number of worker threads.\"\"\""},{"line_number":162,"context_line":"        return len(self._workers)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def idle_threads(self):"},{"line_number":165,"context_line":"        \"\"\"Get the number of currently idle threads."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        A thread is idle if it\u0027s waiting for new tasks from the queue."}],"source_content_type":"text/x-python","patch_set":1,"id":"854b2583_8ec59dd3","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":20},"updated":"2025-07-24 15:11:32.000000000","message":"Any specific reason not to use property for this ?\n\nAlso I wonder if we can name these two properties about worker numbers more consistently, like num_workers and num_idle_workers.","commit_id":"3cf095255163b9c7780392dd8076f5abe7bdffd2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6cba580cb3753b073340b17a879190cd0cd97223","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        \"\"\"The current number of worker threads.\"\"\""},{"line_number":162,"context_line":"        return len(self._workers)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def idle_threads(self):"},{"line_number":165,"context_line":"        \"\"\"Get the number of currently idle threads."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        A thread is idle if it\u0027s waiting for new tasks from the queue."}],"source_content_type":"text/x-python","patch_set":1,"id":"d8b27185_7c0e28c1","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":20},"in_reply_to":"854b2583_8ec59dd3","updated":"2025-07-24 16:09:25.000000000","message":"There likely is not, although it *will* trigger the lock which means its not a possible set value, but an action which requires the lock. So, maybe a property is the wrong idea here.","commit_id":"3cf095255163b9c7780392dd8076f5abe7bdffd2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a39ff646cba4571926099be368cc77f4a7656ced","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        \"\"\"The current number of worker threads.\"\"\""},{"line_number":162,"context_line":"        return len(self._workers)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def idle_threads(self):"},{"line_number":165,"context_line":"        \"\"\"Get the number of currently idle threads."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        A thread is idle if it\u0027s waiting for new tasks from the queue."}],"source_content_type":"text/x-python","patch_set":1,"id":"b78bd951_6bd24389","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":20},"in_reply_to":"8adbe0ff_b38477a8","updated":"2025-07-25 15:13:07.000000000","message":"I guess my point is more, sure, we can, but it is going to hold a lock to provide a result which is a bit more than a property. I guess I\u0027d like to get more folks to chime in on this.","commit_id":"3cf095255163b9c7780392dd8076f5abe7bdffd2"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"472ae494a0efff46ff8ae5a34fbccf137f021925","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        \"\"\"The current number of worker threads.\"\"\""},{"line_number":162,"context_line":"        return len(self._workers)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def idle_threads(self):"},{"line_number":165,"context_line":"        \"\"\"Get the number of currently idle threads."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        A thread is idle if it\u0027s waiting for new tasks from the queue."}],"source_content_type":"text/x-python","patch_set":1,"id":"ca5b05c3_1de4eb0a","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":20},"in_reply_to":"b78bd951_6bd24389","updated":"2025-07-25 15:25:20.000000000","message":"Here are my thoughts.\n\nI agree with Julia concerning the fact that a property is maybe not the right choice here, due to the locking aspects.\n\nThe lock is likely to block, or whether the call might introduce a non-trivial latency, which would surprise a user expecting a simple attribute.\n\nI agree with Takashi concerning the naming aspects. I\u0027d prefer `num_idle_workers` or `get_num_idle_workers` which would better reflects what we should expect by calling it.","commit_id":"3cf095255163b9c7780392dd8076f5abe7bdffd2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4c21e3bf7330bc1ddaaaf640db6fd4102e13845c","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        \"\"\"The current number of worker threads.\"\"\""},{"line_number":162,"context_line":"        return len(self._workers)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def idle_threads(self):"},{"line_number":165,"context_line":"        \"\"\"Get the number of currently idle threads."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        A thread is idle if it\u0027s waiting for new tasks from the queue."}],"source_content_type":"text/x-python","patch_set":1,"id":"696e6120_0a984c54","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":20},"in_reply_to":"ca5b05c3_1de4eb0a","updated":"2025-07-26 13:53:30.000000000","message":"Changing in next revision.","commit_id":"3cf095255163b9c7780392dd8076f5abe7bdffd2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"55d7539edc582e2bb782933e75a526a449d79e2a","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        \"\"\"The current number of worker threads.\"\"\""},{"line_number":162,"context_line":"        return len(self._workers)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def idle_threads(self):"},{"line_number":165,"context_line":"        \"\"\"Get the number of currently idle threads."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        A thread is idle if it\u0027s waiting for new tasks from the queue."}],"source_content_type":"text/x-python","patch_set":1,"id":"8adbe0ff_b38477a8","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":20},"in_reply_to":"d8b27185_7c0e28c1","updated":"2025-07-25 06:41:45.000000000","message":"I agree we can\u0027t set it and this is read-only but that does not conflict with using @property decorator to allow access like a usual attribute, rather than a method.","commit_id":"3cf095255163b9c7780392dd8076f5abe7bdffd2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5d5023fa96d7837d03b2be65f60e56b140ddc545","unresolved":true,"context_lines":[{"line_number":157,"context_line":"        return self._work_queue.qsize()"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @property"},{"line_number":160,"context_line":"    def current_size(self):"},{"line_number":161,"context_line":"        \"\"\"The current number of worker threads.\"\"\""},{"line_number":162,"context_line":"        return len(self._workers)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7efc4332_c586c70f","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":20},"updated":"2025-07-27 14:19:13.000000000","message":"I\u0027m afraid my previous comment was not clear enough but can we also name this num_workers ?","commit_id":"bdcf03528a8f8aedb28ebe08ef8bb392e0d2c786"}]}
