)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7e4fb1884949328947740532d3651f5b5fd1b9d4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flavio Percoco \u003cflaper87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-07 15:40:50 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Complete refactor to glance-store\u0027s API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I11fc3a89df24b1fa6bb7047ad918f2430334e24c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_3fab8a1e","line":7,"updated":"2014-10-21 21:00:31.000000000","message":"It would be great, if you could highlight some of the major points as bullets in the commit message.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flavio Percoco \u003cflaper87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-07 15:40:50 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Complete refactor to glance-store\u0027s API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I11fc3a89df24b1fa6bb7047ad918f2430334e24c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_a351f70f","line":7,"in_reply_to":"9aa7fdbe_3fab8a1e","updated":"2014-10-23 07:58:59.000000000","message":"sure, will do before merge once we agree on what to do.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"}],"specs/kilo/glance-store-refactor.rst":[{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"3e2e172ca140620c32e4748ede9cd7b906d3a02f","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Example Spec - The title of your blueprint"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The recently-created glance-store library is a slightly modified copy of what"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_3f4c6a70","line":8,"updated":"2014-10-21 20:52:28.000000000","message":"Refactoring of the glance-store\u0027s API","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Example Spec - The title of your blueprint"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The recently-created glance-store library is a slightly modified copy of what"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_188de531","line":8,"in_reply_to":"9aa7fdbe_3f4c6a70","updated":"2014-10-23 07:58:59.000000000","message":"LOL, done!","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"f3bc992e8c489470647375d8546f4a65e134c33d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"does makes the usage of this library hard and it prevents new features from"},{"line_number":32,"context_line":"being developed - Copy on Writes, for example."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"In adition to the problems mentioned above, the current API makes implementing"},{"line_number":35,"context_line":"new drivers quite dificult and it does not encourage new addition by not having"},{"line_number":36,"context_line":"a well documented or readable base implementation. Furthermore, it currently"},{"line_number":37,"context_line":"doesn\u0027t take advantage of, the already supported, stevedore\u0027s plugin model."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_0a778ad5","line":34,"updated":"2014-10-20 20:12:26.000000000","message":"typo: addition","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"does makes the usage of this library hard and it prevents new features from"},{"line_number":32,"context_line":"being developed - Copy on Writes, for example."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"In adition to the problems mentioned above, the current API makes implementing"},{"line_number":35,"context_line":"new drivers quite dificult and it does not encourage new addition by not having"},{"line_number":36,"context_line":"a well documented or readable base implementation. Furthermore, it currently"},{"line_number":37,"context_line":"doesn\u0027t take advantage of, the already supported, stevedore\u0027s plugin model."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_b8777939","line":34,"in_reply_to":"9aa7fdbe_0a778ad5","updated":"2014-10-23 07:58:59.000000000","message":"Done","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"3e2e172ca140620c32e4748ede9cd7b906d3a02f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    class Store(object):"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        def __init__(self, conf):"},{"line_number":55,"context_line":"            # Load stores from conf"},{"line_number":56,"context_line":"            # Select the default store"},{"line_number":57,"context_line":"            # do other stuff"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_5ab5bc2f","line":55,"updated":"2014-10-21 20:52:28.000000000","message":"I see this as too many things to do in a constructor.\n\nAlso, I would like to take this spec as an opportunity to solve the problem that we have currently where the stores are not fully configured (for example: configure() was called but not configure_add()).\n\nWould be interested to have your thoughts...","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    class Store(object):"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        def __init__(self, conf):"},{"line_number":55,"context_line":"            # Load stores from conf"},{"line_number":56,"context_line":"            # Select the default store"},{"line_number":57,"context_line":"            # do other stuff"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_c86ff8c3","line":55,"in_reply_to":"9aa7fdbe_5ab5bc2f","updated":"2014-10-23 07:58:59.000000000","message":"Mmh, I really don\u0027t think is much. Python modules, once loaded through stevedore, will be cached so future loads will be immediate. The reason I think this has to be done per store is because it uses a local config and one could use different config objects to create separate `Store` instances that enable different drivers.\n\nYes, the plan is to fix the partially configured stores issue too. FWIW, configure_add is always called now, that was fixed (IIRC) as part of the glance_store\u0027s work. That said, I\u0027d like to get rid of the partially configured stores and just disable all stores that fail to configure (or even raise an exception and fail miserably).","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"3e2e172ca140620c32e4748ede9cd7b906d3a02f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        def get(self, ...):"},{"line_number":60,"context_line":"            # Get data from the store"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        def save(self, ...):"},{"line_number":63,"context_line":"            # Save data"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, ...):"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_ff8902cb","line":62,"updated":"2014-10-21 20:52:28.000000000","message":"I am not sure to see how this abstraction helps to bring new APIs like CoW. Could you add more details on that front?","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        def get(self, ...):"},{"line_number":60,"context_line":"            # Get data from the store"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        def save(self, ...):"},{"line_number":63,"context_line":"            # Save data"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, ...):"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_2892449f","line":62,"in_reply_to":"9aa7fdbe_ff8902cb","updated":"2014-10-23 07:58:59.000000000","message":"The idea is to ease the interaction with images by having a local, object oriented API that allows for an easier access to the image data. We currently have a function-based, global state dependent library that breaks in unexpected ways.\n\nThe benefits are not just in this specific API but in the clean-up of the old API and rewrite of the drivers code too.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"3e2e172ca140620c32e4748ede9cd7b906d3a02f","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"File-like objects will be accepted/returned by this API with support for random"},{"line_number":70,"context_line":"access to data portions."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"This spec also proposes removing completely the dependency on global config"},{"line_number":73,"context_line":"options and reduce to the minimum the dependency on oslo.config."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_7f199287","line":70,"updated":"2014-10-21 20:52:28.000000000","message":"I am not sure that all the stores support random access. How the client code should deal with this case?","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7e4fb1884949328947740532d3651f5b5fd1b9d4","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"File-like objects will be accepted/returned by this API with support for random"},{"line_number":70,"context_line":"access to data portions."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"This spec also proposes removing completely the dependency on global config"},{"line_number":73,"context_line":"options and reduce to the minimum the dependency on oslo.config."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_3f78eaf1","line":70,"updated":"2014-10-21 21:00:31.000000000","message":"While I understand that the intent behind this approach is to keep things simple for the user\u0027s of store API. We\u0027d be careful in creating a pigeonhole here. \n\nLet\u0027s keep the basic methods simple and easy to use and provide and advanced usage interface for supporting value-added options to the store API.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"File-like objects will be accepted/returned by this API with support for random"},{"line_number":70,"context_line":"access to data portions."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"This spec also proposes removing completely the dependency on global config"},{"line_number":73,"context_line":"options and reduce to the minimum the dependency on oslo.config."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_c842980f","line":70,"in_reply_to":"9aa7fdbe_3f78eaf1","updated":"2014-10-23 07:58:59.000000000","message":"There are 2 ways I was thinking about this:\n\n1. We implement a \u0027fake\u0027 random access for stores that don\u0027t support it.\n2. We raise an error and say that feature is not supported for store X.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7e4fb1884949328947740532d3651f5b5fd1b9d4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"options and reduce to the minimum the dependency on oslo.config."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"More changes will likely be required. Nontheless, the above clearly shows the"},{"line_number":76,"context_line":"need of a complete rewrite and that\u0027s what is being proposed here. The existing"},{"line_number":77,"context_line":"code will be kept and marked as deprecated. Each one of the publicly available"},{"line_number":78,"context_line":"functions will provide enough documentation showing how the same thing can be"},{"line_number":79,"context_line":"achieved using the new API."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_1f5a4650","line":76,"updated":"2014-10-21 21:00:31.000000000","message":"Do you believe that we can achieve a complete rewrite in one cycle?","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"options and reduce to the minimum the dependency on oslo.config."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"More changes will likely be required. Nontheless, the above clearly shows the"},{"line_number":76,"context_line":"need of a complete rewrite and that\u0027s what is being proposed here. The existing"},{"line_number":77,"context_line":"code will be kept and marked as deprecated. Each one of the publicly available"},{"line_number":78,"context_line":"functions will provide enough documentation showing how the same thing can be"},{"line_number":79,"context_line":"achieved using the new API."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_2847a41e","line":76,"in_reply_to":"9aa7fdbe_1f5a4650","updated":"2014-10-23 07:58:59.000000000","message":"I do believe so, it\u0027ll be 2 of us working on it.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"f3bc992e8c489470647375d8546f4a65e134c33d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"code will be kept and marked as deprecated. Each one of the publicly available"},{"line_number":78,"context_line":"functions will provide enough documentation showing how the same thing can be"},{"line_number":79,"context_line":"achieved using the new API."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_adee9820","line":80,"updated":"2014-10-20 20:12:26.000000000","message":"Someone might argue this is jumping the gun, but I\u0027d like to see the full public API design. It would be especially helpful if it were written in the form of behavior based black box tests.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"code will be kept and marked as deprecated. Each one of the publicly available"},{"line_number":78,"context_line":"functions will provide enough documentation showing how the same thing can be"},{"line_number":79,"context_line":"achieved using the new API."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_486dc897","line":80,"in_reply_to":"9aa7fdbe_adee9820","updated":"2014-10-23 07:58:59.000000000","message":"I think I understood what you mean and if I did, I agree with you. :P\n\nMind elaborating more?","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7e4fb1884949328947740532d3651f5b5fd1b9d4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Don\u0027t do anything and pay the consequences in the future :D"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Data model impact"},{"line_number":87,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_5a477c4b","line":84,"updated":"2014-10-21 21:00:31.000000000","message":"May be a plan B would be good to mention here:\n\n- finding the biggest pain points\n- removing any old unused code/store drivers\n- implement in smaller chunks focusing on stability\n\nLet\u0027s see what other inputs people may have. I would like to see if we are able to break this down into smaller action items which people can watch out for and keep the important changes like the stevedore plugin be implemented seamlessly.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Don\u0027t do anything and pay the consequences in the future :D"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Data model impact"},{"line_number":87,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_68160cf3","line":84,"in_reply_to":"9aa7fdbe_5a477c4b","updated":"2014-10-23 07:58:59.000000000","message":"I don\u0027t think there\u0027s a good way to fix the current state of the library without a rewrite. The 2 things I find most disturbing about the current library are:\n\n1. It depends on global states, which makes it hard to consume and error prone.\n2. It\u0027s function-based whereas the data \u0027traveling\u0027 through it is all about context and objects.\n\nIf we make it non-dependent on global states, we\u0027ll have to add several keywords to the existing functions and make sure we pass them on every call. This would make consuming the library harder because you need to have those objects everywhere to be able to consume the library (conf object for example). Furthermore, this will make the consumption from other projects even harder.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"3e2e172ca140620c32e4748ede9cd7b906d3a02f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Security impact"},{"line_number":97,"context_line":"---------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"We must be careful not to add any regresions that will end up being security"},{"line_number":100,"context_line":"holes. Other than that, there\u0027s no security impact."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_fa13d059","line":99,"updated":"2014-10-21 20:52:28.000000000","message":"typo: regressions","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Security impact"},{"line_number":97,"context_line":"---------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"We must be careful not to add any regresions that will end up being security"},{"line_number":100,"context_line":"holes. Other than that, there\u0027s no security impact."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_c8de183f","line":99,"in_reply_to":"9aa7fdbe_fa13d059","updated":"2014-10-23 07:58:59.000000000","message":"Done","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"c75c4602902d8a6558f6c7b1ad88a7dffeb2d20e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Other end user impact"},{"line_number":108,"context_line":"---------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"No impact for \"Glance\" users. IT definitely impacts glance-store users as it\u0027ll"},{"line_number":111,"context_line":"require them to move to the new API. A deprecation period for the old one will"},{"line_number":112,"context_line":"be given."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_d7eed0b3","line":110,"updated":"2014-10-22 12:39:05.000000000","message":"Typo on It. I spent far too long trying to work out what the acronym was!","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Other end user impact"},{"line_number":108,"context_line":"---------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"No impact for \"Glance\" users. IT definitely impacts glance-store users as it\u0027ll"},{"line_number":111,"context_line":"require them to move to the new API. A deprecation period for the old one will"},{"line_number":112,"context_line":"be given."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_28e32406","line":110,"in_reply_to":"9aa7fdbe_d7eed0b3","updated":"2014-10-23 07:58:59.000000000","message":"Done","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7e4fb1884949328947740532d3651f5b5fd1b9d4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Other deployer impact"},{"line_number":120,"context_line":"---------------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"None"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Developer impact"},{"line_number":125,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_3abab823","line":122,"updated":"2014-10-21 21:00:31.000000000","message":"We may see some deployer impact. This is a first level project now so, not sure if we can do alpha/beta releases with known bugs.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Other deployer impact"},{"line_number":120,"context_line":"---------------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"None"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Developer impact"},{"line_number":125,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_e8b83ce7","line":122,"in_reply_to":"9aa7fdbe_3abab823","updated":"2014-10-23 07:58:59.000000000","message":"What impacts do you see? The idea is to do the re-factor without requiring changes in the current configs. Other than updating the library, I don\u0027t see any impact.\n\nAm I missing something?","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7e4fb1884949328947740532d3651f5b5fd1b9d4","unresolved":false,"context_lines":[{"line_number":124,"context_line":"Developer impact"},{"line_number":125,"context_line":"----------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"It\u0027ll make many devs happy and fewer kittens will die."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Implementation"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_9a9f24b4","line":127,"updated":"2014-10-21 21:00:31.000000000","message":"May be good to mention deprecation phase changes needed and based on the breakdown what follows what.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"f3bc992e8c489470647375d8546f4a65e134c33d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"Developer impact"},{"line_number":125,"context_line":"----------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"It\u0027ll make many devs happy and fewer kittens will die."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Implementation"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_2a09ae31","line":127,"updated":"2014-10-20 20:12:26.000000000","message":"lol","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":124,"context_line":"Developer impact"},{"line_number":125,"context_line":"----------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"It\u0027ll make many devs happy and fewer kittens will die."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Implementation"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_28ca446e","line":127,"in_reply_to":"9aa7fdbe_9a9f24b4","updated":"2014-10-23 07:58:59.000000000","message":"Good point, will do.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7e4fb1884949328947740532d3651f5b5fd1b9d4","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Work Items"},{"line_number":142,"context_line":"----------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* Write the `Store` implementation on top of the existing functions"},{"line_number":145,"context_line":"* Improve store drivers API and let the new `Store` class use them directly"},{"line_number":146,"context_line":"* Mark the old API as deprecated"},{"line_number":147,"context_line":"* More cleanups, as needed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_bacb08a4","line":144,"updated":"2014-10-21 21:00:31.000000000","message":"Let\u0027s try to make these a bit more granular and find the pieces which can be implemented in parallel.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cf8446b189f0488d408c1af64b144b1c39e375d7","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Work Items"},{"line_number":142,"context_line":"----------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* Write the `Store` implementation on top of the existing functions"},{"line_number":145,"context_line":"* Improve store drivers API and let the new `Store` class use them directly"},{"line_number":146,"context_line":"* Mark the old API as deprecated"},{"line_number":147,"context_line":"* More cleanups, as needed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_28c6c449","line":144,"in_reply_to":"9aa7fdbe_bacb08a4","updated":"2014-10-23 07:58:59.000000000","message":"mmh, I wish there was a better way to express dependencies here. I was thinking about the first 2 as something that could be done in parallel.\n\nI\u0027ll split it, we could definitely do drivers migrations in parallel.","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"f3bc992e8c489470647375d8546f4a65e134c33d","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Mostly unittests and integration tests with glance. Once glance\u0027s usage of"},{"line_number":158,"context_line":"glance-store is updated, it\u0027ll be automatically tested functionally along with"},{"line_number":159,"context_line":"all Glance\u0027s tests."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Documentation Impact"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_cd203c9e","line":159,"updated":"2014-10-20 20:12:26.000000000","message":"I\u0027d love to see the actual black box API level tests here that would be used as a basis for implementation: I think it would go a long way towards understanding of the changes and consensus building.\n\nI don\u0027t believe we are currently using this, but I think it could be a helpful resource and potentially an ideal candidate for starting to: http://pythonhosted.org/behave/","commit_id":"6bd49d751aae2f1363277540f77a1f457d2145e6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"a2a3a1eda208c544008a38fccb08358ea5000aa4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"API that would be consumable from other applications, hence this spec."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"https://blueprints.launchpad.net/glance/+spec/refactor-glance-store"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_7e33f461","line":19,"updated":"2014-11-14 20:01:37.000000000","message":"We\u0027d probably add APIImpact flag here.\n\nPlease see https://review.openstack.org/#/c/131622/","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"98d5a07f925d18e5797f59da76462165502788b1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"API that would be consumable from other applications, hence this spec."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"https://blueprints.launchpad.net/glance/+spec/refactor-glance-store"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_c774d869","line":19,"in_reply_to":"5a890539_7e33f461","updated":"2014-11-18 10:43:55.000000000","message":"mmh, I don\u0027t think we need the flag here. The review explicitly states that the flag is needed for changes to the REST API so that the API WG can track those.","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"3dcbc6d96696db728ead21bdeb2876c34c38bacb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            # do other stuff"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        def get(self, ...):"},{"line_number":60,"context_line":"            # Get data from the store"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        def save(self, ...):"},{"line_number":63,"context_line":"            # Save data"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_3a5e4113","line":60,"updated":"2014-11-03 20:30:28.000000000","message":"Is the data without type, or are we specifically acting on objects?","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ad76f54959cae54c1801be701a5865386ecd6437","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            # do other stuff"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        def get(self, ...):"},{"line_number":60,"context_line":"            # Get data from the store"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        def save(self, ...):"},{"line_number":63,"context_line":"            # Save data"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_4855de4e","line":60,"in_reply_to":"7a8c0949_3a5e4113","updated":"2014-11-13 09:32:19.000000000","message":"I should probably update that comment. We would be returning a `BackendObject`, which is described below.","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"3dcbc6d96696db728ead21bdeb2876c34c38bacb","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, ...):"},{"line_number":66,"context_line":"            # remove data"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Note that the `Store` implementation shown above does not refer to the"},{"line_number":69,"context_line":"driver but to the object consumers of this library will have access"},{"line_number":70,"context_line":"to."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_7a644949","line":67,"updated":"2014-11-03 20:30:28.000000000","message":"In addition to get, save, and delete, I see list, filter, map:\ne.g.\n\n\u003e map (++\"-deleted\") $ filter (\u003d\u003d\"os\") [\"os\", \"os\", \"user\", \"os\", \"user\"]\n[\"os-deleted\",\"os-deleted\",\"os-deleted\"]\n\nIt would be ideal if we could compose and apply these operations on the object store.\n\nOne way to achieve these additional operations in a more OO fashion would be to add a list method that has a filter param. The get and delete methods could then either take a filtered list or also have the filter param.","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ad76f54959cae54c1801be701a5865386ecd6437","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, ...):"},{"line_number":66,"context_line":"            # remove data"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Note that the `Store` implementation shown above does not refer to the"},{"line_number":69,"context_line":"driver but to the object consumers of this library will have access"},{"line_number":70,"context_line":"to."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_eb9f64b2","line":67,"in_reply_to":"5a890539_4990ceec","updated":"2014-11-13 09:32:19.000000000","message":"mmh, I\u0027m with Eddie on this one. glance_store gives already lots of power to the user of the library on what they can do and adding other functions like listing and filtering would allow them to do more than they should through this library.\n\nIn addition to the above, there\u0027s a very high chance that most of the stores won\u0027t be able to support such features and that will make the library inconsistent.\n\nMoreover, the library is meant to be used with absolute paths to objects stored in the storage. In order to support listing, filtering and map, we\u0027d need to be able to point to containers, buckets whatsoever and basically create a cross-storage client library.\n\nFWIW, I\u0027m not fully opposed but I\u0027d prefer to do that as an evolution of the work proposed here.","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"a95a9ac507762f07e4c7657a9048b636c46a68b7","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, ...):"},{"line_number":66,"context_line":"            # remove data"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Note that the `Store` implementation shown above does not refer to the"},{"line_number":69,"context_line":"driver but to the object consumers of this library will have access"},{"line_number":70,"context_line":"to."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_4990ceec","line":67,"in_reply_to":"5a890539_b0ed208e","updated":"2014-11-10 21:11:48.000000000","message":"\"But then all you\u0027ve done is rewrite glanceclient and call it glance-store.\"\n\nI hope not. Glance client communicates with a stateful store. I\u0027m talking about a single consistent API for interacting with immutable data objects which contain metadata.\n\n\"Glance-store is more like a low-level driver into the various stores that glance can use, just abstracted out.\"\n\nThat is going to have a new external API. I\u0027m talking about that new external API.\n\n\"The object store doesn\u0027t have the metadata that you\u0027re asking to filter on\"\n\nGlance store might not be able to easily glean all of the metadata that Glance has from the objects in the store. However, there is some metadata (i.e. the image id / location information) that can be used to filter the list (e.g. filtering all images for a specific image). Planning for filtering paves a path for a fully-featured stateless API.\n\n\"so you would be putting code into glance-store to call back to glance for the filtering then talk to swift for the actual object.\"\n\nThis is the opposite direction that I would like to see this project go. I would like to keep any future work out of the business of braiding state into them.\n\n\"If you need to filter, use glanceclient. If you already know exactly what you want, bypass all the glance stuff and get it directly.\"\n\nThis is a feasible technical solution, and I suspect where things will end up in the short term. This doesn\u0027t mean we can\u0027t start paving the way to a single stateless API that can accomplish both tasks.\n\n\"Glance-store is NOT a full api into glance - just into the backend store. It just knows how to use all the relevant glance configs and location urls to do the communication.\"\n\nExactly. It\u0027s not an API into Glance. It\u0027s a core component used to interface with the object stores. Historically, it was a core component of only the Glance API. Now it\u0027s going to be a core component of an alternative API into the object stores. That API should be stateless. That API could eventually replace the current API.\n\nWe\u0027re talking about a new external API for interfacing with the Object Stores. This is an opportunity to improve upon what we have using our current knowledge.","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"e8cedd7501e002e47624ac3a597f20734110ada6","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, ...):"},{"line_number":66,"context_line":"            # remove data"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Note that the `Store` implementation shown above does not refer to the"},{"line_number":69,"context_line":"driver but to the object consumers of this library will have access"},{"line_number":70,"context_line":"to."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_67f0d2fe","line":67,"in_reply_to":"5a890539_eb9f64b2","updated":"2014-11-14 14:51:31.000000000","message":"\"an evolution of the work proposed here.\"\n\nagreed\n\nI do feel there should be some concern about using glance store directly in this case vs providing support through a single consistent public API, such as glance client, that leverages glance store as an internal library.","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"06e1ac375cb6247a5f8e904c00e74284a1c8c01d","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, ...):"},{"line_number":66,"context_line":"            # remove data"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Note that the `Store` implementation shown above does not refer to the"},{"line_number":69,"context_line":"driver but to the object consumers of this library will have access"},{"line_number":70,"context_line":"to."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_7e040fc0","line":67,"in_reply_to":"7a8c0949_4aeddf8a","updated":"2014-11-06 16:49:37.000000000","message":"I think they are in the scope of the API that is used to access the objects in the object store. If external code (e.g. Nova) is going to directly call glance_store code, then I believe the API should support these operations. If instead, calls would be made to glanceclient that would in turn use glance_store, then the operations should define glanceclient.\n\nGlance should provide a single consistent (ideally stateless) API into the object stores.","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},"change_message_id":"3528bfa3011d76c6016442de82ced00fb80e530b","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, ...):"},{"line_number":66,"context_line":"            # remove data"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Note that the `Store` implementation shown above does not refer to the"},{"line_number":69,"context_line":"driver but to the object consumers of this library will have access"},{"line_number":70,"context_line":"to."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_4aeddf8a","line":67,"in_reply_to":"7a8c0949_7a644949","updated":"2014-11-05 22:22:56.000000000","message":"I don\u0027t believe these kind of operations are within the scope of glance_store. Unless I\u0027m mistaken this is really intended as a direct connection into whatever the backing store glance is using, not into glance itself. A typical use case for a glance_store consumer would be to find the image of interest using glance (via glanceclient likely), then talk to glance_store library using the locations from the image to access the image data, bypassing glance for the data transfer. In fact glance_store could be used by glanceclient making the entire process transparent to consumers. This opens up several possible usage scenarios.","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},"change_message_id":"5405cfa3e46fa064f25442937dc482b913f9471b","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def delete(self, ...):"},{"line_number":66,"context_line":"            # remove data"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Note that the `Store` implementation shown above does not refer to the"},{"line_number":69,"context_line":"driver but to the object consumers of this library will have access"},{"line_number":70,"context_line":"to."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_b0ed208e","line":67,"in_reply_to":"7a8c0949_7e040fc0","updated":"2014-11-10 15:20:36.000000000","message":"But then all you\u0027ve done is rewrite glanceclient and call it glance-store. Glance-store is more like a low-level driver into the various stores that glance can use, just abstracted out. The object store doesn\u0027t have the metadata that you\u0027re asking to filter on, so you would be putting code into glance-store to call back to glance for the filtering then talk to swift for the actual object. If you need to filter, use glanceclient. If you already know exactly what you want, bypass all the glance stuff and get it directly. Glance-store is NOT a full api into glance - just into the backend store. It just knows how to use all the relevant glance configs and location urls to do the communication.","commit_id":"e3104e59a9fe161c8316da9b526f9f2538f5e90f"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"fcab6888dc8a4ba52be5731c8331006b73bba520","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The new implementation will consist on a mostly private - in terms of what is"},{"line_number":46,"context_line":"actually exposed to the user of the library - implementation. It\u0027ll expose an"},{"line_number":47,"context_line":"abstraction that will allow users to easily create `Store` instances and it\u0027ll"},{"line_number":48,"context_line":"completely remove the need to access store drivers directly."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The `Store` abstraction will be implemented along the lines of: ::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_6d96b14a","line":47,"updated":"2015-01-16 21:34:24.000000000","message":"I\u0027m a little confused about the Store instances. Are these users users of the library or driver authors? Would the instance of Store created be returned from the library? I\u0027m probably missing something here, so it would be nice if this could be clarified in a later PS.","commit_id":"e698959c92449f20443dd5aa674210a99bdece72"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"fcab6888dc8a4ba52be5731c8331006b73bba520","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        def get(self, ...):"},{"line_number":60,"context_line":"            # Get data from the store"},{"line_number":61,"context_line":"\t    # return a `BackendObject`"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        def save(self, ...):"},{"line_number":64,"context_line":"            # Save data"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_6ddeb16b","line":61,"updated":"2015-01-16 21:34:24.000000000","message":"Erroneous tab character?","commit_id":"e698959c92449f20443dd5aa674210a99bdece72"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"fcab6888dc8a4ba52be5731c8331006b73bba520","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            pass"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Likewise, the `Store` object will accept a file-like object that it"},{"line_number":102,"context_line":"can read data from and write it into the store."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"This spec also proposes removing completely the dependency on global"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_2df4a9cd","line":101,"updated":"2015-01-16 21:34:24.000000000","message":"Where does Store accept this file-like object? Is it provided by the driver author, or the user of glance_store?","commit_id":"e698959c92449f20443dd5aa674210a99bdece72"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"fcab6888dc8a4ba52be5731c8331006b73bba520","unresolved":false,"context_lines":[{"line_number":164,"context_line":"OpenStack standards and it\u0027ll also point developers on the right"},{"line_number":165,"context_line":"direction to consume the new API."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Other than that, it\u0027ll make many devs happy and fewer kittens will"},{"line_number":168,"context_line":"die."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_0d960d94","line":167,"updated":"2015-01-16 21:34:24.000000000","message":"-1 Ideally a guarantee no more kittens should die after this refactoring.","commit_id":"e698959c92449f20443dd5aa674210a99bdece72"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"fcab6888dc8a4ba52be5731c8331006b73bba520","unresolved":false,"context_lines":[{"line_number":193,"context_line":"Work Items"},{"line_number":194,"context_line":"----------"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"* Write a new API for storage drivers that\u0027s file-like"},{"line_number":197,"context_line":"  * Port existing drivers (with support from the community)"},{"line_number":198,"context_line":"* Write the `Store` implementation and make it consume the new drivers."},{"line_number":199,"context_line":"* Mark the old API as deprecated"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_2daae9d1","line":196,"updated":"2015-01-16 21:34:24.000000000","message":"Documentation of how to consume the new API should be added here.","commit_id":"e698959c92449f20443dd5aa674210a99bdece72"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"fcab6888dc8a4ba52be5731c8331006b73bba520","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Mostly unittests and integration tests with glance. Once glance\u0027s usage of"},{"line_number":211,"context_line":"glance-store is updated, it\u0027ll be automatically tested functionally along with"},{"line_number":212,"context_line":"all Glance\u0027s tests."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Documentation Impact"},{"line_number":215,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_6d42313c","line":212,"updated":"2015-01-16 21:34:24.000000000","message":"This is only for the released version of glance_store, however.","commit_id":"e698959c92449f20443dd5aa674210a99bdece72"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"fcab6888dc8a4ba52be5731c8331006b73bba520","unresolved":false,"context_lines":[{"line_number":214,"context_line":"Documentation Impact"},{"line_number":215,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"New developers documentation will be needed."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"References"},{"line_number":220,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_eda46108","line":217,"updated":"2015-01-16 21:34:24.000000000","message":"I\u0027d say this should be stressed a little more. The ease of use of the new API strongly depends on the quality of the documentation surrounding it.","commit_id":"e698959c92449f20443dd5aa674210a99bdece72"}]}
