)]}'
{"specs/kilo/sighup-conf-reload.rst":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"3118bea71e76ba40938f05fd771f69b260f41028","unresolved":false,"context_lines":[{"line_number":5,"context_line":"https://blueprints.launchpad.net/glance/+spec/sighup-conf-reload"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"No need to restart the glance api service when user modifies"},{"line_number":8,"context_line":"configuration files."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Problem description"},{"line_number":11,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_12bcafdb","line":8,"updated":"2014-10-15 14:51:40.000000000","message":"nit: This sounds a little as if the configuration file change will be picked up automatically, I think some verbiage to make it clear that an operator needs to send a signal for the new conf to get picked up would be good.","commit_id":"d16eabaa151291181430d2b278da07995ec4a6d6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c76dd57d66936efb354d6d851f12806e2aa6fa41","unresolved":false,"context_lines":[{"line_number":5,"context_line":"https://blueprints.launchpad.net/glance/+spec/sighup-conf-reload"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"No need to restart the glance api service when user modifies"},{"line_number":8,"context_line":"configuration files."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Problem description"},{"line_number":11,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_0ef9d97f","line":8,"in_reply_to":"baa201ad_12bcafdb","updated":"2014-10-16 07:36:58.000000000","message":"Done","commit_id":"d16eabaa151291181430d2b278da07995ec4a6d6"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"3118bea71e76ba40938f05fd771f69b260f41028","unresolved":false,"context_lines":[{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"The following eventlet change is required:"},{"line_number":129,"context_line":"https://github.com/eventlet/eventlet/pull/138/files"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_927dff1e","line":129,"updated":"2014-10-15 14:51:40.000000000","message":"Maybe mention that this has merged and will be part of the next eventlet release.","commit_id":"d16eabaa151291181430d2b278da07995ec4a6d6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c76dd57d66936efb354d6d851f12806e2aa6fa41","unresolved":false,"context_lines":[{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"The following eventlet change is required:"},{"line_number":129,"context_line":"https://github.com/eventlet/eventlet/pull/138/files"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_2ef69d8f","line":129,"in_reply_to":"baa201ad_927dff1e","updated":"2014-10-16 07:36:58.000000000","message":"Done","commit_id":"d16eabaa151291181430d2b278da07995ec4a6d6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8242517a589b0943b9da008e595b2f2f47ef4121","unresolved":false,"context_lines":[{"line_number":5,"context_line":"https://blueprints.launchpad.net/glance/+spec/sighup-conf-reload"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"No need to restart the glance api service when user modifies"},{"line_number":8,"context_line":"configuration files. Operator/User can send SIGHUP signal to glance"},{"line_number":9,"context_line":"service which will reload the configuration file."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_e09d115b","line":8,"updated":"2015-02-07 22:10:11.000000000","message":"Nit 1: instead of \"No need\" how about \"We propose to eliminate the need\".\n\nNit 2: instead of \"when user modifies config files\" how about \"when configuration files are modified\".\n\nNit 3: instead of \"Operator/User\" how about just \"Operator\"?  An arbitrary glance user is not going to be in the position to send a SIGHUP (I\u0027d hope!).","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b920d0feafee80e9dad8e4bdc2ec708825cab82","unresolved":false,"context_lines":[{"line_number":5,"context_line":"https://blueprints.launchpad.net/glance/+spec/sighup-conf-reload"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"No need to restart the glance api service when user modifies"},{"line_number":8,"context_line":"configuration files. Operator/User can send SIGHUP signal to glance"},{"line_number":9,"context_line":"service which will reload the configuration file."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_bf9a4bc3","line":8,"in_reply_to":"da86d52c_e09d115b","updated":"2015-02-09 11:29:42.000000000","message":"Done","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8242517a589b0943b9da008e595b2f2f47ef4121","unresolved":false,"context_lines":[{"line_number":14,"context_line":"In production environment, administrator modifies the glance-api.conf"},{"line_number":15,"context_line":"configuration parameters like filesystem_store_datadirs when the storage"},{"line_number":16,"context_line":"is almost full to add more capacity by adding more disks, or to increase"},{"line_number":17,"context_line":"the number of workers or log configuration etc. then he/she need to restart"},{"line_number":18,"context_line":"the glance service explicitly to make these changes effective. Restarting"},{"line_number":19,"context_line":"service would break users connected to it which is not good in users point"},{"line_number":20,"context_line":"of view."}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_80037575","line":17,"updated":"2015-02-07 22:10:11.000000000","message":"Change \"then\" to \"Then\" and \"need\" to \"needs\".","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b920d0feafee80e9dad8e4bdc2ec708825cab82","unresolved":false,"context_lines":[{"line_number":14,"context_line":"In production environment, administrator modifies the glance-api.conf"},{"line_number":15,"context_line":"configuration parameters like filesystem_store_datadirs when the storage"},{"line_number":16,"context_line":"is almost full to add more capacity by adding more disks, or to increase"},{"line_number":17,"context_line":"the number of workers or log configuration etc. then he/she need to restart"},{"line_number":18,"context_line":"the glance service explicitly to make these changes effective. Restarting"},{"line_number":19,"context_line":"service would break users connected to it which is not good in users point"},{"line_number":20,"context_line":"of view."}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_df9fffb2","line":17,"in_reply_to":"da86d52c_80037575","updated":"2015-02-09 11:29:42.000000000","message":"Done","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8242517a589b0943b9da008e595b2f2f47ef4121","unresolved":false,"context_lines":[{"line_number":16,"context_line":"is almost full to add more capacity by adding more disks, or to increase"},{"line_number":17,"context_line":"the number of workers or log configuration etc. then he/she need to restart"},{"line_number":18,"context_line":"the glance service explicitly to make these changes effective. Restarting"},{"line_number":19,"context_line":"service would break users connected to it which is not good in users point"},{"line_number":20,"context_line":"of view."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_a0087992","line":19,"updated":"2015-02-07 22:10:11.000000000","message":"Maybe change \"in users\" to \"from users\u0027\".","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b920d0feafee80e9dad8e4bdc2ec708825cab82","unresolved":false,"context_lines":[{"line_number":16,"context_line":"is almost full to add more capacity by adding more disks, or to increase"},{"line_number":17,"context_line":"the number of workers or log configuration etc. then he/she need to restart"},{"line_number":18,"context_line":"the glance service explicitly to make these changes effective. Restarting"},{"line_number":19,"context_line":"service would break users connected to it which is not good in users point"},{"line_number":20,"context_line":"of view."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_1faa77d4","line":19,"in_reply_to":"da86d52c_a0087992","updated":"2015-02-09 11:29:42.000000000","message":"Done","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8242517a589b0943b9da008e595b2f2f47ef4121","unresolved":false,"context_lines":[{"line_number":48,"context_line":"- Long lived pre-SIGHUP idle client connections can stall request"},{"line_number":49,"context_line":"processing indefinitely."},{"line_number":50,"context_line":"- Not all parameters can be changed, eg number of workers."},{"line_number":51,"context_line":"- The wsgi pipeline cannot be changed, eg to enable caching."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_c0348d4c","line":51,"updated":"2015-02-07 22:10:11.000000000","message":"Please change \"eg\" to \"for example, \" (it\u0027s an OpenStack documentation style thing).","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b920d0feafee80e9dad8e4bdc2ec708825cab82","unresolved":false,"context_lines":[{"line_number":48,"context_line":"- Long lived pre-SIGHUP idle client connections can stall request"},{"line_number":49,"context_line":"processing indefinitely."},{"line_number":50,"context_line":"- Not all parameters can be changed, eg number of workers."},{"line_number":51,"context_line":"- The wsgi pipeline cannot be changed, eg to enable caching."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_5fab0fd6","line":51,"in_reply_to":"da86d52c_c0348d4c","updated":"2015-02-09 11:29:42.000000000","message":"Done","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8242517a589b0943b9da008e595b2f2f47ef4121","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Might hit the performance if the reload takes too long (e.g. ~50ms) then API"},{"line_number":91,"context_line":"requests will be delayed while the reload takes place, and that will be"},{"line_number":92,"context_line":"user visible."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Other deployer impact"},{"line_number":95,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_c059ed8f","line":92,"updated":"2015-02-07 22:10:11.000000000","message":"If I understand correctly, your plan is to tell the n current worker processes to stop accepting requests and continue with what they\u0027re doing, while the master process starts n replacement workers with the new configuration.  So there\u0027s a possibility that the glance node will be running twice as many workers as it\u0027s configured to run for a while ... I think that could impact performance, especially if it\u0027s an underpowered node that\u0027s already configured to run as many workers as it can handle without degradation.  Is that something we need to worry about?  Or is it at least something to warn operators about, namely, that if they\u0027re going to use the dynamic configuration via SIGHUP, they need to make sure the node isn\u0027t over-provisioned with workers?","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b920d0feafee80e9dad8e4bdc2ec708825cab82","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Might hit the performance if the reload takes too long (e.g. ~50ms) then API"},{"line_number":91,"context_line":"requests will be delayed while the reload takes place, and that will be"},{"line_number":92,"context_line":"user visible."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Other deployer impact"},{"line_number":95,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_b38c3f37","line":92,"in_reply_to":"da86d52c_c059ed8f","updated":"2015-02-09 11:29:42.000000000","message":"Yes, this will affect performance.","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8242517a589b0943b9da008e595b2f2f47ef4121","unresolved":false,"context_lines":[{"line_number":95,"context_line":"---------------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Need to document the impact of config changes for some params like workers,"},{"line_number":98,"context_line":"host, port etc."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_404dfdc3","line":98,"updated":"2015-02-07 22:10:11.000000000","message":"You\u0027ll want to keep this list updated as you start coding.","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b920d0feafee80e9dad8e4bdc2ec708825cab82","unresolved":false,"context_lines":[{"line_number":95,"context_line":"---------------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Need to document the impact of config changes for some params like workers,"},{"line_number":98,"context_line":"host, port etc."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_7372c74a","line":98,"in_reply_to":"da86d52c_404dfdc3","updated":"2015-02-09 11:29:42.000000000","message":"right, I will start updating the list","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3898b8ec6c92173195076ac65331658806c827d2","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"The above change has merged in the eventlet and will be available"},{"line_number":133,"context_line":"in the next release of eventlet library."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Testing"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_d422b850","line":134,"updated":"2015-02-06 11:11:01.000000000","message":"No dependency now as new version of eventlet is released with the mentioned change.\n\nImplementation patch is up for review https://review.openstack.org/122181","commit_id":"ca4641b147cfad27e8ad779d3d82cf86f6f92072"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"57a57c070bb0740220d96af2a9a6e6ed07236cc2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Problem description"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In production environment, administrator modifies the glance-api.conf"},{"line_number":15,"context_line":"configuration parameters like filesystem_store_datadirs when the storage"},{"line_number":16,"context_line":"is almost full to add more capacity by adding more disks, or to increase"},{"line_number":17,"context_line":"the number of workers or log configuration etc. Then he/she needs to restart"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_ef101150","line":14,"updated":"2015-02-11 17:45:38.000000000","message":"Nit: \"In a production environment, an administrator will modify ...\"","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"172169cd64444703754ee8de42f1d1bd846832eb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Problem description"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In production environment, administrator modifies the glance-api.conf"},{"line_number":15,"context_line":"configuration parameters like filesystem_store_datadirs when the storage"},{"line_number":16,"context_line":"is almost full to add more capacity by adding more disks, or to increase"},{"line_number":17,"context_line":"the number of workers or log configuration etc. Then he/she needs to restart"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_35a42007","line":14,"in_reply_to":"da86d52c_ef101150","updated":"2015-02-12 06:07:12.000000000","message":"Done","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"57a57c070bb0740220d96af2a9a6e6ed07236cc2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"In production environment, administrator modifies the glance-api.conf"},{"line_number":15,"context_line":"configuration parameters like filesystem_store_datadirs when the storage"},{"line_number":16,"context_line":"is almost full to add more capacity by adding more disks, or to increase"},{"line_number":17,"context_line":"the number of workers or log configuration etc. Then he/she needs to restart"},{"line_number":18,"context_line":"the glance service explicitly to make these changes effective. Restarting"},{"line_number":19,"context_line":"service would break users connected to it which is not good from users point"},{"line_number":20,"context_line":"of view."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_2fb3094e","line":17,"updated":"2015-02-11 17:45:38.000000000","message":"For an unknown administrator, there\u0027s no need to say \"he/she\". It\u0027s grammatically acceptable to say \"they\", e.g., \"Then they need to restart the glance services explicitly for these changes to be loaded.\"","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"172169cd64444703754ee8de42f1d1bd846832eb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"In production environment, administrator modifies the glance-api.conf"},{"line_number":15,"context_line":"configuration parameters like filesystem_store_datadirs when the storage"},{"line_number":16,"context_line":"is almost full to add more capacity by adding more disks, or to increase"},{"line_number":17,"context_line":"the number of workers or log configuration etc. Then he/she needs to restart"},{"line_number":18,"context_line":"the glance service explicitly to make these changes effective. Restarting"},{"line_number":19,"context_line":"service would break users connected to it which is not good from users point"},{"line_number":20,"context_line":"of view."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_f584485f","line":17,"in_reply_to":"da86d52c_2fb3094e","updated":"2015-02-12 06:07:12.000000000","message":"Done","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"57a57c070bb0740220d96af2a9a6e6ed07236cc2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Add the ability to dynamically change configuration settings of a running"},{"line_number":26,"context_line":"glance server with no impact to service."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A running glance server consists of a parent/master process and one or"},{"line_number":29,"context_line":"more child/worker processes."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"On receipt of a SIGHUP signal the master process will:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_f2d715ec","line":28,"updated":"2015-02-11 17:45:38.000000000","message":"I think it makes sense to leave it as parent - child instead of having the /alt-name syntax. We can then make the rest of this section consistent using parent - child.","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"172169cd64444703754ee8de42f1d1bd846832eb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Add the ability to dynamically change configuration settings of a running"},{"line_number":26,"context_line":"glance server with no impact to service."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"A running glance server consists of a parent/master process and one or"},{"line_number":29,"context_line":"more child/worker processes."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"On receipt of a SIGHUP signal the master process will:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_d5890470","line":28,"in_reply_to":"da86d52c_f2d715ec","updated":"2015-02-12 06:07:12.000000000","message":"Done","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"57a57c070bb0740220d96af2a9a6e6ed07236cc2","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Might be an alternative,"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"save-and-restore long running tasks via taskflow, so that process restart only"},{"line_number":59,"context_line":"has to deal with short lived requests (e.g. API DB lookups) and then no user"},{"line_number":60,"context_line":"visible downtime is required for regular restarts"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_4de3e0d8","line":58,"updated":"2015-02-11 17:45:38.000000000","message":"Nit: We can rewrite this in a slightly friendlier way. Shorter sentences make it easier to read.\n\n\"An alternative may be to attempt to save and then restore long running tasks using taskflow. The process restart would then only need to deal with .... \"","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"172169cd64444703754ee8de42f1d1bd846832eb","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Might be an alternative,"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"save-and-restore long running tasks via taskflow, so that process restart only"},{"line_number":59,"context_line":"has to deal with short lived requests (e.g. API DB lookups) and then no user"},{"line_number":60,"context_line":"visible downtime is required for regular restarts"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_55f514eb","line":58,"in_reply_to":"da86d52c_4de3e0d8","updated":"2015-02-12 06:07:12.000000000","message":"Done","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"57a57c070bb0740220d96af2a9a6e6ed07236cc2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Performance Impact"},{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Might hit the performance if the reload takes too long (e.g. ~50ms) then API"},{"line_number":91,"context_line":"requests will be delayed while the reload takes place, and that will be"},{"line_number":92,"context_line":"user visible."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_2d614c39","line":90,"updated":"2015-02-11 17:45:38.000000000","message":"Can we reword this a bit?\n\nIf the reload takes too long (e.g., \u003e50ms) then the API requests will be noticably delayed.","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"172169cd64444703754ee8de42f1d1bd846832eb","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Performance Impact"},{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Might hit the performance if the reload takes too long (e.g. ~50ms) then API"},{"line_number":91,"context_line":"requests will be delayed while the reload takes place, and that will be"},{"line_number":92,"context_line":"user visible."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_d513c4fe","line":90,"in_reply_to":"da86d52c_2d614c39","updated":"2015-02-12 06:07:12.000000000","message":"Done","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"57a57c070bb0740220d96af2a9a6e6ed07236cc2","unresolved":false,"context_lines":[{"line_number":99,"context_line":"underpowered node that is already configured to run as many workers as it can"},{"line_number":100,"context_line":"handle without degradation."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"IMO, operator need to make sure the node isn\u0027t over-provisioned with workers,"},{"line_number":103,"context_line":"if they are going to use the dynamic configuration via SIGHUP."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_2d64ec20","line":102,"updated":"2015-02-11 17:45:38.000000000","message":"We need to avoid conversational short hand wherever possible. Please expand \"IMO\" to \"In the author\u0027s opinion,\"","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"172169cd64444703754ee8de42f1d1bd846832eb","unresolved":false,"context_lines":[{"line_number":99,"context_line":"underpowered node that is already configured to run as many workers as it can"},{"line_number":100,"context_line":"handle without degradation."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"IMO, operator need to make sure the node isn\u0027t over-provisioned with workers,"},{"line_number":103,"context_line":"if they are going to use the dynamic configuration via SIGHUP."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_f5d5281c","line":102,"in_reply_to":"da86d52c_2d64ec20","updated":"2015-02-12 06:07:12.000000000","message":"Done","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"57a57c070bb0740220d96af2a9a6e6ed07236cc2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  Stuart McLaren"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Other contributors:"},{"line_number":127,"context_line":"  None"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Work Items"},{"line_number":130,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_0d7ba8be","line":127,"updated":"2015-02-11 17:45:38.000000000","message":"Should this be updated since there are other contributors to this like Abhishek?\n\nAlso, where is the list of core reviewers for this?","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"172169cd64444703754ee8de42f1d1bd846832eb","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  Stuart McLaren"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Other contributors:"},{"line_number":127,"context_line":"  None"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Work Items"},{"line_number":130,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_15d9dc56","line":127,"in_reply_to":"da86d52c_0d7ba8be","updated":"2015-02-12 06:07:12.000000000","message":"Done","commit_id":"3bcdca7f430fa6a51d7a3fe68834d3d35fb32ab4"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"cc8e4048bee3383ae977f4f435de797e3ed42aee","unresolved":false,"context_lines":[{"line_number":29,"context_line":"more child processes."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"On receipt of a SIGHUP signal the parent process will:"},{"line_number":32,"context_line":"- reload the configuration"},{"line_number":33,"context_line":"- send a SIGHUP to the original child processes"},{"line_number":34,"context_line":"- start new child processes with the new configuration"},{"line_number":35,"context_line":"- its listening socket will not be closed"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_b003510c","line":32,"updated":"2015-02-27 16:17:44.000000000","message":"For this to appear as a list you need an extra new-line before the first item.","commit_id":"7251557c00da5610112d6889e2b8189dd2de5900"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8720b22b515def42c7bd37983c3bb1759988590b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"more child processes."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"On receipt of a SIGHUP signal the parent process will:"},{"line_number":32,"context_line":"- reload the configuration"},{"line_number":33,"context_line":"- send a SIGHUP to the original child processes"},{"line_number":34,"context_line":"- start new child processes with the new configuration"},{"line_number":35,"context_line":"- its listening socket will not be closed"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_b347d14a","line":32,"in_reply_to":"ba7be1f8_b003510c","updated":"2015-02-27 19:58:28.000000000","message":"Done","commit_id":"7251557c00da5610112d6889e2b8189dd2de5900"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"cc8e4048bee3383ae977f4f435de797e3ed42aee","unresolved":false,"context_lines":[{"line_number":35,"context_line":"- its listening socket will not be closed"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"On receipt of a SIGHUP signal each original child process will:"},{"line_number":38,"context_line":"- close the listening socket so as not to accept new requests"},{"line_number":39,"context_line":"- complete any in-flight requests"},{"line_number":40,"context_line":"- exit"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_d008c52a","line":38,"updated":"2015-02-27 16:17:44.000000000","message":"Same here","commit_id":"7251557c00da5610112d6889e2b8189dd2de5900"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8720b22b515def42c7bd37983c3bb1759988590b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"- its listening socket will not be closed"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"On receipt of a SIGHUP signal each original child process will:"},{"line_number":38,"context_line":"- close the listening socket so as not to accept new requests"},{"line_number":39,"context_line":"- complete any in-flight requests"},{"line_number":40,"context_line":"- exit"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_d37365b2","line":38,"in_reply_to":"ba7be1f8_d008c52a","updated":"2015-02-27 19:58:28.000000000","message":"Done","commit_id":"7251557c00da5610112d6889e2b8189dd2de5900"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"cc8e4048bee3383ae977f4f435de797e3ed42aee","unresolved":false,"context_lines":[{"line_number":40,"context_line":"- exit"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This approach is based on nginx\u0027s behaviour and avoids some of the"},{"line_number":43,"context_line":"disadvantages of the current oslo\u0027s Launcher reload:"},{"line_number":44,"context_line":"- Race conditions: Launcher does not shutdown eventlet cleanly, existing"},{"line_number":45,"context_line":"requests can fail."},{"line_number":46,"context_line":"- If all child processes are busy there can be a lengthy delay when new"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_d0a4450a","line":43,"updated":"2015-02-27 16:17:44.000000000","message":"Same here","commit_id":"7251557c00da5610112d6889e2b8189dd2de5900"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8720b22b515def42c7bd37983c3bb1759988590b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"- exit"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This approach is based on nginx\u0027s behaviour and avoids some of the"},{"line_number":43,"context_line":"disadvantages of the current oslo\u0027s Launcher reload:"},{"line_number":44,"context_line":"- Race conditions: Launcher does not shutdown eventlet cleanly, existing"},{"line_number":45,"context_line":"requests can fail."},{"line_number":46,"context_line":"- If all child processes are busy there can be a lengthy delay when new"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_f3786991","line":43,"in_reply_to":"ba7be1f8_d0a4450a","updated":"2015-02-27 19:58:28.000000000","message":"Done","commit_id":"7251557c00da5610112d6889e2b8189dd2de5900"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"cc8e4048bee3383ae977f4f435de797e3ed42aee","unresolved":false,"context_lines":[{"line_number":97,"context_line":"especially if it is an underpowered node that is already configured to run"},{"line_number":98,"context_line":"as many child processes as it can handle without degradation."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"In the author\u0027s opinion,, operator need to make sure the node isn\u0027t"},{"line_number":101,"context_line":"over-provisioned with child processes(workers), if they are going to use the"},{"line_number":102,"context_line":"dynamic configuration via SIGHUP."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_50e69545","line":100,"updated":"2015-02-27 16:17:44.000000000","message":"You have two commas (,) here. Also while we\u0027re here, can we say \"the operator\"?","commit_id":"7251557c00da5610112d6889e2b8189dd2de5900"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8720b22b515def42c7bd37983c3bb1759988590b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"especially if it is an underpowered node that is already configured to run"},{"line_number":98,"context_line":"as many child processes as it can handle without degradation."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"In the author\u0027s opinion,, operator need to make sure the node isn\u0027t"},{"line_number":101,"context_line":"over-provisioned with child processes(workers), if they are going to use the"},{"line_number":102,"context_line":"dynamic configuration via SIGHUP."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_536775ea","line":100,"in_reply_to":"ba7be1f8_50e69545","updated":"2015-02-27 19:58:28.000000000","message":"Done","commit_id":"7251557c00da5610112d6889e2b8189dd2de5900"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"cc8e4048bee3383ae977f4f435de797e3ed42aee","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Documentation Impact"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Please refer Other deployer impact"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_5075b530","line":162,"updated":"2015-02-27 16:17:44.000000000","message":"If you want, you can make this a link by doing the following:\n\n1. Modify L103 to read\n\n    .. _other_deployer:\n\n    Other deployer impact\n    ---------------------\n\n    etc\n\n2. Change L162 to read\n\n    Please refer to :ref:`other_deployer`\n\nBut you don\u0027t have to. I\u0027m just giving you the option and information if you\u0027re interested.","commit_id":"7251557c00da5610112d6889e2b8189dd2de5900"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8720b22b515def42c7bd37983c3bb1759988590b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Documentation Impact"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Please refer Other deployer impact"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_b35ef110","line":162,"in_reply_to":"ba7be1f8_5075b530","updated":"2015-02-27 19:58:28.000000000","message":"Done","commit_id":"7251557c00da5610112d6889e2b8189dd2de5900"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dc43740f975e6ff3267368f5a292d023f7b8ee06","unresolved":false,"context_lines":[{"line_number":92,"context_line":"If the reload takes too long (e.g., \u003e50ms) then the API requests will be"},{"line_number":93,"context_line":"noticeably delayed."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"As we are proposing current worker processes to stop accepting requests and"},{"line_number":96,"context_line":"continue with what they are doing, while the parent process starts and"},{"line_number":97,"context_line":"spawn new child processes with the new configuration. So there is a"},{"line_number":98,"context_line":"possibility that the glance node will be running twice as many child processes"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_30467050","line":95,"updated":"2015-02-27 22:54:39.000000000","message":"Remove \"As\".","commit_id":"0021758739714c6eb6764abe4acb10017ef1dca4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3cad5b208a269e6f15922e7b0f5f9efb99be67ff","unresolved":false,"context_lines":[{"line_number":92,"context_line":"If the reload takes too long (e.g., \u003e50ms) then the API requests will be"},{"line_number":93,"context_line":"noticeably delayed."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"As we are proposing current worker processes to stop accepting requests and"},{"line_number":96,"context_line":"continue with what they are doing, while the parent process starts and"},{"line_number":97,"context_line":"spawn new child processes with the new configuration. So there is a"},{"line_number":98,"context_line":"possibility that the glance node will be running twice as many child processes"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_827c1974","line":95,"in_reply_to":"ba7be1f8_30467050","updated":"2015-03-02 04:57:44.000000000","message":"Done","commit_id":"0021758739714c6eb6764abe4acb10017ef1dca4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b72ab92059ee7e942909c2e8ce2ad50198ef8f8f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"If the reload takes too long (e.g., \u003e50ms) then the API requests will be"},{"line_number":93,"context_line":"noticeably delayed."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"As we are proposing current worker processes to stop accepting requests and"},{"line_number":96,"context_line":"continue with what they are doing, while the parent process starts and"},{"line_number":97,"context_line":"spawn new child processes with the new configuration. So there is a"},{"line_number":98,"context_line":"possibility that the glance node will be running twice as many child processes"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_c58386a7","line":95,"in_reply_to":"ba7be1f8_30467050","updated":"2015-03-01 06:17:55.000000000","message":"Hi Brian,\n\nI will remove it in next PS.","commit_id":"0021758739714c6eb6764abe4acb10017ef1dca4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dc43740f975e6ff3267368f5a292d023f7b8ee06","unresolved":false,"context_lines":[{"line_number":103,"context_line":"In the author\u0027s opinion, the operator need to make sure the node isn\u0027t"},{"line_number":104,"context_line":"over-provisioned with child processes(workers), if they are going to use the"},{"line_number":105,"context_line":"dynamic configuration via SIGHUP."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. _other_deployer:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_f06218d8","line":106,"updated":"2015-02-27 22:54:39.000000000","message":"This is an OK position to take, but please make clear that the default for this option will be off.","commit_id":"0021758739714c6eb6764abe4acb10017ef1dca4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3cad5b208a269e6f15922e7b0f5f9efb99be67ff","unresolved":false,"context_lines":[{"line_number":103,"context_line":"In the author\u0027s opinion, the operator need to make sure the node isn\u0027t"},{"line_number":104,"context_line":"over-provisioned with child processes(workers), if they are going to use the"},{"line_number":105,"context_line":"dynamic configuration via SIGHUP."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. _other_deployer:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_62856558","line":106,"in_reply_to":"ba7be1f8_5fecba29","updated":"2015-03-02 04:57:44.000000000","message":"Done","commit_id":"0021758739714c6eb6764abe4acb10017ef1dca4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3c4d08bae16668bcad44a0264d48e93ee276fde5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"In the author\u0027s opinion, the operator need to make sure the node isn\u0027t"},{"line_number":104,"context_line":"over-provisioned with child processes(workers), if they are going to use the"},{"line_number":105,"context_line":"dynamic configuration via SIGHUP."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. _other_deployer:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_5fecba29","line":106,"in_reply_to":"ba7be1f8_85a26e49","updated":"2015-03-02 03:42:30.000000000","message":"Hi Abhishek,\n\nI think this is a confusion on my part.  Your text states:\n\nIn the author\u0027s opinion, the operator need to make sure the node isn\u0027t over-provisioned with child processes(workers), if they are going to use the dynamic configuration via SIGHUP.\n\nThe \"if\" makes it sound to me like the operator has a choice about how the glance api service will behave if it gets a SIGHUP.   From your question (and the one below), I take it that that\u0027s not the case.  In other words, once your patch is merged, when the glance api service receives a SIGHUP, it will stop accepting requests on current processes, will spawn the new processes with the new config, and kill the current processes after they have completed what they\u0027re working on.\n\nIf this is the case, please change your text to something like this:\n\nIn the author\u0027s opinion, it is the responsibility of the operator to make sure the node will not be over-provisioned with child processes (workers).  If an operator wants to run a node with no headroom for additional child processes, the author suggests that such an operator not use dynamic configuration via SIGHUP.  Instead, such an operator should use the old fashioned technique of restarting the api service.","commit_id":"0021758739714c6eb6764abe4acb10017ef1dca4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b72ab92059ee7e942909c2e8ce2ad50198ef8f8f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"In the author\u0027s opinion, the operator need to make sure the node isn\u0027t"},{"line_number":104,"context_line":"over-provisioned with child processes(workers), if they are going to use the"},{"line_number":105,"context_line":"dynamic configuration via SIGHUP."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. _other_deployer:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_85a26e49","line":106,"in_reply_to":"ba7be1f8_f06218d8","updated":"2015-03-01 06:17:55.000000000","message":"Hi Brian,\n\nCould you please let me know which option here you are talking about?","commit_id":"0021758739714c6eb6764abe4acb10017ef1dca4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dc43740f975e6ff3267368f5a292d023f7b8ee06","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Other deployer impact"},{"line_number":110,"context_line":"---------------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Need to document the impact of config changes for some params like workers,"},{"line_number":113,"context_line":"host, port etc."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_50e92419","line":111,"updated":"2015-02-27 22:54:39.000000000","message":"How exactly is this going to be configured, i.e., will there be a config setting to enable this?","commit_id":"0021758739714c6eb6764abe4acb10017ef1dca4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b72ab92059ee7e942909c2e8ce2ad50198ef8f8f","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Other deployer impact"},{"line_number":110,"context_line":"---------------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Need to document the impact of config changes for some params like workers,"},{"line_number":113,"context_line":"host, port etc."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_659f3a04","line":111,"in_reply_to":"ba7be1f8_50e92419","updated":"2015-03-01 06:17:55.000000000","message":"Hi Brian,\n\nThere are no config settings to enable this.\nOperator simply needs to send SIGHUP signal to API service to reload the config changes.","commit_id":"0021758739714c6eb6764abe4acb10017ef1dca4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3c4d08bae16668bcad44a0264d48e93ee276fde5","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Other deployer impact"},{"line_number":110,"context_line":"---------------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Need to document the impact of config changes for some params like workers,"},{"line_number":113,"context_line":"host, port etc."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_5f3afa98","line":111,"in_reply_to":"ba7be1f8_659f3a04","updated":"2015-03-02 03:42:30.000000000","message":"Thanks Abhishek.  This will be addressed when you clarify the text above.","commit_id":"0021758739714c6eb6764abe4acb10017ef1dca4"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"cb30e05c5c13751bd4a09953413b53b06f88ec9d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"An alternative may be to attempt to save and then restore long running tasks"},{"line_number":60,"context_line":"using taskflow. The process restart would then only need to deal with with"},{"line_number":61,"context_line":"short lived requests (e.g. API DB lookups) and then no user visible downtime"},{"line_number":62,"context_line":"is required for regular restarts"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba7be1f8_4decb8bb","line":60,"updated":"2015-03-03 18:39:38.000000000","message":"\"with with\" at the end of the line.","commit_id":"0fc9fcd623524189c36d608d30b621f4833e9b40"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0bdb75cf22cf2ece138cc74a62d260534785418e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"An alternative may be to attempt to save and then restore long running tasks"},{"line_number":60,"context_line":"using taskflow. The process restart would then only need to deal with with"},{"line_number":61,"context_line":"short lived requests (e.g. API DB lookups) and then no user visible downtime"},{"line_number":62,"context_line":"is required for regular restarts"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba7be1f8_eddbacea","line":60,"in_reply_to":"ba7be1f8_4decb8bb","updated":"2015-03-03 18:49:20.000000000","message":"Done","commit_id":"0fc9fcd623524189c36d608d30b621f4833e9b40"}]}