)]}'
{"specs/liberty/migrate-replicator-to-requests.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"17d0e0e82f57517a77befc288a8521a1e2db008f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"support deployments of Glance served only over HTTPS. In its current state,"},{"line_number":16,"context_line":"``glance-replicator`` uses ``httplib`` and thus does not properly verify"},{"line_number":17,"context_line":"HTTPS connections. This allows for various and very serious attacks to be"},{"line_number":18,"context_line":"performed while the user of ``glance-replicator`` attempts to communicate with"},{"line_number":19,"context_line":"Glance."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a41bdd9_d2745269","line":18,"updated":"2015-07-15 04:00:51.000000000","message":"Maybe just eliminate \"user of\"","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0e815226056780898342635bb345ab4e3ee1f2aa","unresolved":false,"context_lines":[{"line_number":15,"context_line":"support deployments of Glance served only over HTTPS. In its current state,"},{"line_number":16,"context_line":"``glance-replicator`` uses ``httplib`` and thus does not properly verify"},{"line_number":17,"context_line":"HTTPS connections. This allows for various and very serious attacks to be"},{"line_number":18,"context_line":"performed while the user of ``glance-replicator`` attempts to communicate with"},{"line_number":19,"context_line":"Glance."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba3cc151_b223ac57","line":18,"updated":"2015-07-01 21:28:54.000000000","message":"use of?","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"4e8cd528f8f24de53d4aa71d497e37a16621d912","unresolved":false,"context_lines":[{"line_number":15,"context_line":"support deployments of Glance served only over HTTPS. In its current state,"},{"line_number":16,"context_line":"``glance-replicator`` uses ``httplib`` and thus does not properly verify"},{"line_number":17,"context_line":"HTTPS connections. This allows for various and very serious attacks to be"},{"line_number":18,"context_line":"performed while the user of ``glance-replicator`` attempts to communicate with"},{"line_number":19,"context_line":"Glance."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_1c667829","line":18,"in_reply_to":"9a41bdd9_d2745269","updated":"2015-07-27 12:16:26.000000000","message":"+ 1 for removing \u0027the user of\u0027","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"4e8cd528f8f24de53d4aa71d497e37a16621d912","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Glance."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Many deployments currently support both HTTP and HTTPS connections to Glance\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_fc306c09","line":22,"updated":"2015-07-27 12:16:26.000000000","message":"Could you please replace the underlining \u003d\u003d\u003d\u003d\u003d\u003d with ~~~~~~ for the Heading 2 here and below in the patch?","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"7d84dcd59a010021638d63b69ef4ca791c70bf36","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Glance."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Many deployments currently support both HTTP and HTTPS connections to Glance\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_b1cc988b","line":22,"in_reply_to":"3a50d1a3_fc306c09","updated":"2015-07-30 08:46:17.000000000","message":"Please disregard this comment, \u003d\u003d\u003d markup for Heading2 is fine in specs.","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"4e8cd528f8f24de53d4aa71d497e37a16621d912","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This specification proposes that the code using ``httplib`` in"},{"line_number":45,"context_line":"``glance-replicator`` be rewritten to use ``requests``. ``requests`` supports"},{"line_number":46,"context_line":"automatic certificate verification on all HTTPS connections and allows users"},{"line_number":47,"context_line":"to provide custom certificate bundles for self-signed certificates."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_2242233f","line":45,"updated":"2015-07-27 12:16:26.000000000","message":"be rewritten -\u003e  is rewritten","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"b253bd09808ca609fd26fddbf810a9949e7d2f48","unresolved":false,"context_lines":[{"line_number":46,"context_line":"automatic certificate verification on all HTTPS connections and allows users"},{"line_number":47,"context_line":"to provide custom certificate bundles for self-signed certificates."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Given that an operator may choose to sign their own ceritificates for their"},{"line_number":50,"context_line":"deployment of Glance, this specification also proposes the addition of a"},{"line_number":51,"context_line":"command-line option to ``glance-replicator`` to allow the operator to specify"},{"line_number":52,"context_line":"a custom certificate bundle to use when verifying the certificate."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_fda5ee46","line":49,"updated":"2015-06-26 23:18:31.000000000","message":"nit: \"ceritificates\" should be replaced with \"certificates\"","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"b253bd09808ca609fd26fddbf810a9949e7d2f48","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"One alternative to ``requests`` that\u0027s already used in other OpenStack"},{"line_number":58,"context_line":"projects is ``httplib2``. This library provides a nearly identical API to"},{"line_number":59,"context_line":"``httplib`` and performs certificate verifcation. The library, however, is"},{"line_number":60,"context_line":"being actively replaced by many of these same projects by ``requests``."},{"line_number":61,"context_line":"Reducing the number of dependencies that an operator needs to install is also"},{"line_number":62,"context_line":"very favorable."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_5d6bbaf1","line":59,"updated":"2015-06-26 23:18:31.000000000","message":"nit: \"verifcation\" should be replaced with \"verification\"","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"4e8cd528f8f24de53d4aa71d497e37a16621d912","unresolved":false,"context_lines":[{"line_number":57,"context_line":"One alternative to ``requests`` that\u0027s already used in other OpenStack"},{"line_number":58,"context_line":"projects is ``httplib2``. This library provides a nearly identical API to"},{"line_number":59,"context_line":"``httplib`` and performs certificate verifcation. The library, however, is"},{"line_number":60,"context_line":"being actively replaced by many of these same projects by ``requests``."},{"line_number":61,"context_line":"Reducing the number of dependencies that an operator needs to install is also"},{"line_number":62,"context_line":"very favorable."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_426e4f97","line":60,"updated":"2015-07-27 12:16:26.000000000","message":"by many of these same projects -\u003e IN many of these same projects?","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"17d0e0e82f57517a77befc288a8521a1e2db008f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"``glance-replicator`` previously did not generate errors, this may be an"},{"line_number":95,"context_line":"unpleasant experience for the user. It is the position of the author of this"},{"line_number":96,"context_line":"specification that an option to insecurely connect to Glance is a poor choice"},{"line_number":97,"context_line":"since the errors will encourage the operators to properly configure Glance to"},{"line_number":98,"context_line":"be served over HTTPS."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a41bdd9_c5a22afc","line":97,"updated":"2015-07-15 04:00:51.000000000","message":"Suggestion: use a full stop after \u0027poor choice\u0027 and drop the \u0027since\u0027.  Then it will read \"... an option to insecurely connect to Glance is a poor choice. The errors will encourage operators to properly configure Glance ...\"","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"4e8cd528f8f24de53d4aa71d497e37a16621d912","unresolved":false,"context_lines":[{"line_number":94,"context_line":"``glance-replicator`` previously did not generate errors, this may be an"},{"line_number":95,"context_line":"unpleasant experience for the user. It is the position of the author of this"},{"line_number":96,"context_line":"specification that an option to insecurely connect to Glance is a poor choice"},{"line_number":97,"context_line":"since the errors will encourage the operators to properly configure Glance to"},{"line_number":98,"context_line":"be served over HTTPS."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_2255434f","line":97,"in_reply_to":"9a41bdd9_c5a22afc","updated":"2015-07-27 12:16:26.000000000","message":"+1. Currently the sentence seems too long.","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0e815226056780898342635bb345ab4e3ee1f2aa","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Other deployer impact"},{"line_number":106,"context_line":"---------------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Developer impact"},{"line_number":111,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba3cc151_52a82077","line":108,"updated":"2015-07-01 21:28:54.000000000","message":"Should  we mark https as a dependency of this feature?","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"4e8cd528f8f24de53d4aa71d497e37a16621d912","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  nikhil-komawar"},{"line_number":137,"context_line":"  kragniz"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Work Items"},{"line_number":140,"context_line":"----------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- Refactor ``glance-replicator`` to drop a some of its conventions surrounding"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_02e1279a","line":139,"updated":"2015-07-27 12:16:26.000000000","message":"Items -\u003e items (as we use sentence capitalization for headings in openstack.docs)","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"4e8cd528f8f24de53d4aa71d497e37a16621d912","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Work Items"},{"line_number":140,"context_line":"----------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- Refactor ``glance-replicator`` to drop a some of its conventions surrounding"},{"line_number":143,"context_line":"  ``httplib``"},{"line_number":144,"context_line":"- Replace ``httplib`` with ``requests``"},{"line_number":145,"context_line":"- Add option to specify a custom certificate bundle"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_e2fc3b40","line":142,"updated":"2015-07-27 12:16:26.000000000","message":"a some -\u003e some?","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"4e8cd528f8f24de53d4aa71d497e37a16621d912","unresolved":false,"context_lines":[{"line_number":160,"context_line":"to ensure that proper coverage is achieved."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Documentation Impact"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"``glance-replicator``\u0027s man page will need to be updated regarding the new"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_629fcb03","line":163,"updated":"2015-07-27 12:16:26.000000000","message":"Impact -\u003e impact","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"4e8cd528f8f24de53d4aa71d497e37a16621d912","unresolved":false,"context_lines":[{"line_number":163,"context_line":"Documentation Impact"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"``glance-replicator``\u0027s man page will need to be updated regarding the new"},{"line_number":167,"context_line":"configuration options. We should note the two current ways of setting a custom"},{"line_number":168,"context_line":"certificate:"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_d5e537a8","line":166,"updated":"2015-07-27 12:16:26.000000000","message":"man -\u003e main","commit_id":"a18d7f79620653af22c189072f72d6824e07774b"}]}