)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"658766e2d3d70c624905f5e67ae33ec3ddd6a6a1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance sorting API specification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec describes and precises new sorting standard for image"},{"line_number":10,"context_line":"output in Glance and defines the system behavior in different"},{"line_number":11,"context_line":"cases."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba7be1f8_12eccc8e","line":9,"updated":"2015-02-24 14:38:38.000000000","message":"Nit: I\u0027d leave out \"and precises\" part.\n\n\"This spec describes new sorting standard for image output ... \"\n\nis informative enough.","commit_id":"7a3d184dc33961e5af2f82a7c37af650ad3be1a1"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"e62a41212d7537243e34be70d18ec5e6fccb5c42","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance sorting API specification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec describes and precises new sorting standard for image"},{"line_number":10,"context_line":"output in Glance and defines the system behavior in different"},{"line_number":11,"context_line":"cases."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba7be1f8_4d95c985","line":9,"in_reply_to":"ba7be1f8_12eccc8e","updated":"2015-02-24 14:51:12.000000000","message":"Done","commit_id":"7a3d184dc33961e5af2f82a7c37af650ad3be1a1"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"00fe0f1c0d18bc4c157938f3942543ecd9835803","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-09 22:46:53 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance sorting API specification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec describes new sorting standard for image output"},{"line_number":10,"context_line":"in Glance and defines the system behavior in different cases."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9a80dd14_b77354b3","line":8,"updated":"2015-03-11 05:17:19.000000000","message":"Also, please mention that you\u0027re amending the existing api listing spec","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-09 22:46:53 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance sorting API specification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec describes new sorting standard for image output"},{"line_number":10,"context_line":"in Glance and defines the system behavior in different cases."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9a80dd14_e4feea04","line":8,"in_reply_to":"9a80dd14_b77354b3","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"}],"specs/api/v2/lists-image-api-v2.rst":[{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":41,"context_line":"**Sorting**"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The results of this operation can be ordered by using classic and new"},{"line_number":44,"context_line":"sorting syntax. Classic syntax uses multiple \u0027sort\\_key\u0027 and"},{"line_number":45,"context_line":"\u0027sort\\_dir\u0027 parameters and new one accepts a single \u0027sort\u0027 string with"},{"line_number":46,"context_line":"comma separated sort keys with optional sort direction after \u0027:\u0027."},{"line_number":47,"context_line":"Both syntax provide an ability to sort output with multiple keys and"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_643a31e8","line":44,"updated":"2015-02-26 18:13:19.000000000","message":"We speak about 2 syntaxes here, so I would add an ending \u0027es\u0027 to \u0027syntax\u0027 -\u003e \u0027syntaxes\u0027.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"**Sorting**"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The results of this operation can be ordered by using classic and new"},{"line_number":44,"context_line":"sorting syntax. Classic syntax uses multiple \u0027sort\\_key\u0027 and"},{"line_number":45,"context_line":"\u0027sort\\_dir\u0027 parameters and new one accepts a single \u0027sort\u0027 string with"},{"line_number":46,"context_line":"comma separated sort keys with optional sort direction after \u0027:\u0027."},{"line_number":47,"context_line":"Both syntax provide an ability to sort output with multiple keys and"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_2f3a5434","line":44,"in_reply_to":"ba7be1f8_643a31e8","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"sorting syntax. Classic syntax uses multiple \u0027sort\\_key\u0027 and"},{"line_number":45,"context_line":"\u0027sort\\_dir\u0027 parameters and new one accepts a single \u0027sort\u0027 string with"},{"line_number":46,"context_line":"comma separated sort keys with optional sort direction after \u0027:\u0027."},{"line_number":47,"context_line":"Both syntax provide an ability to sort output with multiple keys and"},{"line_number":48,"context_line":"directions, but with some differences."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The classic syntax takes a list of keys and either exactly the same"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_ae49d8b8","line":47,"updated":"2015-02-26 18:13:19.000000000","message":"\u0027syntax\u0027 -\u003e \u0027syntaxes\u0027 here as well I guess.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"sorting syntax. Classic syntax uses multiple \u0027sort\\_key\u0027 and"},{"line_number":45,"context_line":"\u0027sort\\_dir\u0027 parameters and new one accepts a single \u0027sort\u0027 string with"},{"line_number":46,"context_line":"comma separated sort keys with optional sort direction after \u0027:\u0027."},{"line_number":47,"context_line":"Both syntax provide an ability to sort output with multiple keys and"},{"line_number":48,"context_line":"directions, but with some differences."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The classic syntax takes a list of keys and either exactly the same"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_0f3f5026","line":47,"in_reply_to":"ba7be1f8_ae49d8b8","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\u0027sort\\_dir\u0027 parameters and new one accepts a single \u0027sort\u0027 string with"},{"line_number":46,"context_line":"comma separated sort keys with optional sort direction after \u0027:\u0027."},{"line_number":47,"context_line":"Both syntax provide an ability to sort output with multiple keys and"},{"line_number":48,"context_line":"directions, but with some differences."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The classic syntax takes a list of keys and either exactly the same"},{"line_number":51,"context_line":"number of directions for each key, or only one that specifies the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_6eda80e9","line":48,"updated":"2015-02-26 18:13:19.000000000","message":"A comma is not needed before \u0027but\u0027 unless it separates 2 independent clauses.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\u0027sort\\_dir\u0027 parameters and new one accepts a single \u0027sort\u0027 string with"},{"line_number":46,"context_line":"comma separated sort keys with optional sort direction after \u0027:\u0027."},{"line_number":47,"context_line":"Both syntax provide an ability to sort output with multiple keys and"},{"line_number":48,"context_line":"directions, but with some differences."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The classic syntax takes a list of keys and either exactly the same"},{"line_number":51,"context_line":"number of directions for each key, or only one that specifies the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_ef383c3f","line":48,"in_reply_to":"ba7be1f8_6eda80e9","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"The classic syntax takes a list of keys and either exactly the same"},{"line_number":51,"context_line":"number of directions for each key, or only one that specifies the"},{"line_number":52,"context_line":"default value for all keys."},{"line_number":53,"context_line":"The new syntax applies a default direction for all keys where it\u0027s"},{"line_number":54,"context_line":"missing."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The API uses the natural sorting of whatever image attribute is"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_eec3d0ea","line":53,"updated":"2015-02-26 18:13:19.000000000","message":"If the verb \u0027apply\u0027 means \u0027assign smth to smth\u0027 here, a preposition \u0027to\u0027 should be used instead of \u0027for\u0027 -\u003e \u0027applies ... to all keys\u0027.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"The classic syntax takes a list of keys and either exactly the same"},{"line_number":51,"context_line":"number of directions for each key, or only one that specifies the"},{"line_number":52,"context_line":"default value for all keys."},{"line_number":53,"context_line":"The new syntax applies a default direction for all keys where it\u0027s"},{"line_number":54,"context_line":"missing."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The API uses the natural sorting of whatever image attribute is"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_cf353847","line":53,"in_reply_to":"ba7be1f8_eec3d0ea","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"sort key: \u0027name\u0027, \u0027status\u0027, \u0027container\\_format\u0027, \u0027disk\\_format\u0027,"},{"line_number":59,"context_line":"\u0027size\u0027, \u0027id\u0027, \u0027created\\_at\u0027, \u0027updated\\_at\u0027. The sort dir parameter"},{"line_number":60,"context_line":"indicates in which direction to sort. Acceptable values are \u0027asc\u0027"},{"line_number":61,"context_line":"(ascending) and \u0027desc\u0027 (descending). Defaults values for sort key and"},{"line_number":62,"context_line":"sort direction are \u0027created\\_at\u0027 and \u0027desc\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Examples of sorting:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_6940ba34","line":61,"updated":"2015-02-26 18:13:19.000000000","message":"We shouldn\u0027t add an -s to an adjective when used with a noun in plural -\u003e \u0027Default values\u0027","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"sort key: \u0027name\u0027, \u0027status\u0027, \u0027container\\_format\u0027, \u0027disk\\_format\u0027,"},{"line_number":59,"context_line":"\u0027size\u0027, \u0027id\u0027, \u0027created\\_at\u0027, \u0027updated\\_at\u0027. The sort dir parameter"},{"line_number":60,"context_line":"indicates in which direction to sort. Acceptable values are \u0027asc\u0027"},{"line_number":61,"context_line":"(ascending) and \u0027desc\u0027 (descending). Defaults values for sort key and"},{"line_number":62,"context_line":"sort direction are \u0027created\\_at\u0027 and \u0027desc\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Examples of sorting:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_af2e44f8","line":61,"in_reply_to":"ba7be1f8_6940ba34","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":62,"context_line":"sort direction are \u0027created\\_at\u0027 and \u0027desc\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Examples of sorting:"},{"line_number":65,"context_line":"1. Classic syntax with specified default direction."},{"line_number":66,"context_line":"sort\\_key\u003dname\u0026sort\\_key\u003dstatus\u0026sort\\_dir\u003dasc"},{"line_number":67,"context_line":"Sort: by name with asc order, then by status with asc order."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_097bbe7b","line":65,"updated":"2015-02-26 18:13:19.000000000","message":"I would put the 1st item of the list after a blank line in .rst (to be displayed in a new line). Also, is it okay that 2 next lines below do not start from a new line in .html format?","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"sort direction are \u0027created\\_at\u0027 and \u0027desc\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Examples of sorting:"},{"line_number":65,"context_line":"1. Classic syntax with specified default direction."},{"line_number":66,"context_line":"sort\\_key\u003dname\u0026sort\\_key\u003dstatus\u0026sort\\_dir\u003dasc"},{"line_number":67,"context_line":"Sort: by name with asc order, then by status with asc order."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_8f2b40ea","line":65,"in_reply_to":"ba7be1f8_097bbe7b","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"sort\\_key\u003dname\u0026sort\\_key\u003dstatus"},{"line_number":71,"context_line":"Sort: by name with desc order, then by status with desc order."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"3. Classic syntax with missing key and specified default direction"},{"line_number":74,"context_line":"sort\\_dir\u003dasc"},{"line_number":75,"context_line":"Sort: by created_at with asc order."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_4956965d","line":73,"updated":"2015-02-26 18:13:19.000000000","message":"I guess, a dot is missing at the end of the phrase.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"sort\\_key\u003dname\u0026sort\\_key\u003dstatus"},{"line_number":71,"context_line":"Sort: by name with desc order, then by status with desc order."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"3. Classic syntax with missing key and specified default direction"},{"line_number":74,"context_line":"sort\\_dir\u003dasc"},{"line_number":75,"context_line":"Sort: by created_at with asc order."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_6fed2cb7","line":73,"in_reply_to":"ba7be1f8_4956965d","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"3ae2d8ac80b4afe25c4d737a48d69e9c238429ce","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"1. Classic syntax with specified default direction."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   sort\\_key\u003dname\u0026sort\\_key\u003dstatus\u0026sort\\_dir\u003dasc"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"   Sort: by name with asc order, then by status with asc order."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba7be1f8_c79155f2","line":68,"updated":"2015-03-04 01:02:48.000000000","message":"If you use\n\n    ::\n\n        sort_key\u003dname\u0026sort_key\u003dstatus\u0026sort_dir\u003dasc\n\nYou can drop the \\ here and below.","commit_id":"08d7f0697dc0cd01967243af2bb0a4b583e2f3c5"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"54b3f022cff6db3ba2a8bc178e688685a3cb0088","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"1. Classic syntax with specified default direction."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   sort\\_key\u003dname\u0026sort\\_key\u003dstatus\u0026sort\\_dir\u003dasc"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"   Sort: by name with asc order, then by status with asc order."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a80dd14_19e70942","line":68,"in_reply_to":"ba7be1f8_c79155f2","updated":"2015-03-04 13:38:23.000000000","message":"Done","commit_id":"08d7f0697dc0cd01967243af2bb0a4b583e2f3c5"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"e1204e31fa97c6599d3f0610e6cc39da43451779","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      sort_key\u003dname\u0026sort_key\u003dstatus\u0026sort_dir\u003dasc"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"      Sort: by name with asc order, then by status with asc order."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"2. Classic syntax with missing direction::"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a80dd14_5bab15d8","line":70,"updated":"2015-03-05 02:26:10.000000000","message":"Sorry. One more nit\n\nThe description of it should be outdented, e.g.,\n\n    1. Classic syntax with specified default direction::\n\n          sort_key\u003dname\u0026sort_key\u003dstatus\u0026sort_dir\u003dasc\n\n       Sort: by name with asc order, then by status with asc order.","commit_id":"40a08e6c4137302b00419039da75a261dea35bf7"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"404dbafd34ad22ee2a89e235474cacd44bbb6b1d","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"      sort_key\u003dname\u0026sort_key\u003dstatus\u0026sort_dir\u003dasc"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"      Sort: by name with asc order, then by status with asc order."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"2. Classic syntax with missing direction::"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a80dd14_294a89c5","line":70,"in_reply_to":"9a80dd14_5bab15d8","updated":"2015-03-05 11:49:28.000000000","message":"Okay, I got you. Now it\u0027s nearly perfect :)","commit_id":"40a08e6c4137302b00419039da75a261dea35bf7"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"7ef08ffa4c69a910817acf1a79d533bf4b0edf5e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"(ascending) and \u0027desc\u0027 (descending). Default values for sort key and"},{"line_number":62,"context_line":"sort direction are \u0027created\\_at\u0027 and \u0027desc\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Examples of sorting:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"1. Classic syntax with specified default direction::"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_4bfe506c","line":64,"updated":"2015-03-09 13:42:42.000000000","message":"In the examples below, could you put the \"new\" style first.  IMO, the preferred style should be listed first.","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ed979323066fe606d7f0ea8e3612cd1ae85c0784","unresolved":false,"context_lines":[{"line_number":61,"context_line":"(ascending) and \u0027desc\u0027 (descending). Default values for sort key and"},{"line_number":62,"context_line":"sort direction are \u0027created\\_at\u0027 and \u0027desc\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Examples of sorting:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"1. Classic syntax with specified default direction::"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_ba99c67a","line":64,"in_reply_to":"9a80dd14_4bfe506c","updated":"2015-03-09 19:46:19.000000000","message":"Done","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The results of this operation can be ordered by using classic and new"},{"line_number":44,"context_line":"sorting syntaxes. Classic syntax uses multiple \u0027sort\\_key\u0027 and"},{"line_number":45,"context_line":"\u0027sort\\_dir\u0027 parameters and new one accepts a single \u0027sort\u0027 string with"},{"line_number":46,"context_line":"comma separated sort keys with optional sort direction after \u0027:\u0027."},{"line_number":47,"context_line":"Both syntaxes provide an ability to sort output with multiple keys and"},{"line_number":48,"context_line":"directions but with some differences."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_af2a187c","line":45,"updated":"2015-03-11 11:24:38.000000000","message":"A comma is missing before \u0027and\u0027.","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The results of this operation can be ordered by using classic and new"},{"line_number":44,"context_line":"sorting syntaxes. Classic syntax uses multiple \u0027sort\\_key\u0027 and"},{"line_number":45,"context_line":"\u0027sort\\_dir\u0027 parameters and new one accepts a single \u0027sort\u0027 string with"},{"line_number":46,"context_line":"comma separated sort keys with optional sort direction after \u0027:\u0027."},{"line_number":47,"context_line":"Both syntaxes provide an ability to sort output with multiple keys and"},{"line_number":48,"context_line":"directions but with some differences."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_09d5d742","line":45,"in_reply_to":"9a80dd14_af2a187c","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"69288b10ccb633d7d2b2d4f6375c041e0c56cddc","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      sort_key\u003dname\u0026sort_dir\u003ddesc\u0026sort_key\u003dstatus\u0026sort_dir\u003dasc"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"   Sort: by name with asc order, then by status with asc order."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"#. Classic syntax with different number of keys and directions::"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a80dd14_645d9a48","line":107,"updated":"2015-03-11 13:26:14.000000000","message":"name should be sort by desc, right?","commit_id":"d81203c0774a16f7394c36cfcf2495db694dc273"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ed44e07b1874dfbba22fd35943d799769d5a9ea0","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      sort_key\u003dname\u0026sort_dir\u003ddesc\u0026sort_key\u003dstatus\u0026sort_dir\u003dasc"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"   Sort: by name with asc order, then by status with asc order."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"#. Classic syntax with different number of keys and directions::"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a80dd14_3ee2ca03","line":107,"in_reply_to":"9a80dd14_645d9a48","updated":"2015-03-11 14:00:58.000000000","message":"Done","commit_id":"d81203c0774a16f7394c36cfcf2495db694dc273"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"69288b10ccb633d7d2b2d4f6375c041e0c56cddc","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"#. Classic syntax with different number of keys and directions::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      sort_key\u003dname\u0026sort_dir\u003dasc\u0026sort_key\u003dstatus\u0026sort_dir\u003dascsort_key\u003did"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"   Will be an error."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a80dd14_84ac4e37","line":111,"updated":"2015-03-11 13:26:14.000000000","message":"IMO \u0027\u0026\u0027 need to be placed before sort_key.","commit_id":"d81203c0774a16f7394c36cfcf2495db694dc273"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ed44e07b1874dfbba22fd35943d799769d5a9ea0","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"#. Classic syntax with different number of keys and directions::"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      sort_key\u003dname\u0026sort_dir\u003dasc\u0026sort_key\u003dstatus\u0026sort_dir\u003dascsort_key\u003did"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"   Will be an error."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a80dd14_1edd0643","line":111,"in_reply_to":"9a80dd14_84ac4e37","updated":"2015-03-11 14:00:58.000000000","message":"Done","commit_id":"d81203c0774a16f7394c36cfcf2495db694dc273"}],"specs/kilo/new-sorting-syntax.rst":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"c1e474da41ebb875c931e8a7f1418f9bdf1a5d47","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"},{"line_number":23,"context_line":"directions; a multiple sort keys and one direction is currently supported"},{"line_number":24,"context_line":"and it is defaulted to descending sort order by the [\"created_at\"] key."},{"line_number":25,"context_line":"In order to retrieve data in any sort order and direction, the REST APIs"},{"line_number":26,"context_line":"need to accept multiple sort keys and directions."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_7243ea3e","line":24,"updated":"2015-02-19 20:38:29.000000000","message":"Why are there square brackets around created_at?","commit_id":"2c5710be0bffb9b2f5404c11ebd68329b68e4406"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"04800c2bd1a1863b8f7c1d4802de5d3faba616d3","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"},{"line_number":23,"context_line":"directions; a multiple sort keys and one direction is currently supported"},{"line_number":24,"context_line":"and it is defaulted to descending sort order by the [\"created_at\"] key."},{"line_number":25,"context_line":"In order to retrieve data in any sort order and direction, the REST APIs"},{"line_number":26,"context_line":"need to accept multiple sort keys and directions."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba7be1f8_67746c36","line":24,"in_reply_to":"da86d52c_7243ea3e","updated":"2015-02-24 14:21:55.000000000","message":"Done","commit_id":"2c5710be0bffb9b2f5404c11ebd68329b68e4406"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"ab543da2af4d6bf80ff66ce529703a482937a147","unresolved":false,"context_lines":[{"line_number":102,"context_line":"+-----------+-------+--------+------------------------------------------------+"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Currently, the images query supports the \u0027sort_key\u0027 and \u0027sort_dir\u0027 parameters;"},{"line_number":105,"context_line":"these will be deprecated. The API will raise a \"badRequest\" error response"},{"line_number":106,"context_line":"(code 400) if both the new \u0027sort\u0027 parameter and a deprecated \u0027sort_key\u0027 or"},{"line_number":107,"context_line":"\u0027sort_dir\u0027 parameter is specified."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_e35ab280","line":105,"updated":"2015-02-19 18:06:59.000000000","message":"s/badRequest/BadRequest","commit_id":"2c5710be0bffb9b2f5404c11ebd68329b68e4406"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"04800c2bd1a1863b8f7c1d4802de5d3faba616d3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"+-----------+-------+--------+------------------------------------------------+"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Currently, the images query supports the \u0027sort_key\u0027 and \u0027sort_dir\u0027 parameters;"},{"line_number":105,"context_line":"these will be deprecated. The API will raise a \"badRequest\" error response"},{"line_number":106,"context_line":"(code 400) if both the new \u0027sort\u0027 parameter and a deprecated \u0027sort_key\u0027 or"},{"line_number":107,"context_line":"\u0027sort_dir\u0027 parameter is specified."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba7be1f8_277ef419","line":105,"in_reply_to":"da86d52c_e35ab280","updated":"2015-02-24 14:21:55.000000000","message":"Done","commit_id":"2c5710be0bffb9b2f5404c11ebd68329b68e4406"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"ab543da2af4d6bf80ff66ce529703a482937a147","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Neither the API response format nor the return codes will be modified, only"},{"line_number":110,"context_line":"the order of the images that are returned."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"In the event that an invalid sort key is specified then a \"badRequest\" error"},{"line_number":113,"context_line":"response (code 400) will be returned with a message like \"Invalid input"},{"line_number":114,"context_line":"received: Invalid sort key\"."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_637962c4","line":112,"updated":"2015-02-19 18:06:59.000000000","message":"same thing here","commit_id":"2c5710be0bffb9b2f5404c11ebd68329b68e4406"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"04800c2bd1a1863b8f7c1d4802de5d3faba616d3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Neither the API response format nor the return codes will be modified, only"},{"line_number":110,"context_line":"the order of the images that are returned."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"In the event that an invalid sort key is specified then a \"badRequest\" error"},{"line_number":113,"context_line":"response (code 400) will be returned with a message like \"Invalid input"},{"line_number":114,"context_line":"received: Invalid sort key\"."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba7be1f8_07865013","line":112,"in_reply_to":"da86d52c_637962c4","updated":"2015-02-24 14:21:55.000000000","message":"Done","commit_id":"2c5710be0bffb9b2f5404c11ebd68329b68e4406"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"c1e474da41ebb875c931e8a7f1418f9bdf1a5d47","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* Update the existing API to retrieve the sort information and pass down to"},{"line_number":176,"context_line":"  the DB layer (https://review.openstack.org/#/c/148326/)"},{"line_number":177,"context_line":"* Extend API with new syntax to support multiple sorting keys and direrections"},{"line_number":178,"context_line":"  (https://review.openstack.org/#/c/148512/)"},{"line_number":179,"context_line":"* Update the python-glanceclient to accept and process multiple sort keys and"},{"line_number":180,"context_line":"  sort directions with classic and new sorting syntax"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_26c5b35b","line":177,"updated":"2015-02-19 20:38:29.000000000","message":"Nit: \"directions\" not \"direrections\"","commit_id":"2c5710be0bffb9b2f5404c11ebd68329b68e4406"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"04800c2bd1a1863b8f7c1d4802de5d3faba616d3","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* Update the existing API to retrieve the sort information and pass down to"},{"line_number":176,"context_line":"  the DB layer (https://review.openstack.org/#/c/148326/)"},{"line_number":177,"context_line":"* Extend API with new syntax to support multiple sorting keys and direrections"},{"line_number":178,"context_line":"  (https://review.openstack.org/#/c/148512/)"},{"line_number":179,"context_line":"* Update the python-glanceclient to accept and process multiple sort keys and"},{"line_number":180,"context_line":"  sort directions with classic and new sorting syntax"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba7be1f8_c78fd828","line":177,"in_reply_to":"da86d52c_26c5b35b","updated":"2015-02-24 14:21:55.000000000","message":"Done","commit_id":"2c5710be0bffb9b2f5404c11ebd68329b68e4406"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"c1e474da41ebb875c931e8a7f1418f9bdf1a5d47","unresolved":false,"context_lines":[{"line_number":222,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"API Working group sorting guidelines:"},{"line_number":225,"context_line":"https://github.com/openstack/api-wg/blob/master/guidelines/"},{"line_number":226,"context_line":"pagination_filter_sort.rst"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_66896b25","line":225,"updated":"2015-02-19 20:38:29.000000000","message":"In the document, can we put the URI on one line?","commit_id":"2c5710be0bffb9b2f5404c11ebd68329b68e4406"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"04800c2bd1a1863b8f7c1d4802de5d3faba616d3","unresolved":false,"context_lines":[{"line_number":222,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"API Working group sorting guidelines:"},{"line_number":225,"context_line":"https://github.com/openstack/api-wg/blob/master/guidelines/"},{"line_number":226,"context_line":"pagination_filter_sort.rst"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba7be1f8_a78ae418","line":225,"in_reply_to":"da86d52c_66896b25","updated":"2015-02-24 14:21:55.000000000","message":"Done","commit_id":"2c5710be0bffb9b2f5404c11ebd68329b68e4406"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"},{"line_number":23,"context_line":"directions; a multiple sort keys and one direction is currently supported"},{"line_number":24,"context_line":"and it is defaulted to descending sort order by the \"created_at\" key."},{"line_number":25,"context_line":"In order to retrieve data in any sort order and direction, the REST APIs"},{"line_number":26,"context_line":"need to accept multiple sort keys and directions."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_a46737b6","line":23,"updated":"2015-02-26 18:13:19.000000000","message":"I would not use the article \u0027a\u0027 here here because \u0027keys\u0027 are in plural. And if so, \u0027is\u0027 should be replaced with \u0027are\u0027.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"},{"line_number":23,"context_line":"directions; a multiple sort keys and one direction is currently supported"},{"line_number":24,"context_line":"and it is defaulted to descending sort order by the \"created_at\" key."},{"line_number":25,"context_line":"In order to retrieve data in any sort order and direction, the REST APIs"},{"line_number":26,"context_line":"need to accept multiple sort keys and directions."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_5efc9c3e","line":23,"in_reply_to":"ba7be1f8_a46737b6","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"},{"line_number":23,"context_line":"directions; a multiple sort keys and one direction is currently supported"},{"line_number":24,"context_line":"and it is defaulted to descending sort order by the \"created_at\" key."},{"line_number":25,"context_line":"In order to retrieve data in any sort order and direction, the REST APIs"},{"line_number":26,"context_line":"need to accept multiple sort keys and directions."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_24afc795","line":24,"updated":"2015-02-26 18:13:19.000000000","message":"I would add a comma before \u0027and\u0027, and I would replace \u0027is\u0027 with \u0027are\u0027, as we have 2 subjects in the 1st clause.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"},{"line_number":23,"context_line":"directions; a multiple sort keys and one direction is currently supported"},{"line_number":24,"context_line":"and it is defaulted to descending sort order by the \"created_at\" key."},{"line_number":25,"context_line":"In order to retrieve data in any sort order and direction, the REST APIs"},{"line_number":26,"context_line":"need to accept multiple sort keys and directions."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_19023e3e","line":24,"in_reply_to":"ba7be1f8_24afc795","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"},{"line_number":23,"context_line":"directions; a multiple sort keys and one direction is currently supported"},{"line_number":24,"context_line":"and it is defaulted to descending sort order by the \"created_at\" key."},{"line_number":25,"context_line":"In order to retrieve data in any sort order and direction, the REST APIs"},{"line_number":26,"context_line":"need to accept multiple sort keys and directions."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Case: A UI that displays a table with only the page of data that it"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_a472d70e","line":25,"updated":"2015-02-26 18:13:19.000000000","message":"I would use the verb \u0027retrieve\u0027 with a preposition \u0027from\u0027 instead of \u0027in\u0027.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"},{"line_number":23,"context_line":"directions; a multiple sort keys and one direction is currently supported"},{"line_number":24,"context_line":"and it is defaulted to descending sort order by the \"created_at\" key."},{"line_number":25,"context_line":"In order to retrieve data in any sort order and direction, the REST APIs"},{"line_number":26,"context_line":"need to accept multiple sort keys and directions."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Case: A UI that displays a table with only the page of data that it"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_54db9b1a","line":25,"in_reply_to":"ba7be1f8_a472d70e","updated":"2015-03-02 19:08:21.000000000","message":"I think \u0027in\u0027 here is right.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Case: A UI that displays a table with only the page of data that it"},{"line_number":29,"context_line":"has retrieved from the server. The items in this table need to be sorted"},{"line_number":30,"context_line":"by status first and by display name second. In order to retrieve data in"},{"line_number":31,"context_line":"this order, the APIs must accept multiple sort keys/directions."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_3f577f27","line":30,"updated":"2015-02-26 18:13:19.000000000","message":"The same: preposition \u0027from\u0027 is better than \u0027in\u0027 with \u0027retrieve\u0027.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Case: A UI that displays a table with only the page of data that it"},{"line_number":29,"context_line":"has retrieved from the server. The items in this table need to be sorted"},{"line_number":30,"context_line":"by status first and by display name second. In order to retrieve data in"},{"line_number":31,"context_line":"this order, the APIs must accept multiple sort keys/directions."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_9404337f","line":30,"in_reply_to":"ba7be1f8_3f577f27","updated":"2015-03-02 19:08:21.000000000","message":"ditto.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":46,"context_line":"``/images?sort\u003dstatus:asc,name:asc,created_at:desc``"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Note: The \"created_at\" and \"id\" sort keys are always appended at the end of"},{"line_number":49,"context_line":"the key list if they are not already specified on the request."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The database layer already supports multiple sort keys and directions. This"},{"line_number":52,"context_line":"blueprint will update the API layer to retrieve the sort information from"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_49538816","line":49,"updated":"2015-02-26 18:13:19.000000000","message":"I would use a preposition \u0027in\u0027 instead of \u0027on\u0027 here.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"``/images?sort\u003dstatus:asc,name:asc,created_at:desc``"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Note: The \"created_at\" and \"id\" sort keys are always appended at the end of"},{"line_number":49,"context_line":"the key list if they are not already specified on the request."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The database layer already supports multiple sort keys and directions. This"},{"line_number":52,"context_line":"blueprint will update the API layer to retrieve the sort information from"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_79e09a96","line":49,"in_reply_to":"ba7be1f8_49538816","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"* /v2/images/detail"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Note that the design described in this blueprint could be applied to other GET"},{"line_number":87,"context_line":"REST APIs but this blueprint is scoped to only those listed above. Once this"},{"line_number":88,"context_line":"design is finalized, then the same approach could be applied to other APIs."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The existing API documentation needs to be updated to include the following"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_24ecb929","line":87,"updated":"2015-02-26 18:13:19.000000000","message":"a comma is needed before \u0027but\u0027 when it connects 2 main clauses.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"* /v2/images/detail"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Note that the design described in this blueprint could be applied to other GET"},{"line_number":87,"context_line":"REST APIs but this blueprint is scoped to only those listed above. Once this"},{"line_number":88,"context_line":"design is finalized, then the same approach could be applied to other APIs."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The existing API documentation needs to be updated to include the following"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_39d622c4","line":87,"in_reply_to":"ba7be1f8_24ecb929","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"9e04b16114871cf3cbf0e142b61f1b8481416ebf","unresolved":false,"context_lines":[{"line_number":200,"context_line":"default sort keys (\"created_at\" and \"id\") are always appended to the user"},{"line_number":201,"context_line":"supplied keys (if the user did not already specify them)."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Testing should be done against multiple backend database types."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_a44189aa","line":203,"updated":"2015-02-26 18:13:19.000000000","message":"If the word \u0027back end\u0027 is an adjective, it should have a hyphen -\u003e \u0027back-end\u0027.","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"316a0acb28f60e910d6191ab0e31bda0f40b631c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"default sort keys (\"created_at\" and \"id\") are always appended to the user"},{"line_number":201,"context_line":"supplied keys (if the user did not already specify them)."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Testing should be done against multiple backend database types."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_79497ab6","line":203,"in_reply_to":"ba7be1f8_a44189aa","updated":"2015-03-02 19:08:21.000000000","message":"Done","commit_id":"63fa72a992c34791c06234005d7354f8cd035e4d"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"3ae2d8ac80b4afe25c4d737a48d69e9c238429ce","unresolved":false,"context_lines":[{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Multiple sort keys and directions could be passed using repeated \u0027sort_key\u0027"},{"line_number":66,"context_line":"and \u0027sort_dir\u0027 query parameters. For example:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"``/images?sort_key\u003dstatus\u0026sort_dir\u003dasc\u0026sort_key\u003dname\u0026sort_dir\u003dasc\u0026"},{"line_number":69,"context_line":"sort_key\u003dcreated_at\u0026sort_dir\u003ddesc``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba7be1f8_c756b529","line":66,"updated":"2015-03-04 01:02:48.000000000","message":"If you end this line with two :s and indent the next line you won\u0027t need the `` `` around the URL","commit_id":"08d7f0697dc0cd01967243af2bb0a4b583e2f3c5"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"54b3f022cff6db3ba2a8bc178e688685a3cb0088","unresolved":false,"context_lines":[{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Multiple sort keys and directions could be passed using repeated \u0027sort_key\u0027"},{"line_number":66,"context_line":"and \u0027sort_dir\u0027 query parameters. For example:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"``/images?sort_key\u003dstatus\u0026sort_dir\u003dasc\u0026sort_key\u003dname\u0026sort_dir\u003dasc\u0026"},{"line_number":69,"context_line":"sort_key\u003dcreated_at\u0026sort_dir\u003ddesc``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a80dd14_79d56542","line":66,"in_reply_to":"ba7be1f8_c756b529","updated":"2015-03-04 13:38:23.000000000","message":"Done","commit_id":"08d7f0697dc0cd01967243af2bb0a4b583e2f3c5"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"3ae2d8ac80b4afe25c4d737a48d69e9c238429ce","unresolved":false,"context_lines":[{"line_number":158,"context_line":"-----------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Primary assignee:"},{"line_number":161,"context_line":"  Mike Fedosin (mfedosin@mirantis.com)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Other contributors:"},{"line_number":164,"context_line":"  None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba7be1f8_87275dc9","line":161,"updated":"2015-03-04 01:02:48.000000000","message":"Shouldn\u0027t this be your launchpad id?","commit_id":"08d7f0697dc0cd01967243af2bb0a4b583e2f3c5"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"54b3f022cff6db3ba2a8bc178e688685a3cb0088","unresolved":false,"context_lines":[{"line_number":158,"context_line":"-----------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Primary assignee:"},{"line_number":161,"context_line":"  Mike Fedosin (mfedosin@mirantis.com)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Other contributors:"},{"line_number":164,"context_line":"  None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a80dd14_b9cfddaf","line":161,"in_reply_to":"ba7be1f8_87275dc9","updated":"2015-03-04 13:38:23.000000000","message":"Done","commit_id":"08d7f0697dc0cd01967243af2bb0a4b583e2f3c5"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"3ae2d8ac80b4afe25c4d737a48d69e9c238429ce","unresolved":false,"context_lines":[{"line_number":201,"context_line":"default sort keys (\"created_at\" and \"id\") are always appended to the user"},{"line_number":202,"context_line":"supplied keys (if the user did not already specify them)."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Testing should be done against multiple back-end database types."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba7be1f8_c704f519","line":204,"updated":"2015-03-04 01:02:48.000000000","message":"Is this part necessary? Most any database should support this with the likely exception of sqlite. What benefit do we get in testing the fact that a database supports sorting on a column in a specified direction?","commit_id":"08d7f0697dc0cd01967243af2bb0a4b583e2f3c5"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"54b3f022cff6db3ba2a8bc178e688685a3cb0088","unresolved":false,"context_lines":[{"line_number":201,"context_line":"default sort keys (\"created_at\" and \"id\") are always appended to the user"},{"line_number":202,"context_line":"supplied keys (if the user did not already specify them)."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Testing should be done against multiple back-end database types."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a80dd14_793c8594","line":204,"in_reply_to":"ba7be1f8_c704f519","updated":"2015-03-04 13:38:23.000000000","message":"Done","commit_id":"08d7f0697dc0cd01967243af2bb0a4b583e2f3c5"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"7ef08ffa4c69a910817acf1a79d533bf4b0edf5e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"},{"line_number":23,"context_line":"directions; multiple sort keys and one direction are currently"},{"line_number":24,"context_line":"supported, and they\u0027re defaulted to descending sort order by the"},{"line_number":25,"context_line":"\"created_at\" key."},{"line_number":26,"context_line":"In order to retrieve data in any sort order and direction, the REST"},{"line_number":27,"context_line":"APIs need to accept multiple sort keys and directions."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_2b511c36","line":25,"updated":"2015-03-09 13:42:42.000000000","message":"Space between paragraphs?","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ed979323066fe606d7f0ea8e3612cd1ae85c0784","unresolved":false,"context_lines":[{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"},{"line_number":23,"context_line":"directions; multiple sort keys and one direction are currently"},{"line_number":24,"context_line":"supported, and they\u0027re defaulted to descending sort order by the"},{"line_number":25,"context_line":"\"created_at\" key."},{"line_number":26,"context_line":"In order to retrieve data in any sort order and direction, the REST"},{"line_number":27,"context_line":"APIs need to accept multiple sort keys and directions."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_e034764b","line":25,"in_reply_to":"9a80dd14_2b511c36","updated":"2015-03-09 19:46:19.000000000","message":"Done","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"7ef08ffa4c69a910817acf1a79d533bf4b0edf5e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  sort_key\u003dcreated_at\u0026sort_dir\u003ddesc"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"However, this is not aligned with the API sorting guidelines, but anyway"},{"line_number":73,"context_line":"should be created."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Data model impact"},{"line_number":76,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_8b28489b","line":73,"updated":"2015-03-09 13:42:42.000000000","message":"What do you mean \"should be created\"?  Do you know that this should also be supported?","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ed979323066fe606d7f0ea8e3612cd1ae85c0784","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  sort_key\u003dcreated_at\u0026sort_dir\u003ddesc"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"However, this is not aligned with the API sorting guidelines, but anyway"},{"line_number":73,"context_line":"should be created."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Data model impact"},{"line_number":76,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_8071fa0d","line":73,"in_reply_to":"9a80dd14_8b28489b","updated":"2015-03-09 19:46:19.000000000","message":"I think this phrase should be clarified a little bit... Please, see my next PS.","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"7ef08ffa4c69a910817acf1a79d533bf4b0edf5e","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"In the event that an invalid sort key is specified then a \"BadRequest\" error"},{"line_number":115,"context_line":"response (code 400) will be returned with a message like \"Invalid input"},{"line_number":116,"context_line":"received: Invalid sort key\"."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Security impact"},{"line_number":119,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_eb00e403","line":116,"updated":"2015-03-09 13:42:42.000000000","message":"What about an invalid sort direction?","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ed979323066fe606d7f0ea8e3612cd1ae85c0784","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"In the event that an invalid sort key is specified then a \"BadRequest\" error"},{"line_number":115,"context_line":"response (code 400) will be returned with a message like \"Invalid input"},{"line_number":116,"context_line":"received: Invalid sort key\"."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Security impact"},{"line_number":119,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_a02efef8","line":116,"in_reply_to":"9a80dd14_eb00e403","updated":"2015-03-09 19:46:19.000000000","message":"Done","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"7ef08ffa4c69a910817acf1a79d533bf4b0edf5e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"The python-glanceclient should be updated to accept sort keys and"},{"line_number":132,"context_line":"sort directions, using the \u0027sort\u0027 parameter being proposed in the"},{"line_number":133,"context_line":"cross-project spec:"},{"line_number":134,"context_line":"https://review.openstack.org/#/c/145544/"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance Impact"},{"line_number":137,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_fe77c09d","line":134,"updated":"2015-03-09 13:42:42.000000000","message":"This has now merged, please reference it here:\n\nhttp://specs.openstack.org/openstack/openstack-specs/specs/cli-sorting-args.html","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ed979323066fe606d7f0ea8e3612cd1ae85c0784","unresolved":false,"context_lines":[{"line_number":131,"context_line":"The python-glanceclient should be updated to accept sort keys and"},{"line_number":132,"context_line":"sort directions, using the \u0027sort\u0027 parameter being proposed in the"},{"line_number":133,"context_line":"cross-project spec:"},{"line_number":134,"context_line":"https://review.openstack.org/#/c/145544/"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance Impact"},{"line_number":137,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_60f16694","line":134,"in_reply_to":"9a80dd14_fe77c09d","updated":"2015-03-09 19:46:19.000000000","message":"Done","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"7ef08ffa4c69a910817acf1a79d533bf4b0edf5e","unresolved":false,"context_lines":[{"line_number":192,"context_line":"* Related (but independent) change being proposed in nova:"},{"line_number":193,"context_line":"  https://blueprints.launchpad.net/nova/+spec/nova-pagination"},{"line_number":194,"context_line":"* CLI Sorting Argument Guidelines cross project spec:"},{"line_number":195,"context_line":"  https://review.openstack.org/#/c/145544/"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_3e7cf871","line":195,"updated":"2015-03-09 13:42:42.000000000","message":"Again, please update the reference here.","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ed979323066fe606d7f0ea8e3612cd1ae85c0784","unresolved":false,"context_lines":[{"line_number":192,"context_line":"* Related (but independent) change being proposed in nova:"},{"line_number":193,"context_line":"  https://blueprints.launchpad.net/nova/+spec/nova-pagination"},{"line_number":194,"context_line":"* CLI Sorting Argument Guidelines cross project spec:"},{"line_number":195,"context_line":"  https://review.openstack.org/#/c/145544/"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_40f62290","line":195,"in_reply_to":"9a80dd14_3e7cf871","updated":"2015-03-09 19:46:19.000000000","message":"Done","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"7ef08ffa4c69a910817acf1a79d533bf4b0edf5e","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  sort key list"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"The documentation could also note that query performance will be affected by"},{"line_number":219,"context_line":"the choice of the sort key, noting which keys are indexed."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_deb83c13","line":219,"updated":"2015-03-09 13:42:42.000000000","message":"This seems to contradict the \"other deployer impact\" section.","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ed979323066fe606d7f0ea8e3612cd1ae85c0784","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  sort key list"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"The documentation could also note that query performance will be affected by"},{"line_number":219,"context_line":"the choice of the sort key, noting which keys are indexed."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a80dd14_20fbee79","line":219,"in_reply_to":"9a80dd14_deb83c13","updated":"2015-03-09 19:46:19.000000000","message":"Done","commit_id":"2982530b52916e2d9f80b2909b746b610fb08e99"}],"specs/kilo/sorting-enhancements.rst":[{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Glance Sorting Enhancements"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_221c7f13","line":7,"updated":"2015-03-11 11:24:38.000000000","message":"There are excessive \u0027\u003d\u0027s above and below the heading, they should end on the last letter of sentence.\nAlso, only the 1st word of heading should be capitalized.","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Glance Sorting Enhancements"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_3edd6f43","line":7,"in_reply_to":"9a80dd14_221c7f13","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"multiple sort keys and sort directions can be supplied on the request."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_e22a672b","line":19,"updated":"2015-03-11 11:24:38.000000000","message":"If we want to use Heading 2 here, then tildes should be used as markup (instead of equals signs).","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":16,"context_line":"multiple sort keys and sort directions can be supplied on the request."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"There is no support for retrieving image data based on multiple sort"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_be195f24","line":19,"in_reply_to":"9a80dd14_e22a672b","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The /images and /images/detail APIs will align with the API working group"},{"line_number":40,"context_line":"guidelines [1]_ for sorting and support the following parameter on the"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_021f7b0a","line":37,"updated":"2015-03-11 11:24:38.000000000","message":"Heading 2 markup?","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The /images and /images/detail APIs will align with the API working group"},{"line_number":40,"context_line":"guidelines [1]_ for sorting and support the following parameter on the"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_5e2b0330","line":37,"in_reply_to":"9a80dd14_021f7b0a","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* sort: Comma-separated list of sort keys, each key is optionally appended"},{"line_number":44,"context_line":"  with \u003c:dir\u003e, where \u0027dir\u0027 is the direction for the corresponding sort key"},{"line_number":45,"context_line":"  (supported values are \u0027asc\u0027 for ascending and \u0027desc\u0027 for descending)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"For example::"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_0595c587","line":45,"updated":"2015-03-11 11:24:38.000000000","message":"I would put a dot at the end of phrase.","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* sort: Comma-separated list of sort keys, each key is optionally appended"},{"line_number":44,"context_line":"  with \u003c:dir\u003e, where \u0027dir\u0027 is the direction for the corresponding sort key"},{"line_number":45,"context_line":"  (supported values are \u0027asc\u0027 for ascending and \u0027desc\u0027 for descending)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"For example::"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_7e1fe709","line":45,"in_reply_to":"9a80dd14_0595c587","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"the API request and pass that information down to the database layer."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"All sorting is handled in the glance.db.sqlalchemy.api._paginate_query"},{"line_number":59,"context_line":"function.  This function accepts an ORM model class as an argument and the"},{"line_number":60,"context_line":"only valid sort keys are attributes on the given model class.  Therefore,"},{"line_number":61,"context_line":"the valid sort keys are: \u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"},{"line_number":62,"context_line":"\u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_e5cef1b3","line":59,"updated":"2015-03-11 11:24:38.000000000","message":"Too much spaces after dot.","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":56,"context_line":"the API request and pass that information down to the database layer."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"All sorting is handled in the glance.db.sqlalchemy.api._paginate_query"},{"line_number":59,"context_line":"function.  This function accepts an ORM model class as an argument and the"},{"line_number":60,"context_line":"only valid sort keys are attributes on the given model class.  Therefore,"},{"line_number":61,"context_line":"the valid sort keys are: \u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"},{"line_number":62,"context_line":"\u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_be023fb2","line":59,"in_reply_to":"9a80dd14_e5cef1b3","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"All sorting is handled in the glance.db.sqlalchemy.api._paginate_query"},{"line_number":59,"context_line":"function.  This function accepts an ORM model class as an argument and the"},{"line_number":60,"context_line":"only valid sort keys are attributes on the given model class.  Therefore,"},{"line_number":61,"context_line":"the valid sort keys are: \u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"},{"line_number":62,"context_line":"\u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_a53b199b","line":60,"updated":"2015-03-11 11:24:38.000000000","message":"Too much spaces after dot.","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"All sorting is handled in the glance.db.sqlalchemy.api._paginate_query"},{"line_number":59,"context_line":"function.  This function accepts an ORM model class as an argument and the"},{"line_number":60,"context_line":"only valid sort keys are attributes on the given model class.  Therefore,"},{"line_number":61,"context_line":"the valid sort keys are: \u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"},{"line_number":62,"context_line":"\u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_9ef57bcd","line":60,"in_reply_to":"9a80dd14_a53b199b","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  /images?sort_key\u003dstatus\u0026sort_dir\u003dasc\u0026sort_key\u003dname\u0026sort_dir\u003dasc\u0026"},{"line_number":71,"context_line":"  sort_key\u003dcreated_at\u0026sort_dir\u003ddesc"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"To provide users the ability to use the classic familiar syntax and to ensure"},{"line_number":74,"context_line":"a smoother transition to the new syntax this option should be implemented too,"},{"line_number":75,"context_line":"along with the other one."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_91e81318","line":73,"updated":"2015-03-11 11:24:38.000000000","message":"\u0027To provide users WITH the...\u0027","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  /images?sort_key\u003dstatus\u0026sort_dir\u003dasc\u0026sort_key\u003dname\u0026sort_dir\u003dasc\u0026"},{"line_number":71,"context_line":"  sort_key\u003dcreated_at\u0026sort_dir\u003ddesc"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"To provide users the ability to use the classic familiar syntax and to ensure"},{"line_number":74,"context_line":"a smoother transition to the new syntax this option should be implemented too,"},{"line_number":75,"context_line":"along with the other one."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_3e580ffa","line":73,"in_reply_to":"9a80dd14_91e81318","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  sort_key\u003dcreated_at\u0026sort_dir\u003ddesc"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"To provide users the ability to use the classic familiar syntax and to ensure"},{"line_number":74,"context_line":"a smoother transition to the new syntax this option should be implemented too,"},{"line_number":75,"context_line":"along with the other one."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_a5c079e1","line":74,"updated":"2015-03-11 11:24:38.000000000","message":"\u0027to the new syntax this option\u0027 -\u003e \u0027to the new one, classic syntax\u0027.\n\nAnd I would replace \u0027too\u0027 with \u0027also\u0027. A new variant: \u0027...transition to the new one, the classic option should also be implemented, along with the new syntax.","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  sort_key\u003dcreated_at\u0026sort_dir\u003ddesc"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"To provide users the ability to use the classic familiar syntax and to ensure"},{"line_number":74,"context_line":"a smoother transition to the new syntax this option should be implemented too,"},{"line_number":75,"context_line":"along with the other one."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_fe5d97ed","line":74,"in_reply_to":"9a80dd14_a5c079e1","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"To provide users the ability to use the classic familiar syntax and to ensure"},{"line_number":74,"context_line":"a smoother transition to the new syntax this option should be implemented too,"},{"line_number":75,"context_line":"along with the other one."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Data model impact"},{"line_number":78,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_65a68155","line":75,"updated":"2015-03-11 11:24:38.000000000","message":"\u0027other\u0027 -\u003e \u0027new\u0027","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"To provide users the ability to use the classic familiar syntax and to ensure"},{"line_number":74,"context_line":"a smoother transition to the new syntax this option should be implemented too,"},{"line_number":75,"context_line":"along with the other one."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Data model impact"},{"line_number":78,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_3ea56f04","line":75,"in_reply_to":"9a80dd14_65a68155","updated":"2015-03-11 13:04:58.000000000","message":"I removed \"along with the other one\" part, it\u0027s obvious.","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"new Request Parameters:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"+-----------+-------+--------+------------------------------------------------+"},{"line_number":98,"context_line":"| Parameter | Style | Type   | Description                                    |"},{"line_number":99,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":100,"context_line":"| sort      | query | string | Comma-separated list of sort keys and optional |"},{"line_number":101,"context_line":"|           |       |        | sort directions in the form of key\u003c:dir\u003e,      |"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_bb64164a","line":98,"updated":"2015-03-11 11:24:38.000000000","message":"Is it okay that the table doesn\u0027t contain vertical lines (in .html)?","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":95,"context_line":"new Request Parameters:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"+-----------+-------+--------+------------------------------------------------+"},{"line_number":98,"context_line":"| Parameter | Style | Type   | Description                                    |"},{"line_number":99,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":100,"context_line":"| sort      | query | string | Comma-separated list of sort keys and optional |"},{"line_number":101,"context_line":"|           |       |        | sort directions in the form of key\u003c:dir\u003e,      |"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_69957387","line":98,"in_reply_to":"9a80dd14_bb64164a","updated":"2015-03-11 13:04:58.000000000","message":"it\u0027s okay :)","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Neither the API response format nor the return codes will be modified, only"},{"line_number":114,"context_line":"the order of the images that are returned."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"In the event that an invalid sort key or sort direction is specified then a"},{"line_number":117,"context_line":"\"BadRequest\" error response (code 400) will be returned with a message like"},{"line_number":118,"context_line":"\"Invalid input received: Invalid sort key\" or \"Invalid input received: Invalid"},{"line_number":119,"context_line":"sort dir\" respectively."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_91fe5304","line":116,"updated":"2015-03-11 11:24:38.000000000","message":"A comma before \u0027then\u0027, please.","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Neither the API response format nor the return codes will be modified, only"},{"line_number":114,"context_line":"the order of the images that are returned."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"In the event that an invalid sort key or sort direction is specified then a"},{"line_number":117,"context_line":"\"BadRequest\" error response (code 400) will be returned with a message like"},{"line_number":118,"context_line":"\"Invalid input received: Invalid sort key\" or \"Invalid input received: Invalid"},{"line_number":119,"context_line":"sort dir\" respectively."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_7e67e7ea","line":116,"in_reply_to":"9a80dd14_91fe5304","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Implementation"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Assignee(s)"},{"line_number":161,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_51613bd2","line":158,"updated":"2015-03-11 11:24:38.000000000","message":"Heading 2 with ~~~ is required here?","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Implementation"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Assignee(s)"},{"line_number":161,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_1e798b93","line":158,"in_reply_to":"9a80dd14_51613bd2","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"475cda8318e9d8532e8415f9d636befed426aa7a","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Other contributors:"},{"line_number":167,"context_line":"  None"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Work Items"},{"line_number":170,"context_line":"----------"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_b74c3478","line":168,"updated":"2015-03-11 05:16:16.000000000","message":"Reviewers?","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Other contributors:"},{"line_number":167,"context_line":"  None"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Work Items"},{"line_number":170,"context_line":"----------"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_3e356f46","line":168,"in_reply_to":"9a80dd14_b74c3478","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":188,"context_line":"* Implement the full test coverage for the new changes"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Dependencies"},{"line_number":192,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"* CLI Sorting Argument Guidelines cross project spec [2]_;"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_d181abfc","line":191,"updated":"2015-03-11 11:24:38.000000000","message":"Tilde markup for heading 2?","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":188,"context_line":"* Implement the full test coverage for the new changes"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Dependencies"},{"line_number":192,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"* CLI Sorting Argument Guidelines cross project spec [2]_;"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_de47f349","line":191,"in_reply_to":"9a80dd14_d181abfc","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":196,"context_line":"* Related (but independent) change being proposed in nova [3]_."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Testing"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Both unit and Tempest tests need to be created to ensure that the data is"},{"line_number":202,"context_line":"retrieved in the specified sort order. Tests should also verify that the"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_3178472b","line":199,"updated":"2015-03-11 11:24:38.000000000","message":"Tilde markup?","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":196,"context_line":"* Related (but independent) change being proposed in nova [3]_."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Testing"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Both unit and Tempest tests need to be created to ensure that the data is"},{"line_number":202,"context_line":"retrieved in the specified sort order. Tests should also verify that the"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_7e40c735","line":199,"in_reply_to":"9a80dd14_3178472b","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Documentation Impact"},{"line_number":208,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"The /images and /images/detail API documentation will need to be updated"},{"line_number":211,"context_line":"to:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_d198cb6c","line":208,"updated":"2015-03-11 11:24:38.000000000","message":"Tilde markup?","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Documentation Impact"},{"line_number":208,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"The /images and /images/detail API documentation will need to be updated"},{"line_number":211,"context_line":"to:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_5e5ce325","line":208,"in_reply_to":"9a80dd14_d198cb6c","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":210,"context_line":"The /images and /images/detail API documentation will need to be updated"},{"line_number":211,"context_line":"to:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"- Reflect the new sorting parameters and explain that these parameters will"},{"line_number":214,"context_line":"  affect the order in which the data is returned."},{"line_number":215,"context_line":"- Explain how the default sort keys will always be added at the end of the"},{"line_number":216,"context_line":"  sort key list"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_31cda75e","line":213,"updated":"2015-03-11 11:24:38.000000000","message":"Reflect -\u003e reflect\nExplain -\u003e explain (line 215)","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":210,"context_line":"The /images and /images/detail API documentation will need to be updated"},{"line_number":211,"context_line":"to:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"- Reflect the new sorting parameters and explain that these parameters will"},{"line_number":214,"context_line":"  affect the order in which the data is returned."},{"line_number":215,"context_line":"- Explain how the default sort keys will always be added at the end of the"},{"line_number":216,"context_line":"  sort key list"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_fea037a7","line":213,"in_reply_to":"9a80dd14_31cda75e","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":213,"context_line":"- Reflect the new sorting parameters and explain that these parameters will"},{"line_number":214,"context_line":"  affect the order in which the data is returned."},{"line_number":215,"context_line":"- Explain how the default sort keys will always be added at the end of the"},{"line_number":216,"context_line":"  sort key list"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_912ad3e5","line":216,"updated":"2015-03-11 11:24:38.000000000","message":"A dot is missing after \u0027list\u0027.","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":213,"context_line":"- Reflect the new sorting parameters and explain that these parameters will"},{"line_number":214,"context_line":"  affect the order in which the data is returned."},{"line_number":215,"context_line":"- Explain how the default sort keys will always be added at the end of the"},{"line_number":216,"context_line":"  sort key list"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_3b12e162","line":216,"in_reply_to":"9a80dd14_912ad3e5","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29e78f3c0eb8378aad533700f485ad17989d91f8","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"References"},{"line_number":220,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":".. [1]"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_113ee329","line":220,"updated":"2015-03-11 11:24:38.000000000","message":"Tilde markup?","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"891d192afea5133efc8f6848f892651e3ad78406","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"References"},{"line_number":220,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":".. [1]"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a80dd14_fb176952","line":220,"in_reply_to":"9a80dd14_113ee329","updated":"2015-03-11 13:04:58.000000000","message":"Done","commit_id":"b1443b2612bd5a5422006bb6c7acf208c3684b09"}]}