)]}'
{"specs/kilo/metadefs-upgrade-by-json-file.rst":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"168e572665d4ea4908b0c856895b2c90ac527732","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"   If the Namespace is not found, merge_metadefs should:"},{"line_number":66,"context_line":"   report an error?"},{"line_number":67,"context_line":"   add the new Namespace?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_5a5df3eb","line":67,"updated":"2015-02-27 02:55:48.000000000","message":"I personally like to see adding the new namespace, so I think change \u0027db_load_metadefs\u0027 seems like a good idea, check my follow comment pls.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f7ad69bb3a202c7dcbb95cdda3dc83580078e62a","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"   If the Namespace is not found, merge_metadefs should:"},{"line_number":66,"context_line":"   report an error?"},{"line_number":67,"context_line":"   add the new Namespace?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_e05c384f","line":67,"in_reply_to":"ba7be1f8_5a5df3eb","updated":"2015-02-27 04:33:59.000000000","message":"I think Zhi Yan is right.  It should add.  The case of \"don\u0027t merge this unless it already exists\" sounds like a different flag all together that could be used in conjunction with the other flags.  Something like --only-if-exists\n\nSeems like a corner case, but if I speculate, this might be the corner case:\n\nNew metadata definitions properties are provided and I\u0027ve already deleted some namespaces.  I don\u0027t want them to show back up.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"dcda770250f24c21b5fa453f5f4b2ae1f818ddc0","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"   If the Namespace is not found, merge_metadefs should:"},{"line_number":66,"context_line":"   report an error?"},{"line_number":67,"context_line":"   add the new Namespace?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_79b9b3ca","line":67,"in_reply_to":"ba7be1f8_e05c384f","updated":"2015-02-28 01:28:28.000000000","message":"I\u0027ve adjusted the comments to reflect that the Namespace will be added.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"168e572665d4ea4908b0c856895b2c90ac527732","unresolved":false,"context_lines":[{"line_number":65,"context_line":"   If the Namespace is not found, merge_metadefs should:"},{"line_number":66,"context_line":"   report an error?"},{"line_number":67,"context_line":"   add the new Namespace?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":"1. Could overload the glance-manage db load_metadefs command."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_fabf87fa","line":68,"updated":"2015-02-27 02:55:48.000000000","message":"May I know what\u0027s the result/output for this command? Did you think there\u0027s a report, e.g. to tell operator how many namespace/properties/objects are remained/modified (list them out?)","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"dcda770250f24c21b5fa453f5f4b2ae1f818ddc0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"   If the Namespace is not found, merge_metadefs should:"},{"line_number":66,"context_line":"   report an error?"},{"line_number":67,"context_line":"   add the new Namespace?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":"1. Could overload the glance-manage db load_metadefs command."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_d9c9bf5b","line":68,"in_reply_to":"ba7be1f8_c048148a","updated":"2015-02-28 01:28:28.000000000","message":"I\u0027ve included a --dry-run option. I think more detail will be needed for Pawel to implement.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f7ad69bb3a202c7dcbb95cdda3dc83580078e62a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"   If the Namespace is not found, merge_metadefs should:"},{"line_number":66,"context_line":"   report an error?"},{"line_number":67,"context_line":"   add the new Namespace?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":"1. Could overload the glance-manage db load_metadefs command."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_c048148a","line":68,"in_reply_to":"ba7be1f8_fabf87fa","updated":"2015-02-27 04:33:59.000000000","message":"This is also a good idea.  In fact, would be even better if this was used in conjunction with --dry-run.  So you could see what would happen.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"168e572665d4ea4908b0c856895b2c90ac527732","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":"1. Could overload the glance-manage db load_metadefs command."},{"line_number":72,"context_line":"   We could keep the --path choice while adding the --file JSON-file"},{"line_number":73,"context_line":"   option and the merge options listed above."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_da11e354","line":71,"updated":"2015-02-27 02:55:48.000000000","message":"I trend to like this idea, to give a new optional argument to db_load_metadefs command, like \u0027--merge\u0027, it will has three valid options as above mentioned - \u0027overwrite\u0027, \u0027remain-existing\u0027, \u0027update-existing\u0027. I think this way is more succinct.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"168e572665d4ea4908b0c856895b2c90ac527732","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":"1. Could overload the glance-manage db load_metadefs command."},{"line_number":72,"context_line":"   We could keep the --path choice while adding the --file JSON-file"},{"line_number":73,"context_line":"   option and the merge options listed above."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"2. The --prefer-new option tag is of debatable worth as it is only different"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_3ab59f31","line":72,"updated":"2015-02-27 02:55:48.000000000","message":"I\u0027m thinking if we can support full file path on --path option, if operator gives the option a full file path of a json file instead of a directory (folder-with-JSON-files) , we will don\u0027t need to add a --file option, IMHO it\u0027s confused and duplicated from operator\u0027s perspective a little bit. If operator didn\u0027t provide a full-file-path on --patch argument, we will upgrade all. Thoughts?","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"dcda770250f24c21b5fa453f5f4b2ae1f818ddc0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":"1. Could overload the glance-manage db load_metadefs command."},{"line_number":72,"context_line":"   We could keep the --path choice while adding the --file JSON-file"},{"line_number":73,"context_line":"   option and the merge options listed above."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"2. The --prefer-new option tag is of debatable worth as it is only different"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_7907f381","line":72,"in_reply_to":"ba7be1f8_00086c2c","updated":"2015-02-28 01:28:28.000000000","message":"I\u0027ve adjusted the comments to show the --path option with the new modification that it could be a full file as well.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f7ad69bb3a202c7dcbb95cdda3dc83580078e62a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":"1. Could overload the glance-manage db load_metadefs command."},{"line_number":72,"context_line":"   We could keep the --path choice while adding the --file JSON-file"},{"line_number":73,"context_line":"   option and the merge options listed above."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"2. The --prefer-new option tag is of debatable worth as it is only different"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_00086c2c","line":72,"in_reply_to":"ba7be1f8_3ab59f31","updated":"2015-02-27 04:33:59.000000000","message":"If I copy a file I can either specify full path or just directory, so single option is better and is really only a tiny bit of code to make determination.  The ONLY downside to a single option is that it is easier to accidentally do a whole directory than a single file.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f7ad69bb3a202c7dcbb95cdda3dc83580078e62a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"2. The --prefer-new option tag is of debatable worth as it is only different"},{"line_number":76,"context_line":"   from --overwrite on how it treats the \"existing, but, not new Properties,"},{"line_number":77,"context_line":"   Objects and Tags\" (i.e., it leaves them in place). If this is not deemed"},{"line_number":78,"context_line":"   critical, then we may not implement the --prefer-new option."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"3. The ability to update an existing Namespace via a JSON file may be added"},{"line_number":81,"context_line":"   to the python-glanceclient tool, either alternatively or in conjunction"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_c372deac","line":78,"updated":"2015-02-27 04:33:59.000000000","message":"Agreed that it is lower priority.  However, I can tell you that I think I need to submit a bug to update metadata definitions to Kilo and in some cases we might need to update descriptions or constraints. If an operator has already customized a namespace by adding their own properties, it would be painful for them to get updates to just the \"out of the box\" metadata definitions.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"dcda770250f24c21b5fa453f5f4b2ae1f818ddc0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"2. The --prefer-new option tag is of debatable worth as it is only different"},{"line_number":76,"context_line":"   from --overwrite on how it treats the \"existing, but, not new Properties,"},{"line_number":77,"context_line":"   Objects and Tags\" (i.e., it leaves them in place). If this is not deemed"},{"line_number":78,"context_line":"   critical, then we may not implement the --prefer-new option."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"3. The ability to update an existing Namespace via a JSON file may be added"},{"line_number":81,"context_line":"   to the python-glanceclient tool, either alternatively or in conjunction"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_39e01b96","line":78,"in_reply_to":"ba7be1f8_c372deac","updated":"2015-02-28 01:28:28.000000000","message":"ok...I think Pawel is intending to support this.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"168e572665d4ea4908b0c856895b2c90ac527732","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"3. The ability to update an existing Namespace via a JSON file may be added"},{"line_number":81,"context_line":"   to the python-glanceclient tool, either alternatively or in conjunction"},{"line_number":82,"context_line":"   with adding to glance-manage."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"4. The --prefer-existing option could reject new JSON Properties, Objects or"},{"line_number":85,"context_line":"   Tags rather than add them in."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_7abe37d6","line":82,"updated":"2015-02-27 02:55:48.000000000","message":"If you go the way of enhancing db_load_metdefs option, I prefer to keep existing glance-manage way.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"dcda770250f24c21b5fa453f5f4b2ae1f818ddc0","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"3. The ability to update an existing Namespace via a JSON file may be added"},{"line_number":81,"context_line":"   to the python-glanceclient tool, either alternatively or in conjunction"},{"line_number":82,"context_line":"   with adding to glance-manage."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"4. The --prefer-existing option could reject new JSON Properties, Objects or"},{"line_number":85,"context_line":"   Tags rather than add them in."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_39ed7bb8","line":82,"in_reply_to":"ba7be1f8_7abe37d6","updated":"2015-02-28 01:28:28.000000000","message":"Very good. I think we will go with db load_metadefs version.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"168e572665d4ea4908b0c856895b2c90ac527732","unresolved":false,"context_lines":[{"line_number":82,"context_line":"   with adding to glance-manage."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"4. The --prefer-existing option could reject new JSON Properties, Objects or"},{"line_number":85,"context_line":"   Tags rather than add them in."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Data model impact"},{"line_number":88,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_5a033376","line":85,"updated":"2015-02-27 02:55:48.000000000","message":"IMO we shouldn\u0027t reject them, three reasons to me: 1) we are talking about \u0027merge\u0027 option/approach, so new stuff within the namespace should be finally merged into existing namespace. 2) merging them in is hurtless from operator\u0027s opinion, existing ones are still there, news ones are come from our in-tree/reviewed built-in template, so he can use them when needed or just ignore them freely. 3) Merging them directly will prevent we make this stuff too complex, it\u0027s ok enough (currently at least).","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"dcda770250f24c21b5fa453f5f4b2ae1f818ddc0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"   with adding to glance-manage."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"4. The --prefer-existing option could reject new JSON Properties, Objects or"},{"line_number":85,"context_line":"   Tags rather than add them in."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Data model impact"},{"line_number":88,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_3949fbb7","line":85,"in_reply_to":"ba7be1f8_5a033376","updated":"2015-02-28 01:28:28.000000000","message":"Agree. We will add in new JSON Properties, Objects and Tags.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"168e572665d4ea4908b0c856895b2c90ac527732","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Other end user impact"},{"line_number":108,"context_line":"---------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"No, impacts glance-manage and/or glance client."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Performance Impact"},{"line_number":113,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_7a2f17f7","line":110,"updated":"2015-02-27 02:55:48.000000000","message":"glance-manage is a part of glance client. (or I mis-understood your point here)","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"dcda770250f24c21b5fa453f5f4b2ae1f818ddc0","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Other end user impact"},{"line_number":108,"context_line":"---------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"No, impacts glance-manage and/or glance client."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Performance Impact"},{"line_number":113,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_99358748","line":110,"in_reply_to":"ba7be1f8_7a2f17f7","updated":"2015-02-28 01:28:28.000000000","message":"Set to None in the document.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"168e572665d4ea4908b0c856895b2c90ac527732","unresolved":false,"context_lines":[{"line_number":149,"context_line":"Work Items"},{"line_number":150,"context_line":"----------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Provide definition files for different categories of software."},{"line_number":153,"context_line":" - Databases"},{"line_number":154,"context_line":" - Web servers"},{"line_number":155,"context_line":" - Runtime environments"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_da3d632e","line":152,"updated":"2015-02-27 02:55:48.000000000","message":"seems this part is wrong copy\u0026paste.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"},{"author":{"_account_id":10383,"name":"Wayne Okuma","email":"wayne.okuma@hpe.com","username":"okumaw"},"change_message_id":"dcda770250f24c21b5fa453f5f4b2ae1f818ddc0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"Work Items"},{"line_number":150,"context_line":"----------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Provide definition files for different categories of software."},{"line_number":153,"context_line":" - Databases"},{"line_number":154,"context_line":" - Web servers"},{"line_number":155,"context_line":" - Runtime environments"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba7be1f8_7915339a","line":152,"in_reply_to":"ba7be1f8_da3d632e","updated":"2015-02-28 01:28:28.000000000","message":"Yes, bad copy paste. Thanks for catching this.","commit_id":"d752ea5357cb56aa6cda3f604178fdb434628fac"}]}