)]}'
{"specs/api/v2/http-patch-image-api-v2.rst":[{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"429e8348f2316064d7d27382a9ffc1c66877d1fc","unresolved":false,"context_lines":[{"line_number":113,"context_line":"The add operation adds a new value at a specified location in the target"},{"line_number":114,"context_line":"image. The location must reference an image property to add to an"},{"line_number":115,"context_line":"existing image. If the image property already exists, it is replaced by"},{"line_number":116,"context_line":"the specified value."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"The operation object specifies a \"value\" member and associated value."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5ad58531_4dced95b","line":116,"updated":"2015-05-11 19:27:55.000000000","message":"As I saw earlier, there needs to be an error message prior to replacing the image property.  \n\nAlso, in the security impact section, I think there may need to be a sentence or two about how to handle sensitive properties that may need to be restricted from changing.  For example, for signed images.","commit_id":"6a714356b8ffcf83ac023b864d7284e08b3d0232"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"b2420cf434c1b1204b506f97d56ef43a10871ba4","unresolved":false,"context_lines":[{"line_number":113,"context_line":"The add operation adds a new value at a specified location in the target"},{"line_number":114,"context_line":"image. The location must reference an image property to add to an"},{"line_number":115,"context_line":"existing image. If the image property already exists, it is replaced by"},{"line_number":116,"context_line":"the specified value."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"The operation object specifies a \"value\" member and associated value."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5ad58531_938744d7","line":116,"in_reply_to":"5ad58531_4d7499ce","updated":"2015-05-11 20:16:23.000000000","message":"This is just a proposed feature https://blueprints.launchpad.net/glance/+spec/encrypted-and-authenticated-image-support, but when available, the permissions won\u0027t allow the signature to be changed by the user.  Therefore, I think you can disregard this particular security impact comment.  Thanks.","commit_id":"6a714356b8ffcf83ac023b864d7284e08b3d0232"},{"author":{"_account_id":7939,"name":"Luke Wollney","email":"luke.wollney@rackspace.com","username":"lwollney"},"change_message_id":"339ce90b4e30603d80ec8aaba4456b8f8044ee13","unresolved":false,"context_lines":[{"line_number":113,"context_line":"The add operation adds a new value at a specified location in the target"},{"line_number":114,"context_line":"image. The location must reference an image property to add to an"},{"line_number":115,"context_line":"existing image. If the image property already exists, it is replaced by"},{"line_number":116,"context_line":"the specified value."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"The operation object specifies a \"value\" member and associated value."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5ad58531_4d7499ce","line":116,"in_reply_to":"5ad58531_4dced95b","updated":"2015-05-11 19:34:01.000000000","message":"What defines a \u0027signed\u0027 image?","commit_id":"6a714356b8ffcf83ac023b864d7284e08b3d0232"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"d93a3b82d958c52d8c393c9ebb54ad630a8b5ecf","unresolved":false,"context_lines":[{"line_number":114,"context_line":"image. The location must reference an image property to add to an"},{"line_number":115,"context_line":"existing image. If the image property already exists, it is replaced by"},{"line_number":116,"context_line":"the specified value."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"The operation object specifies a \"value\" member and associated value."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Example:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_625e29eb","line":117,"updated":"2015-05-12 13:41:43.000000000","message":"OK, the only reason I\u0027m leaving the -1 is that I don\u0027t see the issue addressed to provide an error code or warning message if existing property info will be replaced.","commit_id":"6a714356b8ffcf83ac023b864d7284e08b3d0232"},{"author":{"_account_id":15447,"name":"yongfeng","email":"dolpher.du@intel.com","username":"dolpher"},"change_message_id":"0c8649b03a79e4100ec8579467cdc74851e5fb07","unresolved":false,"context_lines":[{"line_number":114,"context_line":"image. The location must reference an image property to add to an"},{"line_number":115,"context_line":"existing image. If the image property already exists, it is replaced by"},{"line_number":116,"context_line":"the specified value."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"The operation object specifies a \"value\" member and associated value."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Example:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_6c9efd57","line":117,"in_reply_to":"9a0c5dc1_625e29eb","updated":"2015-05-15 03:25:13.000000000","message":"Although without much experience on the restful API, I do read a lot doc/article/spec about this recently.\nMaybe I\u0027m wrong but I have an impression that, the \"replace\" behavior is a well-known behavior for the \"add\" operation. Whether or not we should provide a warning message depends on how many people think it\u0027s a \"dangerous\" behavior.\n\nI\u0027m happy to add that warning in the code if necessary, but seems this bug is not drawing much attention for discussion.","commit_id":"6a714356b8ffcf83ac023b864d7284e08b3d0232"}]}