)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5cfcfd85a3de51d5913d732fb7070c098698a88c","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"ApiImpact"},{"line_number":14,"context_line":"Implements: bp v2-additional-filtering"},{"line_number":15,"context_line":"Change-Id: I45e79173425f305a150408b5995468e1dca546aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_de56645d","line":14,"updated":"2015-07-08 23:22:17.000000000","message":"How does this spec implement the bp? Shouldn\u0027t that be on the final implementation rather than design?\n\nAlso I\u0027m not convinced that this specification has any impact on the API nor Docs, that would be the implementation as well.","commit_id":"816b9a046c904ca6ccc183e7f47de9bd39dbe5b8"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"30a8ee450fa3b175faa72a115fb8b3e0806e7504","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"ApiImpact"},{"line_number":14,"context_line":"Implements: bp v2-additional-filtering"},{"line_number":15,"context_line":"Change-Id: I45e79173425f305a150408b5995468e1dca546aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_73e4f10b","line":14,"in_reply_to":"ba3cc151_de56645d","updated":"2015-07-16 04:38:45.000000000","message":"The API-WG ask specifically to tag specs because generally by the time an implementation is up it\u0027s a bit too late to fix API design issues.\n\nThe rest of it was me being defensive and following behaviors I had seen in OpenStack and may not actually be appropriate.  Sorry for the confusion there.","commit_id":"816b9a046c904ca6ccc183e7f47de9bd39dbe5b8"}],"specs/liberty/v2-additional-filtering.rst":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"6acf72f0b54c3b198c8ec0aa2f922e3133e6df2c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                  datetime."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"These filters will be added using syntax that conforms to the latest"},{"line_number":93,"context_line":"guidelines from the OpenStack API Working Group, and any applicable drafts"},{"line_number":94,"context_line":"guidelines [4]_. This implies support for optional comparison operators with"},{"line_number":95,"context_line":"the implied default comparison operator being \u0027equals\u0027 for exact matches."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_296cd806","line":93,"updated":"2015-06-18 17:48:26.000000000","message":"draft","commit_id":"98c04b7117d5ebebd033eeaa4fba98fd31298ad5"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"6acf72f0b54c3b198c8ec0aa2f922e3133e6df2c","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"An example of an acceptable criteria using an optional comparison operator::"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  gte,1985-04-12T23:20:50.52Z"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"This represents any time at or after 20 minutes and 50.52 seconds after the"},{"line_number":102,"context_line":"23rd hour of April 12th, 1985 in UTC."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_4946fc7b","line":99,"updated":"2015-06-18 17:48:26.000000000","message":"separator switching to \u0027:\u0027 in current review","commit_id":"98c04b7117d5ebebd033eeaa4fba98fd31298ad5"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"6acf72f0b54c3b198c8ec0aa2f922e3133e6df2c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"23rd hour of April 12th, 1985 in UTC."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":".. note:: In all cases, literal expressions in any of these filters will be"},{"line_number":105,"context_line":"   treated as case-indifferent."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Both new filters will support access control through oslo.policy enforcement"},{"line_number":108,"context_line":"to allow a deployer to restrict usage of these filters. Because these filters"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_440b4124","line":105,"updated":"2015-06-18 17:48:26.000000000","message":"case-insensitive is clearer","commit_id":"98c04b7117d5ebebd033eeaa4fba98fd31298ad5"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"919cbd1994ac5e6cb109c94fb3501c74be9bf369","unresolved":false,"context_lines":[{"line_number":105,"context_line":"   treated as case-indifferent."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Both new filters will support access control through oslo.policy enforcement"},{"line_number":108,"context_line":"to allow a deployer to restrict usage of these filters. Because these filters"},{"line_number":109,"context_line":"support this access control, no guarantee is given for availability of these"},{"line_number":110,"context_line":"filters for all API consumers. Performance or security concerns around these"},{"line_number":111,"context_line":"filters in any given deployment can be addressed through the use of custom"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_a94d48c5","line":108,"updated":"2015-06-18 15:02:04.000000000","message":"What was the motivation to have access controls on these (just curious)? Because they are expensive calls?","commit_id":"98c04b7117d5ebebd033eeaa4fba98fd31298ad5"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"6acf72f0b54c3b198c8ec0aa2f922e3133e6df2c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"   treated as case-indifferent."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Both new filters will support access control through oslo.policy enforcement"},{"line_number":108,"context_line":"to allow a deployer to restrict usage of these filters. Because these filters"},{"line_number":109,"context_line":"support this access control, no guarantee is given for availability of these"},{"line_number":110,"context_line":"filters for all API consumers. Performance or security concerns around these"},{"line_number":111,"context_line":"filters in any given deployment can be addressed through the use of custom"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_5ba79bbc","line":108,"in_reply_to":"fa32b979_a94d48c5","updated":"2015-06-18 17:48:26.000000000","message":"These calls should not be expensive with the indexes provided. If a particular deployer experiences unforeseen issues in production, this functionality can provide a workaround.\n\nThis detail was a hold-over from when this spec also included changes for filtering for images in deleted status. \n\nThat concern is now covered by https://review.openstack.org/#/c/172784/ but the analysis said that deleted images could be something a deployer might elect to limit visibility of. There is an intention to provide policy enforcement as a following patch to the status filtering so that gap with the current proposals is expected to be closed.\n\nLeaving the policy enforcement in for these two filters seemed like it would be a small piece of work but would still be acceptable to include for these reasons.","commit_id":"98c04b7117d5ebebd033eeaa4fba98fd31298ad5"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"6acf72f0b54c3b198c8ec0aa2f922e3133e6df2c","unresolved":false,"context_lines":[{"line_number":133,"context_line":"The appropriate indexes will also be updated on each row create and/or update"},{"line_number":134,"context_line":"to the associated image row. This is considered a minimal impact."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance for existing support sort operations on the indexed columns would"},{"line_number":137,"context_line":"be improved."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_29d058c8","line":136,"updated":"2015-06-18 17:48:26.000000000","message":"needs edit","commit_id":"98c04b7117d5ebebd033eeaa4fba98fd31298ad5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ccad0a55372aa692415c2d01ed80629c2b248190","unresolved":false,"context_lines":[{"line_number":92,"context_line":"These filters will be added using syntax that conforms to the latest"},{"line_number":93,"context_line":"guidelines from the OpenStack API Working Group, and any applicable draft"},{"line_number":94,"context_line":"guidelines [4]_. This implies support for optional comparison operators with"},{"line_number":95,"context_line":"the implied default comparison operator being \u0027equals\u0027 for exact matches."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"An example of an acceptable criteria using an optional comparison operator::"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a41bdd9_146a8181","line":95,"updated":"2015-07-15 05:16:58.000000000","message":"Could you clarify which comparison operators you are proposing to implement?  (\"For queries that need comparisons other than simple equals, operators are supported for membership, inequality, greater-than, greater-than-or-equal, less-than, and less-than-or-equal-to. In order, the operators are: in, neq, gt, gte, lt, and lte. Simple equality is the default operation, and is performed as ?f_param\u003dfoo.\")  I take it that it would not make sense to have a membership operator here, but are you proposing to implement all the others?","commit_id":"816b9a046c904ca6ccc183e7f47de9bd39dbe5b8"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"30a8ee450fa3b175faa72a115fb8b3e0806e7504","unresolved":false,"context_lines":[{"line_number":92,"context_line":"These filters will be added using syntax that conforms to the latest"},{"line_number":93,"context_line":"guidelines from the OpenStack API Working Group, and any applicable draft"},{"line_number":94,"context_line":"guidelines [4]_. This implies support for optional comparison operators with"},{"line_number":95,"context_line":"the implied default comparison operator being \u0027equals\u0027 for exact matches."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"An example of an acceptable criteria using an optional comparison operator::"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a41bdd9_7705d411","line":95,"in_reply_to":"9a41bdd9_146a8181","updated":"2015-07-16 04:38:45.000000000","message":"You are correct. The in operator would not make much sense here.  The operators: neq, gt, gte, lt, and lte and basic equality should be supported by the implementation.","commit_id":"816b9a046c904ca6ccc183e7f47de9bd39dbe5b8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f8d50b41d1b6b7b5c90f8042c97431c3a3ef088b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Other end user impact"},{"line_number":126,"context_line":"---------------------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Update python-glanceclient as needed."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Performance Impact"},{"line_number":131,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_3750d531","line":128,"updated":"2015-06-24 14:20:17.000000000","message":"It seems like for Nova, when we get requests for our image API\u0027s changes-since, we can translate that to updated-at when talking to v2.\n\nSo this looks good to me.","commit_id":"816b9a046c904ca6ccc183e7f47de9bd39dbe5b8"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"37db26f4319b68bf9d656a42dbdaa90be80b5e5c","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"  `Image service API v2 \u003chttp://developer.openstack.org/"},{"line_number":200,"context_line":"  api-ref-image-v2.html\u003e`_"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":".. [2]"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"  `Glance sorting enhancements \u003chttp://specs.openstack.org/openstack/"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba3cc151_7b5c0a19","line":201,"updated":"2015-07-08 22:36:23.000000000","message":"Usually URLs are on the same line.  When this is rendered, please make sure there aren\u0027t any spaces added in.","commit_id":"816b9a046c904ca6ccc183e7f47de9bd39dbe5b8"}]}