)]}'
{"specs/liberty/scrub-images-in-parallel.rst":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ae6571fed976e8ec23cf3031489fce26f45554ea","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"None"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Notifications impact"},{"line_number":62,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba15a1d1_801a6116","line":59,"updated":"2015-09-14 12:03:37.000000000","message":"Based on the performance impact mentioned below, would it be possible for an attacker to constantly create small images and delete them to make the scrubber hit the rate-limit?","commit_id":"2769d9c11417ee9aa61ee9706a5c523aedbc7225"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1470a7ea243c2bb6c3e21872efb5facc1b5fc1ce","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"None"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Notifications impact"},{"line_number":62,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba15a1d1_fef5f282","line":59,"in_reply_to":"ba15a1d1_801a6116","updated":"2015-09-14 16:05:12.000000000","message":"If the rate-limits on the backend storage are not taken into consideration while setting the pool size, yeah, it\u0027s definitely possible.","commit_id":"2769d9c11417ee9aa61ee9706a5c523aedbc7225"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"153390b1adbc87465158b8649bd13886f10066c9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"None"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Notifications impact"},{"line_number":62,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba15a1d1_b11a4b6d","line":59,"in_reply_to":"ba15a1d1_9e9396fa","updated":"2015-09-14 16:11:23.000000000","message":"Yes, pushing up a PS.","commit_id":"2769d9c11417ee9aa61ee9706a5c523aedbc7225"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e765d2ab5b6f5c93f7fd585f44be02d3259be450","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"None"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Notifications impact"},{"line_number":62,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba15a1d1_9e9396fa","line":59,"in_reply_to":"ba15a1d1_fef5f282","updated":"2015-09-14 16:07:50.000000000","message":"could you mention this as well?\n\nThanks!","commit_id":"2769d9c11417ee9aa61ee9706a5c523aedbc7225"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ae6571fed976e8ec23cf3031489fce26f45554ea","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Other deployer impact"},{"line_number":79,"context_line":"---------------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Developer impact"},{"line_number":84,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba15a1d1_000f31e2","line":81,"updated":"2015-09-14 12:03:37.000000000","message":"The current implementation adds a new config option that should be mentioned here (and in the proposed change).","commit_id":"2769d9c11417ee9aa61ee9706a5c523aedbc7225"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1470a7ea243c2bb6c3e21872efb5facc1b5fc1ce","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Other deployer impact"},{"line_number":79,"context_line":"---------------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Developer impact"},{"line_number":84,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba15a1d1_7e300257","line":81,"in_reply_to":"ba15a1d1_000f31e2","updated":"2015-09-14 16:05:12.000000000","message":"Done","commit_id":"2769d9c11417ee9aa61ee9706a5c523aedbc7225"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ddb4777d4a7b1df03568b0674f330802b78cb5c7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"As mentioned in the performance impact section, while setting the degree of"},{"line_number":60,"context_line":"parallelism one should take into account any rate-limits enforced by the"},{"line_number":61,"context_line":"backend store. If the degree of parallelism is set to go beyond the"},{"line_number":62,"context_line":"rate-limits, an attacker may be able to force the scrubber hit the rate-limits"},{"line_number":63,"context_line":"by creating and deleting several images in a short span of time."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_eff9bec9","line":62,"updated":"2015-09-14 17:06:19.000000000","message":"nit: replace \u0027hit\u0027 with \u0027to exceed\u0027","commit_id":"23c5f584e74847564fb5e406c219bc8115f0982b"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"90f3ff49c76fd9a914df0cb55676a9fbf01b07c6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"As mentioned in the performance impact section, while setting the degree of"},{"line_number":60,"context_line":"parallelism one should take into account any rate-limits enforced by the"},{"line_number":61,"context_line":"backend store. If the degree of parallelism is set to go beyond the"},{"line_number":62,"context_line":"rate-limits, an attacker may be able to force the scrubber hit the rate-limits"},{"line_number":63,"context_line":"by creating and deleting several images in a short span of time."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_ca69488d","line":62,"in_reply_to":"ba15a1d1_eff9bec9","updated":"2015-09-14 17:16:03.000000000","message":"sure.","commit_id":"23c5f584e74847564fb5e406c219bc8115f0982b"}]}
