)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"e039c182187cf813efb6d543f4f19faaca9d4e59","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\u0027id\u0027, \u0027name\u0027, \u0027container_format\u0027, \u0027disk_format\u0027 using the \u0027in\u0027"},{"line_number":11,"context_line":"operator between the values."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements spec-bp: in-filtering-operator"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia2a00f11ba961457243fa748d51ba7c38429845a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a740942_5dc1ebe2","line":13,"updated":"2015-12-14 14:44:58.000000000","message":"If you do another patch, it\u0027d be great to add \"APIImpact\" so more API-wg folks can discover it.","commit_id":"4daf452acfa0f500251a0ac5bd33760de64cdcda"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"86f1af2aeb962051fdfa18b9c2146c72ebaa60dc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I propose to add the ability to filter the images on the properties"},{"line_number":10,"context_line":"\u0027id\u0027, \u0027name\u0027, \u0027container_format\u0027, \u0027disk_format\u0027 using the \u0027in\u0027"},{"line_number":11,"context_line":"operator between the values."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a7e1126_fe0f0986","line":11,"updated":"2015-12-17 14:51:38.000000000","message":"Probably more accurate simply to end this sentence after \u0027operator\u0027 (it doesn\u0027t really go between the values).","commit_id":"5e1063c781ba81db2a15c85b3e1b8d2cfebf91bc"}],"specs/mitaka/approved/v2-add-filters-with-in-operator.rst":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"f412e12e6a71836d838af99be7dcc38be1ac6cee","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"An example of an acceptance criteria using the \u0027in\u0027 operator for name::"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  ?name\u003din:name1,name2,name3"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"These filters will be added using syntax that conforms to the latest"},{"line_number":64,"context_line":"guidelines from the OpenStack API Working Group and any applicable draft"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a710552_a1740f9c","line":61,"updated":"2015-12-15 15:14:51.000000000","message":"It\u0027s fairly obvious, but can we say that these will be simple, exact matches, ie not partial matching. (ie name\u003din:deb does not match debian)","commit_id":"fcad6da25533beaf777fdf1a980fd28024bd49cd"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"37fd5b39c244a9b5591c0f9436ea0b4f541466ed","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"images\" : [image1, image2, ... imageN]"},{"line_number":87,"context_line":"    \"schema\": \"/v2/schemas/images\","},{"line_number":88,"context_line":"    \"first\": \"/v2/images?name\u003din%3name1%2name2\""},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":"Max page size will still be enforced. For example if the max page size is 3"},{"line_number":91,"context_line":"and I do request \u0027id\u003din:1,2,3,4\u0027 - I only get 3 images and a link to get"},{"line_number":92,"context_line":"the fourth."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a7e1126_388cc934","line":89,"range":{"start_line":89,"start_character":2,"end_line":89,"end_character":3},"updated":"2015-12-17 14:23:08.000000000","message":"Hmm, this isn\u0027t what I was expecting.\n\nI was expecting the usual list output format, not something new.\n\neg\n\n GET /v2/images?name\u003din:name1\n\nwould give the same result as\n \n GET /v2/images?name\u003dname1\n\nas you add more names the list would grow to include the new names, and would have the same format as a standard list.\n\nThat seems to be what the working group page indicates:\n\nhttp://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html","commit_id":"5e1063c781ba81db2a15c85b3e1b8d2cfebf91bc"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c72bfda7c0d8f959b11b6e5984c01a5e54bb003b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"images\" : [image1, image2, ... imageN]"},{"line_number":87,"context_line":"    \"schema\": \"/v2/schemas/images\","},{"line_number":88,"context_line":"    \"first\": \"/v2/images?name\u003din%3name1%2name2\""},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":"Max page size will still be enforced. For example if the max page size is 3"},{"line_number":91,"context_line":"and I do request \u0027id\u003din:1,2,3,4\u0027 - I only get 3 images and a link to get"},{"line_number":92,"context_line":"the fourth."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a7e1126_eb695426","line":89,"range":{"start_line":89,"start_character":2,"end_line":89,"end_character":3},"in_reply_to":"3a7e1126_04fff534","updated":"2015-12-18 12:10:27.000000000","message":"I\u0027ve provided an example response here:\n\nhttp://paste.openstack.org/raw/482296/\n\nIt would be super to update the document to include that.","commit_id":"5e1063c781ba81db2a15c85b3e1b8d2cfebf91bc"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c72bfda7c0d8f959b11b6e5984c01a5e54bb003b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"images\" : [image1, image2, ... imageN]"},{"line_number":87,"context_line":"    \"schema\": \"/v2/schemas/images\","},{"line_number":88,"context_line":"    \"first\": \"/v2/images?name\u003din%3name1%2name2\""},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":"Max page size will still be enforced. For example if the max page size is 3"},{"line_number":91,"context_line":"and I do request \u0027id\u003din:1,2,3,4\u0027 - I only get 3 images and a link to get"},{"line_number":92,"context_line":"the fourth."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a7e1126_f8eac1ab","line":89,"range":{"start_line":89,"start_character":2,"end_line":89,"end_character":3},"in_reply_to":"3a7e1126_388cc934","updated":"2015-12-18 12:10:27.000000000","message":"Done","commit_id":"5e1063c781ba81db2a15c85b3e1b8d2cfebf91bc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"86f1af2aeb962051fdfa18b9c2146c72ebaa60dc","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"images\" : [image1, image2, ... imageN]"},{"line_number":87,"context_line":"    \"schema\": \"/v2/schemas/images\","},{"line_number":88,"context_line":"    \"first\": \"/v2/images?name\u003din%3name1%2name2\""},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":"Max page size will still be enforced. For example if the max page size is 3"},{"line_number":91,"context_line":"and I do request \u0027id\u003din:1,2,3,4\u0027 - I only get 3 images and a link to get"},{"line_number":92,"context_line":"the fourth."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a7e1126_1eea1510","line":89,"range":{"start_line":89,"start_character":2,"end_line":89,"end_character":3},"in_reply_to":"3a7e1126_388cc934","updated":"2015-12-17 14:51:38.000000000","message":"I agree with Stuart, the response should be a standard image list response, with the content filtered to meet the criteria expressed in the query string.","commit_id":"5e1063c781ba81db2a15c85b3e1b8d2cfebf91bc"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"06ffb4cfb9491ed8c4221a710c8c5d6c190452d5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"images\" : [image1, image2, ... imageN]"},{"line_number":87,"context_line":"    \"schema\": \"/v2/schemas/images\","},{"line_number":88,"context_line":"    \"first\": \"/v2/images?name\u003din%3name1%2name2\""},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":"Max page size will still be enforced. For example if the max page size is 3"},{"line_number":91,"context_line":"and I do request \u0027id\u003din:1,2,3,4\u0027 - I only get 3 images and a link to get"},{"line_number":92,"context_line":"the fourth."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a7e1126_04fff534","line":89,"range":{"start_line":89,"start_character":2,"end_line":89,"end_character":3},"in_reply_to":"3a7e1126_388cc934","updated":"2015-12-18 10:34:55.000000000","message":"This is standard response from the server, I just did not paint the image detail. e.g. http://paste.openstack.org/show/482279/","commit_id":"5e1063c781ba81db2a15c85b3e1b8d2cfebf91bc"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"074ff07a0008037b2d3a401fb5ded895c4216a3a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"images\" : [image1, image2, ... imageN]"},{"line_number":87,"context_line":"    \"schema\": \"/v2/schemas/images\","},{"line_number":88,"context_line":"    \"first\": \"/v2/images?name\u003din%3name1%2name2\""},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":"Max page size will still be enforced. For example if the max page size is 3"},{"line_number":91,"context_line":"and I do request \u0027id\u003din:1,2,3,4\u0027 - I only get 3 images and a link to get"},{"line_number":92,"context_line":"the fourth."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a7e1126_06b5b5ec","line":89,"range":{"start_line":89,"start_character":2,"end_line":89,"end_character":3},"in_reply_to":"3a7e1126_eb695426","updated":"2015-12-18 12:22:12.000000000","message":"Done","commit_id":"5e1063c781ba81db2a15c85b3e1b8d2cfebf91bc"}],"specs/mitaka/v2-add-filters-with-in-operator.rst":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"4b20af6dbd9da9e5a1d60666a881839bd6b904a0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"I propose to add the ability to filter the images on the properties"},{"line_number":13,"context_line":"``id``, ``name``, ``container_format``, ``disk_format`` using the \u0027in\u0027"},{"line_number":14,"context_line":"operator between the values."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_18c41b5d","line":12,"updated":"2015-11-18 15:22:59.000000000","message":"This spec introduces a feature to the Glance v2 API for filtering images based on lists of ``id``, ``name``, ``container_format`` or ``disk_format`` using the \u0027in\u0027 operator.\n\nThe introduction of this feature is important because it allows Horizon to make only one request to Glance instead of multiple single requests, which improves system performance and reduces the load.","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"1f705b0c4c4d6d3106a109a0cc146979b277bb59","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"I propose to add the ability to filter the images on the properties"},{"line_number":13,"context_line":"``id``, ``name``, ``container_format``, ``disk_format`` using the \u0027in\u0027"},{"line_number":14,"context_line":"operator between the values."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_782a6a80","line":12,"in_reply_to":"ba8a016a_18c41b5d","updated":"2015-11-21 14:16:27.000000000","message":"Done","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"a084e1ec620a47837b5b1aaf2eaa7f6714c6dae4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"I propose to add the ability to filter the images on the properties"},{"line_number":13,"context_line":"``id``, ``name``, ``container_format``, ``disk_format`` using the \u0027in\u0027"},{"line_number":14,"context_line":"operator between the values."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_1e1638f1","line":14,"updated":"2015-11-18 18:42:10.000000000","message":"why not include image status?","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"1f705b0c4c4d6d3106a109a0cc146979b277bb59","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"I propose to add the ability to filter the images on the properties"},{"line_number":13,"context_line":"``id``, ``name``, ``container_format``, ``disk_format`` using the \u0027in\u0027"},{"line_number":14,"context_line":"operator between the values."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_1d6c7007","line":14,"in_reply_to":"ba8a016a_1e1638f1","updated":"2015-11-21 14:16:27.000000000","message":"Done","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"18c5561fae6bd8a14274072cfcec083b57c88bf0","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"I propose to add the ability to filter the images on the properties"},{"line_number":13,"context_line":"``id``, ``name``, ``container_format``, ``disk_format`` using the \u0027in\u0027"},{"line_number":14,"context_line":"operator between the values."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_beb84cc9","line":14,"in_reply_to":"ba8a016a_1e1638f1","updated":"2015-11-18 18:43:12.000000000","message":"Good point!","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"4b20af6dbd9da9e5a1d60666a881839bd6b904a0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"~~~~~~~~~~~~~~~"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"I propose to add the ability to filter the images on the properties ``id``,"},{"line_number":27,"context_line":"``name``, ``container_format``, ``disk_format`` using the \u0027in\u0027 operator"},{"line_number":28,"context_line":"between the values."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_3898ff77","line":26,"updated":"2015-11-18 15:22:59.000000000","message":"It\u0027s proposed :)","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"1f705b0c4c4d6d3106a109a0cc146979b277bb59","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"~~~~~~~~~~~~~~~"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"I propose to add the ability to filter the images on the properties ``id``,"},{"line_number":27,"context_line":"``name``, ``container_format``, ``disk_format`` using the \u0027in\u0027 operator"},{"line_number":28,"context_line":"between the values."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_b819b27b","line":26,"in_reply_to":"ba8a016a_3898ff77","updated":"2015-11-21 14:16:27.000000000","message":"Done","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"4b20af6dbd9da9e5a1d60666a881839bd6b904a0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Data model impact"},{"line_number":36,"context_line":"-----------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Modify the Image domain class to raise indexes for the ``id``,"},{"line_number":39,"context_line":"``name``, ``container_format``, ``disk_format`` columns on the images DB table."},{"line_number":40,"context_line":"The additional indexes raised will impose a longer upgrade window for larger"},{"line_number":41,"context_line":"Glance installs while the indexes are built."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_95d454bd","line":38,"updated":"2015-11-18 15:22:59.000000000","message":"Indexing by id is not required, because it\u0027s a primary key and it\u0027s done by default.","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"1f705b0c4c4d6d3106a109a0cc146979b277bb59","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Data model impact"},{"line_number":36,"context_line":"-----------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Modify the Image domain class to raise indexes for the ``id``,"},{"line_number":39,"context_line":"``name``, ``container_format``, ``disk_format`` columns on the images DB table."},{"line_number":40,"context_line":"The additional indexes raised will impose a longer upgrade window for larger"},{"line_number":41,"context_line":"Glance installs while the indexes are built."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_582526ac","line":38,"in_reply_to":"ba8a016a_95d454bd","updated":"2015-11-21 14:16:27.000000000","message":"Done","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"4b20af6dbd9da9e5a1d60666a881839bd6b904a0","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Filter by adding optional query parameters::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  id, name. disk_format, container_format"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"An example of an acceptable criteria using an \u0027in\u0027 operator for name::"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_d5965c3e","line":55,"updated":"2015-11-18 15:22:59.000000000","message":"should be comma after \u0027name\u0027","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"1f705b0c4c4d6d3106a109a0cc146979b277bb59","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Filter by adding optional query parameters::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  id, name. disk_format, container_format"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"An example of an acceptable criteria using an \u0027in\u0027 operator for name::"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_181f9e5c","line":55,"in_reply_to":"ba8a016a_d5965c3e","updated":"2015-11-21 14:16:27.000000000","message":"Done","commit_id":"55c2ecc22fb2cc61cb5474c5d8bd0f8a198b95be"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a41a33b019d814df6b8cf4e394f09a0311c0e18c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"``disk_format`` using the \u0027in\u0027 operator."},{"line_number":14,"context_line":"The introduction of this feature is important because it allows Horizon"},{"line_number":15,"context_line":"to make only one request to Glance instead of multiple single requests, which"},{"line_number":16,"context_line":"improves system performance and reduces the load."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_d9dd7915","line":16,"updated":"2015-11-25 14:53:02.000000000","message":"Any data to back this claim up?","commit_id":"80d6520dc1477bfe60cfbc5168417703e908d329"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a41a33b019d814df6b8cf4e394f09a0311c0e18c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Modify the Image domain class to raise indexes for the ``status``,"},{"line_number":41,"context_line":"``name``, ``container_format``, ``disk_format`` columns on the images DB table."},{"line_number":42,"context_line":"The additional indexes raised will impose a longer upgrade window for larger"},{"line_number":43,"context_line":"Glance installs while the indexes are built."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"REST API impact"},{"line_number":46,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_b9d435bd","line":43,"updated":"2015-11-25 14:53:02.000000000","message":"I\u0027m not the DB guy here, but in my understanding the adding bunch of new indexes will increase the size of the DB, how big of an impact this will be to the DB-servers?","commit_id":"80d6520dc1477bfe60cfbc5168417703e908d329"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"15a10044ebf85f07e013bab2769e847541d4183b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"query parameters, using the field to filter as the key and the filter criteria"},{"line_number":47,"context_line":"as the value in the parameter."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Changes apply exclusively to Image API v2 Image entity listings:"},{"line_number":50,"context_line":"    GET /v2/images/{image\\_id}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Filter by adding optional query parameters::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_204413b5","line":49,"updated":"2015-11-27 17:22:30.000000000","message":"Can we remove one word \u0027Image\u0027 here? Or it was done intentionally?","commit_id":"f961d2b4afde8bec34745cb0792094dbe3f6d83e"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"a0f2d85d3da9cfc14a6b952a1759996fea32d131","unresolved":false,"context_lines":[{"line_number":46,"context_line":"query parameters, using the field to filter as the key and the filter criteria"},{"line_number":47,"context_line":"as the value in the parameter."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Changes apply exclusively to Image API v2 Image entity listings:"},{"line_number":50,"context_line":"    GET /v2/images/{image\\_id}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Filter by adding optional query parameters::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_7f44c948","line":49,"in_reply_to":"9a8ffd7b_204413b5","updated":"2015-11-30 10:10:01.000000000","message":"Done","commit_id":"f961d2b4afde8bec34745cb0792094dbe3f6d83e"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"15a10044ebf85f07e013bab2769e847541d4183b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"~~~~~~~~~~~~"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The appropriate indexes will also be updated on each row create and/or update"},{"line_number":135,"context_line":"to the associated image row. This is considered a minimal impact."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_afb6acf6","line":134,"updated":"2015-11-27 17:22:30.000000000","message":"Is it okay to add \u0027row\u0027 before the word \u0027update\u0027 for clarity here?","commit_id":"f961d2b4afde8bec34745cb0792094dbe3f6d83e"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"7914435dc72aa41d6e7f3da8a8cc7f562f755bf4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add filters using an \u0027in\u0027 operator"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This specification introduces a feature to the Glance v2 API for filtering"},{"line_number":12,"context_line":"images based on lists of ``id``, ``name``, ``status``, ``container_format`` or"},{"line_number":13,"context_line":"``disk_format`` using the \u0027in\u0027 operator."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_f025f95b","line":10,"updated":"2015-12-01 14:49:59.000000000","message":"Add a link to the blueprint here https://blueprints.launchpad.net/glance/+spec/in-filtering-operator","commit_id":"8574d696f9e98f69f4bb37462892a4956f9e1b32"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"d5f9f05fa4cb2720a6fb2424b5af5e35c6ee8111","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add filters using an \u0027in\u0027 operator"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This specification introduces a feature to the Glance v2 API for filtering"},{"line_number":12,"context_line":"images based on lists of ``id``, ``name``, ``status``, ``container_format`` or"},{"line_number":13,"context_line":"``disk_format`` using the \u0027in\u0027 operator."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_53664f2a","line":10,"in_reply_to":"9a8ffd7b_f025f95b","updated":"2015-12-01 15:00:24.000000000","message":"Done","commit_id":"8574d696f9e98f69f4bb37462892a4956f9e1b32"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"7914435dc72aa41d6e7f3da8a8cc7f562f755bf4","unresolved":false,"context_lines":[{"line_number":68,"context_line":"available to all API consumers. The performance or security concerns around"},{"line_number":69,"context_line":"these filters in any given deployment can be addressed by using custom"},{"line_number":70,"context_line":"policy rules. Standard response codes will apply when access to the filter is"},{"line_number":71,"context_line":"forbidden."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Security impact"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_902a6d8f","line":71,"updated":"2015-12-01 14:49:59.000000000","message":"I\u0027m not sure if we really need policy rules here. I mean it\u0027s just simplification of work with Glance API, because instead of large number of requests we can do only one. And it\u0027s shown in your graphic - you access the same information, but much faster.","commit_id":"8574d696f9e98f69f4bb37462892a4956f9e1b32"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"d5f9f05fa4cb2720a6fb2424b5af5e35c6ee8111","unresolved":false,"context_lines":[{"line_number":68,"context_line":"available to all API consumers. The performance or security concerns around"},{"line_number":69,"context_line":"these filters in any given deployment can be addressed by using custom"},{"line_number":70,"context_line":"policy rules. Standard response codes will apply when access to the filter is"},{"line_number":71,"context_line":"forbidden."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Security impact"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_33bceb6b","line":71,"in_reply_to":"9a8ffd7b_902a6d8f","updated":"2015-12-01 15:00:24.000000000","message":"Done","commit_id":"8574d696f9e98f69f4bb37462892a4956f9e1b32"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"7914435dc72aa41d6e7f3da8a8cc7f562f755bf4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"Reviewers"},{"line_number":124,"context_line":"---------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"mfedosin"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_b0953141","line":126,"updated":"2015-12-01 14:49:59.000000000","message":"Add \u0027jokke\u0027 as a reviewer, please.","commit_id":"8574d696f9e98f69f4bb37462892a4956f9e1b32"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"d5f9f05fa4cb2720a6fb2424b5af5e35c6ee8111","unresolved":false,"context_lines":[{"line_number":123,"context_line":"Reviewers"},{"line_number":124,"context_line":"---------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"mfedosin"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_53bf2f60","line":126,"in_reply_to":"9a8ffd7b_b0953141","updated":"2015-12-01 15:00:24.000000000","message":"Done","commit_id":"8574d696f9e98f69f4bb37462892a4956f9e1b32"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"e039c182187cf813efb6d543f4f19faaca9d4e59","unresolved":false,"context_lines":[{"line_number":148,"context_line":".. [1]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  `API Working Group filtering guidelines draft \u003chttps://review.openstack.org/"},{"line_number":151,"context_line":"  #/c/177468/\u003e`_"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":".. [2]"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a740942_e03eeab6","line":151,"updated":"2015-12-14 14:44:58.000000000","message":"Super minor: you can link to the rendered version of the spec since it was merged here http://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html","commit_id":"4daf452acfa0f500251a0ac5bd33760de64cdcda"}]}