)]}'
{"specs/mitaka/prevention-of-401-in-swift-driver.rst":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"ac071df0866ec09b936313dc5cd024d0214ab65f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    In general, it proposed the following scenario:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    1. Before the upload glance_store identifies if image need to be chunked."},{"line_number":65,"context_line":"    In case of chunked image glance_store initializes ConnectionManager that"},{"line_number":66,"context_line":"    support re-authentication. If re-authentication is enabled,"},{"line_number":67,"context_line":"    ConnectionManager requests all pre-requisites that allow to request the new"},{"line_number":68,"context_line":"    token:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_9ca4e757","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":6},"updated":"2016-01-12 17:38:01.000000000","message":"nit: The connection manager stuff is not specific to upload. It might make sense to move the explanation of how we will refresh tokens to a generic section, and then refer to it in the upload/download sections.","commit_id":"dc6416ed6bae93238ca8c4db8e43f173db052ef0"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"fc457ad94922296aea60e28891542b7dd05f27d8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    In general, it proposed the following scenario:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    1. Before the upload glance_store identifies if image need to be chunked."},{"line_number":65,"context_line":"    In case of chunked image glance_store initializes ConnectionManager that"},{"line_number":66,"context_line":"    support re-authentication. If re-authentication is enabled,"},{"line_number":67,"context_line":"    ConnectionManager requests all pre-requisites that allow to request the new"},{"line_number":68,"context_line":"    token:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_68ba680c","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":6},"in_reply_to":"da6ed579_9ca4e757","updated":"2016-01-13 09:51:22.000000000","message":"Done","commit_id":"dc6416ed6bae93238ca8c4db8e43f173db052ef0"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"ac071df0866ec09b936313dc5cd024d0214ab65f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    support re-authentication. If re-authentication is enabled,"},{"line_number":67,"context_line":"    ConnectionManager requests all pre-requisites that allow to request the new"},{"line_number":68,"context_line":"    token:"},{"line_number":69,"context_line":"    - for single-tenant store: glance service user credentials (auth_url,"},{"line_number":70,"context_line":"    domain, username, password, project)"},{"line_number":71,"context_line":"    - for multi-tenant store: trust id, glance service user credentials ("},{"line_number":72,"context_line":"    username, password)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_fc588358","line":69,"range":{"start_line":69,"start_character":31,"end_line":69,"end_character":62},"updated":"2016-01-12 17:38:01.000000000","message":"What are the \u0027glance service user credentials\u0027? Are they something new this spec is proposing?","commit_id":"dc6416ed6bae93238ca8c4db8e43f173db052ef0"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"fc457ad94922296aea60e28891542b7dd05f27d8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    support re-authentication. If re-authentication is enabled,"},{"line_number":67,"context_line":"    ConnectionManager requests all pre-requisites that allow to request the new"},{"line_number":68,"context_line":"    token:"},{"line_number":69,"context_line":"    - for single-tenant store: glance service user credentials (auth_url,"},{"line_number":70,"context_line":"    domain, username, password, project)"},{"line_number":71,"context_line":"    - for multi-tenant store: trust id, glance service user credentials ("},{"line_number":72,"context_line":"    username, password)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_88b0fc44","line":69,"range":{"start_line":69,"start_character":31,"end_line":69,"end_character":62},"in_reply_to":"da6ed579_fc588358","updated":"2016-01-13 09:51:22.000000000","message":"They come from StoreLocation object. AFAIK StoreLocation parses the credentials from swift_store_config_file or swift store configurations (swift_store_auth_version, swift_store_auth_address and others).","commit_id":"dc6416ed6bae93238ca8c4db8e43f173db052ef0"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"ac071df0866ec09b936313dc5cd024d0214ab65f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    token:"},{"line_number":69,"context_line":"    - for single-tenant store: glance service user credentials (auth_url,"},{"line_number":70,"context_line":"    domain, username, password, project)"},{"line_number":71,"context_line":"    - for multi-tenant store: trust id, glance service user credentials ("},{"line_number":72,"context_line":"    username, password)."},{"line_number":73,"context_line":"    After that ConnectionManager initializes and stores keystone client."},{"line_number":74,"context_line":"    *Note* If client cannot be created because of some reason then glance_store"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_1cd9d721","line":71,"range":{"start_line":71,"start_character":30,"end_line":71,"end_character":38},"updated":"2016-01-12 17:38:01.000000000","message":"Can we document where the trust id comes from?","commit_id":"dc6416ed6bae93238ca8c4db8e43f173db052ef0"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"fc457ad94922296aea60e28891542b7dd05f27d8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    token:"},{"line_number":69,"context_line":"    - for single-tenant store: glance service user credentials (auth_url,"},{"line_number":70,"context_line":"    domain, username, password, project)"},{"line_number":71,"context_line":"    - for multi-tenant store: trust id, glance service user credentials ("},{"line_number":72,"context_line":"    username, password)."},{"line_number":73,"context_line":"    After that ConnectionManager initializes and stores keystone client."},{"line_number":74,"context_line":"    *Note* If client cannot be created because of some reason then glance_store"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_a8ab80d5","line":71,"range":{"start_line":71,"start_character":30,"end_line":71,"end_character":38},"in_reply_to":"da6ed579_1cd9d721","updated":"2016-01-13 09:51:22.000000000","message":"Done","commit_id":"dc6416ed6bae93238ca8c4db8e43f173db052ef0"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"ac071df0866ec09b936313dc5cd024d0214ab65f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    *Note* \u0027will_expire_soon\u0027 used because glance_store might lose the data if"},{"line_number":87,"context_line":"    request to swiftclient fail with Unauthorized error. Unfortunately,"},{"line_number":88,"context_line":"    requests lib starts reading the data before checking the token so we cannot"},{"line_number":89,"context_line":"    retry the requests after failure."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"2. Download case."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_5cc2ef86","line":89,"range":{"start_line":89,"start_character":29,"end_line":89,"end_character":36},"updated":"2016-01-12 17:38:01.000000000","message":"More specifically, the requests library doesn\u0027t support 100-continue.","commit_id":"dc6416ed6bae93238ca8c4db8e43f173db052ef0"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"fc457ad94922296aea60e28891542b7dd05f27d8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    *Note* \u0027will_expire_soon\u0027 used because glance_store might lose the data if"},{"line_number":87,"context_line":"    request to swiftclient fail with Unauthorized error. Unfortunately,"},{"line_number":88,"context_line":"    requests lib starts reading the data before checking the token so we cannot"},{"line_number":89,"context_line":"    retry the requests after failure."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"2. Download case."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_289f90b5","line":89,"range":{"start_line":89,"start_character":29,"end_line":89,"end_character":36},"in_reply_to":"da6ed579_5cc2ef86","updated":"2016-01-13 09:51:22.000000000","message":"Added to the spec.","commit_id":"dc6416ed6bae93238ca8c4db8e43f173db052ef0"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"ac071df0866ec09b936313dc5cd024d0214ab65f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    connection. ConnectionManager stores the client in the same way as"},{"line_number":100,"context_line":"    described in step 1 of Upload case."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    2. In the case of unsuccessful download of the file, before the retry,"},{"line_number":103,"context_line":"    ConnectionManager checks if re-authentication is enabled and connection"},{"line_number":104,"context_line":"    token is going to expire soon. If the previous condition is true"},{"line_number":105,"context_line":"    ConnectionManager requests new token and returns new connection."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_47dbf87c","line":102,"range":{"start_line":102,"start_character":68,"end_line":102,"end_character":73},"updated":"2016-01-12 17:38:01.000000000","message":"Note that there is a new, native, swift client download retry:\n\nhttps://review.openstack.org/#/c/159208\n\nI was hoping we could switch to use that at some point. It means we could remove our glance-specific retry mechanism. Would it be possible to integrate with that?","commit_id":"dc6416ed6bae93238ca8c4db8e43f173db052ef0"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"fc457ad94922296aea60e28891542b7dd05f27d8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    connection. ConnectionManager stores the client in the same way as"},{"line_number":100,"context_line":"    described in step 1 of Upload case."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    2. In the case of unsuccessful download of the file, before the retry,"},{"line_number":103,"context_line":"    ConnectionManager checks if re-authentication is enabled and connection"},{"line_number":104,"context_line":"    token is going to expire soon. If the previous condition is true"},{"line_number":105,"context_line":"    ConnectionManager requests new token and returns new connection."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_ab0ffa2c","line":102,"range":{"start_line":102,"start_character":68,"end_line":102,"end_character":73},"in_reply_to":"da6ed579_47dbf87c","updated":"2016-01-13 09:51:22.000000000","message":"AFAIU you use the same connection for each retry iteration. That means that the token may expire when we will try to request the data again in swiftclient. So we will need to manage that in glance until retry body will provide a mechanism to update connection during each retry iteration.","commit_id":"dc6416ed6bae93238ca8c4db8e43f173db052ef0"}]}
