)]}'
{"specs/newton/approved/glance/centralize-configs.rst":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"d09cb731da2e931cf8b7a3bd96f05c92c4005456","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a061dce_757cbf72","side":"PARENT","updated":"2016-04-04 21:00:13.000000000","message":"Lite specs should all go into the `lite-specs` file so that they can be listed altogether under the same section. They are not meant to be put in separate files.","commit_id":"11712a947e7efade0e3368f622846ed1e538abb3"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"d09cb731da2e931cf8b7a3bd96f05c92c4005456","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    To assist the above refactoring, as a precursor, we want to centralize the"},{"line_number":21,"context_line":"    configuration options first. Having all the configuration options in one"},{"line_number":22,"context_line":"    central place makes it easier to refactor. Towards this , we are proposing"},{"line_number":23,"context_line":"    a similar change as mentioned in [1]."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    #. There will be a new package called ``glance/conf``."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a061dce_15ee2322","line":23,"updated":"2016-04-04 21:00:13.000000000","message":"I think it\u0027d be good to clarify the proposed solution won\u0027t change the current config files names `glance-api.conf`, `glance-registry.conf` etc.","commit_id":"943d9c618ee70ee2ec83ab5820a84865d221e5b9"}],"specs/newton/approved/glance/lite-specs.rst":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"cafd0a265745624546fb8b52cc6a994d01538150","unresolved":false,"context_lines":[{"line_number":35,"context_line":"+++++++++++++++"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Add your Spec Lite before this line"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Centralize Configuration Options in Glance and Glance Store"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_61cfe1b0","line":38,"updated":"2016-04-04 23:04:19.000000000","message":"Was this really that difficult?","commit_id":"319819d5663d17d8a04b9682092b095eea4c051f"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"b652c170a2d84988c04c25794ab2d600ef9e9769","unresolved":false,"context_lines":[{"line_number":35,"context_line":"+++++++++++++++"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Add your Spec Lite before this line"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Centralize Configuration Options in Glance and Glance Store"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_81b67588","line":38,"in_reply_to":"9a061dce_61cfe1b0","updated":"2016-04-04 23:41:05.000000000","message":"Yes!","commit_id":"319819d5663d17d8a04b9682092b095eea4c051f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"cafd0a265745624546fb8b52cc6a994d01538150","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    definition and usage are close to each other. However, this makes it"},{"line_number":48,"context_line":"    difficult to get a consolidated view of all the configuration options as"},{"line_number":49,"context_line":"    they are littered all over the codebase. This makes refactoring of"},{"line_number":50,"context_line":"    configuration options, discussed in the cross-poject spec [0], harder."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":":solution:"},{"line_number":53,"context_line":"    To assist the above refactoring, as a precursor, we want to centralize the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_a179f931","line":50,"updated":"2016-04-04 23:04:19.000000000","message":"Hmm-m, I need to read that x-proj spec again and comment in there, but personally I think there is now two things mixed together.\n\nThere is the conde that defines the config options. This part _is_ for developers, like stated in the x-proj spec and so many more discussion general public should not need to crawl through the code to figure out the config options. So lets not encourage that by making it \"easy\" to point out towards the code base.\n\nThe example config files and documentation is there to aid the deployer/operator/etc. to understand the config options. That is the part we need to improve if we want to make life easier for the \"general public\".\n\nNova might have totally different needs than we do already based on the fact that they deploy mainly just single config file affecting everything Nova while we do provide config files for each individual component.\n\nAs it is currently I have problem understanding/agreeing with the problem description reflected to Glance and even more agreeing on taking refactoring for work that has not agreed on.","commit_id":"319819d5663d17d8a04b9682092b095eea4c051f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6a35c5424f7f7da5b15aa4ff800b44d1293b94b8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    definition and usage are close to each other. However, this makes it"},{"line_number":48,"context_line":"    difficult to get a consolidated view of all the configuration options as"},{"line_number":49,"context_line":"    they are littered all over the codebase. This makes refactoring of"},{"line_number":50,"context_line":"    configuration options, discussed in the cross-poject spec [0], harder."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":":solution:"},{"line_number":53,"context_line":"    To assist the above refactoring, as a precursor, we want to centralize the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_48abdd74","line":50,"in_reply_to":"9a061dce_45ef48e8","updated":"2016-04-05 00:18:29.000000000","message":"I really hate that Nova is time after time referred as OpenStack community in whole. ;)","commit_id":"319819d5663d17d8a04b9682092b095eea4c051f"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"93763921e06c770750dee68c126475ceaf8c9b28","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    definition and usage are close to each other. However, this makes it"},{"line_number":48,"context_line":"    difficult to get a consolidated view of all the configuration options as"},{"line_number":49,"context_line":"    they are littered all over the codebase. This makes refactoring of"},{"line_number":50,"context_line":"    configuration options, discussed in the cross-poject spec [0], harder."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":":solution:"},{"line_number":53,"context_line":"    To assist the above refactoring, as a precursor, we want to centralize the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_a82b99ea","line":50,"in_reply_to":"9a061dce_48abdd74","updated":"2016-04-05 03:26:58.000000000","message":"Maybe I should have mentioned clearly, but I was referring to the discussion on the cross-project spec. Let\u0027s see the how that spec evolves.","commit_id":"319819d5663d17d8a04b9682092b095eea4c051f"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"b652c170a2d84988c04c25794ab2d600ef9e9769","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    definition and usage are close to each other. However, this makes it"},{"line_number":48,"context_line":"    difficult to get a consolidated view of all the configuration options as"},{"line_number":49,"context_line":"    they are littered all over the codebase. This makes refactoring of"},{"line_number":50,"context_line":"    configuration options, discussed in the cross-poject spec [0], harder."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":":solution:"},{"line_number":53,"context_line":"    To assist the above refactoring, as a precursor, we want to centralize the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_45ef48e8","line":50,"in_reply_to":"9a061dce_a179f931","updated":"2016-04-04 23:41:05.000000000","message":"This change, like I mentioned, is a precursor to improving the documentation and later categorizing the config options. Having all config options in a centralized location in code just make it that much easier. Also, it looks we, as a community, are converging on the idea that maintaining, improving and deprecating the config options is a tad easy if all of them can be found in one place.\n\nThis effort is NOT done keeping the operator in mind. This is solely for developers and intended to make developers\u0027 life easy to maintain the config options.","commit_id":"319819d5663d17d8a04b9682092b095eea4c051f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"cafd0a265745624546fb8b52cc6a994d01538150","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"#. All ``CONF.import_opt(...)`` calls get removed from the functional modules"},{"line_number":72,"context_line":"   as they don\u0027t serve their purpose anymore. That\u0027s because after the import"},{"line_number":73,"context_line":"   of ``glance.conf``, all config options will be available."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"#. All ``CONF.register_opts(...)`` calls get moved to the modules"},{"line_number":76,"context_line":"   ``glance/conf/\u003cmodule-name\u003e.py``. By that these modules can control"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_01aee584","line":73,"updated":"2016-04-04 23:04:19.000000000","message":"If the proposal here is again trying to move to single config file for Glance I\u0027m 100% against it so far. Please convince me.","commit_id":"319819d5663d17d8a04b9682092b095eea4c051f"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"b652c170a2d84988c04c25794ab2d600ef9e9769","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"#. All ``CONF.import_opt(...)`` calls get removed from the functional modules"},{"line_number":72,"context_line":"   as they don\u0027t serve their purpose anymore. That\u0027s because after the import"},{"line_number":73,"context_line":"   of ``glance.conf``, all config options will be available."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"#. All ``CONF.register_opts(...)`` calls get moved to the modules"},{"line_number":76,"context_line":"   ``glance/conf/\u003cmodule-name\u003e.py``. By that these modules can control"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_61bb6173","line":73,"in_reply_to":"9a061dce_01aee584","updated":"2016-04-04 23:41:05.000000000","message":"I don\u0027t see any need for any convincing here because the proposal is NOT about moving configs to a single file. As mentioned in the impacts section, there won\u0027t be any change whatsoever to the config files. \n\nHere we are talking about importing ``glance.conf``, which is the one centralized module where all config options are going to live.","commit_id":"319819d5663d17d8a04b9682092b095eea4c051f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6a35c5424f7f7da5b15aa4ff800b44d1293b94b8","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"#. All ``CONF.import_opt(...)`` calls get removed from the functional modules"},{"line_number":72,"context_line":"   as they don\u0027t serve their purpose anymore. That\u0027s because after the import"},{"line_number":73,"context_line":"   of ``glance.conf``, all config options will be available."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"#. All ``CONF.register_opts(...)`` calls get moved to the modules"},{"line_number":76,"context_line":"   ``glance/conf/\u003cmodule-name\u003e.py``. By that these modules can control"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_c8b08df7","line":73,"in_reply_to":"9a061dce_61bb6173","updated":"2016-04-05 00:18:29.000000000","message":"Thanks, misunderstood the point, fortunately. :)","commit_id":"319819d5663d17d8a04b9682092b095eea4c051f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"cafd0a265745624546fb8b52cc6a994d01538150","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    * Use data files to provide configuration options to the operator."},{"line_number":109,"context_line":"        The concern is that if not side-by-side with the code, this would not"},{"line_number":110,"context_line":"        be updated as frequently as the options themselves will be."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    * Use a global object to control access to the ``CONF`` object."},{"line_number":113,"context_line":"        This would allow for a number of things - testability, cleaner code,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a061dce_01c5453b","line":110,"updated":"2016-04-04 23:04:19.000000000","message":"Isn\u0027t this exactly what the example configs are for?","commit_id":"319819d5663d17d8a04b9682092b095eea4c051f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"27701d3530091146d50468f394909bbdf512e850","unresolved":false,"context_lines":[{"line_number":49,"context_line":":solution:"},{"line_number":50,"context_line":"    To assist the above refactoring, as a precursor, we want to centralize the"},{"line_number":51,"context_line":"    configuration options first. Having all the configuration options in one"},{"line_number":52,"context_line":"    central place makes it easier to refactor. Towards this , we are proposing"},{"line_number":53,"context_line":"    a similar change as mentioned in [1]."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    #. There will be a new package called ``glance/conf``."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a1b2928_105e43e9","line":52,"range":{"start_line":52,"start_character":59,"end_line":52,"end_character":60},"updated":"2016-04-11 13:43:04.000000000","message":"nit: unnecessary space","commit_id":"06a6cecf487ba2720f1d999121503fe1e0cd8a0a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"27701d3530091146d50468f394909bbdf512e850","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   * [...]"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#. All ``CONF.import_opt(...)`` calls get removed from the functional modules"},{"line_number":69,"context_line":"   as they don\u0027t serve their purpose anymore. That\u0027s because after the import"},{"line_number":70,"context_line":"   of ``glance.conf``, all config options will be available."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#. All ``CONF.register_opts(...)`` calls get moved to the modules"},{"line_number":73,"context_line":"   ``glance/conf/\u003cmodule-name\u003e.py``. By that these modules can control"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a1b2928_50127b63","line":70,"range":{"start_line":69,"start_character":46,"end_line":70,"end_character":60},"updated":"2016-04-11 13:43:04.000000000","message":"This worries me a bit, but this is probably an issue to discuss on the cross-project spec, not this one.  It just gives me an uneasy feeling that we\u0027re breaking encapsulation.  Currently, a module only has access to its own configuration options.  Now it has easy access to all options.  I\u0027m just wondering whether this is going to encourage coupling among modules.","commit_id":"06a6cecf487ba2720f1d999121503fe1e0cd8a0a"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"44d8ee7097d53fbbf9a7623a9c1d37816d77d444","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   * [...]"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#. All ``CONF.import_opt(...)`` calls get removed from the functional modules"},{"line_number":69,"context_line":"   as they don\u0027t serve their purpose anymore. That\u0027s because after the import"},{"line_number":70,"context_line":"   of ``glance.conf``, all config options will be available."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#. All ``CONF.register_opts(...)`` calls get moved to the modules"},{"line_number":73,"context_line":"   ``glance/conf/\u003cmodule-name\u003e.py``. By that these modules can control"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a1b2928_5a256ea9","line":70,"range":{"start_line":69,"start_character":46,"end_line":70,"end_character":60},"in_reply_to":"7a1b2928_50127b63","updated":"2016-04-11 16:08:09.000000000","message":"+1\nThis is a valid concern and it has been discussed quite a bit on the dev list [0]. It\u0027s been mentioned as one of the alternatives on the nova-spec[1] as well. Essentially, like you said, encapsulation is desired and there\u0027s no denying that. Before we make progress on how to get there, this is an intermediate step to improve the config options as mentioned in the cross-project spec.\n\n\n[0] http://lists.openstack.org/pipermail/openstack-dev/2015-\nJuly/070453.html\n[1] http://specs.openstack.org/openstack/nova-specs/specs/mitaka/implemented/centralize-config-options.html#alternatives","commit_id":"06a6cecf487ba2720f1d999121503fe1e0cd8a0a"}]}