)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"cdc984d9790b0e67c7c6fde9e1c873217247f149","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dharini Chandrasekar \u003cdharini.chandrasekar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-09 19:32:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" 1 Return 409 if removing/replacing image locations."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently image location updates (removing, replacing) are permitted for"},{"line_number":10,"context_line":"images even if their state is not ``active``."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_9baa6884","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2016-09-09 19:34:36.000000000","message":"eh .. cruft","commit_id":"0cdfc994337dfd1bde88fe60abbc4fc8e7428953"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"cdc984d9790b0e67c7c6fde9e1c873217247f149","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This lite-spec describes the need to prevent removal and replacement of image"},{"line_number":12,"context_line":"locations of images that are not in ``active`` by returning a Conflict Error"},{"line_number":13,"context_line":"(409 response code)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6d984fcafa49ad806dce2bd56abcee66fdc77525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_1b9f3860","line":14,"updated":"2016-09-09 19:34:36.000000000","message":"see my comment on previous PS about all the updates needed on the CM","commit_id":"0cdfc994337dfd1bde88fe60abbc4fc8e7428953"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"0b3fa77742ec3741f791cc4e654a4aed9ccb80ed","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This lite-spec describes the need to prevent removal and replacement of image"},{"line_number":12,"context_line":"locations of images that are not in ``active`` by returning a Conflict Error"},{"line_number":13,"context_line":"(409 response code)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6d984fcafa49ad806dce2bd56abcee66fdc77525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_5b8e2028","line":14,"in_reply_to":"9a89bdaa_1b9f3860","updated":"2016-09-09 19:35:54.000000000","message":"duh.. ignore that. Friday evening \u003d\u003d poor reviews ( I was thinking this is openstack/glance (not glance-specs)!","commit_id":"0cdfc994337dfd1bde88fe60abbc4fc8e7428953"}],"specs/newton/approved/glance/lite-specs.rst":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"394ca85461d90e585378b8baa77066a526976243","unresolved":false,"context_lines":[{"line_number":62,"context_line":"-------------------------------------------------------------------------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":":problem: When ``show_multiple_locations`` is activated, users currently can"},{"line_number":65,"context_line":"          remove or replace locations to an image irrespective of the image"},{"line_number":66,"context_line":"          status."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":":solution: Return Conflict Error (409 response code) if an attempt to remove"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a89bdaa_177c6c71","line":65,"range":{"start_line":65,"start_character":38,"end_line":65,"end_character":40},"updated":"2016-09-09 19:50:02.000000000","message":"nit: s/to/for/ or s/to/of/","commit_id":"f1d695b11f79a3d3a16f82a7423c5f2d974368e9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"030ee59a8dcc93029e5240aa149bcd3a70a8e6f5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"-------------------------------------------------------------------------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":":problem: When ``show_multiple_locations`` is activated, users currently can"},{"line_number":65,"context_line":"          remove or replace locations to an image irrespective of the image"},{"line_number":66,"context_line":"          status."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":":solution: Return Conflict Error (409 response code) if an attempt to remove"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a89bdaa_d7b5a4d0","line":65,"range":{"start_line":65,"start_character":38,"end_line":65,"end_character":40},"in_reply_to":"9a89bdaa_177c6c71","updated":"2016-09-09 19:57:45.000000000","message":"Done","commit_id":"f1d695b11f79a3d3a16f82a7423c5f2d974368e9"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"394ca85461d90e585378b8baa77066a526976243","unresolved":false,"context_lines":[{"line_number":66,"context_line":"          status."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":":solution: Return Conflict Error (409 response code) if an attempt to remove"},{"line_number":69,"context_line":"           or replace the image location is done when the status of the image"},{"line_number":70,"context_line":"           is anything but ``active``."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":":impacts: A Conflict Error will be thrown preventing users from replacing or"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a89bdaa_97907c97","line":69,"range":{"start_line":69,"start_character":44,"end_line":69,"end_character":48},"updated":"2016-09-09 19:50:02.000000000","message":"nit: s/done/made/","commit_id":"f1d695b11f79a3d3a16f82a7423c5f2d974368e9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"030ee59a8dcc93029e5240aa149bcd3a70a8e6f5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"          status."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":":solution: Return Conflict Error (409 response code) if an attempt to remove"},{"line_number":69,"context_line":"           or replace the image location is done when the status of the image"},{"line_number":70,"context_line":"           is anything but ``active``."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":":impacts: A Conflict Error will be thrown preventing users from replacing or"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a89bdaa_f7b8e8c9","line":69,"range":{"start_line":69,"start_character":44,"end_line":69,"end_character":48},"in_reply_to":"9a89bdaa_97907c97","updated":"2016-09-09 19:57:45.000000000","message":"Done","commit_id":"f1d695b11f79a3d3a16f82a7423c5f2d974368e9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2351e8a072af1540ecb6307bf1e143c540033358","unresolved":false,"context_lines":[{"line_number":70,"context_line":"           is anything but ``active``."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":":impacts: A Conflict Error will be thrown preventing users from replacing or"},{"line_number":73,"context_line":"         removing locations to images when the image status is not ``active``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":":timeline: Expected to be merged within the newton-rc time frame."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a89bdaa_573a74ce","line":73,"updated":"2016-09-09 19:47:11.000000000","message":"indentation is one ws behind. also, this line will wrap when corrected.","commit_id":"f1d695b11f79a3d3a16f82a7423c5f2d974368e9"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"030ee59a8dcc93029e5240aa149bcd3a70a8e6f5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"           is anything but ``active``."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":":impacts: A Conflict Error will be thrown preventing users from replacing or"},{"line_number":73,"context_line":"         removing locations to images when the image status is not ``active``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":":timeline: Expected to be merged within the newton-rc time frame."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a89bdaa_17b0ecdc","line":73,"in_reply_to":"9a89bdaa_573a74ce","updated":"2016-09-09 19:57:45.000000000","message":"Done","commit_id":"f1d695b11f79a3d3a16f82a7423c5f2d974368e9"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"5152a41a4b3a17a77144aa1b8cb90c67a84773d4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Return 409 if removing/replacing the location of an image that\u0027s not ``active``"},{"line_number":62,"context_line":"-------------------------------------------------------------------------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":":problem: When ``show_multiple_locations`` is activated, users currently can"},{"line_number":65,"context_line":"          remove or replace locations of an image irrespective of the image"},{"line_number":66,"context_line":"          status."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a89bdaa_37b9707a","line":64,"range":{"start_line":64,"start_character":46,"end_line":64,"end_character":55},"updated":"2016-09-09 20:05:21.000000000","message":"I think we need to correct it above too, but this should read as\n\n  ``show_multiple_locations`` is set to True\n\nnot a big deal atm (given it\u0027s the way it is above)","commit_id":"591f858902acbc5f1348e4c5347254546209ed98"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"bcd8b710fdd396d573b6878d4022f1054541da03","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Return 409 if removing/replacing the location of an image that\u0027s not ``active``"},{"line_number":62,"context_line":"-------------------------------------------------------------------------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":":problem: When ``show_multiple_locations`` is activated, users currently can"},{"line_number":65,"context_line":"          remove or replace locations of an image irrespective of the image"},{"line_number":66,"context_line":"          status."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_0ceeeeb3","line":64,"range":{"start_line":64,"start_character":46,"end_line":64,"end_character":55},"in_reply_to":"9a89bdaa_37b9707a","updated":"2016-10-20 00:53:35.000000000","message":"Done","commit_id":"591f858902acbc5f1348e4c5347254546209ed98"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"47e0220d0e223183f8c6007588dd01863d0aebf4","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":":problem: When ``show_multiple_locations`` is activated, users currently can"},{"line_number":65,"context_line":"          remove or replace locations of an image irrespective of the image"},{"line_number":66,"context_line":"          status."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":":solution: Return Conflict Error (409 response code) if an attempt to remove"},{"line_number":69,"context_line":"           or replace the image location is made when the status of the image"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_9344e11b","line":66,"updated":"2016-10-19 21:37:59.000000000","message":"I think you should use part of the commit message on your patch to explain why this is a problem.","commit_id":"591f858902acbc5f1348e4c5347254546209ed98"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"bcd8b710fdd396d573b6878d4022f1054541da03","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":":problem: When ``show_multiple_locations`` is activated, users currently can"},{"line_number":65,"context_line":"          remove or replace locations of an image irrespective of the image"},{"line_number":66,"context_line":"          status."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":":solution: Return Conflict Error (409 response code) if an attempt to remove"},{"line_number":69,"context_line":"           or replace the image location is made when the status of the image"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_ecf29a99","line":66,"in_reply_to":"fa6399be_9344e11b","updated":"2016-10-20 00:53:35.000000000","message":"Done","commit_id":"591f858902acbc5f1348e4c5347254546209ed98"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b749a0b25a9f15998c55237459863c70dfb9c692","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":":solution: Return Conflict Error (409 response code) if an attempt to remove"},{"line_number":82,"context_line":"           or replace the image location is made when the status of the image"},{"line_number":83,"context_line":"           is anything but ``active``."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":":impacts: A Conflict Error will be thrown preventing users from replacing or"},{"line_number":86,"context_line":"          removing locations to images when the image status is not ``active``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a77a97e_5c4703bb","line":83,"updated":"2016-11-15 17:25:39.000000000","message":"I\u0027m missing something here ... how does this proposal square with #2 above, where you say about status\u003d\u003dqueued \"However users can be allowed to replace the image location to maintain backward compatibility and also because replacing could mean replacing an empty location by a non-empty image location\"?","commit_id":"fced831864306f8703dcb820e2fb54062ebffec6"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2f6e34c582a29b9821fc3df9d8ce307221965f99","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":":solution: Return Conflict Error (409 response code) if an attempt to remove"},{"line_number":82,"context_line":"           or replace the image location is made when the status of the image"},{"line_number":83,"context_line":"           is anything but ``active``."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":":impacts: A Conflict Error will be thrown preventing users from replacing or"},{"line_number":86,"context_line":"          removing locations to images when the image status is not ``active``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a77a97e_3756e0d2","line":83,"in_reply_to":"7a77a97e_5c4703bb","updated":"2016-11-15 17:58:25.000000000","message":"Thanks for pointing this out Brian. This needs to be edited to separately address ``replace`` and ``remove`` for image locations.","commit_id":"fced831864306f8703dcb820e2fb54062ebffec6"}]}
