)]}'
{"specs/pike/approved/glance/lite-specs.rst":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d4448bdf49cc3b1d3cff58b794753366ff6c2c78","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Support random image access from cache"},{"line_number":107,"context_line":"--------------------------------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":":problem: When a request for a random image access (partial download) is"},{"line_number":110,"context_line":"          obtained with cache enabled, glance cache does not serve the image"},{"line_number":111,"context_line":"          from cache irrespective of whether the image is cached or not. The"},{"line_number":112,"context_line":"          request proceeds to the glance root app every time."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":":solution: Teach glance cahce to do the following: 1) If the image is already"},{"line_number":115,"context_line":"           cached, serve the requested bytes alone from cache. 2) If the image"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_4e9a8d14","line":112,"range":{"start_line":109,"start_character":10,"end_line":112,"end_character":61},"updated":"2017-03-31 22:08:45.000000000","message":"We didn\u0027t merge this https://review.openstack.org/#/c/434558\nSo, this isn\u0027t true yet.","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"8200d985a374b60a3150dbd98b89fd133679f7da","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Support random image access from cache"},{"line_number":107,"context_line":"--------------------------------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":":problem: When a request for a random image access (partial download) is"},{"line_number":110,"context_line":"          obtained with cache enabled, glance cache does not serve the image"},{"line_number":111,"context_line":"          from cache irrespective of whether the image is cached or not. The"},{"line_number":112,"context_line":"          request proceeds to the glance root app every time."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":":solution: Teach glance cahce to do the following: 1) If the image is already"},{"line_number":115,"context_line":"           cached, serve the requested bytes alone from cache. 2) If the image"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_67ffe167","line":112,"range":{"start_line":109,"start_character":10,"end_line":112,"end_character":61},"in_reply_to":"dfeb2761_4e9a8d14","updated":"2017-04-05 15:44:12.000000000","message":"Sure Hemanth. I needed that to go in for this lite-spec.","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4b31fcf8c19327a072ac4e2024645feadcc24650","unresolved":false,"context_lines":[{"line_number":111,"context_line":"          from cache irrespective of whether the image is cached or not. The"},{"line_number":112,"context_line":"          request proceeds to the glance root app every time."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":":solution: Teach glance cahce to do the following: 1) If the image is already"},{"line_number":115,"context_line":"           cached, serve the requested bytes alone from cache. 2) If the image"},{"line_number":116,"context_line":"           is not cached, cache the entire image, but serve the requested bytes"},{"line_number":117,"context_line":"           from the store via the glance root app. (tee-iterator like behavior)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_b26400bb","line":114,"range":{"start_line":114,"start_character":24,"end_line":114,"end_character":29},"updated":"2017-03-31 03:36:39.000000000","message":"\"cache\"","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"98b35753859ee8e505ea0f56eae65208659774ea","unresolved":false,"context_lines":[{"line_number":111,"context_line":"          from cache irrespective of whether the image is cached or not. The"},{"line_number":112,"context_line":"          request proceeds to the glance root app every time."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":":solution: Teach glance cahce to do the following: 1) If the image is already"},{"line_number":115,"context_line":"           cached, serve the requested bytes alone from cache. 2) If the image"},{"line_number":116,"context_line":"           is not cached, cache the entire image, but serve the requested bytes"},{"line_number":117,"context_line":"           from the store via the glance root app. (tee-iterator like behavior)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_ec03c90e","line":114,"range":{"start_line":114,"start_character":24,"end_line":114,"end_character":29},"in_reply_to":"dfeb2761_b26400bb","updated":"2017-04-05 21:24:33.000000000","message":"Done","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4b31fcf8c19327a072ac4e2024645feadcc24650","unresolved":false,"context_lines":[{"line_number":114,"context_line":":solution: Teach glance cahce to do the following: 1) If the image is already"},{"line_number":115,"context_line":"           cached, serve the requested bytes alone from cache. 2) If the image"},{"line_number":116,"context_line":"           is not cached, cache the entire image, but serve the requested bytes"},{"line_number":117,"context_line":"           from the store via the glance root app. (tee-iterator like behavior)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":":impacts: Users trying partial downloads with cache enabled will experience"},{"line_number":120,"context_line":"          better performance as we avoid a fetch from the store."}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_f273a84c","line":117,"updated":"2017-03-31 03:36:39.000000000","message":"The problem I see with this is that since the cache isn\u0027t shared among glance nodes, you could have a situation where the request for bytes 500-999 hits a different glance node than the initial request for bytes 0-499 did, so the image is not in the cache *and* we can\u0027t use a tee because we don\u0027t want to send bytes 0-499 in the response to the second request.  So it looks like we need to load the image into the cache first and then return the bytes to the requester.  So I wonder about the performance improvement here.","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"d4448bdf49cc3b1d3cff58b794753366ff6c2c78","unresolved":false,"context_lines":[{"line_number":112,"context_line":"          request proceeds to the glance root app every time."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":":solution: Teach glance cahce to do the following: 1) If the image is already"},{"line_number":115,"context_line":"           cached, serve the requested bytes alone from cache. 2) If the image"},{"line_number":116,"context_line":"           is not cached, cache the entire image, but serve the requested bytes"},{"line_number":117,"context_line":"           from the store via the glance root app. (tee-iterator like behavior)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":":impacts: Users trying partial downloads with cache enabled will experience"},{"line_number":120,"context_line":"          better performance as we avoid a fetch from the store."}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_0ebda564","line":117,"range":{"start_line":115,"start_character":63,"end_line":117,"end_character":79},"updated":"2017-03-31 22:08:45.000000000","message":"Why do we want to do this? #2 is out of scope for this lite-spec. Just doing #1 in cache middleware should be enough as it serves the purpose of a cache. \n\n#2 is not the function of a cache as I see it. Image cache should serve an image only if the image exists in cache.","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"98b35753859ee8e505ea0f56eae65208659774ea","unresolved":false,"context_lines":[{"line_number":112,"context_line":"          request proceeds to the glance root app every time."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":":solution: Teach glance cahce to do the following: 1) If the image is already"},{"line_number":115,"context_line":"           cached, serve the requested bytes alone from cache. 2) If the image"},{"line_number":116,"context_line":"           is not cached, cache the entire image, but serve the requested bytes"},{"line_number":117,"context_line":"           from the store via the glance root app. (tee-iterator like behavior)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":":impacts: Users trying partial downloads with cache enabled will experience"},{"line_number":120,"context_line":"          better performance as we avoid a fetch from the store."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_c7fe9e04","line":117,"range":{"start_line":115,"start_character":63,"end_line":117,"end_character":79},"in_reply_to":"bff0334d_467614db","updated":"2017-04-05 21:24:33.000000000","message":"I agree. I think we can wait till eliminate redundant downloads spec is implemented for this use case.","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"df6bb8117ed5aae5ad8acc54f4cf58eebae1e97c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"          request proceeds to the glance root app every time."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":":solution: Teach glance cahce to do the following: 1) If the image is already"},{"line_number":115,"context_line":"           cached, serve the requested bytes alone from cache. 2) If the image"},{"line_number":116,"context_line":"           is not cached, cache the entire image, but serve the requested bytes"},{"line_number":117,"context_line":"           from the store via the glance root app. (tee-iterator like behavior)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":":impacts: Users trying partial downloads with cache enabled will experience"},{"line_number":120,"context_line":"          better performance as we avoid a fetch from the store."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_467614db","line":117,"range":{"start_line":115,"start_character":63,"end_line":117,"end_character":79},"in_reply_to":"bff0334d_c7b46d38","updated":"2017-04-05 20:40:00.000000000","message":"Sure, but we don\u0027t know how often partial image downloads are used. Let\u0027s do it when we have a case for it.","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"8200d985a374b60a3150dbd98b89fd133679f7da","unresolved":false,"context_lines":[{"line_number":112,"context_line":"          request proceeds to the glance root app every time."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":":solution: Teach glance cahce to do the following: 1) If the image is already"},{"line_number":115,"context_line":"           cached, serve the requested bytes alone from cache. 2) If the image"},{"line_number":116,"context_line":"           is not cached, cache the entire image, but serve the requested bytes"},{"line_number":117,"context_line":"           from the store via the glance root app. (tee-iterator like behavior)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":":impacts: Users trying partial downloads with cache enabled will experience"},{"line_number":120,"context_line":"          better performance as we avoid a fetch from the store."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_c7b46d38","line":117,"range":{"start_line":115,"start_character":63,"end_line":117,"end_character":79},"in_reply_to":"dfeb2761_0ebda564","updated":"2017-04-05 15:44:12.000000000","message":"Hemanth and Brian:\nI had included 2, to allow the first partial image download trigger the caching of the full image just like a first full image download already does. That way, any subsequent request for that image (full or partial) can be served from cache.\n\nJust doing 1 would mean that only the full image download will cause caching. So, if there are 100 partial download requests and no full image download request at all, without doing 2, all 100 will proceed to glance root app. Which I felt was not a good idea.\n\nWe can limit to 1 if you guy think that it is the scope of this lite-spec.","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"8200d985a374b60a3150dbd98b89fd133679f7da","unresolved":false,"context_lines":[{"line_number":114,"context_line":":solution: Teach glance cahce to do the following: 1) If the image is already"},{"line_number":115,"context_line":"           cached, serve the requested bytes alone from cache. 2) If the image"},{"line_number":116,"context_line":"           is not cached, cache the entire image, but serve the requested bytes"},{"line_number":117,"context_line":"           from the store via the glance root app. (tee-iterator like behavior)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":":impacts: Users trying partial downloads with cache enabled will experience"},{"line_number":120,"context_line":"          better performance as we avoid a fetch from the store."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_4713bd0e","line":117,"in_reply_to":"dfeb2761_f273a84c","updated":"2017-04-05 15:44:12.000000000","message":"Brian, since we cache the full image after the first request (0-499) comes, when the second request comes and the image is not in cache, it will also trigger a caching of the image but the requested bytes (500-999) will be served from the root app. (this is what we do currently).\n\nHowever if the second request came a little later, the image already would be in cache cos the first (0-499) request triggered the caching of the entire image and would be served from cache.","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4b31fcf8c19327a072ac4e2024645feadcc24650","unresolved":false,"context_lines":[{"line_number":119,"context_line":":impacts: Users trying partial downloads with cache enabled will experience"},{"line_number":120,"context_line":"          better performance as we avoid a fetch from the store."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":":timeline: Pike-1"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":":assignee: dharinic"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_524a5427","line":122,"range":{"start_line":122,"start_character":11,"end_line":122,"end_character":17},"updated":"2017-03-31 03:36:39.000000000","message":"would be P-2 at the earliest.","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"98b35753859ee8e505ea0f56eae65208659774ea","unresolved":false,"context_lines":[{"line_number":119,"context_line":":impacts: Users trying partial downloads with cache enabled will experience"},{"line_number":120,"context_line":"          better performance as we avoid a fetch from the store."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":":timeline: Pike-1"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":":assignee: dharinic"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_071c8668","line":122,"range":{"start_line":122,"start_character":11,"end_line":122,"end_character":17},"in_reply_to":"dfeb2761_524a5427","updated":"2017-04-05 21:24:33.000000000","message":"Done","commit_id":"5b8d64e47ef662da66d6234b35873b3b3afbeb9d"}]}
