)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b0c8f1875da22f9131613415acd41c44565f6eca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Artem Tiumentcev \u003cdarland.maik@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-27 12:09:47 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SPEC] Add basic quotas"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"APIImpact"},{"line_number":10,"context_line":"Change-Id: If5794672b6d652f13a18cb22e1871cf4580cc99f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_95988b6a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2017-10-05 14:56:55.000000000","message":"you don\u0027t need to write spec here, it\u0027s in the spec repo","commit_id":"38c0c10bb63ec0bacea27bf21c39019dd85b65cf"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b0c8f1875da22f9131613415acd41c44565f6eca","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SPEC] Add basic quotas"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"APIImpact"},{"line_number":10,"context_line":"Change-Id: If5794672b6d652f13a18cb22e1871cf4580cc99f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_359d5757","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":9},"updated":"2017-10-05 14:56:55.000000000","message":"no need, make sure you do have it for the respective glance/client commits","commit_id":"38c0c10bb63ec0bacea27bf21c39019dd85b65cf"}],"specs/queens/approved/glance/glance-basic-quotas.rst":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b0c8f1875da22f9131613415acd41c44565f6eca","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Add four following quota resources:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* total_images_number"},{"line_number":31,"context_line":"* total_images_size"},{"line_number":32,"context_line":"* total_snapshots_number"},{"line_number":33,"context_line":"* total_snapshots_size"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_b8d49e48","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":21},"updated":"2017-10-05 14:56:55.000000000","message":"either here or later, please explain:\n\n1. what do these terms mean\n2. what are the defaults \"glance\" will know or will set by default (it could also mean\n3. what do you limit these values on, per tenant / user and what happens when user is tenant","commit_id":"38c0c10bb63ec0bacea27bf21c39019dd85b65cf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0913e3fadc5d2b3604fa02f4b27e29bb058e980f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* total_images_size"},{"line_number":32,"context_line":"* total_snapshots_number"},{"line_number":33,"context_line":"* total_snapshots_size"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"And following new APIs:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* quota-class-show \u003cresource_name\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df3967d1_240ad5d1","line":34,"updated":"2017-07-31 21:15:17.000000000","message":"How do you propose distinguishing \"snapshots\" from \"images\"?","commit_id":"38c0c10bb63ec0bacea27bf21c39019dd85b65cf"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b0c8f1875da22f9131613415acd41c44565f6eca","unresolved":false,"context_lines":[{"line_number":32,"context_line":"* total_snapshots_number"},{"line_number":33,"context_line":"* total_snapshots_size"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"And following new APIs:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* quota-class-show \u003cresource_name\u003e"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_f867b6b6","line":35,"range":{"start_line":35,"start_character":18,"end_line":35,"end_character":23},"updated":"2017-10-05 14:56:55.000000000","message":"let\u0027s call these features or functionalities (not the APIs). what you started documenting below (REST API impact) is good representation of the APIs","commit_id":"38c0c10bb63ec0bacea27bf21c39019dd85b65cf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0913e3fadc5d2b3604fa02f4b27e29bb058e980f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* total_snapshots_size"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"And following new APIs:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* quota-class-show \u003cresource_name\u003e"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  This API allows to read default values for resource quotas that are applied"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df3967d1_24bd35b7","line":36,"updated":"2017-07-31 21:15:17.000000000","message":"If you haven\u0027t already, it would be good to check what the API working group suggests for this type of API and make sure what you\u0027re proposing is aligned with their aspirations for OpenStack APIs.  Also, it would be good to see whether your proposal aligns with what other OpenStack APIs do.  For example, it looks like both the Compute and Block-Storage APIs use \u0027quota-sets\u0027 instead of \u0027quota-classes\u0027.","commit_id":"38c0c10bb63ec0bacea27bf21c39019dd85b65cf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0913e3fadc5d2b3604fa02f4b27e29bb058e980f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Data model impact"},{"line_number":93,"context_line":"-----------------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Following new DB models will be added:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* quotas"},{"line_number":98,"context_line":"* quota_classes"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df3967d1_c488a9c7","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":38},"updated":"2017-07-31 21:15:17.000000000","message":"You\u0027ll need to see what the status of the \"Unified Limits\" work is:\nhttps://specs.openstack.org/openstack/keystone-specs/specs/keystone/ongoing/unified-limits.html\n\nHere\u0027s the patch for that spec in case the discussion on it is useful:\nhttps://review.openstack.org/#/c/440815/\n\nMy impression is that the idea is that Keystone will store the limits, and all we\u0027ll have to do is calculate current usage and compare to the limit to decide whether a user is over quota or not.  So maybe we don\u0027t need any database work?\n\nIn any case, we want to make sure whatever we do in Glance is consistent with the Unified Limits work, because that\u0027s the direction OpenStack is taking.","commit_id":"38c0c10bb63ec0bacea27bf21c39019dd85b65cf"},{"author":{"_account_id":26734,"name":"Scott McClymont","email":"scott.mcclymont@verizonwireless.com","username":"smcclymont"},"change_message_id":"44e3378a5649fd735bfa236e08978b0f3cc773b7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Data model impact"},{"line_number":93,"context_line":"-----------------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Following new DB models will be added:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* quotas"},{"line_number":98,"context_line":"* quota_classes"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_07619fd3","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":38},"in_reply_to":"df3967d1_c488a9c7","updated":"2017-10-25 12:54:38.000000000","message":"Do we have any additional information on what these data models might look like when they are implemented with this spec?","commit_id":"38c0c10bb63ec0bacea27bf21c39019dd85b65cf"},{"author":{"_account_id":26734,"name":"Scott McClymont","email":"scott.mcclymont@verizonwireless.com","username":"smcclymont"},"change_message_id":"44e3378a5649fd735bfa236e08978b0f3cc773b7","unresolved":false,"context_lines":[{"line_number":181,"context_line":"Other deployer impact"},{"line_number":182,"context_line":"---------------------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Deployer will \"be able\"/\"need\" to define default quotas."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Developer impact"},{"line_number":187,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_273ffbb4","line":184,"updated":"2017-10-25 12:54:38.000000000","message":"I would clear this up, it will likely be required in order to function as listed in this spec correct?","commit_id":"38c0c10bb63ec0bacea27bf21c39019dd85b65cf"}]}
