)]}'
{"specs/queens/approved/glance/operator-image-workflow.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1739071c94dc3eaed606a3bba7427c5502696469","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Also, user will be able to see image details with \"image-show\"."},{"line_number":61,"context_line":"Because, the visibility \"hide\" as potentially the same scope as \"public\" the"},{"line_number":62,"context_line":"user roles that can use this visibility need to be controlled by policy."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_8720e4f8","line":63,"updated":"2017-09-29 03:34:28.000000000","message":"I just want to make sure I understand correctly.  What you\u0027re proposing is something like \"public_hidden\", that is, images with this visibility would be treated like public images as far as being accessible to all users, but these images wouldn\u0027t show up in the default image list.  Since they\u0027re essentially public images, only users with the publicize_image permission would be able to assign this visibility. (I suppose you could introduce a new permission, but you\u0027d want it to be a subset of the users with publicize_image, or else you\u0027d have a situation where people who can\u0027t make a public image can make a public_hidden image, which doesn\u0027t seem right; my point is, introducing a new policy would make this easy to misconfigure, so it might not be a good idea.)\n\nThe downside is that you couldn\u0027t make community, shared, or private images hidden.  I\u0027m not sure if that\u0027s good or bad.  What are your thoughts?","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5bfe07ff257764970c034d477e5a69a61f36d162","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Also, user will be able to see image details with \"image-show\"."},{"line_number":61,"context_line":"Because, the visibility \"hide\" as potentially the same scope as \"public\" the"},{"line_number":62,"context_line":"user roles that can use this visibility need to be controlled by policy."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_65b6ce8c","line":63,"in_reply_to":"7f515b1d_58e986e3","updated":"2017-10-03 03:55:51.000000000","message":"OK, thanks for clarifying.  I need to think about this some more.  I\u0027m not sure I like using the \u0027visibility\u0027 property in this way.","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7f41e853cb47cef1df2db395abf1a024dc63b4a6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Also, user will be able to see image details with \"image-show\"."},{"line_number":61,"context_line":"Because, the visibility \"hide\" as potentially the same scope as \"public\" the"},{"line_number":62,"context_line":"user roles that can use this visibility need to be controlled by policy."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_86c42a61","line":63,"in_reply_to":"7f515b1d_65b6ce8c","updated":"2017-10-03 12:57:57.000000000","message":"I definitely don\u0027t like doing this by changing the visibility enumeration.  (See my response below about the discovery issue.)","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"454fb2e752891212f920277c17cf134863e1a0cf","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Also, user will be able to see image details with \"image-show\"."},{"line_number":61,"context_line":"Because, the visibility \"hide\" as potentially the same scope as \"public\" the"},{"line_number":62,"context_line":"user roles that can use this visibility need to be controlled by policy."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_58e986e3","line":63,"in_reply_to":"7f515b1d_8720e4f8","updated":"2017-10-02 15:51:53.000000000","message":"Yes, the proposal is to have a new visibility that will hide public images. I agree with you, it doesn\u0027t make a lot of sense to have someone setting this new visibility if they are not allowed to set a public image.\n\nI think that setting \"hidden\" to community, shared or private images is a different problem. I don\u0027t have any use case for that. Also, the scope of those images is already different because they are not available to everyone.","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1739071c94dc3eaed606a3bba7427c5502696469","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Instead using a new image visibility we can have an image property \"hide\" that"},{"line_number":68,"context_line":"can be used to filter the default image list to the user."},{"line_number":69,"context_line":"This option could be more problematic for image discovery."},{"line_number":70,"context_line":"However, an image property can be used by all users and the public visibility"},{"line_number":71,"context_line":"scope is not duplicated."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_67a608ae","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":57},"updated":"2017-09-29 03:34:28.000000000","message":"something like this has been proposed before, https://review.openstack.org/#/c/108574/","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"454fb2e752891212f920277c17cf134863e1a0cf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Instead using a new image visibility we can have an image property \"hide\" that"},{"line_number":68,"context_line":"can be used to filter the default image list to the user."},{"line_number":69,"context_line":"This option could be more problematic for image discovery."},{"line_number":70,"context_line":"However, an image property can be used by all users and the public visibility"},{"line_number":71,"context_line":"scope is not duplicated."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_78b322ea","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":57},"in_reply_to":"7f515b1d_67a608ae","updated":"2017-10-02 15:51:53.000000000","message":"Thanks for the spec. I wasn\u0027t aware of it.\nI find the \"hide\" property concept more flexible however we can end up with \"complicated\" scenarios (hidden private images...) not sure how useful this will be.","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1739071c94dc3eaed606a3bba7427c5502696469","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Instead using a new image visibility we can have an image property \"hide\" that"},{"line_number":68,"context_line":"can be used to filter the default image list to the user."},{"line_number":69,"context_line":"This option could be more problematic for image discovery."},{"line_number":70,"context_line":"However, an image property can be used by all users and the public visibility"},{"line_number":71,"context_line":"scope is not duplicated."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_67bf28aa","line":69,"updated":"2017-09-29 03:34:28.000000000","message":"Could you explain this a bit?  Just curious why you think this could be a problem.","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7f41e853cb47cef1df2db395abf1a024dc63b4a6","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Instead using a new image visibility we can have an image property \"hide\" that"},{"line_number":68,"context_line":"can be used to filter the default image list to the user."},{"line_number":69,"context_line":"This option could be more problematic for image discovery."},{"line_number":70,"context_line":"However, an image property can be used by all users and the public visibility"},{"line_number":71,"context_line":"scope is not duplicated."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_86fd4ab3","line":69,"in_reply_to":"7f515b1d_38f7ea8d","updated":"2017-10-03 12:57:57.000000000","message":"Got it.  I\u0027m thinking the opposite, namely that it would help with discovery.  Here\u0027s what I\u0027m thinking:\n\nI want to find an image.  I ask myself, \"where do i want to get it from?\" the provider (public), the community (community), a friend (shared), my own stash (private). \n\nI want a provider image, so I put \"?visibility\u003dpublic\" on my GET v2/images call.\n\nI see a CentOS 7 image, but notice that its created_at is today, so I realize it\u0027s not the same image I used last week and that I need to use again.  So now I add \"?visibility\u003dpublic\u0026hidden\u003dtrue\".\n\nThat seems to make sense as a workflow, and it could be applicable to community images, too, which I think would be good.  Community providers will have the same issue you are having, namely, when they release an updated image, they may not want to delete the \"old\" image immediately, but they only want the most recent to show up in the image-list call.\n\nI like this better than introducing new \"*_hidden\" visibilities because it provides better separation of concerns.","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"454fb2e752891212f920277c17cf134863e1a0cf","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Instead using a new image visibility we can have an image property \"hide\" that"},{"line_number":68,"context_line":"can be used to filter the default image list to the user."},{"line_number":69,"context_line":"This option could be more problematic for image discovery."},{"line_number":70,"context_line":"However, an image property can be used by all users and the public visibility"},{"line_number":71,"context_line":"scope is not duplicated."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_38f7ea8d","line":69,"in_reply_to":"7f515b1d_67bf28aa","updated":"2017-10-02 15:51:53.000000000","message":"I was just thinking about all combinations that we can have with the \"hide\" property (shared/hide/not hide; community/hide/not hide; ...).","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fabd39b5d78aed333f3fd4994d18f703a837d8d8","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Instead using a new image visibility we can have an image property \"hide\" that"},{"line_number":68,"context_line":"can be used to filter the default image list to the user."},{"line_number":69,"context_line":"This option could be more problematic for image discovery."},{"line_number":70,"context_line":"However, an image property can be used by all users and the public visibility"},{"line_number":71,"context_line":"scope is not duplicated."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_dde1c12c","line":69,"in_reply_to":"7f515b1d_86fd4ab3","updated":"2017-10-04 04:47:47.000000000","message":"I agree with Brian here, using additional property \"hidden\" over introducing new visibility would be better.\n\nCouple of points;\n1. We need to use property protections for new property as other users should not able to add/update/delete it.\n\n2. Suppose a cloud has 3 CentOS images and operator added a new one then he needs to set hidden\u003dTrue to all previous images. (which can be overhead imo)","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"a2aeccafb62936c4383e3ac4467884189d93ef7b","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Instead using a new image visibility we can have an image property \"hide\" that"},{"line_number":68,"context_line":"can be used to filter the default image list to the user."},{"line_number":69,"context_line":"This option could be more problematic for image discovery."},{"line_number":70,"context_line":"However, an image property can be used by all users and the public visibility"},{"line_number":71,"context_line":"scope is not duplicated."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_11783629","line":69,"in_reply_to":"7f515b1d_86fd4ab3","updated":"2017-10-05 11:24:39.000000000","message":"Yes, I understand your point.\nThis will also work for me.","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"a2aeccafb62936c4383e3ac4467884189d93ef7b","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Instead using a new image visibility we can have an image property \"hide\" that"},{"line_number":68,"context_line":"can be used to filter the default image list to the user."},{"line_number":69,"context_line":"This option could be more problematic for image discovery."},{"line_number":70,"context_line":"However, an image property can be used by all users and the public visibility"},{"line_number":71,"context_line":"scope is not duplicated."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_f120faf9","line":69,"in_reply_to":"7f515b1d_dde1c12c","updated":"2017-10-05 11:24:39.000000000","message":"Considering the points that you mention:\n1. Can you explain a little bit. I\u0027m not understanding why we need extra protections.\n2. If the cloud already as 3 CentOS images probably the operator is already marking 2 of them as \"old\". Moving the current \"old\" list to \"hidden\" will be a one time operation. When updating a new recent image the operator marks the previous has \"hidden\". But all this workflow is then decided by the operator.","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a84a28c36b2bb4ff37df36b5401665720bea121d","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Instead using a new image visibility we can have an image property \"hide\" that"},{"line_number":68,"context_line":"can be used to filter the default image list to the user."},{"line_number":69,"context_line":"This option could be more problematic for image discovery."},{"line_number":70,"context_line":"However, an image property can be used by all users and the public visibility"},{"line_number":71,"context_line":"scope is not duplicated."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_f99e7c05","line":69,"in_reply_to":"7f515b1d_f120faf9","updated":"2017-10-06 13:02:15.000000000","message":"\u003e 1. Can you explain a little bit. I\u0027m not understanding why we need extra protections.\n\nAbhishek is thinking that if we use a \"regular\" image property for this, we\u0027ll need to control access.  But I think this is going to have to be a \"core\" image property because of its affect on the default image-list.\n\nWe need to decide whether making an image hidden needs to be governed by a policy.  I am thinking not -- we might as well allow all users to do this.  Unlike image sharing, where you can \"spam\" other users with garbage images, if you hide an image, no one else will know about it.  And the images would still be discoverable.  So even though the initial use case is for operators, I don\u0027t see why we don\u0027t make this a general functionality that any user can take advantage of.\n\n---\nI agree with Belmiro about the one-time cost to hide all your old images, I think that\u0027s acceptable.","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"50a37cadcc7a659bc2709477f11a6122984ce267","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Instead using a new image visibility we can have an image property \"hide\" that"},{"line_number":68,"context_line":"can be used to filter the default image list to the user."},{"line_number":69,"context_line":"This option could be more problematic for image discovery."},{"line_number":70,"context_line":"However, an image property can be used by all users and the public visibility"},{"line_number":71,"context_line":"scope is not duplicated."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_8001273b","line":69,"in_reply_to":"7f515b1d_f99e7c05","updated":"2017-10-08 11:02:03.000000000","message":"Got it. I was thinking about a core image.","commit_id":"77aae7775e10f84bd9b1948efad8d7f21cce8310"}]}
