)]}'
{"specs/queens/approved/glance/new-image-status-deleting.rst.txt":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"335e49c76f97778df0052c1329b0c670a6710c65","unresolved":false,"context_lines":[{"line_number":42,"context_line":"deletes the image from backend\r"},{"line_number":43,"context_line":"mark image in db as deleted\u003dtrue and deleted_at \u003d time\r"},{"line_number":44,"context_line":"\r"},{"line_number":45,"context_line":"So, image delete action is inconsistent among v1 and v2 apis as well.\r"},{"line_number":46,"context_line":"\r"},{"line_number":47,"context_line":"\r"},{"line_number":48,"context_line":"Proposed change\r"}],"source_content_type":"text/plain","patch_set":2,"id":"3fa0c359_6ee22604","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":69},"updated":"2018-02-15 12:47:23.000000000","message":"This does not matter at all as Images API v1 has been deprecated for quite a while and is due to removal early Rocky (we failed to do it in Queens as planned).","commit_id":"1344e485b9398e356f199d12b0947ed5cc7a13ea"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"335e49c76f97778df0052c1329b0c670a6710c65","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\r"},{"line_number":50,"context_line":"\r"},{"line_number":51,"context_line":"Changes are designed on the following 2 objectives:\r"},{"line_number":52,"context_line":"1. Ensure the image is unusable as the delete action is invoked on any authorized image,\r"},{"line_number":53,"context_line":"ir-respective of failures encountered during the process.\r"},{"line_number":54,"context_line":"2. Users should be able to re-issue delete operation on same image even if, the previous action\r"},{"line_number":55,"context_line":"encountered any failures.\r"},{"line_number":56,"context_line":"This fix introduces a new status \u0027deleting\u0027. For cases delayed_delete\u003dFalse,\r"}],"source_content_type":"text/plain","patch_set":2,"id":"3fa0c359_ceba5ae0","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":57},"updated":"2018-02-15 12:47:23.000000000","message":"This is the current case, no change needed.","commit_id":"1344e485b9398e356f199d12b0947ed5cc7a13ea"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"335e49c76f97778df0052c1329b0c670a6710c65","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Changes are designed on the following 2 objectives:\r"},{"line_number":52,"context_line":"1. Ensure the image is unusable as the delete action is invoked on any authorized image,\r"},{"line_number":53,"context_line":"ir-respective of failures encountered during the process.\r"},{"line_number":54,"context_line":"2. Users should be able to re-issue delete operation on same image even if, the previous action\r"},{"line_number":55,"context_line":"encountered any failures.\r"},{"line_number":56,"context_line":"This fix introduces a new status \u0027deleting\u0027. For cases delayed_delete\u003dFalse,\r"},{"line_number":57,"context_line":"we first set image status\u003ddeleting and then proceed for store delete.\r"},{"line_number":58,"context_line":"For cases where delayed_delete\u003dTrue, image status is set to pending_delete as usual.\r"}],"source_content_type":"text/plain","patch_set":2,"id":"3fa0c359_0e9da265","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":25},"updated":"2018-02-15 12:47:23.000000000","message":"If I understand correctly from your analysis, this was already achieved while Bug #1276142 was fixed. So no action needed there either.","commit_id":"1344e485b9398e356f199d12b0947ed5cc7a13ea"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"335e49c76f97778df0052c1329b0c670a6710c65","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Other end user impact\r"},{"line_number":85,"context_line":"---------------------\r"},{"line_number":86,"context_line":"\r"},{"line_number":87,"context_line":"Users will get to see new image status as \"deleting\" or \"error\".\r"},{"line_number":88,"context_line":"\r"},{"line_number":89,"context_line":"Performance Impact\r"},{"line_number":90,"context_line":"------------------\r"}],"source_content_type":"text/plain","patch_set":2,"id":"3fa0c359_eee076cf","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":64},"updated":"2018-02-15 12:47:23.000000000","message":"Users should not ever be allowed to set such internal statuses,","commit_id":"1344e485b9398e356f199d12b0947ed5cc7a13ea"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"335e49c76f97778df0052c1329b0c670a6710c65","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Other deployer impact\r"},{"line_number":95,"context_line":"---------------------\r"},{"line_number":96,"context_line":"\r"},{"line_number":97,"context_line":"None\r"},{"line_number":98,"context_line":"\r"},{"line_number":99,"context_line":"Developer impact\r"},{"line_number":100,"context_line":"----------------\r"}],"source_content_type":"text/plain","patch_set":2,"id":"3fa0c359_ceeeda8a","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":4},"updated":"2018-02-15 12:47:23.000000000","message":"There is plenty, which is why we are extremely conservative of introducing new statuses.\n\nFirstly all clients needs to be able to understand and deal with the new statuses.\nAll operator tooling needs to understand the new statuses and be able to deal with them.\nIt will take long time before such changes probagate into the wide scale of deployments and thus causes issues with interoperability, which is greatly valued by our community and there has been lots of efforts put in to achieve/maintain that.","commit_id":"1344e485b9398e356f199d12b0947ed5cc7a13ea"}]}
