)]}'
{"specs/stein/approved/glance/spec-lite-add-description-field-to-image.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"80304f788d528bf354577455b32a6e3d9a76f4b4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"           interoperability purposes) but will be stored as a user-defined"},{"line_number":26,"context_line":"           image property (so will not require any database changes)."},{"line_number":27,"context_line":"           You can set ``--property`` to add ``description`` properties when"},{"line_number":28,"context_line":"           executing the CLI."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"           For example:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_1004ce6b","line":28,"updated":"2018-12-13 16:05:54.000000000","message":"At today\u0027s Glance meeting Erno mentioned that we had decided that all future \"system\" image properties should be prefixed by \u0027os_\u0027 so that they don\u0027t clash with custom user properties.  It makes sense not to require that for this field, however.  So please add a sentence or two here, something like:\n\nThis is an exception to the Glance policy that new image properties should be prefixed with \u0027os_\u0027.  It\u0027s not necessary for this spec because the \u0027description\u0027 is being stored as a custom image property, and thus will not block the display of any \u0027description\u0027 properties that have already been created.  Additionally, it\u0027s to be expected that a property named \u0027description\u0027 will in fact contain some kind of description of the image.  Finally, using the name \u0027description\u0027 is consistent with the other services (nova, cinder) that recognize \u0027description\u0027 metadata.","commit_id":"9ed129d5218a0b41121512e422abfddc5f006df9"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"cf933ad223ac70463a72d55995290f66848eab13","unresolved":false,"context_lines":[{"line_number":25,"context_line":"           interoperability purposes) but will be stored as a user-defined"},{"line_number":26,"context_line":"           image property (so will not require any database changes)."},{"line_number":27,"context_line":"           You can set ``--property`` to add ``description`` properties when"},{"line_number":28,"context_line":"           executing the CLI."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"           For example:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_0509e781","line":28,"in_reply_to":"3f79a3b5_1004ce6b","updated":"2018-12-14 01:03:07.000000000","message":"Done","commit_id":"9ed129d5218a0b41121512e422abfddc5f006df9"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0fee51c4c6b904d37bde6981a823f58588879942","unresolved":false,"context_lines":[{"line_number":40,"context_line":"           Finally, using the name ``description`` is consistent with the other"},{"line_number":41,"context_line":"           services (nova, cinder) that recognize ``description`` metadata."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"           CLI execution example:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"             $openstack image create test_image"},{"line_number":46,"context_line":"               --property description\u003d\u0027This is a test image file.\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_cc64f7ea","line":43,"updated":"2018-12-20 22:48:10.000000000","message":"End this line with two :: (that\u0027s the ReST command to mark the following block as a code block)","commit_id":"ac6b6cb30cf26131347dee4bb39dd6d58764a8db"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0fee51c4c6b904d37bde6981a823f58588879942","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               --file cirros-0.3.4-x86_64-disk.img"},{"line_number":48,"context_line":"               --disk-format qcow2"},{"line_number":49,"context_line":"               --container-office bare"},{"line_number":50,"context_line":"               --public"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":":alternatives: Add a microversion and add the ``description`` column to the"},{"line_number":53,"context_line":"               ``images`` database table."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_8c627fd9","line":50,"updated":"2018-12-20 22:48:10.000000000","message":"On the command line, each of these lines (except the last) would end with a space-backslash ( \\).","commit_id":"ac6b6cb30cf26131347dee4bb39dd6d58764a8db"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a51046d32d6ffede919012a0ab6fe423ce7b931f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"           executing the CLI."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"           This is an exception to the Glance policy that new image properties"},{"line_number":31,"context_line":"           should be prefixed with ``os_``. It\u0027s not necessary for this spec"},{"line_number":32,"context_line":"           because the ``description`` is being stored as a custom image"},{"line_number":33,"context_line":"           property, and thus will not block the display of any ``description``"},{"line_number":34,"context_line":"           properties that have already been created."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"           Additionally, it\u0027s to be expected that a property named"},{"line_number":37,"context_line":"           ``description`` will in fact contain some kind of description of the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_53cef383","line":34,"range":{"start_line":31,"start_character":44,"end_line":34,"end_character":53},"updated":"2019-03-20 14:56:01.000000000","message":"I don\u0027t think this is valid excuse for avoiding the agreement we have. The next point below is very valid reason not to do it. Specially as there is similar common properties like `os_distro` that refers to the Operating System, not the image and this could be confusing. I\u0027m pro of keeping this as `description` instead of `os_description` just not for the above reasons.","commit_id":"c7f906864eee1c18e69974514f984a5c429e10ae"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0690ece6908066156cc81b744252697690aa70be","unresolved":false,"context_lines":[{"line_number":28,"context_line":"           executing the CLI."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"           This is an exception to the Glance policy that new image properties"},{"line_number":31,"context_line":"           should be prefixed with ``os_``. It\u0027s not necessary for this spec"},{"line_number":32,"context_line":"           because the ``description`` is being stored as a custom image"},{"line_number":33,"context_line":"           property, and thus will not block the display of any ``description``"},{"line_number":34,"context_line":"           properties that have already been created."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"           Additionally, it\u0027s to be expected that a property named"},{"line_number":37,"context_line":"           ``description`` will in fact contain some kind of description of the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_2e05f17a","line":34,"range":{"start_line":31,"start_character":44,"end_line":34,"end_character":53},"in_reply_to":"5fc1f717_53cef383","updated":"2019-03-20 21:16:44.000000000","message":"I\u0027ll address this in the updated patch.","commit_id":"c7f906864eee1c18e69974514f984a5c429e10ae"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a51046d32d6ffede919012a0ab6fe423ce7b931f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"               --container-office bare"},{"line_number":50,"context_line":"               --public"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":":alternatives: Add a microversion and add the ``description`` column to the"},{"line_number":53,"context_line":"               ``images`` database table."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":":timeline: Include in Stein release."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_33e24731","line":53,"range":{"start_line":52,"start_character":14,"end_line":53,"end_character":41},"updated":"2019-03-20 14:56:01.000000000","message":"Nope,\n\nAdding microversions to Glance is not an option and definitely not viable alternative for reserving property name for schema purposes. This needs to go.\n\nViable option would be to stay as we are and let users to put their descriptions into the properties like they can now and just not include it into the schema.","commit_id":"c7f906864eee1c18e69974514f984a5c429e10ae"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0690ece6908066156cc81b744252697690aa70be","unresolved":false,"context_lines":[{"line_number":49,"context_line":"               --container-office bare"},{"line_number":50,"context_line":"               --public"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":":alternatives: Add a microversion and add the ``description`` column to the"},{"line_number":53,"context_line":"               ``images`` database table."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":":timeline: Include in Stein release."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fc1f717_0e04b57a","line":53,"range":{"start_line":52,"start_character":14,"end_line":53,"end_character":41},"in_reply_to":"5fc1f717_33e24731","updated":"2019-03-20 21:16:44.000000000","message":"Will update with the more realistic alternative you suggest.","commit_id":"c7f906864eee1c18e69974514f984a5c429e10ae"}],"specs/stein/approved/spec-lite-add-description-field-to-image.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"accda3966fef6588a67a3492fed23083a68944b3","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":":project: glance"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":":problem: there is not has the field to record the description of a image."},{"line_number":14,"context_line":"          In most of our customer environments, users typically upload"},{"line_number":15,"context_line":"          multiple images. Because of the large number of users, it is"},{"line_number":16,"context_line":"          difficult to distinguish the purpose of an image through the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_4f6c6304","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":36},"updated":"2018-12-07 15:36:16.000000000","message":"I suggest changing this to \"Currently there is not a dedicated image property\"","commit_id":"303fe41a39103c2c02286907a317ab718177f8d1"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"873df46b20c3d52d5c07dd279c2504b08be6f672","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":":project: glance"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":":problem: there is not has the field to record the description of a image."},{"line_number":14,"context_line":"          In most of our customer environments, users typically upload"},{"line_number":15,"context_line":"          multiple images. Because of the large number of users, it is"},{"line_number":16,"context_line":"          difficult to distinguish the purpose of an image through the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b89c465c","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":36},"in_reply_to":"3f79a3b5_4f6c6304","updated":"2018-12-10 01:11:56.000000000","message":"Done","commit_id":"303fe41a39103c2c02286907a317ab718177f8d1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"accda3966fef6588a67a3492fed23083a68944b3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"          and the ``description`` field allows you to record the specific"},{"line_number":21,"context_line":"          purpose of the object."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":":solution: Add ``description`` field as a \"common image property\" to image."},{"line_number":24,"context_line":"           You can set ``--property`` to add ``description`` properties when"},{"line_number":25,"context_line":"           executing the CLI."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_4f1a2380","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":75},"updated":"2018-12-07 15:36:16.000000000","message":"Maybe add a sentence after this saying \"This way it will appear in the image schema (good for interoperability purposes) but will be stored as a user-defined image property (so will not require any database changes).\"","commit_id":"303fe41a39103c2c02286907a317ab718177f8d1"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"873df46b20c3d52d5c07dd279c2504b08be6f672","unresolved":false,"context_lines":[{"line_number":20,"context_line":"          and the ``description`` field allows you to record the specific"},{"line_number":21,"context_line":"          purpose of the object."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":":solution: Add ``description`` field as a \"common image property\" to image."},{"line_number":24,"context_line":"           You can set ``--property`` to add ``description`` properties when"},{"line_number":25,"context_line":"           executing the CLI."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_38259616","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":75},"in_reply_to":"3f79a3b5_4f1a2380","updated":"2018-12-10 01:11:56.000000000","message":"Done","commit_id":"303fe41a39103c2c02286907a317ab718177f8d1"}]}