)]}'
{"specs/victoria/approved/glance_store/handle-sparse-image.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d3ce50fc17cbabd82b3e81879ea4afdf8b67325c","unresolved":false,"context_lines":[{"line_number":209,"context_line":"Work Items"},{"line_number":210,"context_line":"----------"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"* Update drivers who can handle sparse images: sheepdog, filesystem and rbd."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Dependencies"},{"line_number":215,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_5b21d7b3","line":212,"range":{"start_line":212,"start_character":47,"end_line":212,"end_character":55},"updated":"2020-06-03 14:49:14.000000000","message":"sheepdog is deprecated and removed from glance-store now.\nSo we need to do this for file and rbd drivers only.","commit_id":"59432291aef7c7ebc14835dea56a00efcdbbef5a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e079aee5dec3bd7133d1fe805939e8b8006382bf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"checking if the chunk readed is only composed of null bytes, if it\u0027s the"},{"line_number":85,"context_line":"case, just increase the offset without writing any data to the store."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Rely on filesystem instruction to skip holes"},{"line_number":88,"context_line":"--------------------------------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"This second optimization will rely on the syscall SEEK_HOLE and SEEK_DATA,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff570b3c_a03a3ec1","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":44},"updated":"2020-06-08 05:19:18.000000000","message":"As we have agreed to go ahead with this solution I guess we should keep this as primary solution and move the other one as alternative.\n\nI think you should also mention about configuration option here as well, also whether this new configuration option is defined at store level or top level?\n\nAlso you should mention that this will not work for windows and what if kernel and python does not support this operation.","commit_id":"bcd805b19e05287eaafcd13b67ff9a89a794e646"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"7d76ca2d8b90f2b79eb10798fc84b79359faa445","unresolved":false,"context_lines":[{"line_number":84,"context_line":"checking if the chunk readed is only composed of null bytes, if it\u0027s the"},{"line_number":85,"context_line":"case, just increase the offset without writing any data to the store."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Rely on filesystem instruction to skip holes"},{"line_number":88,"context_line":"--------------------------------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"This second optimization will rely on the syscall SEEK_HOLE and SEEK_DATA,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_32b5a7ef","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":44},"in_reply_to":"bf51134e_85201ef9","updated":"2020-07-03 14:37:33.000000000","message":"- First point addressed line 75\n- Second point addressed line 94","commit_id":"bcd805b19e05287eaafcd13b67ff9a89a794e646"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4b05970a9791eb54247c6c01ad1366defb272430","unresolved":false,"context_lines":[{"line_number":84,"context_line":"checking if the chunk readed is only composed of null bytes, if it\u0027s the"},{"line_number":85,"context_line":"case, just increase the offset without writing any data to the store."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Rely on filesystem instruction to skip holes"},{"line_number":88,"context_line":"--------------------------------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"This second optimization will rely on the syscall SEEK_HOLE and SEEK_DATA,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_85201ef9","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":44},"in_reply_to":"ff570b3c_a03a3ec1","updated":"2020-06-25 14:59:54.000000000","message":"Ignore 1st para from above comment.\n\n* Please mention about how new config option will be used\n* Need to document that this will not work for windows and other limitations if any.","commit_id":"bcd805b19e05287eaafcd13b67ff9a89a794e646"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9556d4541a02863f86339775f2adcab77f4fc4a6","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Write optimization"},{"line_number":137,"context_line":"++++++++++++++++++"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"These tests have been done against 2 rbd backend sended trough web-download"},{"line_number":140,"context_line":"image-import workflow, with raw conversion enabled."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"For a 8GO Centos qcow2:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_c7a933e0","line":139,"range":{"start_line":139,"start_character":49,"end_line":139,"end_character":62},"updated":"2020-07-02 16:05:37.000000000","message":"sent through","commit_id":"bcd805b19e05287eaafcd13b67ff9a89a794e646"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"7d76ca2d8b90f2b79eb10798fc84b79359faa445","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Write optimization"},{"line_number":137,"context_line":"++++++++++++++++++"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"These tests have been done against 2 rbd backend sended trough web-download"},{"line_number":140,"context_line":"image-import workflow, with raw conversion enabled."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"For a 8GO Centos qcow2:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_d2d6eb27","line":139,"range":{"start_line":139,"start_character":49,"end_line":139,"end_character":62},"in_reply_to":"bf51134e_c7a933e0","updated":"2020-07-03 14:37:33.000000000","message":"Done","commit_id":"bcd805b19e05287eaafcd13b67ff9a89a794e646"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9556d4541a02863f86339775f2adcab77f4fc4a6","unresolved":false,"context_lines":[{"line_number":190,"context_line":"|                                 | **-32,8%**       | **-72,0%**     | **-16,1%**         | **-97,6%**       |"},{"line_number":191,"context_line":"+---------------------------------+------------------+----------------+--------------------+------------------+"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"The optimization for the Qcow2 image tends to be negligeable, as Qcow2 images"},{"line_number":194,"context_line":"does not have holes, so it should be very fast in all case."},{"line_number":195,"context_line":"The point here is to show that there is no negative impact for Qcow2 images,"},{"line_number":196,"context_line":"and huge positive one for raw images, so we can apply this behaviour in all"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_6791479a","line":193,"range":{"start_line":193,"start_character":49,"end_line":193,"end_character":60},"updated":"2020-07-02 16:05:37.000000000","message":"negligible","commit_id":"bcd805b19e05287eaafcd13b67ff9a89a794e646"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"7d76ca2d8b90f2b79eb10798fc84b79359faa445","unresolved":false,"context_lines":[{"line_number":190,"context_line":"|                                 | **-32,8%**       | **-72,0%**     | **-16,1%**         | **-97,6%**       |"},{"line_number":191,"context_line":"+---------------------------------+------------------+----------------+--------------------+------------------+"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"The optimization for the Qcow2 image tends to be negligeable, as Qcow2 images"},{"line_number":194,"context_line":"does not have holes, so it should be very fast in all case."},{"line_number":195,"context_line":"The point here is to show that there is no negative impact for Qcow2 images,"},{"line_number":196,"context_line":"and huge positive one for raw images, so we can apply this behaviour in all"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_32dc8745","line":193,"range":{"start_line":193,"start_character":49,"end_line":193,"end_character":60},"in_reply_to":"bf51134e_6791479a","updated":"2020-07-03 14:37:33.000000000","message":"Done","commit_id":"bcd805b19e05287eaafcd13b67ff9a89a794e646"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9556d4541a02863f86339775f2adcab77f4fc4a6","unresolved":false,"context_lines":[{"line_number":237,"context_line":"Testing"},{"line_number":238,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"* Testing that there is no functionnal regression for the modified drivers."},{"line_number":241,"context_line":"* Testing that it does not have a negative impact on system where"},{"line_number":242,"context_line":"  SEEK_DATA/SEEK_HOLE instruction are not available."},{"line_number":243,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_a7e87f16","line":240,"range":{"start_line":240,"start_character":27,"end_line":240,"end_character":38},"updated":"2020-07-02 16:05:37.000000000","message":"functional","commit_id":"bcd805b19e05287eaafcd13b67ff9a89a794e646"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"7d76ca2d8b90f2b79eb10798fc84b79359faa445","unresolved":false,"context_lines":[{"line_number":237,"context_line":"Testing"},{"line_number":238,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"* Testing that there is no functionnal regression for the modified drivers."},{"line_number":241,"context_line":"* Testing that it does not have a negative impact on system where"},{"line_number":242,"context_line":"  SEEK_DATA/SEEK_HOLE instruction are not available."},{"line_number":243,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf51134e_12e183ff","line":240,"range":{"start_line":240,"start_character":27,"end_line":240,"end_character":38},"in_reply_to":"bf51134e_a7e87f16","updated":"2020-07-03 14:37:33.000000000","message":"Done","commit_id":"bcd805b19e05287eaafcd13b67ff9a89a794e646"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f87e232281fb617e65c234ae973bf3ed0b7c8b3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"* Do not write null bytes sequences inside chunk (Write optimization)"},{"line_number":73,"context_line":"* Rely on filesystem instruction to skip holes (Read optimization)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"A new configuration option ``enable_thin_provisionning`` will be added to rbd"},{"line_number":76,"context_line":"and filesystem backend in order to make it switchable by operator. Enable it"},{"line_number":77,"context_line":"will enable both read and write optimization."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_c3da7915","line":75,"range":{"start_line":75,"start_character":49,"end_line":75,"end_character":51},"updated":"2020-07-07 14:56:00.000000000","message":"Typo: one \u0027n\u0027","commit_id":"ebe44aa0668fd06c74e62d0a7aaf04179dfd8abb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f87e232281fb617e65c234ae973bf3ed0b7c8b3","unresolved":false,"context_lines":[{"line_number":199,"context_line":"Other deployer impact"},{"line_number":200,"context_line":"---------------------"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Addition of a new ``enable_thin_provisionning`` configuration option for rbd"},{"line_number":203,"context_line":"and filesystem store will require operator to enable it. Without this option,"},{"line_number":204,"context_line":"behaviour will stay the same as before."},{"line_number":205,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_e3085d92","line":202,"range":{"start_line":202,"start_character":40,"end_line":202,"end_character":42},"updated":"2020-07-07 14:56:00.000000000","message":"Typo again.","commit_id":"ebe44aa0668fd06c74e62d0a7aaf04179dfd8abb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6f87e232281fb617e65c234ae973bf3ed0b7c8b3","unresolved":false,"context_lines":[{"line_number":244,"context_line":"Documentation Impact"},{"line_number":245,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"* Document the new configuration option ``enable_thin_provisionning`` for rbd"},{"line_number":248,"context_line":"  and filesystem driver."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_63f44d88","line":247,"range":{"start_line":247,"start_character":62,"end_line":247,"end_character":64},"updated":"2020-07-07 14:56:00.000000000","message":"Throughout.","commit_id":"ebe44aa0668fd06c74e62d0a7aaf04179dfd8abb"},{"author":{"_account_id":5679,"name":"Yaniv Kaul","email":"ykaul@redhat.com","username":"ykaul"},"change_message_id":"d7977b08a50e69dff2f9f25489b03b0c42de4483","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Do not write null bytes sequences inside chunk"},{"line_number":80,"context_line":"----------------------------------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This first optimization will work in all case, wether or not the image file"},{"line_number":83,"context_line":"is sparse or not, it is the behaviour implemented in qemu-img. It consist on"},{"line_number":84,"context_line":"checking if the chunk readed is only composed of null bytes, if it\u0027s the"},{"line_number":85,"context_line":"case, just increase the offset without writing any data to the store."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f560f44_18330a16","line":82,"updated":"2020-08-04 10:04:35.000000000","message":"case -\u003e cases","commit_id":"2b40c59f52611830b529639339879201d10ba36b"},{"author":{"_account_id":5679,"name":"Yaniv Kaul","email":"ykaul@redhat.com","username":"ykaul"},"change_message_id":"d7977b08a50e69dff2f9f25489b03b0c42de4483","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This first optimization will work in all case, wether or not the image file"},{"line_number":83,"context_line":"is sparse or not, it is the behaviour implemented in qemu-img. It consist on"},{"line_number":84,"context_line":"checking if the chunk readed is only composed of null bytes, if it\u0027s the"},{"line_number":85,"context_line":"case, just increase the offset without writing any data to the store."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Rely on filesystem instruction to skip holes"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f560f44_b8549e22","line":84,"updated":"2020-08-04 10:04:35.000000000","message":"readed -\u003e read","commit_id":"2b40c59f52611830b529639339879201d10ba36b"}],"specs/victoria/approved/index.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c12f7100cdc610e641c9a633df9695f75b0ce23c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    :maxdepth: 1"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    glance/*"},{"line_number":16,"context_line":"    glance_store/*"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf51134e_fd7ec667","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":18},"updated":"2020-07-15 08:05:25.000000000","message":"Instead of this you need to write separate section\n\nVictoria approved specs for glance_store:\n\n.. toctree::\n    :glob:\n    :maxdepth: 1\n\n    glance_store/*","commit_id":"c5cc21164ccc9ad4fd6c25e6e0f1fa169e12977b"}]}