)]}'
{"specs/victoria/approved/glance/copy-unowned-image.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d6bd73537f95efde7062db5a9ca26b8a548cf844","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Currently only a user may only copy images that they own, and there is"},{"line_number":26,"context_line":"no way to allow otherwise. This may lead to anti-pattern behavior,"},{"line_number":27,"context_line":"such as downloading an image and re-uploading it so that it can be"},{"line_number":28,"context_line":"copied. Further, it may prevent optimizations, such as a user"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_55dc9045","line":25,"range":{"start_line":25,"start_character":10,"end_line":25,"end_character":30},"updated":"2020-07-02 20:12:55.000000000","message":"Drop the first \"only\"?","commit_id":"71704719fc373d555402484e583a84ad16c933d3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"951121beb413960b9c95ace09d8159ec3c96147a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Currently only a user may only copy images that they own, and there is"},{"line_number":26,"context_line":"no way to allow otherwise. This may lead to anti-pattern behavior,"},{"line_number":27,"context_line":"such as downloading an image and re-uploading it so that it can be"},{"line_number":28,"context_line":"copied. Further, it may prevent optimizations, such as a user"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf51134e_353900a3","line":25,"range":{"start_line":25,"start_character":10,"end_line":25,"end_character":30},"in_reply_to":"bf51134e_55dc9045","updated":"2020-07-06 13:36:31.000000000","message":"Doh, yep, thanks :)","commit_id":"71704719fc373d555402484e583a84ad16c933d3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"867cb8b102884faf5e283e961b6e882ee2e3e309","unresolved":false,"context_lines":[{"line_number":56,"context_line":"to aid in auditing. If and only if the policy grants this permission"},{"line_number":57,"context_line":"(which is only possible for `copy-image`) then an admin-capable"},{"line_number":58,"context_line":"`ImageRepo` will be provided to the task for use in image property"},{"line_number":59,"context_line":"manipulation."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_717ed66b","line":59,"updated":"2020-07-07 14:08:08.000000000","message":"I think it would be worth adding something here about ownership of the copy just to be completely clear (i.e., the original image owner still owns the copy, not the user who initiated the copy operation.)\n\nAlso, there was some talk in #openstack-glance about restricting this to images with public visibility?  Or did we decide not to do that?","commit_id":"b2a2c08c37cc0cd9252bbfa5460b70cf39fab4dd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1448516ffcc8d25aacded37801fde44f70262ec0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"to aid in auditing. If and only if the policy grants this permission"},{"line_number":57,"context_line":"(which is only possible for `copy-image`) then an admin-capable"},{"line_number":58,"context_line":"`ImageRepo` will be provided to the task for use in image property"},{"line_number":59,"context_line":"manipulation."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_f1766606","line":59,"in_reply_to":"bf51134e_31bc5edb","updated":"2020-07-07 14:24:38.000000000","message":"About ownership: I think it\u0027s true that we understand it, but I can see people using the \"copy-image\" feature and wondering what happened to \"their\" copy.\n\nAbout image visibility: I think what you have here is fine, it\u0027s clear that it\u0027s controlled by a policy rule.  I just wanted to make sure we weren\u0027t missing anything.","commit_id":"b2a2c08c37cc0cd9252bbfa5460b70cf39fab4dd"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"82de881ddc52864ceb61d3a3a1f3a23faf11e4e2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"to aid in auditing. If and only if the policy grants this permission"},{"line_number":57,"context_line":"(which is only possible for `copy-image`) then an admin-capable"},{"line_number":58,"context_line":"`ImageRepo` will be provided to the task for use in image property"},{"line_number":59,"context_line":"manipulation."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_31bc5edb","line":59,"in_reply_to":"bf51134e_717ed66b","updated":"2020-07-07 14:12:11.000000000","message":"I guess I thought it\u0027s clear that a copy-image doesn\u0027t affect the original image in any way other than adding a new location at the end. I can surely say something like that here if you think it\u0027s important, but since there\u0027s no new object created (i.e. a new image record) I would have thought it was well-understood.\n\nWe did say \"public\" but the code I\u0027ve got just makes it a policy knob, which you can write as \"allow copying public images\" or something more complex. Given how much you can do with policy rules (up to calling out to an external decider service via http) I didn\u0027t think it was important to define a box around what you can do, since it\u0027s just \"whatever you can do with policy\". Maybe I just need to be clear(er) here that this is controlled by a policy rule?","commit_id":"b2a2c08c37cc0cd9252bbfa5460b70cf39fab4dd"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"824c7a27279b0db5a6eced73a3654c6953a5cfd6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"to aid in auditing. If and only if the policy grants this permission"},{"line_number":57,"context_line":"(which is only possible for `copy-image`) then an admin-capable"},{"line_number":58,"context_line":"`ImageRepo` will be provided to the task for use in image property"},{"line_number":59,"context_line":"manipulation."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_51d472bd","line":59,"in_reply_to":"bf51134e_f1766606","updated":"2020-07-07 14:26:20.000000000","message":"\u003e About ownership: I think it\u0027s true that we understand it, but I can\n \u003e see people using the \"copy-image\" feature and wondering what\n \u003e happened to \"their\" copy.\n\nOkay, seems like that\u0027s a matter for the documentation of the feature more so than the spec. However, I\u0027ll put something here and also add a work item below to update the copy-image doc to explain what it means if you\u0027re granted this permission on an image you don\u0027t own. Sound okay?","commit_id":"b2a2c08c37cc0cd9252bbfa5460b70cf39fab4dd"}],"specs/victoria/approved/index.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1c1126ad8eca219380656f0f3d912679f66e8f27","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    :maxdepth: 1"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    glance/*"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_891c106b","side":"PARENT","line":16,"updated":"2020-07-08 13:39:23.000000000","message":"nit: Need to revert this?","commit_id":"f6f7a01a70af94f529006213de8411689688a884"}]}