)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e87cd1eb4c1cd80809b57a8c7dc4839646b09ec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"30d727c0_0653fc26","updated":"2022-07-22 11:34:47.000000000","message":"Abhishek,\nCan you remove abandon ? I have changed it to Zed release, but not able to push change for review.","commit_id":"1dd7f6b3ea9632827b7e7ab31811456f8486e61a"},{"author":{"_account_id":20104,"name":"Dmitrii Galkin","display_name":"Dmitry Galkin","email":"galkindmitrii@gmail.com","username":"galkindmitrii"},"change_message_id":"e66a42457f3925b1162f182225b9924bfc166814","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0b593e11_1aeca001","updated":"2022-05-12 15:47:30.000000000","message":"Hi Abhishek, Brian.\n\nThanks for the feedback.\n\nTo explain the motivation a bit more: we are running this patch/implementation of the spec in our production for about a year now. The use-case is large Windows images that are migrated from another platform. Image sizes reach hundreds of gigabytes and take many hours to upload to our Swift, so we were looking for ways to speed it up and found that using at least 2 threads helps a lot here.\n\nWe are happy to rebase and resubmit the spec and the patches. We could also set the default pool size to be \"1\" which effectively is not changing anything and let Openstack operators decide on the setting that works best for their particular Glance setup.\n\nWhat do you think?","commit_id":"1dd7f6b3ea9632827b7e7ab31811456f8486e61a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f47bd86c21ed1ffb75971db282ead7ca73751f95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea33371f_c2029872","in_reply_to":"0b593e11_1aeca001","updated":"2022-05-12 16:17:17.000000000","message":"I think this will be a swift specific change and will not have impact on other glance backends,and as you are proposing to maintain default behavior I am ok with it. While you resubmit the spec, please answer to comments given by Brian.","commit_id":"1dd7f6b3ea9632827b7e7ab31811456f8486e61a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8c6f280d72acd92c3d01721d05e513583976e7d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d47cd78_ef7cadec","in_reply_to":"30d727c0_0653fc26","updated":"2022-11-03 09:35:00.000000000","message":"Ack,restoring the patch so that we can discuss this for upcoming cycle!","commit_id":"1dd7f6b3ea9632827b7e7ab31811456f8486e61a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d3823b1a84af35a2c84457178fbe2c0cba670ca2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"46514a5f_322078c7","updated":"2022-11-02 18:20:29.000000000","message":"Updated results of tests conducted by rajivmucheli on 10GB and 60GB images.","commit_id":"54049eaa46f4b1a189209082985c99554e5e7fa1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ee5588b86130dec5fc624ae8782a86c854ea965c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c51d1c75_78e1786f","updated":"2023-01-20 10:06:49.000000000","message":"Ping for review.","commit_id":"25cd7e2fab12552e02faa9ffd8e596ab520c8aaf"}],"specs/2023.1/approved/glance_store/speedup-image-upload-to-swift.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8c6f280d72acd92c3d01721d05e513583976e7d2","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Current implementation uses synchronous way to upload fragments of image."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Proposed change"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"97f14f5a_40dff527","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":20},"updated":"2022-11-03 09:35:00.000000000","message":"Can you also point out what are the disadvantages of this kind of upload here?","commit_id":"54049eaa46f4b1a189209082985c99554e5e7fa1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b843cb385ce3e97ee3f7a8219c26e83ed2c0f1c8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Current implementation uses synchronous way to upload fragments of image."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Proposed change"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"36e397c1_1726ce3a","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":20},"in_reply_to":"97f14f5a_40dff527","updated":"2022-11-03 13:29:34.000000000","message":"Done","commit_id":"54049eaa46f4b1a189209082985c99554e5e7fa1"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8c6f280d72acd92c3d01721d05e513583976e7d2","unresolved":true,"context_lines":[{"line_number":23,"context_line":"To make concurrent upload for image fragments."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"A new configuration option ``swift_store_thread_pool_size`` will be added"},{"line_number":26,"context_line":"to Swift store backend."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Alternatives"},{"line_number":29,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"6ca273e1_548ba37e","line":26,"updated":"2022-11-03 09:35:00.000000000","message":"I think we agree on creating a sub-driver based on this logic during PTG discussion (Multi-Threaded swift driver). So it will be better to explain it here as well.","commit_id":"54049eaa46f4b1a189209082985c99554e5e7fa1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b843cb385ce3e97ee3f7a8219c26e83ed2c0f1c8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"To make concurrent upload for image fragments."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"A new configuration option ``swift_store_thread_pool_size`` will be added"},{"line_number":26,"context_line":"to Swift store backend."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Alternatives"},{"line_number":29,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"8a06e721_db17cede","line":26,"in_reply_to":"6ca273e1_548ba37e","updated":"2022-11-03 13:29:34.000000000","message":"With the implementation, I do not think we need sub-driver as only upload functionality is different compared to initial implementation. This can be done with simplicity using if (feature_enabled) check.","commit_id":"54049eaa46f4b1a189209082985c99554e5e7fa1"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f2e01ea4ab1bbadaba93b9fca243d7ea21370f87","unresolved":false,"context_lines":[{"line_number":23,"context_line":"To make concurrent upload for image fragments."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"A new configuration option ``swift_store_thread_pool_size`` will be added"},{"line_number":26,"context_line":"to Swift store backend."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Alternatives"},{"line_number":29,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"0a2eb944_415b7ff7","line":26,"in_reply_to":"8a06e721_db17cede","updated":"2023-01-23 05:04:12.000000000","message":"As I told and discuss during the PTG, this is not how we want to modify the swift driver. We don\u0027t want condition based implementations anymore. Feel free to discuss this in weekly glance meeting.","commit_id":"54049eaa46f4b1a189209082985c99554e5e7fa1"}]}