)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"05de2f3262d6bd22d27efdacee7465d94c745cb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"009f459b_7aab551c","updated":"2021-11-17 06:06:37.000000000","message":"Good start, need some checks before finalizing the same.","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"96aa1bc3f7c453d75308bbcb8490f6ec93e56679","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c3193bc3_dc21349e","updated":"2021-11-29 15:41:35.000000000","message":"Need to remove index.rst to resolve merged conflict.","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"7b602f9a9824d85a67dc26a9139d446db74c7eb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eaa03fb8_caceaf65","updated":"2022-02-15 05:43:31.000000000","message":"Spec freeze time is over so we should move it to zed cycle.","commit_id":"e46b7451d384fa5e543cc6d4c37f2d7f8cd1dc1c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"44932af500e115d8d0349654f71270db5c601c67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"08985a05_d67bb9bb","updated":"2022-05-02 21:31:48.000000000","message":"I think maybe this requires a bugfix, not a new API call.  See comments inline.","commit_id":"12de72f738819dabce5dde06664fea3312599239"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4a8a225974b9f6818a7b411f3992385edc30d40a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fb531135_a8815901","updated":"2022-04-04 16:44:32.000000000","message":"recheck","commit_id":"12de72f738819dabce5dde06664fea3312599239"}],"specs/yoga/approved/glance/add-create-and-delete-api-for-metadef-resource-type.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"05de2f3262d6bd22d27efdacee7465d94c745cb7","unresolved":true,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"8e4e2d4f_e41e90b9","line":1,"updated":"2021-11-17 06:06:37.000000000","message":"You can rename this file to create-delete-resourcetypes.rst","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"0c9f39329a88206522910d962520f60ff99fda23","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"55fed74f_ff8be306","line":1,"in_reply_to":"8e4e2d4f_e41e90b9","updated":"2021-11-30 06:09:14.000000000","message":"Ack","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"05de2f3262d6bd22d27efdacee7465d94c745cb7","unresolved":true,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add new POST and DELETE API for metadef resource types"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/glance/+spec/add-create-and-delete-api-for-metadef-resource-type"}],"source_content_type":"text/x-rst","patch_set":2,"id":"57c037cf_68638f2a","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":54},"updated":"2021-11-17 06:06:37.000000000","message":"Implement POST and DELETE API for metadef resource types","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"0c9f39329a88206522910d962520f60ff99fda23","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add new POST and DELETE API for metadef resource types"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/glance/+spec/add-create-and-delete-api-for-metadef-resource-type"}],"source_content_type":"text/x-rst","patch_set":2,"id":"538b6a32_317835c8","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":54},"in_reply_to":"57c037cf_68638f2a","updated":"2021-11-30 06:09:14.000000000","message":"Ack","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"05de2f3262d6bd22d27efdacee7465d94c745cb7","unresolved":true,"context_lines":[{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"To maintain the consistency and resolve this problem two new APIs needs to be"},{"line_number":31,"context_line":"added with existing policies related to associate and deassociate resource"},{"line_number":32,"context_line":"types,"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"1) POST api to create the metadef resource type"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ddcc633e_1c19064a","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":28},"updated":"2021-11-17 06:06:37.000000000","message":"I think you should mention which existing policies you are going to use here for POST and DELETE.","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"0c9f39329a88206522910d962520f60ff99fda23","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"To maintain the consistency and resolve this problem two new APIs needs to be"},{"line_number":31,"context_line":"added with existing policies related to associate and deassociate resource"},{"line_number":32,"context_line":"types,"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"1) POST api to create the metadef resource type"}],"source_content_type":"text/x-rst","patch_set":2,"id":"25adfba7_fb51bdb8","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":28},"in_reply_to":"ddcc633e_1c19064a","updated":"2021-11-30 06:09:14.000000000","message":"Ack","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"05de2f3262d6bd22d27efdacee7465d94c745cb7","unresolved":true,"context_lines":[{"line_number":43,"context_line":"Data model impact"},{"line_number":44,"context_line":"-----------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The existing data model remains unaffected. Just need to remove the part of"},{"line_number":47,"context_line":"creation of new entries of resource type in metadef_resource_types table"},{"line_number":48,"context_line":"while associating resource type to namespace and add it while creating"},{"line_number":49,"context_line":"new resource type with the new create api."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4ee152e1_a1a3b01d","line":49,"range":{"start_line":46,"start_character":0,"end_line":49,"end_character":42},"updated":"2021-11-17 06:06:37.000000000","message":"I think this is not necessary.\nJust try one thing;\n\n1. Create resource type association\n2. De-associate it \n3. Now it will have orphan resource type in db\n4. Try to create new resource type association with this existing/orphan resource type.\n\n\nIf it is allowed then I don\u0027t think the change you mentioned here is required.","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"f55e7023be3590220578df7e843ab8cf8b02f347","unresolved":true,"context_lines":[{"line_number":43,"context_line":"Data model impact"},{"line_number":44,"context_line":"-----------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The existing data model remains unaffected. Just need to remove the part of"},{"line_number":47,"context_line":"creation of new entries of resource type in metadef_resource_types table"},{"line_number":48,"context_line":"while associating resource type to namespace and add it while creating"},{"line_number":49,"context_line":"new resource type with the new create api."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7c0b946a_6bedecad","line":49,"range":{"start_line":46,"start_character":0,"end_line":49,"end_character":42},"in_reply_to":"0c90a50d_352e82cb","updated":"2021-11-30 06:15:30.000000000","message":"Actually those resource types might get re-used later by user, so i think instead of auto deleting it would be better to give a choice by providing the API.","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"0c9f39329a88206522910d962520f60ff99fda23","unresolved":true,"context_lines":[{"line_number":43,"context_line":"Data model impact"},{"line_number":44,"context_line":"-----------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The existing data model remains unaffected. Just need to remove the part of"},{"line_number":47,"context_line":"creation of new entries of resource type in metadef_resource_types table"},{"line_number":48,"context_line":"while associating resource type to namespace and add it while creating"},{"line_number":49,"context_line":"new resource type with the new create api."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0c90a50d_352e82cb","line":49,"range":{"start_line":46,"start_character":0,"end_line":49,"end_character":42},"in_reply_to":"1428e2c7_56b3d76b","updated":"2021-11-30 06:09:14.000000000","message":"@abhishek, yes that is the existing behavior. The new resource type gets created while associating it with namespace and after De-association , it remains orphan in the the \u0027metadef_resource_types\u0027 table which can be reused.\n\n@Dan, Yes that makes sense, basically the main motto here it to cleanup the orphan/existing resource types, the proposal of having POST is just to maintain the consistency as per the PTG discussion.\nAuto-deleting meaning, should we have some periodic operation instead of having a new api?","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2e4be9c037234b79a1626da06dc35d5e0e44729a","unresolved":true,"context_lines":[{"line_number":43,"context_line":"Data model impact"},{"line_number":44,"context_line":"-----------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The existing data model remains unaffected. Just need to remove the part of"},{"line_number":47,"context_line":"creation of new entries of resource type in metadef_resource_types table"},{"line_number":48,"context_line":"while associating resource type to namespace and add it while creating"},{"line_number":49,"context_line":"new resource type with the new create api."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1428e2c7_56b3d76b","line":49,"range":{"start_line":46,"start_character":0,"end_line":49,"end_character":42},"in_reply_to":"4ee152e1_a1a3b01d","updated":"2021-11-29 16:28:19.000000000","message":"Yeah, we also don\u0027t want to change the existing behavior that results in automatic creation, since it would be an API break right? If we\u0027re not going to remove that (and I don\u0027t think we should) then I don\u0027t think we need POST really, do we?\n\nDELETE might be necessary for cleanup, but...could we not just auto-delete the resource types when we determine they are no longer necessary?","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8465f555759be39a80490662a851e43e996adf66","unresolved":true,"context_lines":[{"line_number":43,"context_line":"Data model impact"},{"line_number":44,"context_line":"-----------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The existing data model remains unaffected. Just need to remove the part of"},{"line_number":47,"context_line":"creation of new entries of resource type in metadef_resource_types table"},{"line_number":48,"context_line":"while associating resource type to namespace and add it while creating"},{"line_number":49,"context_line":"new resource type with the new create api."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e2c667aa_145bef6b","line":49,"range":{"start_line":46,"start_character":0,"end_line":49,"end_character":42},"in_reply_to":"7c0b946a_6bedecad","updated":"2021-11-30 14:41:21.000000000","message":"But why can\u0027t they just be auto-created again when they get used?\n\nBy auto-delete I mean delete the resource type when the last association that uses it is deleted. Either way, DELETE is fine if you want it to be manual, but I\u0027m not sure I see any reason to add POST at this point and let (definitely not require) people create them manually.","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"191269f4fc428b3273904aebba96d06fb94b6438","unresolved":true,"context_lines":[{"line_number":43,"context_line":"Data model impact"},{"line_number":44,"context_line":"-----------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The existing data model remains unaffected. Just need to remove the part of"},{"line_number":47,"context_line":"creation of new entries of resource type in metadef_resource_types table"},{"line_number":48,"context_line":"while associating resource type to namespace and add it while creating"},{"line_number":49,"context_line":"new resource type with the new create api."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"72944767_05b02537","line":49,"range":{"start_line":46,"start_character":0,"end_line":49,"end_character":42},"in_reply_to":"e2c667aa_145bef6b","updated":"2021-12-01 06:04:36.000000000","message":"Yes that\u0027s right, POST is not necessary as such, we can keep it auto-created.\nAs I said earlier in previous comment, POST was proposed just to maintain the consistency as per discussed in PTG. \n\nBut I think, we should have DELETE instead of auto-delete.","commit_id":"5a73e12f2ebf24b16beb35af295f578ffcb212ca"}],"specs/yoga/approved/glance/delete-resource-type.rst":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6a321c9b597d9004fee8a2c68ca02e3a3b323e4f","unresolved":true,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, the non existing metadef resource types are getting newly created"},{"line_number":19,"context_line":"while associating with namespace and the new entries gets added in both"},{"line_number":20,"context_line":"\u0027metadef_resource_types\u0027 and \u0027metadef_namespace_resource_types\u0027 tables."},{"line_number":21,"context_line":"But after namespace deassociation, only entries from"},{"line_number":22,"context_line":"\u0027metadef_namespace_resource_types\u0027 tables gets deleted and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"feb77049_03726743","line":19,"range":{"start_line":19,"start_character":53,"end_line":19,"end_character":57},"updated":"2021-12-15 21:26:34.000000000","message":"get*","commit_id":"e46b7451d384fa5e543cc6d4c37f2d7f8cd1dc1c"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"3111099972a7404c13e12360284d6e7ecf1b7b53","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, the non existing metadef resource types are getting newly created"},{"line_number":19,"context_line":"while associating with namespace and the new entries gets added in both"},{"line_number":20,"context_line":"\u0027metadef_resource_types\u0027 and \u0027metadef_namespace_resource_types\u0027 tables."},{"line_number":21,"context_line":"But after namespace deassociation, only entries from"},{"line_number":22,"context_line":"\u0027metadef_namespace_resource_types\u0027 tables gets deleted and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5bfb2f24_ca81f62c","line":19,"range":{"start_line":19,"start_character":53,"end_line":19,"end_character":57},"in_reply_to":"feb77049_03726743","updated":"2022-01-11 08:17:40.000000000","message":"Ack","commit_id":"e46b7451d384fa5e543cc6d4c37f2d7f8cd1dc1c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6a321c9b597d9004fee8a2c68ca02e3a3b323e4f","unresolved":true,"context_lines":[{"line_number":19,"context_line":"while associating with namespace and the new entries gets added in both"},{"line_number":20,"context_line":"\u0027metadef_resource_types\u0027 and \u0027metadef_namespace_resource_types\u0027 tables."},{"line_number":21,"context_line":"But after namespace deassociation, only entries from"},{"line_number":22,"context_line":"\u0027metadef_namespace_resource_types\u0027 tables gets deleted and"},{"line_number":23,"context_line":"\u0027metadef_resource_types\u0027 entries remains as it is and are uneccessarily"},{"line_number":24,"context_line":"increases the size of table because there is no provision to delete/cleanup"},{"line_number":25,"context_line":"those resource types."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa5829a_2ff60ab2","line":22,"range":{"start_line":22,"start_character":42,"end_line":22,"end_character":46},"updated":"2021-12-15 21:26:34.000000000","message":"get*","commit_id":"e46b7451d384fa5e543cc6d4c37f2d7f8cd1dc1c"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"3111099972a7404c13e12360284d6e7ecf1b7b53","unresolved":false,"context_lines":[{"line_number":19,"context_line":"while associating with namespace and the new entries gets added in both"},{"line_number":20,"context_line":"\u0027metadef_resource_types\u0027 and \u0027metadef_namespace_resource_types\u0027 tables."},{"line_number":21,"context_line":"But after namespace deassociation, only entries from"},{"line_number":22,"context_line":"\u0027metadef_namespace_resource_types\u0027 tables gets deleted and"},{"line_number":23,"context_line":"\u0027metadef_resource_types\u0027 entries remains as it is and are uneccessarily"},{"line_number":24,"context_line":"increases the size of table because there is no provision to delete/cleanup"},{"line_number":25,"context_line":"those resource types."}],"source_content_type":"text/x-rst","patch_set":3,"id":"eb2fc6b1_44a9085d","line":22,"range":{"start_line":22,"start_character":42,"end_line":22,"end_character":46},"in_reply_to":"1aa5829a_2ff60ab2","updated":"2022-01-11 08:17:40.000000000","message":"Ack","commit_id":"e46b7451d384fa5e543cc6d4c37f2d7f8cd1dc1c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6a321c9b597d9004fee8a2c68ca02e3a3b323e4f","unresolved":true,"context_lines":[{"line_number":20,"context_line":"\u0027metadef_resource_types\u0027 and \u0027metadef_namespace_resource_types\u0027 tables."},{"line_number":21,"context_line":"But after namespace deassociation, only entries from"},{"line_number":22,"context_line":"\u0027metadef_namespace_resource_types\u0027 tables gets deleted and"},{"line_number":23,"context_line":"\u0027metadef_resource_types\u0027 entries remains as it is and are uneccessarily"},{"line_number":24,"context_line":"increases the size of table because there is no provision to delete/cleanup"},{"line_number":25,"context_line":"those resource types."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"a5c0710d_ec2dcd96","line":23,"range":{"start_line":23,"start_character":50,"end_line":23,"end_character":53},"updated":"2021-12-15 21:26:34.000000000","message":"[...] remain as they are. This unnecessarily increased [...]","commit_id":"e46b7451d384fa5e543cc6d4c37f2d7f8cd1dc1c"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"3111099972a7404c13e12360284d6e7ecf1b7b53","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u0027metadef_resource_types\u0027 and \u0027metadef_namespace_resource_types\u0027 tables."},{"line_number":21,"context_line":"But after namespace deassociation, only entries from"},{"line_number":22,"context_line":"\u0027metadef_namespace_resource_types\u0027 tables gets deleted and"},{"line_number":23,"context_line":"\u0027metadef_resource_types\u0027 entries remains as it is and are uneccessarily"},{"line_number":24,"context_line":"increases the size of table because there is no provision to delete/cleanup"},{"line_number":25,"context_line":"those resource types."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"8d308fa0_51ebaf85","line":23,"range":{"start_line":23,"start_character":50,"end_line":23,"end_character":53},"in_reply_to":"a5c0710d_ec2dcd96","updated":"2022-01-11 08:17:40.000000000","message":"Ack","commit_id":"e46b7451d384fa5e543cc6d4c37f2d7f8cd1dc1c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6a321c9b597d9004fee8a2c68ca02e3a3b323e4f","unresolved":true,"context_lines":[{"line_number":22,"context_line":"\u0027metadef_namespace_resource_types\u0027 tables gets deleted and"},{"line_number":23,"context_line":"\u0027metadef_resource_types\u0027 entries remains as it is and are uneccessarily"},{"line_number":24,"context_line":"increases the size of table because there is no provision to delete/cleanup"},{"line_number":25,"context_line":"those resource types."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"cf9b8d90_eb8c4882","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":14},"updated":"2021-12-15 21:26:34.000000000","message":"So, silly question, but why do we add the same entries to both tables? Couldn\u0027t we add a newly created metadef resource type to a single one of these tables?","commit_id":"e46b7451d384fa5e543cc6d4c37f2d7f8cd1dc1c"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"3111099972a7404c13e12360284d6e7ecf1b7b53","unresolved":true,"context_lines":[{"line_number":22,"context_line":"\u0027metadef_namespace_resource_types\u0027 tables gets deleted and"},{"line_number":23,"context_line":"\u0027metadef_resource_types\u0027 entries remains as it is and are uneccessarily"},{"line_number":24,"context_line":"increases the size of table because there is no provision to delete/cleanup"},{"line_number":25,"context_line":"those resource types."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5dc03403_cc521c88","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":14},"in_reply_to":"cf9b8d90_eb8c4882","updated":"2022-01-11 08:17:40.000000000","message":"I think the intention behind having the separate metadef_resource_types\u0027 table is, if anyone wants to use that resource type in future then that can be associated to same or different namespace.","commit_id":"e46b7451d384fa5e543cc6d4c37f2d7f8cd1dc1c"}],"specs/zed/approved/glance/delete-resource-type.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"44932af500e115d8d0349654f71270db5c601c67","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, the non existing metadef resource types are getting newly created"},{"line_number":19,"context_line":"while associating with namespace and the new entries gets added in both"},{"line_number":20,"context_line":"\u0027metadef_resource_types\u0027 and \u0027metadef_namespace_resource_types\u0027 tables."},{"line_number":21,"context_line":"But after namespace deassociation, only entries from"},{"line_number":22,"context_line":"\u0027metadef_namespace_resource_types\u0027 tables gets deleted and"},{"line_number":23,"context_line":"\u0027metadef_resource_types\u0027 entries remains as it is and are uneccessarily"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b4740081_0672ea90","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":71},"updated":"2022-05-02 21:31:48.000000000","message":"I think you could rephrase this to make it more clear, something along the lines of \"Currently, metadef resource types are created automatically when a nonexistent resource type is mentioned in a create-resource-type-association call.  This call creates entries in both the \u0027metadef_resource_types\u0027 and \u0027metadef_namespace_resource_types\u0027 tables.","commit_id":"12de72f738819dabce5dde06664fea3312599239"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a343fe58bc9c01db686d76e2e2808fb7b469cad2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, the non existing metadef resource types are getting newly created"},{"line_number":19,"context_line":"while associating with namespace and the new entries gets added in both"},{"line_number":20,"context_line":"\u0027metadef_resource_types\u0027 and \u0027metadef_namespace_resource_types\u0027 tables."},{"line_number":21,"context_line":"But after namespace deassociation, only entries from"},{"line_number":22,"context_line":"\u0027metadef_namespace_resource_types\u0027 tables gets deleted and"},{"line_number":23,"context_line":"\u0027metadef_resource_types\u0027 entries remains as it is and are uneccessarily"}],"source_content_type":"text/x-rst","patch_set":4,"id":"a4123a89_3304c12f","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":71},"in_reply_to":"b4740081_0672ea90","updated":"2022-06-14 13:04:38.000000000","message":"Ack","commit_id":"12de72f738819dabce5dde06664fea3312599239"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"44932af500e115d8d0349654f71270db5c601c67","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"To maintain the consistency and resolve this problem, DELETE API for resource"},{"line_number":31,"context_line":"types needs to be added with \"role:metadef_admin\" similar to existing policies"},{"line_number":32,"context_line":"of other metadef delete APIs."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5c62c835_eb3c3987","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":27},"updated":"2022-05-02 21:31:48.000000000","message":"What exactly are you maintaining consistency with?","commit_id":"12de72f738819dabce5dde06664fea3312599239"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a343fe58bc9c01db686d76e2e2808fb7b469cad2","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"To maintain the consistency and resolve this problem, DELETE API for resource"},{"line_number":31,"context_line":"types needs to be added with \"role:metadef_admin\" similar to existing policies"},{"line_number":32,"context_line":"of other metadef delete APIs."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d051bfea_dcf79612","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":27},"in_reply_to":"5c62c835_eb3c3987","updated":"2022-06-14 13:04:38.000000000","message":"Consistency meaning, like other metadef resources have the dedicated create-delete apis.","commit_id":"12de72f738819dabce5dde06664fea3312599239"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"44932af500e115d8d0349654f71270db5c601c67","unresolved":true,"context_lines":[{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Data model impact"},{"line_number":40,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c20b6a8b_a4dff5a5","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":4},"updated":"2022-05-02 21:31:48.000000000","message":"How about automatically deleting the resource_type when it\u0027s no longer associated with any namespace?  (This would preserve the symmetry of there being no resource-type-create API call.)\n\nDan mentioned this on an earlier patch, and I think it\u0027s a good idea.  You could have a data migration that deletes all the un-associated resource types.  I don\u0027t like adding a delete-resource-type call without a corresponding create-resource-type call.\n\nI think the reason why there\u0027s no create-resource-type call is that you were never supposed to be able to have an un-associated resource type, and the problem is that the delete-association call wasn\u0027t implemented properly.","commit_id":"12de72f738819dabce5dde06664fea3312599239"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a343fe58bc9c01db686d76e2e2808fb7b469cad2","unresolved":true,"context_lines":[{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Data model impact"},{"line_number":40,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d83ef2f4_e87cbd78","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":4},"in_reply_to":"c20b6a8b_a4dff5a5","updated":"2022-06-14 13:04:38.000000000","message":"Yeah, but as i said earlier, it\u0027s good to give a choice to the user to delete the resource types because those resource types can be re-used later by the user if they want to.","commit_id":"12de72f738819dabce5dde06664fea3312599239"}]}