)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a20ab2ba646209b70e0380c5010a437e011c4366","unresolved":true,"context_lines":[{"line_number":10,"context_line":"This patch adds a spec for expanding the ``stores-detail`` API to"},{"line_number":11,"context_line":"expose store detaiils of other stores."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint"},{"line_number":14,"context_line":"Change-Id: I5300789b0bf648fe51798be72aa46e8e66d059f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da647a88_41424e54","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":21},"updated":"2022-04-20 06:40:02.000000000","message":"missing blueprint name","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"e1759974147c61059c632b1e65b01945114bec9f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This patch adds a spec for expanding the ``stores-detail`` API to"},{"line_number":11,"context_line":"expose store detaiils of other stores."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint"},{"line_number":14,"context_line":"Change-Id: I5300789b0bf648fe51798be72aa46e8e66d059f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0e8e7c58_cbe2774a","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":21},"in_reply_to":"da647a88_41424e54","updated":"2022-04-20 07:15:16.000000000","message":"Done","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c79a78ef24a854d19687bb274696e9d8b4395c00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9e79efc1_cec6fa36","updated":"2022-04-06 16:04:53.000000000","message":"This makes sense to me, but I think the spec should have more detail.\n\nAlso the whole thing could use some format cleanup and whitespace trimming.","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c4fadc8c5b486aad028310f9f0b4539467658556","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"caa4b2a7_bc1e42a3","updated":"2022-04-04 16:44:16.000000000","message":"recheck","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4c0ebb910a4422a0e84828fb18e9d4a9665681ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de738242_a8557d21","updated":"2022-03-31 15:55:18.000000000","message":"recheck\n\nFailure looks unrelated, × python setup.py egg_info did not run successfully.\n\n2022-03-31 15:01:15.818591 | ubuntu-focal | Looking in indexes: https://mirror.iad3.inmotion.opendev.org/pypi/simple, https://mirror.iad3.inmotion.opendev.org/wheel/ubuntu-20.04-x86_64\n2022-03-31 15:01:15.819022 | ubuntu-focal | Obtaining file:///home/zuul/src/opendev.org/openstack/glance-specs\n2022-03-31 15:01:15.819721 | ubuntu-focal |   Preparing metadata (setup.py): started\n2022-03-31 15:01:17.172325 | ubuntu-focal |   Preparing metadata (setup.py): finished with status \u0027error\u0027\n2022-03-31 15:01:17.179706 | ubuntu-focal |   error: subprocess-exited-with-error\n2022-03-31 15:01:17.179757 | ubuntu-focal |\n2022-03-31 15:01:17.179764 | ubuntu-focal |   × python setup.py egg_info did not run successfully.\n2022-03-31 15:01:17.179768 | ubuntu-focal |   │ exit code: 1\n2022-03-31 15:01:17.179772 | ubuntu-focal |   ╰─\u003e [30 lines of output]\n2022-03-31 15:01:17.179792 | ubuntu-focal |       /home/zuul/src/opendev.org/openstack/glance-specs/.tox/docs/lib/python3.8/site-packages/setuptools/dist.py:744: UserWarning: Usage of dash-separated \u0027description-file\u0027 will not be supported in future versions. Please use the underscore name \u0027description_file\u0027 instead\n2022-03-31 15:01:17.179798 | ubuntu-focal |         warnings.warn(\n2022-03-31 15:01:17.179809 | ubuntu-focal |       /home/zuul/src/opendev.org/openstack/glance-specs/.tox/docs/lib/python3.8/site-packages/setuptools/dist.py:744: UserWarning: Usage of dash-separated \u0027author-email\u0027 will not be supported in future versions. Please use the underscore name \u0027author_email\u0027 instead\n2022-03-31 15:01:17.179814 | ubuntu-focal |         warnings.warn(\n2022-03-31 15:01:17.179821 | ubuntu-focal |       /home/zuul/src/opendev.org/openstack/glance-specs/.tox/docs/lib/python3.8/site-packages/setuptools/dist.py:744: UserWarning: Usage of dash-separated \u0027home-page\u0027 will not be supported in future versions. Please use the underscore name \u0027home_page\u0027 instead\n2022-03-31 15:01:17.179828 | ubuntu-focal |         warnings.warn(\n2022-03-31 15:01:17.179839 | ubuntu-focal |       /home/zuul/src/opendev.org/openstack/glance-specs/.tox/docs/lib/python3.8/site-packages/setuptools/command/easy_install.py:144: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.\n2022-03-31 15:01:17.179846 | ubuntu-focal |         warnings.warn(\n2022-03-31 15:01:17.179850 | ubuntu-focal |       /home/zuul/src/opendev.org/openstack/glance-specs/.tox/docs/lib/python3.8/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.\n2022-03-31 15:01:17.179861 | ubuntu-focal |         warnings.warn(\n2022-03-31 15:01:17.179865 | ubuntu-focal |       /home/zuul/src/opendev.org/openstack/glance-specs/.tox/docs/lib/python3.8/site-packages/setuptools/dist.py:744: UserWarning: Usage of dash-separated \u0027description-file\u0027 will not be supported in future versions. Please use the underscore name \u0027description_file\u0027 instead\n2022-03-31 15:01:17.179870 | ubuntu-focal |         warnings.warn(\n2022-03-31 15:01:17.179875 | ubuntu-focal |       /home/zuul/src/opendev.org/openstack/glance-specs/.tox/docs/lib/python3.8/site-packages/setuptools/dist.py:744: UserWarning: Usage of dash-separated \u0027author-email\u0027 will not be supported in future versions. Please use the underscore name \u0027author_email\u0027 instead\n2022-03-31 15:01:17.179910 | ubuntu-focal |         warnings.warn(\n2022-03-31 15:01:17.179918 | ubuntu-focal |       /home/zuul/src/opendev.org/openstack/glance-specs/.tox/docs/lib/python3.8/site-packages/setuptools/dist.py:744: UserWarning: Usage of dash-separated \u0027home-page\u0027 will not be supported in future versions. Please use the underscore name \u0027home_page\u0027 instead\n2022-03-31 15:01:17.179923 | ubuntu-focal |         warnings.warn(\n2022-03-31 15:01:17.179928 | ubuntu-focal |       error: Multiple top-level packages discovered in a flat-layout: [\u0027specs\u0027, \u0027priorities\u0027].\n2022-03-31 15:01:17.179933 | ubuntu-focal |\n2022-03-31 15:01:17.179937 | ubuntu-focal |       To avoid accidental inclusion of unwanted files or directories,\n2022-03-31 15:01:17.179941 | ubuntu-focal |       setuptools will not proceed with this build.\n2022-03-31 15:01:17.179945 | ubuntu-focal |\n2022-03-31 15:01:17.179950 | ubuntu-focal |       If you are trying to create a single distribution with multiple packages\n2022-03-31 15:01:17.179954 | ubuntu-focal |       on purpose, you should not rely on automatic discovery.\n2022-03-31 15:01:17.179958 | ubuntu-focal |       Instead, consider the following options:\n2022-03-31 15:01:17.179963 | ubuntu-focal |\n2022-03-31 15:01:17.179967 | ubuntu-focal |       1. set up custom discovery (`find` directive with `include` or `exclude`)\n2022-03-31 15:01:17.179971 | ubuntu-focal |       2. use a `src-layout`\n2022-03-31 15:01:17.179976 | ubuntu-focal |       3. explicitly set `py_modules` or `packages` with a list of names\n2022-03-31 15:01:17.179980 | ubuntu-focal |\n2022-03-31 15:01:17.179985 | ubuntu-focal |       To find more information, look for \"package discovery\" on setuptools docs.\n2022-03-31 15:01:17.179989 | ubuntu-focal |       [end of output]\n2022-03-31 15:01:17.179994 | ubuntu-focal |\n2022-03-31 15:01:17.179998 | ubuntu-focal |   note: This error originates from a subprocess, and is likely not a problem with pip.\n2022-03-31 15:01:17.181975 | ubuntu-focal | error: metadata-generation-failed\n2022-03-31 15:01:17.182017 | ubuntu-focal |\n2022-03-31 15:01:17.182023 | ubuntu-focal | × Encountered error while generating package metadata.\n2022-03-31 15:01:17.182028 | ubuntu-focal | ╰─\u003e See above for output.\n2022-03-31 15:01:17.182032 | ubuntu-focal |\n2022-03-31 15:01:17.182036 | ubuntu-focal | note: This is an issue with the package mentioned above, not pip.\n2022-03-31 15:01:17.182040 | ubuntu-focal | hint: See above for details.\n2022-03-31 15:01:17.286384 | ubuntu-focal | ERROR: invocation failed (exit code 1)\n2022-03-31 15:01:17.286754 | ubuntu-focal | docs finish: developpkg /home/zuul/src/opendev.org/openstack/glance-specs after 2.07 seconds\n2022-03-31 15:01:17.287115 | ubuntu-focal | ___________________________________ summary ____________________________________\n2022-03-31 15:01:17.287262 | ubuntu-focal | ERROR:   docs: InvocationError for command /home/zuul/src/opendev.org/openstack/glance-specs/.tox/docs/bin/python -m pip install --exists-action w -e . (exited with code 1)\n2022-03-31 15:01:17.615995 | ubuntu-focal | ERROR\n2022-03-31 15:01:17.616365 | ubuntu-focal | {\n2022-03-31 15:01:17.616497 | ubuntu-focal |   \"delta\": \"0:00:28.920153\",\n2022-03-31 15:01:17.616620 | ubuntu-focal |   \"end\": \"2022-03-31 15:01:17.321856\",\n2022-03-31 15:01:17.616744 | ubuntu-focal |   \"msg\": \"non-zero return code\",\n2022-03-31 15:01:17.616857 | ubuntu-focal |   \"rc\": 1,\n2022-03-31 15:01:17.617019 | ubuntu-focal |   \"start\": \"2022-03-31 15:00:48.401703\"\n2022-03-31 15:01:17.617139 | ubuntu-focal | }\n2022-03-31 15:01:17.653738 | \n2022-03-31 15:01:17.654014 | PLAY RECAP\n2022-03-31 15:01:17.654198 | ubuntu-focal | ok: 6 changed: 3 unreachable: 0 failed: 1 skipped: 1 rescued: 0 ignored: 0","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eb1f659848cf7320410552ab744134b964eaf925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66bbc406_bf5a4dd9","in_reply_to":"de738242_a8557d21","updated":"2022-03-31 15:57:27.000000000","message":"Specific error\n\n2022-03-31 15:01:17.181975 | ubuntu-focal | error: metadata-generation-failed\n2022-03-31 15:01:17.182017 | ubuntu-focal |\n2022-03-31 15:01:17.182023 | ubuntu-focal | × Encountered error while generating package metadata.\n2022-03-31 15:01:17.182028 | ubuntu-focal | ╰─\u003e See above for output.\n2022-03-31 15:01:17.182032 | ubuntu-focal |\n2022-03-31 15:01:17.182036 | ubuntu-focal | note: This is an issue with the package mentioned above, not pip.","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5a71b53d7cfb35527217fcb6043361ccf6f4a876","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"53dd3bfd_49aa6116","updated":"2022-04-27 05:14:19.000000000","message":"Looks good, you may get some suggestion on rewording of security impact.","commit_id":"7e633a162c4a502013130f734f94aa33f0c63533"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c7f4ccf8f85b68fd3bcddce65a2d3ef50859484f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6c77b792_40b19ec4","updated":"2022-05-02 12:53:01.000000000","message":"Request for clarification inline; otherwise, this looks good.","commit_id":"7e633a162c4a502013130f734f94aa33f0c63533"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"69b4e04f92da4488a8d0440e031b03616d052d2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f204c035_90236959","updated":"2022-05-23 13:58:36.000000000","message":"Design is as per our discussion during the PTG.\nThank you all for reviews!! ","commit_id":"8eaccf946e075f23ec4cea9604c8fb7cfef86c08"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"133950ca4677389adf29f880c8da4f41a852cd24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8fa729de_739a9b03","updated":"2022-05-09 14:58:24.000000000","message":"Revision looks good to me!","commit_id":"8eaccf946e075f23ec4cea9604c8fb7cfef86c08"}],"specs/zed/approved/glance/expanding-stores-detail.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1acdaa524bdbc011fa7f312585c3bb8ee9b29327","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Expanding stores-info detail for other stores"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/glance/+spec/expanding-stores-detail "},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3e5e8c1b_506c0fd2","line":11,"range":{"start_line":11,"start_character":69,"end_line":11,"end_character":70},"updated":"2022-03-29 10:13:39.000000000","message":"remove trailing white space","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"d731a1d28b0848b41ac8228eebc336be20e8e727","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Expanding stores-info detail for other stores"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/glance/+spec/expanding-stores-detail "},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2efffaf6_fa39dd4e","line":11,"range":{"start_line":11,"start_character":69,"end_line":11,"end_character":70},"in_reply_to":"3e5e8c1b_506c0fd2","updated":"2022-03-31 14:56:38.000000000","message":"Done","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1acdaa524bdbc011fa7f312585c3bb8ee9b29327","unresolved":true,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"In Yoga release we added a new API (GET /v2/info/stores/detail) which exposes "},{"line_number":17,"context_line":"the store specific details of a store.  At the moment the Discovery API only exposes"},{"line_number":18,"context_line":"the store details and properties of the RBD backend. We want to make the make the"},{"line_number":19,"context_line":"API more generic and  expose details of  other stores also."}],"source_content_type":"text/x-rst","patch_set":1,"id":"4b8460b1_4a3e150f","line":16,"range":{"start_line":16,"start_character":77,"end_line":16,"end_character":78},"updated":"2022-03-29 10:13:39.000000000","message":"ditto","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"d731a1d28b0848b41ac8228eebc336be20e8e727","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"In Yoga release we added a new API (GET /v2/info/stores/detail) which exposes "},{"line_number":17,"context_line":"the store specific details of a store.  At the moment the Discovery API only exposes"},{"line_number":18,"context_line":"the store details and properties of the RBD backend. We want to make the make the"},{"line_number":19,"context_line":"API more generic and  expose details of  other stores also."}],"source_content_type":"text/x-rst","patch_set":1,"id":"54b17b2e_c942bb8e","line":16,"range":{"start_line":16,"start_character":77,"end_line":16,"end_character":78},"in_reply_to":"4b8460b1_4a3e150f","updated":"2022-03-31 14:56:38.000000000","message":"Done","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1acdaa524bdbc011fa7f312585c3bb8ee9b29327","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"In Yoga release we added a new API (GET /v2/info/stores/detail) which exposes "},{"line_number":17,"context_line":"the store specific details of a store.  At the moment the Discovery API only exposes"},{"line_number":18,"context_line":"the store details and properties of the RBD backend. We want to make the make the"},{"line_number":19,"context_line":"API more generic and  expose details of  other stores also."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8d634071_453f5bc6","line":18,"range":{"start_line":18,"start_character":64,"end_line":18,"end_character":81},"updated":"2022-03-29 10:13:39.000000000","message":"make the","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"d731a1d28b0848b41ac8228eebc336be20e8e727","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"In Yoga release we added a new API (GET /v2/info/stores/detail) which exposes "},{"line_number":17,"context_line":"the store specific details of a store.  At the moment the Discovery API only exposes"},{"line_number":18,"context_line":"the store details and properties of the RBD backend. We want to make the make the"},{"line_number":19,"context_line":"API more generic and  expose details of  other stores also."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8c95835e_f98c56d1","line":18,"range":{"start_line":18,"start_character":64,"end_line":18,"end_character":81},"in_reply_to":"8d634071_453f5bc6","updated":"2022-03-31 14:56:38.000000000","message":"Ack","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1acdaa524bdbc011fa7f312585c3bb8ee9b29327","unresolved":true,"context_lines":[{"line_number":26,"context_line":"specific store properties of other stores like cinder, swift, filesystem etc."},{"line_number":27,"context_line":"Options that can be beneficial to be exposed for different stores :"},{"line_number":28,"context_line":"*  Cinder: cinder_volume_type"},{"line_number":29,"context_line":"* Filesystem: filesystem_store_dir, chunk_size, thin_provisioning"},{"line_number":30,"context_line":"* Swift: container, obj_size and chunk_size"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We will use the existing method ``get_store_from_store_identifier`` which returns"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0059cff4_6ae6b12c","line":29,"range":{"start_line":29,"start_character":14,"end_line":29,"end_character":34},"updated":"2022-03-29 10:13:39.000000000","message":"we do have filesystem_store_dirs as well","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"d731a1d28b0848b41ac8228eebc336be20e8e727","unresolved":false,"context_lines":[{"line_number":26,"context_line":"specific store properties of other stores like cinder, swift, filesystem etc."},{"line_number":27,"context_line":"Options that can be beneficial to be exposed for different stores :"},{"line_number":28,"context_line":"*  Cinder: cinder_volume_type"},{"line_number":29,"context_line":"* Filesystem: filesystem_store_dir, chunk_size, thin_provisioning"},{"line_number":30,"context_line":"* Swift: container, obj_size and chunk_size"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We will use the existing method ``get_store_from_store_identifier`` which returns"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0a1720d7_32093d4e","line":29,"range":{"start_line":29,"start_character":14,"end_line":29,"end_character":34},"in_reply_to":"0059cff4_6ae6b12c","updated":"2022-03-31 14:56:38.000000000","message":"Ack","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1acdaa524bdbc011fa7f312585c3bb8ee9b29327","unresolved":true,"context_lines":[{"line_number":28,"context_line":"*  Cinder: cinder_volume_type"},{"line_number":29,"context_line":"* Filesystem: filesystem_store_dir, chunk_size, thin_provisioning"},{"line_number":30,"context_line":"* Swift: container, obj_size and chunk_size"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We will use the existing method ``get_store_from_store_identifier`` which returns"},{"line_number":33,"context_line":"the store class instance and will utilize it to fetch the store specific information"},{"line_number":34,"context_line":"to return it via API."}],"source_content_type":"text/x-rst","patch_set":1,"id":"df1e822d_79f97544","line":31,"updated":"2022-03-29 10:13:39.000000000","message":"There is S3 store as well, we need to find out important S3 properties which we can expose","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"d731a1d28b0848b41ac8228eebc336be20e8e727","unresolved":false,"context_lines":[{"line_number":28,"context_line":"*  Cinder: cinder_volume_type"},{"line_number":29,"context_line":"* Filesystem: filesystem_store_dir, chunk_size, thin_provisioning"},{"line_number":30,"context_line":"* Swift: container, obj_size and chunk_size"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We will use the existing method ``get_store_from_store_identifier`` which returns"},{"line_number":33,"context_line":"the store class instance and will utilize it to fetch the store specific information"},{"line_number":34,"context_line":"to return it via API."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f3222919_f9b1271a","line":31,"in_reply_to":"df1e822d_79f97544","updated":"2022-03-31 14:56:38.000000000","message":"Ack","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1acdaa524bdbc011fa7f312585c3bb8ee9b29327","unresolved":true,"context_lines":[{"line_number":115,"context_line":"References"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"https://review.opendev.org/c/openstack/glance-specs/+/817391 "}],"source_content_type":"text/x-rst","patch_set":1,"id":"42d3248c_e63015b5","line":118,"range":{"start_line":118,"start_character":60,"end_line":118,"end_character":61},"updated":"2022-03-29 10:13:39.000000000","message":"ditto","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"d731a1d28b0848b41ac8228eebc336be20e8e727","unresolved":false,"context_lines":[{"line_number":115,"context_line":"References"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"https://review.opendev.org/c/openstack/glance-specs/+/817391 "}],"source_content_type":"text/x-rst","patch_set":1,"id":"8a903418_7477eb3d","line":118,"range":{"start_line":118,"start_character":60,"end_line":118,"end_character":61},"in_reply_to":"42d3248c_e63015b5","updated":"2022-03-31 14:56:38.000000000","message":"Done","commit_id":"5763e157c5b50748d8769780ae5dd8121bfbfb6d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a20ab2ba646209b70e0380c5010a437e011c4366","unresolved":true,"context_lines":[{"line_number":25,"context_line":"which will expose the store specific details about the store like store type and other"},{"line_number":26,"context_line":"specific store properties of other stores like cinder, swift, filesystem etc."},{"line_number":27,"context_line":"Options that can be beneficial to be exposed for different stores :"},{"line_number":28,"context_line":"*  Cinder: cinder_volume_type"},{"line_number":29,"context_line":"* Filesystem: filesystem_store_dir, chunk_size, thin_provisioning, filesystem_store_dirs"},{"line_number":30,"context_line":"* Swift: container, obj_size and chunk_size"},{"line_number":31,"context_line":"* S3: s3_store_large_object_size, s3_store_large_object_chunk_size, s3_store_thread_pools"}],"source_content_type":"text/x-rst","patch_set":2,"id":"84499fef_a3b6b213","line":28,"updated":"2022-04-20 06:40:02.000000000","message":"nit: give a new line above line 28 for better readability","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"e1759974147c61059c632b1e65b01945114bec9f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"which will expose the store specific details about the store like store type and other"},{"line_number":26,"context_line":"specific store properties of other stores like cinder, swift, filesystem etc."},{"line_number":27,"context_line":"Options that can be beneficial to be exposed for different stores :"},{"line_number":28,"context_line":"*  Cinder: cinder_volume_type"},{"line_number":29,"context_line":"* Filesystem: filesystem_store_dir, chunk_size, thin_provisioning, filesystem_store_dirs"},{"line_number":30,"context_line":"* Swift: container, obj_size and chunk_size"},{"line_number":31,"context_line":"* S3: s3_store_large_object_size, s3_store_large_object_chunk_size, s3_store_thread_pools"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0b01fc73_fb1b3afb","line":28,"in_reply_to":"84499fef_a3b6b213","updated":"2022-04-20 07:15:16.000000000","message":"Done","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c79a78ef24a854d19687bb274696e9d8b4395c00","unresolved":true,"context_lines":[{"line_number":47,"context_line":"REST API impact"},{"line_number":48,"context_line":"---------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a11ce5a7_770bde6d","line":50,"updated":"2022-04-06 16:04:53.000000000","message":"This by definition has impact to the API right? 😊\n\nCould we have example data structures that we\u0027re expecting to see here?","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dd4b7e0e3cd95bd7572de3d424bae8c89a56f35a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"REST API impact"},{"line_number":48,"context_line":"---------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e35d51d2_c9527cc8","line":50,"in_reply_to":"8c52d84e_1f27d88a","updated":"2022-04-18 05:45:00.000000000","message":"Ack, makes sense, no harm in documenting the API response","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f42619e56293fb3a2a331e60c2c391bb940a8df7","unresolved":true,"context_lines":[{"line_number":47,"context_line":"REST API impact"},{"line_number":48,"context_line":"---------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8c52d84e_1f27d88a","line":50,"in_reply_to":"93d8267a_52c97218","updated":"2022-04-11 13:41:34.000000000","message":"Yeah, I do think that\u0027s an API impact, because you just wrote a good paragraph explaining the impact to the API :) It doesn\u0027t need to be much, but I think you should show and describe how the API is changing. Some operator or user reading this spec would rightfully be confused to see a spec that says \"add/change the api\" and then have no description of the actual change in the \"API impact\" section :)","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d8a9b42b6906e24e4481eaa24a9679d6c20507e2","unresolved":true,"context_lines":[{"line_number":47,"context_line":"REST API impact"},{"line_number":48,"context_line":"---------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"93d8267a_52c97218","line":50,"in_reply_to":"a11ce5a7_770bde6d","updated":"2022-04-11 08:38:33.000000000","message":"I\u0027m not sure if there\u0027s any API impact in this case. IIUC we\u0027ve a defined set of attributes for the response for every store i.e. \"id\", \"type\", \"description\", \"properties\" etc[1]\nWe already return values for \"id\", \"type\" and \"description\" for every store configured and return an empty JSON object {} for the \"properties\" field of stores other than RBD.\nWith this new implementation, we will now be returning the \"properties\" value for other stores but the attribute \"properties\" still exists in the current API response and that won\u0027t change and i don\u0027t consider that to be an API change, thoughts?\n\n[1] https://specs.openstack.org/openstack/glance-specs/specs/yoga/approved/glance/expose-store-specific-info.html#rest-api-impact","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c79a78ef24a854d19687bb274696e9d8b4395c00","unresolved":true,"context_lines":[{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"None"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Notifications impact"},{"line_number":58,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"86eb9f84_486c220a","line":55,"updated":"2022-04-06 16:04:53.000000000","message":"No security impact? Are there no things exposed from these that are potentially sensitive? How is exposing the filesystem_store_dir not a potential security problem?\n\nI think at least documenting that this is supposed to be admin-only is the answer, but it needs to be here, IMHO.","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"e1759974147c61059c632b1e65b01945114bec9f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"None"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Notifications impact"},{"line_number":58,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"87ed2d22_5705833d","line":55,"in_reply_to":"6bb57ae0_838e3497","updated":"2022-04-20 07:15:16.000000000","message":"Ack","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a20ab2ba646209b70e0380c5010a437e011c4366","unresolved":true,"context_lines":[{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"None"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Notifications impact"},{"line_number":58,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6bb57ae0_838e3497","line":55,"in_reply_to":"86eb9f84_486c220a","updated":"2022-04-20 06:40:02.000000000","message":"You can add here something like;\n\nIt is recommended to restrict this API call for admin users only.","commit_id":"5bf1ae6fc0f7a629469289521a2941d1ccde8648"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e414497f06e03883f856db7c4c21eee50e7c8fa4","unresolved":true,"context_lines":[{"line_number":78,"context_line":"              \"properties\": {"},{"line_number":79,"context_line":"                  \"datadir\": \"fdir\""},{"line_number":80,"context_line":"                  \"chunk_size\": 65553"},{"line_number":81,"context_line":"                  \"thin_provisioning\": false "},{"line_number":82,"context_line":"              }"},{"line_number":83,"context_line":"          },"},{"line_number":84,"context_line":"          {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6254edb6_8259c0af","line":81,"range":{"start_line":81,"start_character":44,"end_line":81,"end_character":45},"updated":"2022-04-20 07:00:55.000000000","message":"remove trailing space","commit_id":"34f10ba31f445df8a58d37c60d8fdacb473f0db3"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"e1759974147c61059c632b1e65b01945114bec9f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"              \"properties\": {"},{"line_number":79,"context_line":"                  \"datadir\": \"fdir\""},{"line_number":80,"context_line":"                  \"chunk_size\": 65553"},{"line_number":81,"context_line":"                  \"thin_provisioning\": false "},{"line_number":82,"context_line":"              }"},{"line_number":83,"context_line":"          },"},{"line_number":84,"context_line":"          {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c4b25d61_382f956e","line":81,"range":{"start_line":81,"start_character":44,"end_line":81,"end_character":45},"in_reply_to":"6254edb6_8259c0af","updated":"2022-04-20 07:15:16.000000000","message":"Done","commit_id":"34f10ba31f445df8a58d37c60d8fdacb473f0db3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c7f4ccf8f85b68fd3bcddce65a2d3ef50859484f","unresolved":true,"context_lines":[{"line_number":34,"context_line":"We will use the existing method ``get_store_from_store_identifier`` which returns"},{"line_number":35,"context_line":"the store class instance and will utilize it to fetch the store specific information"},{"line_number":36,"context_line":"to return it via API."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"},{"line_number":39,"context_line":"------------"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"6eb1a224_2a518cf2","line":37,"updated":"2022-05-02 12:53:01.000000000","message":"A question you should address: I believe all the info you are planning to return is contained in the glance config, so this call will not impact glance_store (that is, you are *not* requiring glance_store drivers to implement a \u0027get_store_properties\u0027 function that returns some kind of store_properties dict).  I think this is important because it means you won\u0027t be returning any kind of info that requires a call out to the backend to get values of properties of the store that aren\u0027t configured on the glance side.  Which is fine, I just think you should be clear here about the scope of this effort.","commit_id":"7e633a162c4a502013130f734f94aa33f0c63533"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f9a0029038e2d1072dc7c82cb57df6a17234be83","unresolved":true,"context_lines":[{"line_number":34,"context_line":"We will use the existing method ``get_store_from_store_identifier`` which returns"},{"line_number":35,"context_line":"the store class instance and will utilize it to fetch the store specific information"},{"line_number":36,"context_line":"to return it via API."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"},{"line_number":39,"context_line":"------------"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d6642624_9f287f78","line":37,"in_reply_to":"6eb1a224_2a518cf2","updated":"2022-05-04 09:39:07.000000000","message":"\u003e A question you should address: I believe all the info you are planning to return is contained in the glance config, so this call will not impact glance_store (that is, you are *not* requiring glance_store drivers to implement a \u0027get_store_properties\u0027 function that returns some kind of store_properties dict).\n\nRight, the initial idea was to have glance store changes to return store properties but i think Abhishek pointed out that we already have a method \"get_store_from_store_identifier\" which returns a glance store backend object containing all the configured properties so we just went in with the glance side implementation.\n\n\u003e I think this is important because it means you won\u0027t be returning any kind of info that requires a call out to the backend to get values of properties of the store that aren\u0027t configured on the glance side.  Which is fine, I just think you should be clear here about the scope of this effort.\n\nI\u0027ve some confusion here, we require a call to backend (\"get_store_from_store_identifier\") but we don\u0027t need any implementation on glance store side for it (since it\u0027s already there). I assume you mean to be clear about the scope of work this spec carries (i.e. the areas we need to make changes for this to work) for which i agree would be good to mention.","commit_id":"7e633a162c4a502013130f734f94aa33f0c63533"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"717ef397a7173c138d0ca65c4191fa2ff3731e32","unresolved":true,"context_lines":[{"line_number":110,"context_line":"---------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This API does expose some data that are potentially sensitive. As this is an admin-only"},{"line_number":113,"context_line":"API so there won\u0027t be any scurity impact as this data is not intended for end-users."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Notifications impact"},{"line_number":116,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"33051c0a_b421bffa","line":113,"range":{"start_line":113,"start_character":26,"end_line":113,"end_character":33},"updated":"2022-04-28 14:09:16.000000000","message":"\"security\"\n\nAs Abhi noted, this doesn\u0027t really sit that well with me, but it\u0027s not a huge deal. I\u0027d rather something like this:\n\n\"This API does expose some additional sensitive information, but only to admins, consistent with other things we already expose.\"","commit_id":"7e633a162c4a502013130f734f94aa33f0c63533"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c7f4ccf8f85b68fd3bcddce65a2d3ef50859484f","unresolved":true,"context_lines":[{"line_number":110,"context_line":"---------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This API does expose some data that are potentially sensitive. As this is an admin-only"},{"line_number":113,"context_line":"API so there won\u0027t be any scurity impact as this data is not intended for end-users."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Notifications impact"},{"line_number":116,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c460b74e_1a56939e","line":113,"range":{"start_line":113,"start_character":26,"end_line":113,"end_character":33},"in_reply_to":"33051c0a_b421bffa","updated":"2022-05-02 12:53:01.000000000","message":"I agree with Dan\u0027s suggestion.","commit_id":"7e633a162c4a502013130f734f94aa33f0c63533"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"f62cb34e7a5cac8d5e0be31f14eb09291c296968","unresolved":false,"context_lines":[{"line_number":110,"context_line":"---------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This API does expose some data that are potentially sensitive. As this is an admin-only"},{"line_number":113,"context_line":"API so there won\u0027t be any scurity impact as this data is not intended for end-users."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Notifications impact"},{"line_number":116,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"574ec349_b180c936","line":113,"range":{"start_line":113,"start_character":26,"end_line":113,"end_character":33},"in_reply_to":"5978cd29_65ffbd37","updated":"2022-05-06 08:12:59.000000000","message":"Done","commit_id":"7e633a162c4a502013130f734f94aa33f0c63533"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f9a0029038e2d1072dc7c82cb57df6a17234be83","unresolved":true,"context_lines":[{"line_number":110,"context_line":"---------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This API does expose some data that are potentially sensitive. As this is an admin-only"},{"line_number":113,"context_line":"API so there won\u0027t be any scurity impact as this data is not intended for end-users."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Notifications impact"},{"line_number":116,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5978cd29_65ffbd37","line":113,"range":{"start_line":113,"start_character":26,"end_line":113,"end_character":33},"in_reply_to":"c460b74e_1a56939e","updated":"2022-05-04 09:39:07.000000000","message":"+1","commit_id":"7e633a162c4a502013130f734f94aa33f0c63533"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c7f4ccf8f85b68fd3bcddce65a2d3ef50859484f","unresolved":true,"context_lines":[{"line_number":172,"context_line":"Add documentation providing details about the properties exposed for each store"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"References"},{"line_number":175,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"https://review.opendev.org/c/openstack/glance-specs/+/817391"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c614ce1a_0c0c593c","line":175,"updated":"2022-05-02 12:53:01.000000000","message":"I think it\u0027s worth adding https://review.opendev.org/c/openstack/glance/+/824438 (the implementation for RBD store) here","commit_id":"7e633a162c4a502013130f734f94aa33f0c63533"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"f62cb34e7a5cac8d5e0be31f14eb09291c296968","unresolved":false,"context_lines":[{"line_number":172,"context_line":"Add documentation providing details about the properties exposed for each store"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"References"},{"line_number":175,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"https://review.opendev.org/c/openstack/glance-specs/+/817391"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9c780a3c_7d11db96","line":175,"in_reply_to":"c614ce1a_0c0c593c","updated":"2022-05-06 08:12:59.000000000","message":"Done","commit_id":"7e633a162c4a502013130f734f94aa33f0c63533"}]}