)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"ace377d7c983aacead7adf7584f4bb800b80c255","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cdbc6633_1033cd72","updated":"2022-04-27 15:15:08.000000000","message":"In PTG session we agreed to not add new API for this, but modify the logic of the queueing call to kick off the caching right away unless it\u0027s already doing so. This way we can get rid of the periodic job, speed up the caching to begin and the change for user will be just improved experience rather than needing to manually control it.","commit_id":"581d9ec363261688e08586b1d44d5d0ccc80a06a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ba2f820be470cf2625de880f7054b87e6d023919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d57ebcde_bb6b5837","in_reply_to":"cdbc6633_1033cd72","updated":"2022-04-29 07:41:30.000000000","message":"Yep, thank you for reminding me about the same.\nMade changes as per our discussion during PTG.","commit_id":"581d9ec363261688e08586b1d44d5d0ccc80a06a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f287c5e38f9de5573c551b276cb91083331b5c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0b5b519c_b7300bfc","updated":"2022-05-02 16:05:46.000000000","message":"Mostly looks good!  A few things noted inline.","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d35c80ea0e2a319bb3f7211dc34d26d30cbd3f23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ccc36513_6b02b799","updated":"2022-05-04 05:30:06.000000000","message":"thank you for review Brian, made changes as per your suggestion.\n","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc8b656b689e308b177712b704d581155690dc19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6f9bc72a_c4672ef9","updated":"2022-05-06 05:33:09.000000000","message":"Thank you for review Dan and Cyril!","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a8d9b6cb9979ac4af9f1b2d417cc60aba7fcc6ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2c1e002b_204cb349","updated":"2022-05-05 17:22:37.000000000","message":"This looks cool to me, but I think we should drop the REST API impact because from the API user\u0027s perspective, nothing has changed. This should just describe the change on how or how often we run the cache interval (which is to say, immediately).","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2425f4c60bef3aca458e5cdf7ba45fc83941c6ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1803daa5_ea211288","updated":"2022-05-06 13:25:17.000000000","message":"Revisions LGTM.","commit_id":"ebd62d9a24e4f7148c2aa41c6b0b57f5e58ad4c6"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"719a1c66f42694a258804840477e7713ce01268d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2594f391_ba944b52","updated":"2022-05-09 14:31:13.000000000","message":"Just one addition to the work items, otherwise looks good!","commit_id":"8c796cf195c383303c30eadcf7a43411a2eeeaf8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"83b13e269d79feb5106b09f2952e17cf89e4074e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9348fb20_4ad40bd6","updated":"2022-05-07 19:00:34.000000000","message":"Looks like a good proposal.","commit_id":"8c796cf195c383303c30eadcf7a43411a2eeeaf8"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"80bbac40f9d33d3e91c906f9fa2f49aba1055c3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4d316756_1ceeb8ff","updated":"2022-05-09 14:47:55.000000000","message":"LGTM","commit_id":"c7bce04f5bc65f3e8014196fa685e44e2839afb6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5587940d5b516e562d0c84591f706a302efa070c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ff2f8c17_f8873432","updated":"2022-05-09 14:55:51.000000000","message":"Revisions LGTM.","commit_id":"c7bce04f5bc65f3e8014196fa685e44e2839afb6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b7f7ea916a6489a659404303c1ef05c47130ba48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f64e0199_ae94ebcf","updated":"2022-05-09 14:36:11.000000000","message":"Thank you Erno for review, made changes as per your suggestion!","commit_id":"c7bce04f5bc65f3e8014196fa685e44e2839afb6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2ccc489cba9f8c02fe828ba18a1949fba8626ec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2b429d3b_a81075fb","updated":"2022-05-09 14:57:27.000000000","message":"Thank you all for reviews, approving since the proposal meets the approval criteria!","commit_id":"c7bce04f5bc65f3e8014196fa685e44e2839afb6"}],"specs/template.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f287c5e38f9de5573c551b276cb91083331b5c0","unresolved":true,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Example Spec - The title of your blueprint"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"41e8405c_39d59f02","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":0},"updated":"2022-05-02 16:05:46.000000000","message":"Any reason why you removed this from your spec?","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d35c80ea0e2a319bb3f7211dc34d26d30cbd3f23","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Example Spec - The title of your blueprint"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"453933dd_10ef1c1a","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":0},"in_reply_to":"41e8405c_39d59f02","updated":"2022-05-04 05:30:06.000000000","message":"Generally I always used to remove this part from the spec, will add it back.\nI was not aware that this is required part of the spec.","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"}],"specs/zed/approved/glance/instant_caching.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f287c5e38f9de5573c551b276cb91083331b5c0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Provision for instant caching of an image"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Include the URL of your launchpad blueprint:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"086bf37e_3d192e64","line":2,"range":{"start_line":2,"start_character":14,"end_line":2,"end_character":21},"updated":"2022-05-02 16:05:46.000000000","message":"I think this would be better as \"immediate\", because you\u0027re proposing to do it as soon as possible, not instantaneously!","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d35c80ea0e2a319bb3f7211dc34d26d30cbd3f23","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Provision for instant caching of an image"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Include the URL of your launchpad blueprint:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f6ffeb71_c422c26c","line":2,"range":{"start_line":2,"start_character":14,"end_line":2,"end_character":21},"in_reply_to":"086bf37e_3d192e64","updated":"2022-05-04 05:30:06.000000000","message":"Done","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f287c5e38f9de5573c551b276cb91083331b5c0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"https://blueprints.launchpad.net/glance/+spec/instant_caching"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Provision for instant cache given image on a particular glance node."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"31e94cde_aaf6c4e8","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":39},"updated":"2022-05-02 16:05:46.000000000","message":"immediate caching of a given image","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d35c80ea0e2a319bb3f7211dc34d26d30cbd3f23","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"https://blueprints.launchpad.net/glance/+spec/instant_caching"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Provision for instant cache given image on a particular glance node."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"87d441b0_df4bb3d5","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":39},"in_reply_to":"31e94cde_aaf6c4e8","updated":"2022-05-04 05:30:06.000000000","message":"Done","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f287c5e38f9de5573c551b276cb91083331b5c0","unresolved":true,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"We are proposing to remove existing periodic job from glance-api and add modify"},{"line_number":27,"context_line":"existing `/v2/cache/{image_id}/` PUT API which will queue an image for caching"},{"line_number":28,"context_line":"abd start caching it immediately. If any existing instant caching operation is"},{"line_number":29,"context_line":"in progress then the latest image will be added to the queue so that it will"},{"line_number":30,"context_line":"be picked up for caching as soon as previous operation completes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"13393798_33c25981","line":27,"range":{"start_line":27,"start_character":9,"end_line":27,"end_character":41},"updated":"2022-05-02 16:05:46.000000000","message":"``PUT /v2/cache/{image_id}`` API","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d35c80ea0e2a319bb3f7211dc34d26d30cbd3f23","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"We are proposing to remove existing periodic job from glance-api and add modify"},{"line_number":27,"context_line":"existing `/v2/cache/{image_id}/` PUT API which will queue an image for caching"},{"line_number":28,"context_line":"abd start caching it immediately. If any existing instant caching operation is"},{"line_number":29,"context_line":"in progress then the latest image will be added to the queue so that it will"},{"line_number":30,"context_line":"be picked up for caching as soon as previous operation completes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"f376e250_53095be0","line":27,"range":{"start_line":27,"start_character":9,"end_line":27,"end_character":41},"in_reply_to":"13393798_33c25981","updated":"2022-05-04 05:30:06.000000000","message":"Done","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f287c5e38f9de5573c551b276cb91083331b5c0","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"We are proposing to remove existing periodic job from glance-api and add modify"},{"line_number":27,"context_line":"existing `/v2/cache/{image_id}/` PUT API which will queue an image for caching"},{"line_number":28,"context_line":"abd start caching it immediately. If any existing instant caching operation is"},{"line_number":29,"context_line":"in progress then the latest image will be added to the queue so that it will"},{"line_number":30,"context_line":"be picked up for caching as soon as previous operation completes."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"2ccf59f9_ad273e3d","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":3},"updated":"2022-05-02 16:05:46.000000000","message":"and","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d35c80ea0e2a319bb3f7211dc34d26d30cbd3f23","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"We are proposing to remove existing periodic job from glance-api and add modify"},{"line_number":27,"context_line":"existing `/v2/cache/{image_id}/` PUT API which will queue an image for caching"},{"line_number":28,"context_line":"abd start caching it immediately. If any existing instant caching operation is"},{"line_number":29,"context_line":"in progress then the latest image will be added to the queue so that it will"},{"line_number":30,"context_line":"be picked up for caching as soon as previous operation completes."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"84f495b2_877087b8","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":3},"in_reply_to":"2ccf59f9_ad273e3d","updated":"2022-05-04 05:30:06.000000000","message":"Done","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f287c5e38f9de5573c551b276cb91083331b5c0","unresolved":true,"context_lines":[{"line_number":27,"context_line":"existing `/v2/cache/{image_id}/` PUT API which will queue an image for caching"},{"line_number":28,"context_line":"abd start caching it immediately. If any existing instant caching operation is"},{"line_number":29,"context_line":"in progress then the latest image will be added to the queue so that it will"},{"line_number":30,"context_line":"be picked up for caching as soon as previous operation completes."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"71bdaee2_93d1d568","line":30,"updated":"2022-05-02 16:05:46.000000000","message":"OK, so this won\u0027t be instantaneous if the queue is non-empty.  Might be worth mentioning that you can make the ``GET /v2/cache`` call to see the size of the queue.","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d35c80ea0e2a319bb3f7211dc34d26d30cbd3f23","unresolved":false,"context_lines":[{"line_number":27,"context_line":"existing `/v2/cache/{image_id}/` PUT API which will queue an image for caching"},{"line_number":28,"context_line":"abd start caching it immediately. If any existing instant caching operation is"},{"line_number":29,"context_line":"in progress then the latest image will be added to the queue so that it will"},{"line_number":30,"context_line":"be picked up for caching as soon as previous operation completes."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"847f15a5_d5772e56","line":30,"in_reply_to":"71bdaee2_93d1d568","updated":"2022-05-04 05:30:06.000000000","message":"Done","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f287c5e38f9de5573c551b276cb91083331b5c0","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"**Common Response Codes**"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* Caching Success: `202 Accepted`"},{"line_number":66,"context_line":"* Failure: `400 Bad Request` with details."},{"line_number":67,"context_line":"* Forbidden: `403 Forbidden`"},{"line_number":68,"context_line":"* 404: `404 Image Not Found`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"87b89179_de0824e5","line":65,"range":{"start_line":65,"start_character":19,"end_line":65,"end_character":33},"updated":"2022-05-02 16:05:46.000000000","message":"This is a change from the current API, which is returning 200 (with an empty response body) for this:\n\nhttps://opendev.org/openstack/glance/src/commit/cb65cc8e44523cd04ecace02296061a6ddc3982d/glance/tests/functional/v2/test_cache_api.py#L82\n\nThat being said, the original spec said this was supposed to be a 202:\n\nhttps://opendev.org/openstack/glance-specs/blame/commit/2638ada23d92f714f54b71db00330e4a6c921beb/specs/xena/approved/glance/cache-api.rst#L153\n\nI think we should file a bug for the incorrect response code (that is, change the response to a 202 immediately in master independently of this spec) and backport it to yoga and xena before anyone notices.","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d35c80ea0e2a319bb3f7211dc34d26d30cbd3f23","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"**Common Response Codes**"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* Caching Success: `202 Accepted`"},{"line_number":66,"context_line":"* Failure: `400 Bad Request` with details."},{"line_number":67,"context_line":"* Forbidden: `403 Forbidden`"},{"line_number":68,"context_line":"* 404: `404 Image Not Found`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"09e4d1ba_38e27f3b","line":65,"range":{"start_line":65,"start_character":19,"end_line":65,"end_character":33},"in_reply_to":"87b89179_de0824e5","updated":"2022-05-04 05:30:06.000000000","message":"Ack, will report a bug and fix it right away.\nI think we need to backport it to Yoga only since in yoga we have added this work.","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f287c5e38f9de5573c551b276cb91083331b5c0","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"PUT /v2/cache/{image_id}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Response codes:"},{"line_number":75,"context_line":"* 202 -- The request has been accepted, the image will be cached"},{"line_number":76,"context_line":"* 403 -- Permission denied"},{"line_number":77,"context_line":"* 404 -- Image not found"}],"source_content_type":"text/x-rst","patch_set":2,"id":"cde8514a_07e4b09a","line":74,"updated":"2022-05-02 16:05:46.000000000","message":"formatting: need a blank line here","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d35c80ea0e2a319bb3f7211dc34d26d30cbd3f23","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"PUT /v2/cache/{image_id}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Response codes:"},{"line_number":75,"context_line":"* 202 -- The request has been accepted, the image will be cached"},{"line_number":76,"context_line":"* 403 -- Permission denied"},{"line_number":77,"context_line":"* 404 -- Image not found"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba6049b6_9687d7a3","line":74,"in_reply_to":"cde8514a_07e4b09a","updated":"2022-05-04 05:30:06.000000000","message":"Done","commit_id":"74445abf9a64ed1e07a2f31a7a8e14beb73eec1f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a8d9b6cb9979ac4af9f1b2d417cc60aba7fcc6ae","unresolved":true,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We are proposing to remove existing periodic job from glance-api and add modify"},{"line_number":33,"context_line":"existing ``PUT /v2/cache/{image_id}`` API which will queue an image for caching"},{"line_number":34,"context_line":"and start caching it immediately. If any existing instant caching operation is"},{"line_number":35,"context_line":"in progress then the latest image will be added to the queue so that it will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a27fad0_e2be321f","line":32,"range":{"start_line":32,"start_character":69,"end_line":32,"end_character":72},"updated":"2022-05-05 17:22:37.000000000","message":"s/add modify/modify the/","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc8b656b689e308b177712b704d581155690dc19","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We are proposing to remove existing periodic job from glance-api and add modify"},{"line_number":33,"context_line":"existing ``PUT /v2/cache/{image_id}`` API which will queue an image for caching"},{"line_number":34,"context_line":"and start caching it immediately. If any existing instant caching operation is"},{"line_number":35,"context_line":"in progress then the latest image will be added to the queue so that it will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4cb40e52_29ef8ff1","line":32,"range":{"start_line":32,"start_character":69,"end_line":32,"end_character":72},"in_reply_to":"1a27fad0_e2be321f","updated":"2022-05-06 05:33:09.000000000","message":"Done","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"1f0cbee4d45fbb31dfbda3cf718603ab68637e03","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We are proposing to remove existing periodic job from glance-api and add modify"},{"line_number":33,"context_line":"existing ``PUT /v2/cache/{image_id}`` API which will queue an image for caching"},{"line_number":34,"context_line":"and start caching it immediately. If any existing instant caching operation is"},{"line_number":35,"context_line":"in progress then the latest image will be added to the queue so that it will"},{"line_number":36,"context_line":"be picked up for caching as soon as previous operation completes. User can use"},{"line_number":37,"context_line":"``GET /v2/cache`` API call to see the size of the queue."}],"source_content_type":"text/x-rst","patch_set":4,"id":"2920cef7_e40de1c7","line":34,"range":{"start_line":34,"start_character":34,"end_line":34,"end_character":36},"updated":"2022-05-05 20:32:40.000000000","message":"1) Why didn\u0027t we implement this feature this way from the start? Was there a technical reason that prevented us from doing so?\n\n2) If there are a lot of images to be cached in the queue, doesn\u0027t that prevent one specific image from being immediately cached?","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc8b656b689e308b177712b704d581155690dc19","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We are proposing to remove existing periodic job from glance-api and add modify"},{"line_number":33,"context_line":"existing ``PUT /v2/cache/{image_id}`` API which will queue an image for caching"},{"line_number":34,"context_line":"and start caching it immediately. If any existing instant caching operation is"},{"line_number":35,"context_line":"in progress then the latest image will be added to the queue so that it will"},{"line_number":36,"context_line":"be picked up for caching as soon as previous operation completes. User can use"},{"line_number":37,"context_line":"``GET /v2/cache`` API call to see the size of the queue."}],"source_content_type":"text/x-rst","patch_set":4,"id":"a53c1126_3b628ca2","line":34,"range":{"start_line":34,"start_character":34,"end_line":34,"end_character":36},"in_reply_to":"2920cef7_e40de1c7","updated":"2022-05-06 05:33:09.000000000","message":"1. Initially glance cache was not part of API and it was managed by external tool called as glance-cache-prefetcher, later when we moved the caching operations to API we moved this prefetcher part as a periodic job which is currently running after specific intervals (which is not in end users hand).\n\n2. So to avoid this part we are now modifying any API to immediately trigger caching if it is not running or else add the image to the queue which can be picked later for caching. If the operation is already in progress then yes it\u0027s not very immediate caching, but also it will not wait until next periodic run (which we don\u0027t know how much time admin has configured for the same)","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"1f0cbee4d45fbb31dfbda3cf718603ab68637e03","unresolved":true,"context_lines":[{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Instead of modifying exiting API, we can add a new POST API which will start"},{"line_number":43,"context_line":"instant caching of specified image. We can use existing policy `cache_image`"},{"line_number":44,"context_line":"so that user with appropriate permissions can perform this operation. To make"},{"line_number":45,"context_line":"the policy compatible with secure RBAC we need to ensure to pass required"}],"source_content_type":"text/x-rst","patch_set":4,"id":"153afde1_1ecb2e1b","line":42,"range":{"start_line":42,"start_character":21,"end_line":42,"end_character":28},"updated":"2022-05-05 20:32:40.000000000","message":"existing*","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc8b656b689e308b177712b704d581155690dc19","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Alternatives"},{"line_number":40,"context_line":"------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Instead of modifying exiting API, we can add a new POST API which will start"},{"line_number":43,"context_line":"instant caching of specified image. We can use existing policy `cache_image`"},{"line_number":44,"context_line":"so that user with appropriate permissions can perform this operation. To make"},{"line_number":45,"context_line":"the policy compatible with secure RBAC we need to ensure to pass required"}],"source_content_type":"text/x-rst","patch_set":4,"id":"f15f6c4c_1f8a8266","line":42,"range":{"start_line":42,"start_character":21,"end_line":42,"end_character":28},"in_reply_to":"153afde1_1ecb2e1b","updated":"2022-05-06 05:33:09.000000000","message":"Done","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a8d9b6cb9979ac4af9f1b2d417cc60aba7fcc6ae","unresolved":true,"context_lines":[{"line_number":42,"context_line":"Instead of modifying exiting API, we can add a new POST API which will start"},{"line_number":43,"context_line":"instant caching of specified image. We can use existing policy `cache_image`"},{"line_number":44,"context_line":"so that user with appropriate permissions can perform this operation. To make"},{"line_number":45,"context_line":"the policy compatible with secure RBAC we need to ensure to pass required"},{"line_number":46,"context_line":"parameters like ImageTarget while enforcing the policy. It is recommended"},{"line_number":47,"context_line":"to keep `cache_image` operation limited to admin use only."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"b40dd8e1_c5696a2e","line":45,"range":{"start_line":45,"start_character":50,"end_line":45,"end_character":59},"updated":"2022-05-05 17:22:37.000000000","message":"s/ensure to//\n\nsounds a little more native","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc8b656b689e308b177712b704d581155690dc19","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Instead of modifying exiting API, we can add a new POST API which will start"},{"line_number":43,"context_line":"instant caching of specified image. We can use existing policy `cache_image`"},{"line_number":44,"context_line":"so that user with appropriate permissions can perform this operation. To make"},{"line_number":45,"context_line":"the policy compatible with secure RBAC we need to ensure to pass required"},{"line_number":46,"context_line":"parameters like ImageTarget while enforcing the policy. It is recommended"},{"line_number":47,"context_line":"to keep `cache_image` operation limited to admin use only."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"79ed8d4b_27c8e929","line":45,"range":{"start_line":45,"start_character":50,"end_line":45,"end_character":59},"in_reply_to":"b40dd8e1_c5696a2e","updated":"2022-05-06 05:33:09.000000000","message":"Done","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a8d9b6cb9979ac4af9f1b2d417cc60aba7fcc6ae","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"**Modify existing API**"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Queue an image and start instant caching"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"**Common Response Codes**"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"50d730e0_9c7bd733","line":68,"updated":"2022-05-05 17:22:37.000000000","message":"This is actually not a change right? As far as the user was concerned, queuing an image means it could start caching at any moment. If we had our interval set very low, or we got lucky, the image would seem to start immediately from our perspective.\n\nSo I think if it were me, I\u0027d say this has \"No REST API impact\" and position this as purely a backend behavioral difference. Your codes below still indicate \"202: I\u0027ll start caching this at some point\" so...","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc8b656b689e308b177712b704d581155690dc19","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"**Modify existing API**"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Queue an image and start instant caching"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"**Common Response Codes**"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"a8555798_ff280de7","line":68,"in_reply_to":"50d730e0_9c7bd733","updated":"2022-05-06 05:33:09.000000000","message":"Done","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a8d9b6cb9979ac4af9f1b2d417cc60aba7fcc6ae","unresolved":true,"context_lines":[{"line_number":83,"context_line":"* 202 -- The request has been accepted, the image will be cached"},{"line_number":84,"context_line":"* 403 -- Permission denied"},{"line_number":85,"context_line":"* 404 -- Image not found"},{"line_number":86,"context_line":"* 400 -- Bad request"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Security impact"},{"line_number":89,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d5331108_97750825","line":86,"updated":"2022-05-05 17:22:37.000000000","message":"Are these any different from the existing behavior?","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc8b656b689e308b177712b704d581155690dc19","unresolved":false,"context_lines":[{"line_number":83,"context_line":"* 202 -- The request has been accepted, the image will be cached"},{"line_number":84,"context_line":"* 403 -- Permission denied"},{"line_number":85,"context_line":"* 404 -- Image not found"},{"line_number":86,"context_line":"* 400 -- Bad request"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Security impact"},{"line_number":89,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ae5366bc_3d815b91","line":86,"in_reply_to":"d5331108_97750825","updated":"2022-05-06 05:33:09.000000000","message":"No, removed it","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a8d9b6cb9979ac4af9f1b2d417cc60aba7fcc6ae","unresolved":true,"context_lines":[{"line_number":108,"context_line":"Other deployer impact"},{"line_number":109,"context_line":"---------------------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Caching will be local to each glance node and as this command will be"},{"line_number":112,"context_line":"executed remotely, operator needs to know the direct URL of each glance"},{"line_number":113,"context_line":"node which are behind the load balancer. Operator need to provide this"},{"line_number":114,"context_line":"direct URL to glanceclient so that client should hit particular node"}],"source_content_type":"text/x-rst","patch_set":4,"id":"2602489c_24ee2b8f","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":16},"updated":"2022-05-05 17:22:37.000000000","message":"s/will be/is and will remain/\n\n..right? no change with this.","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc8b656b689e308b177712b704d581155690dc19","unresolved":false,"context_lines":[{"line_number":108,"context_line":"Other deployer impact"},{"line_number":109,"context_line":"---------------------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Caching will be local to each glance node and as this command will be"},{"line_number":112,"context_line":"executed remotely, operator needs to know the direct URL of each glance"},{"line_number":113,"context_line":"node which are behind the load balancer. Operator need to provide this"},{"line_number":114,"context_line":"direct URL to glanceclient so that client should hit particular node"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b4a2a394_c5d2f7b2","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":16},"in_reply_to":"2602489c_24ee2b8f","updated":"2022-05-06 05:33:09.000000000","message":"right!","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a8d9b6cb9979ac4af9f1b2d417cc60aba7fcc6ae","unresolved":true,"context_lines":[{"line_number":127,"context_line":"-----------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Primary assignee:"},{"line_number":130,"context_line":"  dansimth or abhishekk"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Other contributors:"},{"line_number":133,"context_line":"  None"}],"source_content_type":"text/x-rst","patch_set":4,"id":"684a85af_b7e6aecd","line":130,"range":{"start_line":130,"start_character":2,"end_line":130,"end_character":10},"updated":"2022-05-05 17:22:37.000000000","message":"who is this? :P","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f591a7dfb4c3e958e85cac8897eb44d9736f6735","unresolved":false,"context_lines":[{"line_number":127,"context_line":"-----------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Primary assignee:"},{"line_number":130,"context_line":"  dansimth or abhishekk"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Other contributors:"},{"line_number":133,"context_line":"  None"}],"source_content_type":"text/x-rst","patch_set":4,"id":"85a2ca6b_08ca0f9e","line":130,"range":{"start_line":130,"start_character":2,"end_line":130,"end_character":10},"in_reply_to":"0a1e9a63_8be2adea","updated":"2022-05-06 13:53:22.000000000","message":"My point was that it\u0027s misspelled :)","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc8b656b689e308b177712b704d581155690dc19","unresolved":false,"context_lines":[{"line_number":127,"context_line":"-----------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Primary assignee:"},{"line_number":130,"context_line":"  dansimth or abhishekk"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Other contributors:"},{"line_number":133,"context_line":"  None"}],"source_content_type":"text/x-rst","patch_set":4,"id":"0a1e9a63_8be2adea","line":130,"range":{"start_line":130,"start_character":2,"end_line":130,"end_character":10},"in_reply_to":"684a85af_b7e6aecd","updated":"2022-05-06 05:33:09.000000000","message":"Top contributor :D","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4fe8ac6d4bef04c799b71f116ab49300a8aca338","unresolved":false,"context_lines":[{"line_number":127,"context_line":"-----------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Primary assignee:"},{"line_number":130,"context_line":"  dansimth or abhishekk"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Other contributors:"},{"line_number":133,"context_line":"  None"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d961601a_466c4964","line":130,"range":{"start_line":130,"start_character":2,"end_line":130,"end_character":10},"in_reply_to":"85a2ca6b_08ca0f9e","updated":"2022-05-06 14:01:16.000000000","message":"Ohh :D,fixed it!","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a8d9b6cb9979ac4af9f1b2d417cc60aba7fcc6ae","unresolved":true,"context_lines":[{"line_number":152,"context_line":"Testing"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* All new cache API should be tested using tempest tests"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"59736de3_896d3a69","line":155,"updated":"2022-05-05 17:22:37.000000000","message":"and specifically \"will be testable with this change, where it currently isn\u0027t really\"","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc8b656b689e308b177712b704d581155690dc19","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Testing"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* All new cache API should be tested using tempest tests"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5bab3b59_2c7ae521","line":155,"in_reply_to":"59736de3_896d3a69","updated":"2022-05-06 05:33:09.000000000","message":"Yes","commit_id":"6ddcf4d948cf8a8219dfba5d31956db09054e74f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2425f4c60bef3aca458e5cdf7ba45fc83941c6ce","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Caching is and will remain local to each glance node and as this command"},{"line_number":90,"context_line":"will be executed remotely, operator needs to know the direct URL of"},{"line_number":91,"context_line":"each glance node which are behind the load balancer. Operator need to"},{"line_number":92,"context_line":"provide this direct URL to glanceclient so that client should hit"},{"line_number":93,"context_line":"particular node to trigger immediate caching on that node."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"a685ec2e_dda817c2","line":91,"range":{"start_line":91,"start_character":62,"end_line":91,"end_character":66},"updated":"2022-05-06 13:25:17.000000000","message":"nit: needs","commit_id":"ebd62d9a24e4f7148c2aa41c6b0b57f5e58ad4c6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"411e4637b3767e1a02258984a85369bd63ca5579","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Caching is and will remain local to each glance node and as this command"},{"line_number":90,"context_line":"will be executed remotely, operator needs to know the direct URL of"},{"line_number":91,"context_line":"each glance node which are behind the load balancer. Operator need to"},{"line_number":92,"context_line":"provide this direct URL to glanceclient so that client should hit"},{"line_number":93,"context_line":"particular node to trigger immediate caching on that node."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9c753ae9_cc4b3c52","line":91,"range":{"start_line":91,"start_character":62,"end_line":91,"end_character":66},"in_reply_to":"a685ec2e_dda817c2","updated":"2022-05-06 14:00:42.000000000","message":"Done","commit_id":"ebd62d9a24e4f7148c2aa41c6b0b57f5e58ad4c6"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"719a1c66f42694a258804840477e7713ce01268d","unresolved":true,"context_lines":[{"line_number":119,"context_line":"* Modify existing API (PUT /v2/cache/{image_id})"},{"line_number":120,"context_line":"* Modify documentation, update API reference"},{"line_number":121,"context_line":"* Tempest coverage for Caching operations"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Dependencies"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"cc33ff2f_e97da885","line":122,"updated":"2022-05-09 14:31:13.000000000","message":"* remove the \u0027cache_prefetcher_interval\u0027 config option and related tests.","commit_id":"8c796cf195c383303c30eadcf7a43411a2eeeaf8"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b7f7ea916a6489a659404303c1ef05c47130ba48","unresolved":false,"context_lines":[{"line_number":119,"context_line":"* Modify existing API (PUT /v2/cache/{image_id})"},{"line_number":120,"context_line":"* Modify documentation, update API reference"},{"line_number":121,"context_line":"* Tempest coverage for Caching operations"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Dependencies"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0356f01c_3b7aade4","line":122,"in_reply_to":"cc33ff2f_e97da885","updated":"2022-05-09 14:36:11.000000000","message":"Done","commit_id":"8c796cf195c383303c30eadcf7a43411a2eeeaf8"}]}