)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4aa03559496739aabd75b68b1a45769f631318cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87dca42e_3d169512","updated":"2023-01-05 05:39:43.000000000","message":"recheck","commit_id":"cb7adee31db802836c2d7dde0b6d50fefb930d34"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"032c80f65501fc37c1a6fc89630022c23c6d4aa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"002c44c0_d38e0c30","updated":"2023-01-10 04:49:45.000000000","message":"Looks good to me, thank you!!","commit_id":"35a063fbe6b532a972e1941936914ce791ac2129"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bef5bd13289f061ce845ad3497f94f870da9460f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b24ff7f1_bf4c4dd7","updated":"2023-01-09 17:52:20.000000000","message":"Thanks Abhishek","commit_id":"35a063fbe6b532a972e1941936914ce791ac2129"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"e1328e4e85757cd886b29e15d942470edd68382b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f6d2630c_b585674f","updated":"2023-01-18 11:38:54.000000000","message":"Looks good to me, Thanks Rajat!","commit_id":"2c71030db43e3e73c9396daf1032c419ae3b54c6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"037b44fba9cb5431fbf0acabd80f83aed8cd9df4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"67c95f9a_baf7f515","updated":"2023-01-16 17:54:44.000000000","message":"Looks good, thank you!","commit_id":"2c71030db43e3e73c9396daf1032c419ae3b54c6"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"f74f61efe77ec962b4427406420cb0603eebd43c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0f82bd61_9f57cdb1","updated":"2023-01-20 12:31:59.000000000","message":"Approving the spec as we have got minimum required approvals and the proposal is as per the discussion.\nThanks all the reviewers !!\n\n ","commit_id":"481b2228949e013417042e5713f3e4fac40f85e3"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"3dd27b8258ba027e3aaf82414c6bf6d9645fbce9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"91ea3c52_fb589ee5","updated":"2023-01-20 06:18:00.000000000","message":"Looks good !\nThanks !","commit_id":"481b2228949e013417042e5713f3e4fac40f85e3"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"7fa2e9896d5b7faf50a1686ea1c326230454eb6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2541b7bc_28662c75","updated":"2023-01-20 06:17:20.000000000","message":"Thank you Rajat!","commit_id":"481b2228949e013417042e5713f3e4fac40f85e3"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"319071a5573981c7cf1ab7b4848a9103b4741d20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a36c4623_d1984bce","updated":"2023-01-20 11:26:59.000000000","message":"Thanks Rajat!\n\nlgtm","commit_id":"481b2228949e013417042e5713f3e4fac40f85e3"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ca2172c0dcf24c5699c6802cea4f412897710e6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"07148778_b568d34a","updated":"2023-01-20 11:33:12.000000000","message":"This looks good to me, just a simple question about the option we\u0027re adding.","commit_id":"481b2228949e013417042e5713f3e4fac40f85e3"}],"specs/2023.1/approved/glance_store/cinder_extend_in-use_volumes.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"55840cb39bde0116a6900febdb20365a997518dd","unresolved":true,"context_lines":[{"line_number":10,"context_line":":project: glance_store"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":":problem: When creating an image in cinder store, we perform a series of"},{"line_number":13,"context_line":"          API calls to cinder to create, attach, detach, extend etc the"},{"line_number":14,"context_line":"          volume. The sequence of operations performed to copy image into"},{"line_number":15,"context_line":"          the volume are, attach the volume, copy image contents into the"},{"line_number":16,"context_line":"          volume (until we\u0027ve space left in volume), detach the volume,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"36a57aef_7880a0b8","line":13,"range":{"start_line":13,"start_character":33,"end_line":13,"end_character":63},"updated":"2023-01-03 05:13:48.000000000","message":"it should be grammatically creating, attaching ... etc. the volume","commit_id":"cb7adee31db802836c2d7dde0b6d50fefb930d34"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bef5bd13289f061ce845ad3497f94f870da9460f","unresolved":false,"context_lines":[{"line_number":10,"context_line":":project: glance_store"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":":problem: When creating an image in cinder store, we perform a series of"},{"line_number":13,"context_line":"          API calls to cinder to create, attach, detach, extend etc the"},{"line_number":14,"context_line":"          volume. The sequence of operations performed to copy image into"},{"line_number":15,"context_line":"          the volume are, attach the volume, copy image contents into the"},{"line_number":16,"context_line":"          volume (until we\u0027ve space left in volume), detach the volume,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fb079cc2_5d00a418","line":13,"range":{"start_line":13,"start_character":33,"end_line":13,"end_character":63},"in_reply_to":"36a57aef_7880a0b8","updated":"2023-01-09 17:52:20.000000000","message":"Done","commit_id":"cb7adee31db802836c2d7dde0b6d50fefb930d34"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"55840cb39bde0116a6900febdb20365a997518dd","unresolved":true,"context_lines":[{"line_number":24,"context_line":"          Cinder backends that support extend in-use volumes:"},{"line_number":25,"context_line":"          https://docs.openstack.org/cinder/latest/reference/support-matrix.html#operation_online_extend_support"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":":solution: We will introduce a new config option, ``cinder_extend_attached``"},{"line_number":28,"context_line":"           which will be a boolean option. Operators will set it to ``true``"},{"line_number":29,"context_line":"           if the cinder backend they are using supports extending attached"},{"line_number":30,"context_line":"           volumes. By default, this will be ``false``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"984a9104_63fcdc78","line":27,"range":{"start_line":27,"start_character":52,"end_line":27,"end_character":74},"updated":"2023-01-03 05:13:48.000000000","message":"how about cinder_can_extend?","commit_id":"cb7adee31db802836c2d7dde0b6d50fefb930d34"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bef5bd13289f061ce845ad3497f94f870da9460f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          Cinder backends that support extend in-use volumes:"},{"line_number":25,"context_line":"          https://docs.openstack.org/cinder/latest/reference/support-matrix.html#operation_online_extend_support"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":":solution: We will introduce a new config option, ``cinder_extend_attached``"},{"line_number":28,"context_line":"           which will be a boolean option. Operators will set it to ``true``"},{"line_number":29,"context_line":"           if the cinder backend they are using supports extending attached"},{"line_number":30,"context_line":"           volumes. By default, this will be ``false``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e03ca7b2_96399758","line":27,"range":{"start_line":27,"start_character":52,"end_line":27,"end_character":74},"in_reply_to":"984a9104_63fcdc78","updated":"2023-01-09 17:52:20.000000000","message":"Changed to cinder_can_extend_attached since a normal extend is possible but extending an attached volume requires MV and backend support.","commit_id":"cb7adee31db802836c2d7dde0b6d50fefb930d34"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"55840cb39bde0116a6900febdb20365a997518dd","unresolved":true,"context_lines":[{"line_number":29,"context_line":"           if the cinder backend they are using supports extending attached"},{"line_number":30,"context_line":"           volumes. By default, this will be ``false``."},{"line_number":31,"context_line":"           If we have ``cinder_extend_attached`` set to ``true``, we will call"},{"line_number":32,"context_line":"           the cinder ``os-extend`` API with microversion ``3.42`` that will"},{"line_number":33,"context_line":"           allow us to extend the attached volume."},{"line_number":34,"context_line":"           Finally, we will call the ``extend_volume`` method of os-brick to"},{"line_number":35,"context_line":"           instruct the kernel to resize the volume on the host."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3c801ea3_6705e99c","line":32,"range":{"start_line":32,"start_character":58,"end_line":32,"end_character":66},"updated":"2023-01-03 05:13:48.000000000","message":"what if cinder does not support 3.42 (I think this will not be possible that old cinder is used, but just wanted to confirm)","commit_id":"cb7adee31db802836c2d7dde0b6d50fefb930d34"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bef5bd13289f061ce845ad3497f94f870da9460f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"           if the cinder backend they are using supports extending attached"},{"line_number":30,"context_line":"           volumes. By default, this will be ``false``."},{"line_number":31,"context_line":"           If we have ``cinder_extend_attached`` set to ``true``, we will call"},{"line_number":32,"context_line":"           the cinder ``os-extend`` API with microversion ``3.42`` that will"},{"line_number":33,"context_line":"           allow us to extend the attached volume."},{"line_number":34,"context_line":"           Finally, we will call the ``extend_volume`` method of os-brick to"},{"line_number":35,"context_line":"           instruct the kernel to resize the volume on the host."}],"source_content_type":"text/x-rst","patch_set":1,"id":"99622ef7_fc8ec89e","line":32,"range":{"start_line":32,"start_character":58,"end_line":32,"end_character":66},"in_reply_to":"3c801ea3_6705e99c","updated":"2023-01-09 17:52:20.000000000","message":"We currently use MV 3.54[1] during create image. Queens support maximum MV 3.50[2] so we can safely assume deployments not using 2023.1 with branches older than queens.\n\n[1] https://github.com/openstack/glance_store/blob/1a01fe7fd7a30ba1deed9628abf347b599363a27/glance_store/_drivers/cinder.py#L956\n[2] https://github.com/openstack/cinder/blob/8b222bdd1df4c0bcfe46f42a5dfb229424dbb9f9/cinder/api/microversions.py#L140","commit_id":"cb7adee31db802836c2d7dde0b6d50fefb930d34"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"55840cb39bde0116a6900febdb20365a997518dd","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":":timeline: 2023.1"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":":link: "},{"line_number":45,"context_line":"       * https://review.opendev.org/c/openstack/glance_store/+/843103"},{"line_number":46,"context_line":"       * https://review.opendev.org/c/openstack/glance_store/+/868742"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0c9b8c54_04ca88ee","line":44,"range":{"start_line":44,"start_character":6,"end_line":44,"end_character":7},"updated":"2023-01-03 05:13:48.000000000","message":"remove white space","commit_id":"cb7adee31db802836c2d7dde0b6d50fefb930d34"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bef5bd13289f061ce845ad3497f94f870da9460f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":":timeline: 2023.1"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":":link: "},{"line_number":45,"context_line":"       * https://review.opendev.org/c/openstack/glance_store/+/843103"},{"line_number":46,"context_line":"       * https://review.opendev.org/c/openstack/glance_store/+/868742"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ebf8081f_339cc628","line":44,"range":{"start_line":44,"start_character":6,"end_line":44,"end_character":7},"in_reply_to":"0c9b8c54_04ca88ee","updated":"2023-01-09 17:52:20.000000000","message":"Done","commit_id":"cb7adee31db802836c2d7dde0b6d50fefb930d34"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ca2172c0dcf24c5699c6802cea4f412897710e6a","unresolved":true,"context_lines":[{"line_number":32,"context_line":"           ``cinder_do_extend_attached`` which will be a boolean option."},{"line_number":33,"context_line":"           Operators can set it to ``true`` if the cinder backend they are"},{"line_number":34,"context_line":"           using supports extending attached volumes. The default value will"},{"line_number":35,"context_line":"           be ``false``."},{"line_number":36,"context_line":"           If we have ``cinder_do_extend_attached`` set to ``true``, we will"},{"line_number":37,"context_line":"           call the cinder ``os-extend`` API with microversion ``3.42`` that"},{"line_number":38,"context_line":"           will allow us to extend the attached volume."}],"source_content_type":"text/x-rst","patch_set":5,"id":"8e792bd0_f5674290","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":11},"updated":"2023-01-20 11:33:12.000000000","message":"Can\u0027t this be figured out automagically? Why would a user want to set this option to False if the backend support extending attached volumes?","commit_id":"481b2228949e013417042e5713f3e4fac40f85e3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1da3e4f3c36cdbee70e099cce422ec18b865d378","unresolved":true,"context_lines":[{"line_number":32,"context_line":"           ``cinder_do_extend_attached`` which will be a boolean option."},{"line_number":33,"context_line":"           Operators can set it to ``true`` if the cinder backend they are"},{"line_number":34,"context_line":"           using supports extending attached volumes. The default value will"},{"line_number":35,"context_line":"           be ``false``."},{"line_number":36,"context_line":"           If we have ``cinder_do_extend_attached`` set to ``true``, we will"},{"line_number":37,"context_line":"           call the cinder ``os-extend`` API with microversion ``3.42`` that"},{"line_number":38,"context_line":"           will allow us to extend the attached volume."}],"source_content_type":"text/x-rst","patch_set":5,"id":"d49178db_0f6a6ac6","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":11},"in_reply_to":"1164f602_017a861a","updated":"2023-01-20 12:44:45.000000000","message":"Unfortunately no, this information isn\u0027t exposed anywhere and is only available in our support matrix[1]. Most of the backends do support online extend so it shouldn\u0027t be an issue but administrators need to set it manually (knowing their backend supports it) else they won\u0027t be able to create images hence the default is false.\n\n[1] https://docs.openstack.org/cinder/latest/reference/support-matrix.html#operation_online_extend_support","commit_id":"481b2228949e013417042e5713f3e4fac40f85e3"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"f74f61efe77ec962b4427406420cb0603eebd43c","unresolved":true,"context_lines":[{"line_number":32,"context_line":"           ``cinder_do_extend_attached`` which will be a boolean option."},{"line_number":33,"context_line":"           Operators can set it to ``true`` if the cinder backend they are"},{"line_number":34,"context_line":"           using supports extending attached volumes. The default value will"},{"line_number":35,"context_line":"           be ``false``."},{"line_number":36,"context_line":"           If we have ``cinder_do_extend_attached`` set to ``true``, we will"},{"line_number":37,"context_line":"           call the cinder ``os-extend`` API with microversion ``3.42`` that"},{"line_number":38,"context_line":"           will allow us to extend the attached volume."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1164f602_017a861a","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":11},"in_reply_to":"8e792bd0_f5674290","updated":"2023-01-20 12:31:59.000000000","message":"Hey Cyril, this is already been discussed in yesterday\u0027s meeting[1].\nYou can refer the irc logs for more details 😊  \n\n[1]: https://meetings.opendev.org/irclogs/%23openstack-meeting/%23openstack-meeting.2023-01-19.log.html#t2023-01-19T14:21:44","commit_id":"481b2228949e013417042e5713f3e4fac40f85e3"}]}