)]}'
{"specs/2024.2/approved/glance/image-import-plugins-api.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"33f0cbc942478c742d83c3dd7a10943c0e7839dd","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* We will enable the ``image_decompression`` plugin by default. Operators who"},{"line_number":46,"context_line":"  wish to disable this plugin can set the new ``[DEFAULT]"},{"line_number":47,"context_line":"  allowed_compression_algorithms`` option to the empty set (``[]``)."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* We will add a new parameter to the ``/images/{imageID}/import`` API,"},{"line_number":50,"context_line":"  ``compression_format``, that will allow the user to explicitly state the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c84adb50_876a455f","line":47,"updated":"2024-07-19 06:08:55.000000000","message":"Why can\u0027t they simply remove it from `image_import_plugins` config option?\nIf you enable it by default then you need to make sure it should not be executed if normal image is used for importing/downloading.","commit_id":"1f5435bc9ef46d977a02396dc5671575f15eea10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e85d583856b6ad3809c66c4860bf43201e8ca67b","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* We will enable the ``image_decompression`` plugin by default. Operators who"},{"line_number":46,"context_line":"  wish to disable this plugin can set the new ``[DEFAULT]"},{"line_number":47,"context_line":"  allowed_compression_algorithms`` option to the empty set (``[]``)."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* We will add a new parameter to the ``/images/{imageID}/import`` API,"},{"line_number":50,"context_line":"  ``compression_format``, that will allow the user to explicitly state the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"899236b6_d7864c27","line":47,"in_reply_to":"c84adb50_876a455f","updated":"2024-07-19 15:03:12.000000000","message":"I was going to go into detail about how I was going to make this default but decided it wasn\u0027t necessary. Serves me right 😅\n\nMy plan is to move this plugin from `glance/async_/flows/plugins` to `glance/async_/flows/_internal_plugins/`. As such, it won\u0027t be possible to enable/disable this with `[DEFAULT] image_import_plugins`. I can of course simply add it to `[DEFAULT] image_import_plugins` and leave it where it is, but that won\u0027t work for anyone that is using a fully-populated `glance-image-import.conf` with the current defaults.","commit_id":"1f5435bc9ef46d977a02396dc5671575f15eea10"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"33f0cbc942478c742d83c3dd7a10943c0e7839dd","unresolved":true,"context_lines":[{"line_number":49,"context_line":"* We will add a new parameter to the ``/images/{imageID}/import`` API,"},{"line_number":50,"context_line":"  ``compression_format``, that will allow the user to explicitly state the"},{"line_number":51,"context_line":"  compression format used for the image. This must be one of the algorithms"},{"line_number":52,"context_line":"  defined in ``[DEFAULT] allowed_compression_algorithms``, which will be"},{"line_number":53,"context_line":"  exposed via the new ``plugins`` field in the ``/v2/info/import`` API."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8f3e0351_3179e838","line":52,"range":{"start_line":52,"start_character":25,"end_line":52,"end_character":55},"updated":"2024-07-19 06:08:55.000000000","message":"Instead of defining it under DEFAULT section why not define it under [image_decompression] section, similar way we do it for output_format which is related to image conversion plugin and defined under [image_conversion] section.","commit_id":"1f5435bc9ef46d977a02396dc5671575f15eea10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e85d583856b6ad3809c66c4860bf43201e8ca67b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"* We will add a new parameter to the ``/images/{imageID}/import`` API,"},{"line_number":50,"context_line":"  ``compression_format``, that will allow the user to explicitly state the"},{"line_number":51,"context_line":"  compression format used for the image. This must be one of the algorithms"},{"line_number":52,"context_line":"  defined in ``[DEFAULT] allowed_compression_algorithms``, which will be"},{"line_number":53,"context_line":"  exposed via the new ``plugins`` field in the ``/v2/info/import`` API."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3c80d918_561dbfff","line":52,"range":{"start_line":52,"start_character":25,"end_line":52,"end_character":55},"in_reply_to":"8f3e0351_3179e838","updated":"2024-07-19 15:03:12.000000000","message":"Sure, that works for me. Will respin when I get a resolution to the above.","commit_id":"1f5435bc9ef46d977a02396dc5671575f15eea10"}]}