)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"ec4c9f8a3e88eb36b93c496ce8becce0b35d1307","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ae9eb33e_ca2b0f60","updated":"2024-11-08 08:30:15.000000000","message":"Ca you please check, if the spec is now reflecting everything we discussed at the PTG?","commit_id":"e0805f37db8088f317b7df91151f69688567fb8f"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"449580ffd1462224d26288c0b18d3284d8f88173","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d621977a_ac3e588b","updated":"2024-12-10 10:52:02.000000000","message":"Looks good to me, need to rebase.","commit_id":"982ad5bb3fa6faf2744db8c31fdde532aacb7edf"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"6e55c594446509ac971254c835853720bda015e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f8b37531_0634df50","updated":"2024-12-24 06:21:32.000000000","message":"Approving the spec as we have got minimum required approvals. \nThanks all the reviewers !!","commit_id":"1386be3a3369352d77c79095d6681eb48df81bc6"}],"specs/2025.1/approved/glance/standardized_image_encryption.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"705239ea450c78015da1b33849b8dccd17d678b4","unresolved":true,"context_lines":[{"line_number":98,"context_line":"  key should be deleted too"},{"line_number":99,"context_line":"* \u0027os_decrypt_container_format\u0027 - format change, e.g. from \u0027compressed\u0027 to"},{"line_number":100,"context_line":"  \u0027bare\u0027"},{"line_number":101,"context_line":"* \u0027os_decrypt_format\u0027 - the image format after decryption, when the"},{"line_number":102,"context_line":"  \u0027disk_format\u0027 is \u0027LUKS\u0027. It should be \u0027raw\u0027 or \u0027gpt\u0027"},{"line_number":103,"context_line":"* \u0027os_decrypt_size\u0027 - size after payload decryption"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ef1df14b_1f5277cc","line":101,"range":{"start_line":101,"start_character":3,"end_line":101,"end_character":20},"updated":"2024-11-11 05:05:17.000000000","message":"Any validation provided for this, or we are going to use ListOpt with default\u003d[raw,gpt]?","commit_id":"e0805f37db8088f317b7df91151f69688567fb8f"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"0fa7d239be6e70ab0b36cb24a69d70c486af4064","unresolved":true,"context_lines":[{"line_number":98,"context_line":"  key should be deleted too"},{"line_number":99,"context_line":"* \u0027os_decrypt_container_format\u0027 - format change, e.g. from \u0027compressed\u0027 to"},{"line_number":100,"context_line":"  \u0027bare\u0027"},{"line_number":101,"context_line":"* \u0027os_decrypt_format\u0027 - the image format after decryption, when the"},{"line_number":102,"context_line":"  \u0027disk_format\u0027 is \u0027LUKS\u0027. It should be \u0027raw\u0027 or \u0027gpt\u0027"},{"line_number":103,"context_line":"* \u0027os_decrypt_size\u0027 - size after payload decryption"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba9d70ba_cf8aec89","line":101,"range":{"start_line":101,"start_character":3,"end_line":101,"end_character":20},"in_reply_to":"ef1df14b_1f5277cc","updated":"2024-11-12 09:56:48.000000000","message":"After a short discussion with Markus, we decided to remove this for these reasons:\n\n1. to verify the inner disk_format, we would need to decrypt the image. This might be possible, but is a huge overhead for Glance. (And could/should be an additional extra step to keep all the patches clear and small)\n2. Cinder is currently not able to tell, which format is used: in case of a blank encrypted volume, which is attached to a VM and formatted through the guest, the image created from such volume will be encrypted but currently it is unknown, what kind of format that image has.\n3. Cinder currently always expects a raw image, when the image is LUKS-encrypted.\n\nFor now we think it is good to always expect the image to be \u0027raw\u0027 after decryption and being handled as such.","commit_id":"e0805f37db8088f317b7df91151f69688567fb8f"}]}