)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f0bc560a866c4b35ce75f5a6d93183e0baa3d78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c76eb590_104983a0","updated":"2025-12-11 21:02:48.000000000","message":"Thanks for proposing the spec.  A few questions noted inline.","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fe27c163522dc409e1e05d2d2ac0b9d3c544cf85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ed79b7f2_421a0adb","updated":"2026-10-15 06:29:44.000000000","message":"Please remove the tempurl:// location from the image-locations response. This feature should be exposed through a dedicated temp-URL API and store-capability metadata, not by extending the location model. That avoids reintroducing show_multiple_locations-style discovery and keeps backend locations separate from Glance-generated access capabilities.\n\nAlso are you still interested to work on this on priority, kindly let me know. I am willing to take this over on priority.\n\nThank you for working on this.","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"35506e332d62252295c9de28ed9244aa31c3968f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bc5839ac_64742eac","updated":"2026-10-23 15:41:12.000000000","message":"you need entry in index.rst","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f24cfb5592b83d2eba6fac43778418ae6c708bf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4057509f_b0e9d009","updated":"2026-11-05 14:57:21.000000000","message":"The major issue I see is not being able to revoke tempurls.  On the other hand, this is mitigated by restricting who can access them, and by setting a short expiration time (because I believe for swift at least, the expiration of a tempurl doesn\u0027t break a download in process; so as long as the consumer starts using the tempurl right away, the window for the tempurl to be valid could be very short).  Is this the case for other stores that support tempurls as well?","commit_id":"7dc665665bda20487cf45286974e87cc00a4fdc6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"738cc0dfd8dcf8b5858e1f07c058a48fb5ce979c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"39e0cd51_455f7a24","updated":"2026-11-05 14:31:23.000000000","message":"The service role should not grant image access by itself. It only allows\nthe optimized temp-URL path.\n\nPlease use two checks:\n\n1. The primary token must pass ``download_from_store``. This authorizes the\n   image and store exactly like a normal download.\n2. ``generate_image_temp_url`` must default to ``rule:service_api`` and be\n   evaluated with the union of primary-token and service-token roles.\n\nSo Nova should send the user token as ``X-Auth-Token`` and its service token\nas ``X-Service-Token``. This supports private images without making every\nservice token a global image reader.","commit_id":"7dc665665bda20487cf45286974e87cc00a4fdc6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"98f4b088b3bb5c04cdcaf12f423436b6247947e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9852e250_95eedab4","in_reply_to":"4057509f_b0e9d009","updated":"2026-11-05 15:07:34.000000000","message":"Yes both s3 and swift behaves this way, What we can do is reduce the default expiration time to 60~300 seconds to reduce the impact.","commit_id":"7dc665665bda20487cf45286974e87cc00a4fdc6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"da186ed6f12605c1ca52162e5461a329bffe935b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a0f6f271_45cc600e","updated":"2026-11-05 17:32:23.000000000","message":"Just keeping it here for reference, if rosmaita still have concerns.\n\nFor S3, Glance can support a DELETE temp-URL API. The API does not delete the\nimage or the URL string itself. Instead, it marks the S3 object as revoked.\nA bucket policy then denies GET requests for that object, so existing\npresigned URLs stop working. Normal Glance reads can continue if the deny is\nscoped only to the temp-URL signing principal.","commit_id":"047178c909ae36ec750763899d61ec1113e053d0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1ed844d2a58321cd4256a84aee3ddd230d09bf40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"591822cc_503753f2","updated":"2026-11-05 17:23:25.000000000","message":"Looks better to me, keeping default to 300 is good move I would say. We need others views as well. Thank you for working on this.","commit_id":"047178c909ae36ec750763899d61ec1113e053d0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3fe81349381c4e50857b2d3f1f06165e69cd8357","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3949805b_37d5a0db","updated":"2026-11-05 21:53:14.000000000","message":"Nit noted inline about an HTTP response code, but that can be dealt with during development.","commit_id":"6f8323d5ebbf18e899e75b687e562c9e711c6b9f"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"3e66ae848d5f15a5948f20a16fbacd8f2913ead2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e2dc4c94_d4aa9431","updated":"2026-11-05 19:22:35.000000000","message":"OK, I updated the patch so that the empty line removed from index.rst no longer appears.\n\nI would have liked more info about the changes to SDK/OSC, and potentially to glanceclient. I think we should not hold the spec any longer, though. I am assuming Abhishek would +2 this revision since he +2ed rev 13.","commit_id":"6f8323d5ebbf18e899e75b687e562c9e711c6b9f"}],"specs/2026.1/approved/glance/temp-url-generation.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f0bc560a866c4b35ce75f5a6d93183e0baa3d78","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Temp URL generation in Glance"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ce8de95c_b967c873","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":42},"updated":"2025-12-11 21:02:48.000000000","message":"surprised that doc8 didn\u0027t flag this, but the heading indicator should be the same length as the text (top and bottom)","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":38379,"name":"Antonin Ruan","display_name":"Antonin Ruan","email":"antonin.ar.ruan@gmail.com","username":"womax"},"change_message_id":"1cbc4daf0b081bab6eae6b6165bc2c6983a8f7e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Temp URL generation in Glance"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f5e7efa4_d29cdc89","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":42},"in_reply_to":"ce8de95c_b967c873","updated":"2025-12-17 14:55:35.000000000","message":"Acknowledged","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f0bc560a866c4b35ce75f5a6d93183e0baa3d78","unresolved":true,"context_lines":[{"line_number":21,"context_line":"ecosystem, Swift provides such a feature [1] which other components like Ironic"},{"line_number":22,"context_line":"are relying on - see [2]."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"As of today, Ironic already take advantage of this Swift feature. However,"},{"line_number":25,"context_line":"making use of it is directly tied to Swift and its own appropriate functions"},{"line_number":26,"context_line":"library moreover scope is restricted to Ironic use-case."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1b4414c3_e3abad7c","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":65},"updated":"2025-12-11 21:02:48.000000000","message":"Do you know why they use this?  What I mean is, if you have glance caching enabled, the download by glance itself is tee\u0027d into the cache on the first download, so it shouldn\u0027t be much slower than direct download from swift, and then subsequent requests for that image should be served from the cache, which should be faster than getting it out of swift.  It would be helpful to know whether the tempurls address a real problem or are left over from the early days of the Rackspace nextgen cloud.","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":38379,"name":"Antonin Ruan","display_name":"Antonin Ruan","email":"antonin.ar.ruan@gmail.com","username":"womax"},"change_message_id":"1cbc4daf0b081bab6eae6b6165bc2c6983a8f7e4","unresolved":true,"context_lines":[{"line_number":21,"context_line":"ecosystem, Swift provides such a feature [1] which other components like Ironic"},{"line_number":22,"context_line":"are relying on - see [2]."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"As of today, Ironic already take advantage of this Swift feature. However,"},{"line_number":25,"context_line":"making use of it is directly tied to Swift and its own appropriate functions"},{"line_number":26,"context_line":"library moreover scope is restricted to Ironic use-case."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"2ebbbae4_fc312358","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":65},"in_reply_to":"1b4414c3_e3abad7c","updated":"2025-12-17 14:55:35.000000000","message":"Context: current process boot of an ironic server is: nova send a request to ironic API to boot server. API then communicates to ironic conductor that prepares everything needed to boot server, it is finally sent to ironic-python-agent (only part of the code that run on baremetal managed server) that can finally install server.\n\n\nSo it is ironic-python-agent that needs to download the image, but as it is on a small ramdisk only designed to control the hardware, it does not have any access to any credentials. Most if not all of ironic config is only consumed by ironic API and ironic-conductor. So in the boot process ironic-conductor generates a temp URL that it then gives to ironic-python-agent that can successfully acces it without any credentials required","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f0bc560a866c4b35ce75f5a6d93183e0baa3d78","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"As far as we see, this would bring advantages like:"},{"line_number":32,"context_line":"- allow Cloud admins to target either Swift, S3 or any other object storage"},{"line_number":33,"context_line":"  backend in the exact same way"},{"line_number":34,"context_line":"- support tempURL in a multi-store environment"},{"line_number":35,"context_line":"- avoid spreading broadly backend credentials, by generating tempURLs on a"},{"line_number":36,"context_line":"  central Control Plane node like Glance"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fc06a900_94ddc65e","line":33,"updated":"2025-12-11 21:02:48.000000000","message":"line 33 is being flagged as an unexpected indentation; i think maybe you need a blank line before the start of the bulleted list at line 32","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":38379,"name":"Antonin Ruan","display_name":"Antonin Ruan","email":"antonin.ar.ruan@gmail.com","username":"womax"},"change_message_id":"1cbc4daf0b081bab6eae6b6165bc2c6983a8f7e4","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"As far as we see, this would bring advantages like:"},{"line_number":32,"context_line":"- allow Cloud admins to target either Swift, S3 or any other object storage"},{"line_number":33,"context_line":"  backend in the exact same way"},{"line_number":34,"context_line":"- support tempURL in a multi-store environment"},{"line_number":35,"context_line":"- avoid spreading broadly backend credentials, by generating tempURLs on a"},{"line_number":36,"context_line":"  central Control Plane node like Glance"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ffdb9d46_77ca8e55","line":33,"in_reply_to":"fc06a900_94ddc65e","updated":"2025-12-17 14:55:35.000000000","message":"Acknowledged","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f0bc560a866c4b35ce75f5a6d93183e0baa3d78","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Lastly, in the mid or long-term, this feature could be used by Nova to directly"},{"line_number":40,"context_line":"download image stored in backends supporting temp URL generation (Swift, S3),"},{"line_number":41,"context_line":"without Glance acting as a proxy for the download."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"63614236_9b46fd7c","line":41,"updated":"2025-12-11 21:02:48.000000000","message":"So what you\u0027re proposing is to break the abstraction layer and give consumers direct access to the backend.  This seems to be a particularly bad idea for something like S3, where the operator has to pay for data egress.  If glance cache is enabled, you have one download you have to pay for and then other requests for that image are served out of the cache.  If everyone uses tempurls, you are paying multiple times.","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"45d58c0e9a7adcb39fa1fa846e0ff31ef8113d99","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Lastly, in the mid or long-term, this feature could be used by Nova to directly"},{"line_number":40,"context_line":"download image stored in backends supporting temp URL generation (Swift, S3),"},{"line_number":41,"context_line":"without Glance acting as a proxy for the download."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"29df44d3_baaf2561","line":41,"in_reply_to":"63614236_9b46fd7c","updated":"2025-12-17 14:43:03.000000000","message":"I\u0027ll spark some discussion.\nI think we have vastly different deployment sizes in mind.\nLet\u0027s switch gears to deployment at scale, with, say, 1k hosts and 15-20k VMs.\nFor this kind of deployment current abstraction layer is deficient, and forces continuous scaling for glances with deployment\u0027s lifetime, especially as it grows.\nGlance cache is amazing for public images(say, up to 5G), but starts to saturate TX when you have images above this size. It doesn\u0027t work at all for instance backups or images from volumes, because in most cases cache is filled too quickly to hold that data.\n\nActual S3 is not the only S3 flavour in existence, there are also s3api-compatible object stores that could benefit from this possibility.\n\nSpec also clearly states that operators would be able to disable tmpurl generation – in such case there is no possibility to incur increased egress costs.","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f0bc560a866c4b35ce75f5a6d93183e0baa3d78","unresolved":true,"context_lines":[{"line_number":67,"context_line":"None"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"REST API impact"},{"line_number":70,"context_line":"---------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The spec proposes the following API change:"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"34423b87_73cf324d","line":70,"updated":"2025-12-11 21:02:48.000000000","message":"In addition to the new API, I think you\u0027ll need to change the stores discovery API responses.  The /v2/info/stores/detail (admin-only) should definitely indicate whether tempurl is enabled or not on each store.  As far as \"regular\" end users, we could add something to the store object for each store that has it enabled (like we do for read-only), or do nothing and let the end user figure it out by always receiving 501s (which doesn\u0027t sound nice).","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":38379,"name":"Antonin Ruan","display_name":"Antonin Ruan","email":"antonin.ar.ruan@gmail.com","username":"womax"},"change_message_id":"1cbc4daf0b081bab6eae6b6165bc2c6983a8f7e4","unresolved":true,"context_lines":[{"line_number":67,"context_line":"None"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"REST API impact"},{"line_number":70,"context_line":"---------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The spec proposes the following API change:"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bb5a9a8f_ef9aacf7","line":70,"in_reply_to":"34423b87_73cf324d","updated":"2025-12-17 14:55:35.000000000","message":"Wasn\u0027t aware of the existence of this route. Would totally make sense to expose it there rather than an error code.\n\nSo to sum up:\n  - A change to /v2/info/stores/detail API route\n  - A change to store object to add temp URL enable status (no change required to api ?)","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"468bb5a4ef6dd92796be67fffc961c96407d8a91","unresolved":false,"context_lines":[{"line_number":67,"context_line":"None"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"REST API impact"},{"line_number":70,"context_line":"---------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The spec proposes the following API change:"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"d845423a_3a40b2e3","line":70,"in_reply_to":"bb5a9a8f_ef9aacf7","updated":"2026-11-05 13:24:36.000000000","message":"Done","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f0bc560a866c4b35ce75f5a6d93183e0baa3d78","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"       {"},{"line_number":86,"context_line":"           \"temp_url\": \u003ctemp-url\u003e,"},{"line_number":87,"context_line":"           \"valid_for\": \u003cduration\u003e"},{"line_number":88,"context_line":"       }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Response codes:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"108c3975_f44aa5c1","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":34},"updated":"2025-12-11 21:02:48.000000000","message":"Instead of the duration, I think it would be better to give the expiration timestamp in iso 8601 UTC format, and change the name of the field to \u0027expires\u0027.","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":38379,"name":"Antonin Ruan","display_name":"Antonin Ruan","email":"antonin.ar.ruan@gmail.com","username":"womax"},"change_message_id":"1cbc4daf0b081bab6eae6b6165bc2c6983a8f7e4","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"       {"},{"line_number":86,"context_line":"           \"temp_url\": \u003ctemp-url\u003e,"},{"line_number":87,"context_line":"           \"valid_for\": \u003cduration\u003e"},{"line_number":88,"context_line":"       }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Response codes:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5af13496_53fb467c","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":34},"in_reply_to":"108c3975_f44aa5c1","updated":"2025-12-17 14:55:35.000000000","message":"Acknowledged","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f0bc560a866c4b35ce75f5a6d93183e0baa3d78","unresolved":true,"context_lines":[{"line_number":91,"context_line":"* 200 -- Upon authorization and successful request."},{"line_number":92,"context_line":"* 403 -- Permission denied"},{"line_number":93,"context_line":"* 500 -- Temp URL generation failed"},{"line_number":94,"context_line":"* 501 -- No store the image is in supports temp url generation"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Security impact"},{"line_number":97,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b8260341_8b4f71d2","line":94,"range":{"start_line":94,"start_character":9,"end_line":94,"end_character":62},"updated":"2025-12-11 21:02:48.000000000","message":"This brings up an interesting point.  What happens when the image is in multiple stores that support tempurls?","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":38379,"name":"Antonin Ruan","display_name":"Antonin Ruan","email":"antonin.ar.ruan@gmail.com","username":"womax"},"change_message_id":"1cbc4daf0b081bab6eae6b6165bc2c6983a8f7e4","unresolved":true,"context_lines":[{"line_number":91,"context_line":"* 200 -- Upon authorization and successful request."},{"line_number":92,"context_line":"* 403 -- Permission denied"},{"line_number":93,"context_line":"* 500 -- Temp URL generation failed"},{"line_number":94,"context_line":"* 501 -- No store the image is in supports temp url generation"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Security impact"},{"line_number":97,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d9149d34_07e71555","line":94,"range":{"start_line":94,"start_character":9,"end_line":94,"end_character":62},"in_reply_to":"b8260341_8b4f71d2","updated":"2025-12-17 14:55:35.000000000","message":"Good question, didn\u0027t really think of that. \n\nMy first idea would be to:\n 1) use the same strategy to choose store as when trying to download an image just without taking into account store that do not support tempURL.\n\nBut it may not be a wanted behavior, especially considering your previous comment on egress cost for storage backend. So maybe we could:\n 2) have more config options to weight store specifically for tempURL\n 3) force tempURL generation from a given store (maybe moving the route to something like /v2/stores/{store_id}/{image_id}/tempURL)\n 4) Add a config option to specify store preference order for tempURL. Could also be used to enable/disable tempURL usage for each store","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"468bb5a4ef6dd92796be67fffc961c96407d8a91","unresolved":false,"context_lines":[{"line_number":91,"context_line":"* 200 -- Upon authorization and successful request."},{"line_number":92,"context_line":"* 403 -- Permission denied"},{"line_number":93,"context_line":"* 500 -- Temp URL generation failed"},{"line_number":94,"context_line":"* 501 -- No store the image is in supports temp url generation"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Security impact"},{"line_number":97,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0ef24167_97a62998","line":94,"range":{"start_line":94,"start_character":9,"end_line":94,"end_character":62},"in_reply_to":"d9149d34_07e71555","updated":"2026-11-05 13:24:36.000000000","message":"they follow https://opendev.org/openstack/glance-specs/src/branch/master/specs/2023.2/approved/glance_store/store-weight.rst","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f0bc560a866c4b35ce75f5a6d93183e0baa3d78","unresolved":true,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Temp URL are sensitive resources that allow no-auth access to otherwise"},{"line_number":100,"context_line":"protected data. However this data is already accessible via the"},{"line_number":101,"context_line":"``/v2/images/{image_id}/file`` API routes. Users would only be allowed to"},{"line_number":102,"context_line":"generate temp URL for image they already have access to. Policy would also be"},{"line_number":103,"context_line":"used to control who can generate temp URL as most likely only service user"},{"line_number":104,"context_line":"would need to generate them."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"89af4d1a_8a11a9f8","line":102,"range":{"start_line":101,"start_character":43,"end_line":102,"end_character":56},"updated":"2025-12-11 21:02:48.000000000","message":"Yes, but once they have the tempurl, they can pass it around to all their friends, who now have access to the image data whether they have access to the original image or not.","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"468bb5a4ef6dd92796be67fffc961c96407d8a91","unresolved":true,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Temp URL are sensitive resources that allow no-auth access to otherwise"},{"line_number":100,"context_line":"protected data. However this data is already accessible via the"},{"line_number":101,"context_line":"``/v2/images/{image_id}/file`` API routes. Users would only be allowed to"},{"line_number":102,"context_line":"generate temp URL for image they already have access to. Policy would also be"},{"line_number":103,"context_line":"used to control who can generate temp URL as most likely only service user"},{"line_number":104,"context_line":"would need to generate them."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"471fccab_abc008d0","line":102,"range":{"start_line":101,"start_character":43,"end_line":102,"end_character":56},"in_reply_to":"89af4d1a_8a11a9f8","updated":"2026-11-05 13:24:36.000000000","message":"preferably this will only be used by nova/cinder/ironic; but indeed, in case of host compromise that would heavily assist data exfiltration -- hence this is disabled by default. I don\u0027t yet see a mechanism that would cleanly remove this possibility, that also doesn\u0027t depend on glance knowing resource state from other services.","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f0bc560a866c4b35ce75f5a6d93183e0baa3d78","unresolved":true,"context_lines":[{"line_number":101,"context_line":"``/v2/images/{image_id}/file`` API routes. Users would only be allowed to"},{"line_number":102,"context_line":"generate temp URL for image they already have access to. Policy would also be"},{"line_number":103,"context_line":"used to control who can generate temp URL as most likely only service user"},{"line_number":104,"context_line":"would need to generate them."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Notifications impact"},{"line_number":107,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"77959189_970b7dae","line":104,"updated":"2025-12-11 21:02:48.000000000","message":"OK, that would limit the circle of friends who would get free urls, but I\u0027m still not sure I like this idea.","commit_id":"3ad75334fa0f6367d4de1b5588cac3ef2de77e71"}],"specs/2026.2/approved/glance/temp-url-generation.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fe27c163522dc409e1e05d2d2ac0b9d3c544cf85","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"1. Add a method to object storage backends drivers (S3 and Swift) to generate a"},{"line_number":49,"context_line":"   temp URL for a given image (in glance_store)"},{"line_number":50,"context_line":"2. Add configuration options for stores to manage temp url generation (whether"},{"line_number":51,"context_line":"   it is enabled, how long url should be valid)."},{"line_number":52,"context_line":"3. Update API to make feature available:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"   a. Add 2 route, one to redirect to a generated tempURL and one to give a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"8987a0e1_6926f6ef","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":48},"updated":"2026-10-15 06:29:44.000000000","message":"I think we need detail information on what config options needs to be added with default value for expiration time.\n\n\nPlease specify the per-store options, their defaults, and their validation rules. At minimum, each supporting backend needs an explicit opt-in flag and an expiry setting. Swift also needs a secret temp-URL key option because Swift temporary URLs are signed with a separate key from the Swift authentication credentials. The store discovery API should report temp_url_enabled only when the driver supports the feature, the operator has enabled it, and all required per-store configuration is present.","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"468bb5a4ef6dd92796be67fffc961c96407d8a91","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"1. Add a method to object storage backends drivers (S3 and Swift) to generate a"},{"line_number":49,"context_line":"   temp URL for a given image (in glance_store)"},{"line_number":50,"context_line":"2. Add configuration options for stores to manage temp url generation (whether"},{"line_number":51,"context_line":"   it is enabled, how long url should be valid)."},{"line_number":52,"context_line":"3. Update API to make feature available:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"   a. Add 2 route, one to redirect to a generated tempURL and one to give a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"e9b6ef2e_0481625a","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":48},"in_reply_to":"8987a0e1_6926f6ef","updated":"2026-11-05 13:24:36.000000000","message":"Done","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fe27c163522dc409e1e05d2d2ac0b9d3c544cf85","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"   a. Add 2 route, one to redirect to a generated tempURL and one to give a"},{"line_number":55,"context_line":"      tempURL"},{"line_number":56,"context_line":"   b. Update \"//v2/images/{image_id}/locations\" to reflect availability of"},{"line_number":57,"context_line":"      tempURL"},{"line_number":58,"context_line":"   c. Changes would likely be needed to also be reflected in python-glanceclient"},{"line_number":59,"context_line":"      / openstacksdk to allow for client to use feature"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7863e8af_3cf1a49d","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":13},"updated":"2026-10-15 06:29:44.000000000","message":"Please drop the synthetic tempurl:// entry from GET /v2/images/{image_id}/locations. Locations should represent actual backend object locations, not Glance-generated capability routes. This also makes the design look dependent on the deprecated/location-based discovery model.","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"   a. Add 2 route, one to redirect to a generated tempURL and one to give a"},{"line_number":55,"context_line":"      tempURL"},{"line_number":56,"context_line":"   b. Update \"//v2/images/{image_id}/locations\" to reflect availability of"},{"line_number":57,"context_line":"      tempURL"},{"line_number":58,"context_line":"   c. Changes would likely be needed to also be reflected in python-glanceclient"},{"line_number":59,"context_line":"      / openstacksdk to allow for client to use feature"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9c059ada_2aba275a","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":13},"in_reply_to":"7863e8af_3cf1a49d","updated":"2026-10-26 12:36:32.000000000","message":"Acknowledged","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fe27c163522dc409e1e05d2d2ac0b9d3c544cf85","unresolved":true,"context_lines":[{"line_number":58,"context_line":"   c. Changes would likely be needed to also be reflected in python-glanceclient"},{"line_number":59,"context_line":"      / openstacksdk to allow for client to use feature"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"4. Add policy to control which users (default scope to service users) can"},{"line_number":62,"context_line":"   generate temp URL"},{"line_number":63,"context_line":"5. Update python-glanceclient to add access to new routes (so openstack"},{"line_number":64,"context_line":"   services can use them)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"f85657b5_e4a42e06","line":62,"range":{"start_line":61,"start_character":2,"end_line":62,"end_character":20},"updated":"2026-10-15 06:29:44.000000000","message":"Default policy should be service/admin only. Name it explicitly, e.g. generate_image_temp_url, rather than reusing download_image","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":false,"context_lines":[{"line_number":58,"context_line":"   c. Changes would likely be needed to also be reflected in python-glanceclient"},{"line_number":59,"context_line":"      / openstacksdk to allow for client to use feature"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"4. Add policy to control which users (default scope to service users) can"},{"line_number":62,"context_line":"   generate temp URL"},{"line_number":63,"context_line":"5. Update python-glanceclient to add access to new routes (so openstack"},{"line_number":64,"context_line":"   services can use them)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"2f013e55_e66241cd","line":62,"range":{"start_line":61,"start_character":2,"end_line":62,"end_character":20},"in_reply_to":"f85657b5_e4a42e06","updated":"2026-10-26 12:36:32.000000000","message":"Acknowledged","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fe27c163522dc409e1e05d2d2ac0b9d3c544cf85","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. code-block::"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    {"},{"line_number":96,"context_line":"        \"temp_url\": \u003ctemp-url\u003e,"},{"line_number":97,"context_line":"        \"expires_at\": \u003cexpire_timestamp\u003e"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Response codes:"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"16d940bd_1d2e4ecf","line":98,"range":{"start_line":95,"start_character":0,"end_line":98,"end_character":5},"updated":"2026-10-15 06:29:44.000000000","message":"The response should include temp_url, expires_at, and ideally store_id and image_id","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2fce02acbcceaad248c3438819ba54f3c66a21d5","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. code-block::"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    {"},{"line_number":96,"context_line":"        \"temp_url\": \u003ctemp-url\u003e,"},{"line_number":97,"context_line":"        \"expires_at\": \u003cexpire_timestamp\u003e"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Response codes:"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fece5298_9734fcd8","line":98,"range":{"start_line":95,"start_character":0,"end_line":98,"end_character":5},"in_reply_to":"16d940bd_1d2e4ecf","updated":"2026-10-15 07:30:25.000000000","message":"In addition to this I think we also need to include Cache-Control: no-store response header so that no proxy/cache between Nova and Glance retains the secret URL.","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. code-block::"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    {"},{"line_number":96,"context_line":"        \"temp_url\": \u003ctemp-url\u003e,"},{"line_number":97,"context_line":"        \"expires_at\": \u003cexpire_timestamp\u003e"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Response codes:"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3ac2bf25_41c7f46a","line":98,"range":{"start_line":95,"start_character":0,"end_line":98,"end_character":5},"in_reply_to":"fece5298_9734fcd8","updated":"2026-10-26 12:36:32.000000000","message":"Acknowledged","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"b429650c819afa9e573c7e2a1fc85fb54b74ff1f","unresolved":true,"context_lines":[{"line_number":136,"context_line":"   ["},{"line_number":137,"context_line":"     {"},{"line_number":138,"context_line":"       \"url\": \"s3+https://\u003cs3_image_url\u003e\","},{"line_number":139,"context_line":"       \"metadata\": {"},{"line_number":140,"context_line":"         \"store\": \"object-store-wtih-temp-url\""},{"line_number":141,"context_line":"       }"},{"line_number":142,"context_line":"     }"}],"source_content_type":"text/x-rst","patch_set":7,"id":"2d1949a4_49252389","line":139,"updated":"2026-07-28 10:14:07.000000000","message":"With","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"468bb5a4ef6dd92796be67fffc961c96407d8a91","unresolved":false,"context_lines":[{"line_number":136,"context_line":"   ["},{"line_number":137,"context_line":"     {"},{"line_number":138,"context_line":"       \"url\": \"s3+https://\u003cs3_image_url\u003e\","},{"line_number":139,"context_line":"       \"metadata\": {"},{"line_number":140,"context_line":"         \"store\": \"object-store-wtih-temp-url\""},{"line_number":141,"context_line":"       }"},{"line_number":142,"context_line":"     }"}],"source_content_type":"text/x-rst","patch_set":7,"id":"24161912_646dcc60","line":139,"in_reply_to":"2d1949a4_49252389","updated":"2026-11-05 13:24:36.000000000","message":"Acknowledged","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"b429650c819afa9e573c7e2a1fc85fb54b74ff1f","unresolved":true,"context_lines":[{"line_number":163,"context_line":"   ]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Here we would introduce a new custome scheme \"tempurl\" that indicates image can"},{"line_number":166,"context_line":"be download using a tempURL and where to go for the download. TempURL is not"},{"line_number":167,"context_line":"generated at this point as we don\u0027t know yet if client really want to download."},{"line_number":168,"context_line":"We just direct them towards a Glance route they can GET to download image"},{"line_number":169,"context_line":"directly from store."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fb09bc8c_07bd18a4","line":166,"updated":"2026-07-28 10:14:07.000000000","message":"downloaded","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"468bb5a4ef6dd92796be67fffc961c96407d8a91","unresolved":false,"context_lines":[{"line_number":163,"context_line":"   ]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Here we would introduce a new custome scheme \"tempurl\" that indicates image can"},{"line_number":166,"context_line":"be download using a tempURL and where to go for the download. TempURL is not"},{"line_number":167,"context_line":"generated at this point as we don\u0027t know yet if client really want to download."},{"line_number":168,"context_line":"We just direct them towards a Glance route they can GET to download image"},{"line_number":169,"context_line":"directly from store."}],"source_content_type":"text/x-rst","patch_set":7,"id":"f2421f1d_29bd3e5c","line":166,"in_reply_to":"fb09bc8c_07bd18a4","updated":"2026-11-05 13:24:36.000000000","message":"Acknowledged","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fe27c163522dc409e1e05d2d2ac0b9d3c544cf85","unresolved":true,"context_lines":[{"line_number":162,"context_line":"     ..."},{"line_number":163,"context_line":"   ]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Here we would introduce a new custome scheme \"tempurl\" that indicates image can"},{"line_number":166,"context_line":"be download using a tempURL and where to go for the download. TempURL is not"},{"line_number":167,"context_line":"generated at this point as we don\u0027t know yet if client really want to download."},{"line_number":168,"context_line":"We just direct them towards a Glance route they can GET to download image"},{"line_number":169,"context_line":"directly from store."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":" **[UPDATE API] Store details**"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Get stores details::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"a21626d9_a3c14403","line":170,"range":{"start_line":165,"start_character":1,"end_line":170,"end_character":1},"updated":"2026-10-15 06:29:44.000000000","message":"Ditto, we don\u0027t need to rely on the old locations API. Nova can use the image’s stores field and call the dedicated temp-URL API directly.","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":false,"context_lines":[{"line_number":162,"context_line":"     ..."},{"line_number":163,"context_line":"   ]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Here we would introduce a new custome scheme \"tempurl\" that indicates image can"},{"line_number":166,"context_line":"be download using a tempURL and where to go for the download. TempURL is not"},{"line_number":167,"context_line":"generated at this point as we don\u0027t know yet if client really want to download."},{"line_number":168,"context_line":"We just direct them towards a Glance route they can GET to download image"},{"line_number":169,"context_line":"directly from store."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":" **[UPDATE API] Store details**"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Get stores details::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"f2d6e241_808ff571","line":170,"range":{"start_line":165,"start_character":1,"end_line":170,"end_character":1},"in_reply_to":"a21626d9_a3c14403","updated":"2026-10-26 12:36:32.000000000","message":"Acknowledged","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fe27c163522dc409e1e05d2d2ac0b9d3c544cf85","unresolved":true,"context_lines":[{"line_number":203,"context_line":"                 ..."},{"line_number":204,"context_line":"                 \"properties\": {"},{"line_number":205,"context_line":"                     ..."},{"line_number":206,"context_line":"                     \"temp_url_enabled\": false"},{"line_number":207,"context_line":"                 }"},{"line_number":208,"context_line":"            }"},{"line_number":209,"context_line":"        ]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"84706ff5_8c592642","line":206,"range":{"start_line":206,"start_character":21,"end_line":206,"end_character":46},"updated":"2026-10-15 06:29:44.000000000","message":"Are you going to hardcode it for swift and s3 as True or going to introduce new capability for each store?","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                 ..."},{"line_number":204,"context_line":"                 \"properties\": {"},{"line_number":205,"context_line":"                     ..."},{"line_number":206,"context_line":"                     \"temp_url_enabled\": false"},{"line_number":207,"context_line":"                 }"},{"line_number":208,"context_line":"            }"},{"line_number":209,"context_line":"        ]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"cb5cb343_6c041507","line":206,"range":{"start_line":206,"start_character":21,"end_line":206,"end_character":46},"in_reply_to":"84706ff5_8c592642","updated":"2026-10-26 12:36:32.000000000","message":"Acknowledged","commit_id":"e6e8fc7d561d7ce09de1dda1d1e573f253a1d745"}],"specs/2027.1/approved/glance/temp-url-generation.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5733f49b6864958807b1b75c3760844e2b121b8f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/glance/+spec/temp-url-generation"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Let Glance hand out short-lived URLs that read image data straight from an"},{"line_number":14,"context_line":"object store, so consumers such as Nova can download images without"},{"line_number":15,"context_line":"streaming them through the Glance API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"4a2a111c_9c3595ad","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":52},"updated":"2026-10-23 17:42:41.000000000","message":"also mention cinder?","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/glance/+spec/temp-url-generation"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Let Glance hand out short-lived URLs that read image data straight from an"},{"line_number":14,"context_line":"object store, so consumers such as Nova can download images without"},{"line_number":15,"context_line":"streaming them through the Glance API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"e6e2203f_ed010401","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":52},"in_reply_to":"4a2a111c_9c3595ad","updated":"2026-10-26 12:36:32.000000000","message":"Acknowledged","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5733f49b6864958807b1b75c3760844e2b121b8f","unresolved":true,"context_lines":[{"line_number":70,"context_line":"   driver interface, and ``get_temp_url(uri, backend, context\u003dNone)`` to"},{"line_number":71,"context_line":"   the multi-store helpers. A driver returns a tuple of (URL, expiry as an"},{"line_number":72,"context_line":"   aware UTC ``datetime``). A new ``TEMP_URL`` store capability bit"},{"line_number":73,"context_line":"   (``0b10000000``, the next free bit) says which stores give temporary"},{"line_number":74,"context_line":"   URLs: ``get_temp_url`` is guarded by ``capabilities.check`` like ``get``"},{"line_number":75,"context_line":"   and ``add``, and raises a new ``TempURLNotSupported`` on a store"},{"line_number":76,"context_line":"   without the capability. The driver sets the capability only when it"}],"source_content_type":"text/x-rst","patch_set":8,"id":"49e3367c_8776afc0","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":18},"updated":"2026-10-23 17:42:41.000000000","message":"Update BitMasks.ALL and the capability-check mapping for TEMP_URL.","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":false,"context_lines":[{"line_number":70,"context_line":"   driver interface, and ``get_temp_url(uri, backend, context\u003dNone)`` to"},{"line_number":71,"context_line":"   the multi-store helpers. A driver returns a tuple of (URL, expiry as an"},{"line_number":72,"context_line":"   aware UTC ``datetime``). A new ``TEMP_URL`` store capability bit"},{"line_number":73,"context_line":"   (``0b10000000``, the next free bit) says which stores give temporary"},{"line_number":74,"context_line":"   URLs: ``get_temp_url`` is guarded by ``capabilities.check`` like ``get``"},{"line_number":75,"context_line":"   and ``add``, and raises a new ``TempURLNotSupported`` on a store"},{"line_number":76,"context_line":"   without the capability. The driver sets the capability only when it"}],"source_content_type":"text/x-rst","patch_set":8,"id":"62c1b401_7eb462a7","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":18},"in_reply_to":"49e3367c_8776afc0","updated":"2026-10-26 12:36:32.000000000","message":"Acknowledged","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5733f49b6864958807b1b75c3760844e2b121b8f","unresolved":true,"context_lines":[{"line_number":101,"context_line":"Alternatives"},{"line_number":102,"context_line":"------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Expose a ``tempurl://`` entry in the image locations"},{"line_number":105,"context_line":"  Locations should represent actual backend object locations, not"},{"line_number":106,"context_line":"  Glance-generated capability routes. Reading them also relies on"},{"line_number":107,"context_line":"  ``show_multiple_locations``-style discovery. Consumers can use the"},{"line_number":108,"context_line":"  image\u0027s ``stores`` field and call the dedicated API."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"A redirect route answering ``307`` to the temporary URL"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ea5c8d80_13040a47","line":107,"range":{"start_line":104,"start_character":0,"end_line":107,"end_character":30},"updated":"2026-10-23 17:42:41.000000000","message":"I didn\u0027t like this alternative as we are planning to get rid of show_multiple_locations","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"de71090f5f162732f5c589ac1fce6b339991237e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Alternatives"},{"line_number":102,"context_line":"------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Expose a ``tempurl://`` entry in the image locations"},{"line_number":105,"context_line":"  Locations should represent actual backend object locations, not"},{"line_number":106,"context_line":"  Glance-generated capability routes. Reading them also relies on"},{"line_number":107,"context_line":"  ``show_multiple_locations``-style discovery. Consumers can use the"},{"line_number":108,"context_line":"  image\u0027s ``stores`` field and call the dedicated API."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"A redirect route answering ``307`` to the temporary URL"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5178afce_e9f5e6b0","line":107,"range":{"start_line":104,"start_character":0,"end_line":107,"end_character":30},"in_reply_to":"517df4ac_53518163","updated":"2026-11-05 13:13:17.000000000","message":"Done","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":true,"context_lines":[{"line_number":101,"context_line":"Alternatives"},{"line_number":102,"context_line":"------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Expose a ``tempurl://`` entry in the image locations"},{"line_number":105,"context_line":"  Locations should represent actual backend object locations, not"},{"line_number":106,"context_line":"  Glance-generated capability routes. Reading them also relies on"},{"line_number":107,"context_line":"  ``show_multiple_locations``-style discovery. Consumers can use the"},{"line_number":108,"context_line":"  image\u0027s ``stores`` field and call the dedicated API."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"A redirect route answering ``307`` to the temporary URL"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff1194a7_555b304a","line":107,"range":{"start_line":104,"start_character":0,"end_line":107,"end_character":30},"in_reply_to":"ea5c8d80_13040a47","updated":"2026-10-26 12:36:32.000000000","message":"I basically added \"other considered options\" as \"Alternatives\". I\u0027m happy to remove this and the other one if that\u0027s not how it should be approached.","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"78278902b3878c1d8f69de26253bd65867a4f06c","unresolved":true,"context_lines":[{"line_number":101,"context_line":"Alternatives"},{"line_number":102,"context_line":"------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Expose a ``tempurl://`` entry in the image locations"},{"line_number":105,"context_line":"  Locations should represent actual backend object locations, not"},{"line_number":106,"context_line":"  Glance-generated capability routes. Reading them also relies on"},{"line_number":107,"context_line":"  ``show_multiple_locations``-style discovery. Consumers can use the"},{"line_number":108,"context_line":"  image\u0027s ``stores`` field and call the dedicated API."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"A redirect route answering ``307`` to the temporary URL"}],"source_content_type":"text/x-rst","patch_set":8,"id":"517df4ac_53518163","line":107,"range":{"start_line":104,"start_character":0,"end_line":107,"end_character":30},"in_reply_to":"ff1194a7_555b304a","updated":"2026-10-30 06:12:30.000000000","message":"+1 to remove","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5733f49b6864958807b1b75c3760844e2b121b8f","unresolved":true,"context_lines":[{"line_number":126,"context_line":"  support. [OPEN: confirm this is acceptable, or add the store-less route"},{"line_number":127,"context_line":"  now.]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Give the consumers the store credentials"},{"line_number":130,"context_line":"  This is what Nova\u0027s RBD direct download does. For S3 and Swift it would"},{"line_number":131,"context_line":"  spread long-lived credentials and the whole store configuration to"},{"line_number":132,"context_line":"  every compute node."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Data model impact"},{"line_number":135,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"65adeddb_20abb956","line":132,"range":{"start_line":129,"start_character":0,"end_line":132,"end_character":21},"updated":"2026-10-23 17:42:41.000000000","message":"AFAIK during PTG discussion someone from Nova declined this solution to store the credentials at nova side.","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":true,"context_lines":[{"line_number":126,"context_line":"  support. [OPEN: confirm this is acceptable, or add the store-less route"},{"line_number":127,"context_line":"  now.]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Give the consumers the store credentials"},{"line_number":130,"context_line":"  This is what Nova\u0027s RBD direct download does. For S3 and Swift it would"},{"line_number":131,"context_line":"  spread long-lived credentials and the whole store configuration to"},{"line_number":132,"context_line":"  every compute node."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Data model impact"},{"line_number":135,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"74bb6ff2_fcbbd13d","line":132,"range":{"start_line":129,"start_character":0,"end_line":132,"end_character":21},"in_reply_to":"65adeddb_20abb956","updated":"2026-10-26 12:36:32.000000000","message":"I was personally oposing the idea as I\u0027m mostly an operator and storing S3 creds masively increases exposure in case of host compromise. AFAIR Dan (or someone else? not 100% on this) agreed with that sentiment.","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"78278902b3878c1d8f69de26253bd65867a4f06c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  support. [OPEN: confirm this is acceptable, or add the store-less route"},{"line_number":127,"context_line":"  now.]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Give the consumers the store credentials"},{"line_number":130,"context_line":"  This is what Nova\u0027s RBD direct download does. For S3 and Swift it would"},{"line_number":131,"context_line":"  spread long-lived credentials and the whole store configuration to"},{"line_number":132,"context_line":"  every compute node."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Data model impact"},{"line_number":135,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"0db1fc63_85a007b5","line":132,"range":{"start_line":129,"start_character":0,"end_line":132,"end_character":21},"in_reply_to":"74bb6ff2_fcbbd13d","updated":"2026-10-30 06:12:30.000000000","message":"Acknowledged","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5733f49b6864958807b1b75c3760844e2b121b8f","unresolved":true,"context_lines":[{"line_number":176,"context_line":"--     any method other than GET: 405"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"[OPEN: whether this new call needs an Images API minor version bump. The"},{"line_number":180,"context_line":"implementation does not bump it; needs the reviewers\u0027 call.]"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"**[UPDATE API] Store discovery**::"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  GET /v2/info/stores/detail"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba97bc49_80740832","line":181,"range":{"start_line":179,"start_character":0,"end_line":181,"end_character":1},"updated":"2026-10-23 17:42:41.000000000","message":"Yes this will need minor version bump","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":false,"context_lines":[{"line_number":176,"context_line":"--     any method other than GET: 405"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"[OPEN: whether this new call needs an Images API minor version bump. The"},{"line_number":180,"context_line":"implementation does not bump it; needs the reviewers\u0027 call.]"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"**[UPDATE API] Store discovery**::"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  GET /v2/info/stores/detail"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bdfd9ab8_b8267f9e","line":181,"range":{"start_line":179,"start_character":0,"end_line":181,"end_character":1},"in_reply_to":"ba97bc49_80740832","updated":"2026-10-26 12:36:32.000000000","message":"Acknowledged","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5733f49b6864958807b1b75c3760844e2b121b8f","unresolved":true,"context_lines":[{"line_number":204,"context_line":"Mitigations:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* New policy ``generate_image_temp_url``, defaulting to"},{"line_number":207,"context_line":"  ``role:admin or (role:member and service_roles:service)``: a bare"},{"line_number":208,"context_line":"  admin, or a project member whose request comes with a service token"},{"line_number":209,"context_line":"  carrying the ``service`` role (``service_roles`` is evaluated on the"},{"line_number":210,"context_line":"  service token\u0027s roles). Services can therefore only obtain URLs on"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f93aa3f_ca43acb3","line":207,"range":{"start_line":207,"start_character":3,"end_line":207,"end_character":57},"updated":"2026-10-23 17:42:41.000000000","message":"I think role:admin or role:service should be enough. Also use the existing rule:service_api for the service-token check instead of a new inline expression.","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6d742d1ccdefcf78570271e2bfe06d4a5b73d631","unresolved":true,"context_lines":[{"line_number":204,"context_line":"Mitigations:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* New policy ``generate_image_temp_url``, defaulting to"},{"line_number":207,"context_line":"  ``role:admin or (role:member and service_roles:service)``: a bare"},{"line_number":208,"context_line":"  admin, or a project member whose request comes with a service token"},{"line_number":209,"context_line":"  carrying the ``service`` role (``service_roles`` is evaluated on the"},{"line_number":210,"context_line":"  service token\u0027s roles). Services can therefore only obtain URLs on"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3bbd3572_51c58e97","line":207,"range":{"start_line":207,"start_character":3,"end_line":207,"end_character":57},"in_reply_to":"02df9944_e5a6918d","updated":"2026-10-30 14:28:20.000000000","message":"I think this will make glance depend on internal build state of nova and will not work well for other consumers of glance like cinder and ironic.","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":false,"context_lines":[{"line_number":204,"context_line":"Mitigations:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* New policy ``generate_image_temp_url``, defaulting to"},{"line_number":207,"context_line":"  ``role:admin or (role:member and service_roles:service)``: a bare"},{"line_number":208,"context_line":"  admin, or a project member whose request comes with a service token"},{"line_number":209,"context_line":"  carrying the ``service`` role (``service_roles`` is evaluated on the"},{"line_number":210,"context_line":"  service token\u0027s roles). Services can therefore only obtain URLs on"}],"source_content_type":"text/x-rst","patch_set":8,"id":"afcebb3f_e4a45d71","line":207,"range":{"start_line":207,"start_character":3,"end_line":207,"end_character":57},"in_reply_to":"7f93aa3f_ca43acb3","updated":"2026-10-26 12:36:32.000000000","message":"my reasoning for this one was along the lines of: if someone compromises a host, they should be able to at most create tmpurls for images of customers already on that host, hence the member and service requirement. but upon further testing you are correct. if I pass service token as user token as well, glance happily hands a url. so my first (most likely stupid) idea would be to ensure that users are different for each token. but that becomes useless if users for cinder/key-manager are different than nova service user which is highly likely in many deployments.","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"5d4ff202fa303b0c1668393e682c1c424e3d0f49","unresolved":true,"context_lines":[{"line_number":204,"context_line":"Mitigations:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* New policy ``generate_image_temp_url``, defaulting to"},{"line_number":207,"context_line":"  ``role:admin or (role:member and service_roles:service)``: a bare"},{"line_number":208,"context_line":"  admin, or a project member whose request comes with a service token"},{"line_number":209,"context_line":"  carrying the ``service`` role (``service_roles`` is evaluated on the"},{"line_number":210,"context_line":"  service token\u0027s roles). Services can therefore only obtain URLs on"}],"source_content_type":"text/x-rst","patch_set":8,"id":"02df9944_e5a6918d","line":207,"range":{"start_line":207,"start_character":3,"end_line":207,"end_character":57},"in_reply_to":"afcebb3f_e4a45d71","updated":"2026-10-30 11:27:10.000000000","message":"lhenry proposed very interesting idea to substantially limit exposure in case of host compromise: what if we make glance do a call to nova before it generates tmpurl, to ensure that there\u0027s actually an instance spawning that needs it? the moment tmpurl is needed, scheduler already selected which host the instance will build on, so that data should be already available","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5733f49b6864958807b1b75c3760844e2b121b8f","unresolved":true,"context_lines":[{"line_number":210,"context_line":"  service token\u0027s roles). Services can therefore only obtain URLs on"},{"line_number":211,"context_line":"  behalf of a user who actually requested the download; a bare service"},{"line_number":212,"context_line":"  token without a user context, and an ordinary member without a service"},{"line_number":213,"context_line":"  token, are both refused. The caller must also pass ``download_image``"},{"line_number":214,"context_line":"  on the image, so the API never hands out data the caller could not"},{"line_number":215,"context_line":"  download through ``/file``. The check deliberately does not include"},{"line_number":216,"context_line":"  ``project_id:%(project_id)s``: the image may be public, shared or"},{"line_number":217,"context_line":"  community, and the paired ``download_image`` check already enforces the"},{"line_number":218,"context_line":"  caller\u0027s relation to the image."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1c1549a6_f994af65","line":215,"range":{"start_line":213,"start_character":27,"end_line":215,"end_character":29},"updated":"2026-10-23 17:42:41.000000000","message":"Use download_from_store, or explain why download_image is correct for a store-scoped route.","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8dc781358f9e0ac374b37cdb74f103a989f69a28","unresolved":true,"context_lines":[{"line_number":210,"context_line":"  service token\u0027s roles). Services can therefore only obtain URLs on"},{"line_number":211,"context_line":"  behalf of a user who actually requested the download; a bare service"},{"line_number":212,"context_line":"  token without a user context, and an ordinary member without a service"},{"line_number":213,"context_line":"  token, are both refused. The caller must also pass ``download_image``"},{"line_number":214,"context_line":"  on the image, so the API never hands out data the caller could not"},{"line_number":215,"context_line":"  download through ``/file``. The check deliberately does not include"},{"line_number":216,"context_line":"  ``project_id:%(project_id)s``: the image may be public, shared or"},{"line_number":217,"context_line":"  community, and the paired ``download_image`` check already enforces the"},{"line_number":218,"context_line":"  caller\u0027s relation to the image."}],"source_content_type":"text/x-rst","patch_set":8,"id":"add808a6_fe5a7729","line":215,"range":{"start_line":213,"start_character":27,"end_line":215,"end_character":29},"in_reply_to":"1c1549a6_f994af65","updated":"2026-10-26 12:36:32.000000000","message":"I left it like that because I wasn\u0027t sure if L118 alternative with `GET /v2/images/{image_id}/tempurl` wouldn\u0027t be preferred approach","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"78278902b3878c1d8f69de26253bd65867a4f06c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"  service token\u0027s roles). Services can therefore only obtain URLs on"},{"line_number":211,"context_line":"  behalf of a user who actually requested the download; a bare service"},{"line_number":212,"context_line":"  token without a user context, and an ordinary member without a service"},{"line_number":213,"context_line":"  token, are both refused. The caller must also pass ``download_image``"},{"line_number":214,"context_line":"  on the image, so the API never hands out data the caller could not"},{"line_number":215,"context_line":"  download through ``/file``. The check deliberately does not include"},{"line_number":216,"context_line":"  ``project_id:%(project_id)s``: the image may be public, shared or"},{"line_number":217,"context_line":"  community, and the paired ``download_image`` check already enforces the"},{"line_number":218,"context_line":"  caller\u0027s relation to the image."}],"source_content_type":"text/x-rst","patch_set":8,"id":"8169f11f_5caa0196","line":215,"range":{"start_line":213,"start_character":27,"end_line":215,"end_character":29},"in_reply_to":"add808a6_fe5a7729","updated":"2026-10-30 06:12:30.000000000","message":"Acknowledged","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":37535,"name":"Florent Le Lain","display_name":"flelain","email":"florent.le-lain@ovhcloud.com","username":"flelain"},"change_message_id":"613609044cf0d4dda651ce576a4f6bf355043e35","unresolved":true,"context_lines":[{"line_number":344,"context_line":"   change and a requirements bump."},{"line_number":345,"context_line":"3. Swift driver (follow-up glance_store change, same cycle)."},{"line_number":346,"context_line":"4. openstacksdk and python-openstackclient support, this cycle — no new"},{"line_number":347,"context_line":"   user-facing Glance API lands without it. python-glanceclient is not"},{"line_number":348,"context_line":"   changed: the CLI is being deprecated and consumers (Nova first) call"},{"line_number":349,"context_line":"   the API with a plain GET on the keystoneauth session they already have."},{"line_number":350,"context_line":"5. Tempest tests on an S3-backed devstack."}],"source_content_type":"text/x-rst","patch_set":8,"id":"d6806cbd_957b411c","line":347,"updated":"2026-10-30 16:00:59.000000000","message":"1010607 (nova-specs counterpart) suggests `python-glanceclient` will change, on the contrary.\n\n```suggestion\n   user-facing Glance API lands without it. python-glanceclient is\n```","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"3e66ae848d5f15a5948f20a16fbacd8f2913ead2","unresolved":true,"context_lines":[{"line_number":344,"context_line":"   change and a requirements bump."},{"line_number":345,"context_line":"3. Swift driver (follow-up glance_store change, same cycle)."},{"line_number":346,"context_line":"4. openstacksdk and python-openstackclient support, this cycle — no new"},{"line_number":347,"context_line":"   user-facing Glance API lands without it. python-glanceclient is not"},{"line_number":348,"context_line":"   changed: the CLI is being deprecated and consumers (Nova first) call"},{"line_number":349,"context_line":"   the API with a plain GET on the keystoneauth session they already have."},{"line_number":350,"context_line":"5. Tempest tests on an S3-backed devstack."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9c5fd182_45dbc898","line":347,"in_reply_to":"d6806cbd_957b411c","updated":"2026-11-05 19:22:35.000000000","message":"This comment has not been adressed, and we might want to figure out whether we want to add support for this in glanceclient as well. Let\u0027s not hold the spec, though.","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":37535,"name":"Florent Le Lain","display_name":"flelain","email":"florent.le-lain@ovhcloud.com","username":"flelain"},"change_message_id":"613609044cf0d4dda651ce576a4f6bf355043e35","unresolved":true,"context_lines":[{"line_number":367,"context_line":"  auth header (HTTPS only, no redirects), checks size and ``os_hash_value``"},{"line_number":368,"context_line":"  while streaming, and on any error moves to the next store, then falls"},{"line_number":369,"context_line":"  back to ``/file``; a bad image signature fails the download instead of"},{"line_number":370,"context_line":"  falling back; images without ``os_hash_value`` always use ``/file``."},{"line_number":371,"context_line":"  Store order will follow the preferred-store selection work"},{"line_number":372,"context_line":"  (glance-preferred-store) when it lands."},{"line_number":373,"context_line":"* Related: the direct multipart upload spec (1009784), see below."}],"source_content_type":"text/x-rst","patch_set":8,"id":"c621993e_b86475a0","line":370,"updated":"2026-10-30 16:00:59.000000000","message":"This may contradict 1010607, lines 127-131 (nova-spec \"Add Download glance images using temporary URLs\")","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5733f49b6864958807b1b75c3760844e2b121b8f","unresolved":true,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"* A glance_store release containing the driver interface"},{"line_number":360,"context_line":"  (``glance-store\u003e\u003d5.8.0``)."},{"line_number":361,"context_line":"* Nova\u0027s use of this API is specified by nova-spec"},{"line_number":362,"context_line":"  ``glance-temp-url-image-download`` (1010607). The flow implemented and"},{"line_number":363,"context_line":"  tested end to end in our PoC: Nova reads the image\u0027s ``stores`` field,"},{"line_number":364,"context_line":"  calls this API per store with the user\u0027s token plus its service token"},{"line_number":365,"context_line":"  (matching the default policy: the user token carries ``member``, the"},{"line_number":366,"context_line":"  service token carries ``service``), downloads the returned URL with no"},{"line_number":367,"context_line":"  auth header (HTTPS only, no redirects), checks size and ``os_hash_value``"},{"line_number":368,"context_line":"  while streaming, and on any error moves to the next store, then falls"},{"line_number":369,"context_line":"  back to ``/file``; a bad image signature fails the download instead of"},{"line_number":370,"context_line":"  falling back; images without ``os_hash_value`` always use ``/file``."},{"line_number":371,"context_line":"  Store order will follow the preferred-store selection work"},{"line_number":372,"context_line":"  (glance-preferred-store) when it lands."},{"line_number":373,"context_line":"* Related: the direct multipart upload spec (1009784), see below."},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"Consistency with the direct multipart upload spec (1009784)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"509c1eb2_c1a29358","line":372,"range":{"start_line":361,"start_character":0,"end_line":372,"end_character":41},"updated":"2026-10-23 17:42:41.000000000","message":"Nova cannot depend on ``image.stores``: it is derived from locations and\nhidden unless ``get_image_location`` passes. With the default policy, a\nmember plus service token can download but still not see stores. Either\nexpose store IDs without that policy or have Nova call\n``/v2/info/stores/detail``.","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"de71090f5f162732f5c589ac1fce6b339991237e","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"* A glance_store release containing the driver interface"},{"line_number":360,"context_line":"  (``glance-store\u003e\u003d5.8.0``)."},{"line_number":361,"context_line":"* Nova\u0027s use of this API is specified by nova-spec"},{"line_number":362,"context_line":"  ``glance-temp-url-image-download`` (1010607). The flow implemented and"},{"line_number":363,"context_line":"  tested end to end in our PoC: Nova reads the image\u0027s ``stores`` field,"},{"line_number":364,"context_line":"  calls this API per store with the user\u0027s token plus its service token"},{"line_number":365,"context_line":"  (matching the default policy: the user token carries ``member``, the"},{"line_number":366,"context_line":"  service token carries ``service``), downloads the returned URL with no"},{"line_number":367,"context_line":"  auth header (HTTPS only, no redirects), checks size and ``os_hash_value``"},{"line_number":368,"context_line":"  while streaming, and on any error moves to the next store, then falls"},{"line_number":369,"context_line":"  back to ``/file``; a bad image signature fails the download instead of"},{"line_number":370,"context_line":"  falling back; images without ``os_hash_value`` always use ``/file``."},{"line_number":371,"context_line":"  Store order will follow the preferred-store selection work"},{"line_number":372,"context_line":"  (glance-preferred-store) when it lands."},{"line_number":373,"context_line":"* Related: the direct multipart upload spec (1009784), see below."},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"Consistency with the direct multipart upload spec (1009784)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"250c6a58_4a61f97f","line":372,"range":{"start_line":361,"start_character":0,"end_line":372,"end_character":41},"in_reply_to":"509c1eb2_c1a29358","updated":"2026-11-05 13:13:17.000000000","message":"Done","commit_id":"bd9b6cafae9243b8fc1467d23edefc46ee8e84f0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"78278902b3878c1d8f69de26253bd65867a4f06c","unresolved":true,"context_lines":[{"line_number":219,"context_line":"  ``project_id:%(project_id)s``: the image may be public, shared or"},{"line_number":220,"context_line":"  community, and the paired ``download_image`` check already enforces the"},{"line_number":221,"context_line":"  caller\u0027s relation to the image."},{"line_number":222,"context_line":"* Short, bounded expiry: 300 s by default, at most 604800 s (7 days, the"},{"line_number":223,"context_line":"  SigV4 limit). [OPEN: cap the maximum lower, e.g. 3600 s — Nova needs"},{"line_number":224,"context_line":"  seconds; only consumers like Ironic might need more.]"},{"line_number":225,"context_line":"* ``Cache-Control: no-store`` on the response."},{"line_number":226,"context_line":"* The URL is never logged by the Glance API or the drivers and never"},{"line_number":227,"context_line":"  appears in a notification. (Known leak vectors found while testing the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"90f107f0_130201c2","line":224,"range":{"start_line":222,"start_character":43,"end_line":224,"end_character":55},"updated":"2026-10-30 06:12:30.000000000","message":"seven-day maximum expiry is too long, i preffer to cap this at 3600.","commit_id":"86e60d1c940189b113a3217d8cf4bc4c8e354a00"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"468bb5a4ef6dd92796be67fffc961c96407d8a91","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  ``project_id:%(project_id)s``: the image may be public, shared or"},{"line_number":220,"context_line":"  community, and the paired ``download_image`` check already enforces the"},{"line_number":221,"context_line":"  caller\u0027s relation to the image."},{"line_number":222,"context_line":"* Short, bounded expiry: 300 s by default, at most 604800 s (7 days, the"},{"line_number":223,"context_line":"  SigV4 limit). [OPEN: cap the maximum lower, e.g. 3600 s — Nova needs"},{"line_number":224,"context_line":"  seconds; only consumers like Ironic might need more.]"},{"line_number":225,"context_line":"* ``Cache-Control: no-store`` on the response."},{"line_number":226,"context_line":"* The URL is never logged by the Glance API or the drivers and never"},{"line_number":227,"context_line":"  appears in a notification. (Known leak vectors found while testing the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"67a60b21_59ad4d19","line":224,"range":{"start_line":222,"start_character":43,"end_line":224,"end_character":55},"in_reply_to":"90f107f0_130201c2","updated":"2026-11-05 13:24:36.000000000","message":"Done","commit_id":"86e60d1c940189b113a3217d8cf4bc4c8e354a00"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"738cc0dfd8dcf8b5858e1f07c058a48fb5ce979c","unresolved":true,"context_lines":[{"line_number":119,"context_line":"  keeps one code path, and leaves the store choice to the consumer, which"},{"line_number":120,"context_line":"  knows which endpoints it can reach. The store-less call can be added"},{"line_number":121,"context_line":"  later on top of the same driver method if the cores want single-store"},{"line_number":122,"context_line":"  support. [OPEN: confirm this is acceptable, or add the store-less route"},{"line_number":123,"context_line":"  now.]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Data model impact"},{"line_number":126,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"82b7d801_e0254b75","line":123,"range":{"start_line":122,"start_character":11,"end_line":123,"end_character":7},"updated":"2026-11-05 14:31:23.000000000","message":"This decision must be taken before approval. Please either commit to the\nper-store route only, or define the store-less route now. An approved spec\ncannot leave the API shape as [OPEN].","commit_id":"7dc665665bda20487cf45286974e87cc00a4fdc6"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"85bf686677d29ecbd34935b7856df5688b70e7bf","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  keeps one code path, and leaves the store choice to the consumer, which"},{"line_number":120,"context_line":"  knows which endpoints it can reach. The store-less call can be added"},{"line_number":121,"context_line":"  later on top of the same driver method if the cores want single-store"},{"line_number":122,"context_line":"  support. [OPEN: confirm this is acceptable, or add the store-less route"},{"line_number":123,"context_line":"  now.]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Data model impact"},{"line_number":126,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a6428ed_095ff632","line":123,"range":{"start_line":122,"start_character":11,"end_line":123,"end_character":7},"in_reply_to":"82b7d801_e0254b75","updated":"2026-11-05 16:21:11.000000000","message":"Done","commit_id":"7dc665665bda20487cf45286974e87cc00a4fdc6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"738cc0dfd8dcf8b5858e1f07c058a48fb5ce979c","unresolved":true,"context_lines":[{"line_number":203,"context_line":"* New policy ``generate_image_temp_url``, defaulting to"},{"line_number":204,"context_line":"  ``role:admin or role:service``: only an administrator, or a caller"},{"line_number":205,"context_line":"  whose primary token carries the ``service`` role, may generate URLs."},{"line_number":206,"context_line":"  Only the primary token\u0027s roles are checked, so a service token sent as"},{"line_number":207,"context_line":"  ``X-Service-Token`` does not grant access. The caller must also pass"},{"line_number":208,"context_line":"  ``download_from_store`` (the store-selection policy from the"},{"line_number":209,"context_line":"  download-from-suggested-stores work) on the image, so the API does not"},{"line_number":210,"context_line":"  hand out data the caller could not download from a specific store"}],"source_content_type":"text/x-rst","patch_set":10,"id":"42cfed67_ce486c9e","line":207,"range":{"start_line":206,"start_character":0,"end_line":207,"end_character":70},"updated":"2026-11-05 14:31:23.000000000","message":"1. The primary token must pass ``download_from_store``.\n2. ``generate_image_temp_url`` defaults to ``rule:service_api (ie. `role:admin or role:service` and is\n   evaluated with the union of primary-token and service-token roles.\n\nThe service role permits the optimized path; it does not authorize image\ndata by itself.","commit_id":"7dc665665bda20487cf45286974e87cc00a4fdc6"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"85bf686677d29ecbd34935b7856df5688b70e7bf","unresolved":false,"context_lines":[{"line_number":203,"context_line":"* New policy ``generate_image_temp_url``, defaulting to"},{"line_number":204,"context_line":"  ``role:admin or role:service``: only an administrator, or a caller"},{"line_number":205,"context_line":"  whose primary token carries the ``service`` role, may generate URLs."},{"line_number":206,"context_line":"  Only the primary token\u0027s roles are checked, so a service token sent as"},{"line_number":207,"context_line":"  ``X-Service-Token`` does not grant access. The caller must also pass"},{"line_number":208,"context_line":"  ``download_from_store`` (the store-selection policy from the"},{"line_number":209,"context_line":"  download-from-suggested-stores work) on the image, so the API does not"},{"line_number":210,"context_line":"  hand out data the caller could not download from a specific store"}],"source_content_type":"text/x-rst","patch_set":10,"id":"a63db4dc_14100fb5","line":207,"range":{"start_line":206,"start_character":0,"end_line":207,"end_character":70},"in_reply_to":"42cfed67_ce486c9e","updated":"2026-11-05 16:21:11.000000000","message":"Done","commit_id":"7dc665665bda20487cf45286974e87cc00a4fdc6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"738cc0dfd8dcf8b5858e1f07c058a48fb5ce979c","unresolved":true,"context_lines":[{"line_number":390,"context_line":"Expiry field               ``expires_at``                     ``expires_at``"},{"line_number":391,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"* Given that this spec seems further along: align 1009784 to this work."},{"line_number":394,"context_line":"  [OPEN: This whole paragraph can possibly be removed]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Testing"},{"line_number":397,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5d204a40_384520fa","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":54},"updated":"2026-11-05 14:31:23.000000000","message":"This also needs to be removed","commit_id":"7dc665665bda20487cf45286974e87cc00a4fdc6"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"85bf686677d29ecbd34935b7856df5688b70e7bf","unresolved":false,"context_lines":[{"line_number":390,"context_line":"Expiry field               ``expires_at``                     ``expires_at``"},{"line_number":391,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"* Given that this spec seems further along: align 1009784 to this work."},{"line_number":394,"context_line":"  [OPEN: This whole paragraph can possibly be removed]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"Testing"},{"line_number":397,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"2271ce57_3b7dd2e6","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":54},"in_reply_to":"5d204a40_384520fa","updated":"2026-11-05 16:21:11.000000000","message":"Done","commit_id":"7dc665665bda20487cf45286974e87cc00a4fdc6"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"3e66ae848d5f15a5948f20a16fbacd8f2913ead2","unresolved":true,"context_lines":[{"line_number":95,"context_line":"   store is not supported at first: with one account per project each"},{"line_number":96,"context_line":"   account would need its own key, so the driver simply does not set the"},{"line_number":97,"context_line":"   ``TEMP_URL`` capability in that mode."},{"line_number":98,"context_line":"#. openstacksdk and python-openstackclient support, in this cycle."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The feature needs multiple stores (``enabled_backends``): the route"},{"line_number":101,"context_line":"addresses a store by its identifier."}],"source_content_type":"text/x-rst","patch_set":14,"id":"c81313f8_50e24a1e","line":98,"range":{"start_line":98,"start_character":27,"end_line":98,"end_character":42},"updated":"2026-11-05 19:22:35.000000000","message":"I would have liked to see exactly what you had in mind in terms of user-facing interface, but this can be done later.","commit_id":"6f8323d5ebbf18e899e75b687e562c9e711c6b9f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3fe81349381c4e50857b2d3f1f06165e69cd8357","unresolved":true,"context_lines":[{"line_number":157,"context_line":"Order  Condition / code"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":"1      multiple stores (``enabled_backends``) not enabled: 404"},{"line_number":160,"context_line":"2      store unknown on this node: 409"},{"line_number":161,"context_line":"3      image missing or not visible to the primary token: 404"},{"line_number":162,"context_line":"4      a policy check fails: 403"},{"line_number":163,"context_line":"5      image not ``active``: 409"}],"source_content_type":"text/x-rst","patch_set":14,"id":"810a3ff3_05edbead","line":160,"range":{"start_line":160,"start_character":35,"end_line":160,"end_character":38},"updated":"2026-11-05 21:53:14.000000000","message":"This is kind of a nit, but a 409 doesn\u0027t seem quite right for this.  For image upload, \"If the store identifier specified is not recognized, a 400 (Bad Request) response is returned.\" [0]  We should probably do the same thing here for consistency.\n\n[0] https://docs.openstack.org/api-ref/image/v2/#upload-binary-image-data","commit_id":"6f8323d5ebbf18e899e75b687e562c9e711c6b9f"}],"specs/2027.1/approved/index.rst":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"2a11f6a6cc97571d86b3373c8cfe6a11d5d38d73","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e19ae656_c7551520","line":15,"updated":"2026-11-05 19:19:08.000000000","message":"Not sure what this is about :)","commit_id":"047178c909ae36ec750763899d61ec1113e053d0"}]}
