)]}'
{"glance_tempest_plugin/tests/rbac/v2/test_images.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2f21f1a416059c7f929adea9773bc7d51d4d1c7e","unresolved":true,"context_lines":[{"line_number":398,"context_line":"        image_data \u003d six.BytesIO(file_contents)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        project_id \u003d self.persona.credentials.project_id"},{"line_number":401,"context_line":"        project_member \u003d self.setup_user_client(project_id\u003dproject_id)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        # upload file for private image - pass"},{"line_number":404,"context_line":"        image \u003d project_member.image_client_v2.create_image("}],"source_content_type":"text/x-python","patch_set":3,"id":"de849ea2_7747c4b6","line":401,"range":{"start_line":401,"start_character":15,"end_line":401,"end_character":22},"updated":"2021-03-09 23:32:05.000000000","message":"I think I\u0027m missing why this is changing. You use project_client to refer to the same sort of thing below, so this seems wrong. What am I missing?","commit_id":"609c963e90c943dedc0f20348de82c6e37eb0c5c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6b442a5cde1350445c4fd55886210476e68e5a59","unresolved":true,"context_lines":[{"line_number":398,"context_line":"        image_data \u003d six.BytesIO(file_contents)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        project_id \u003d self.persona.credentials.project_id"},{"line_number":401,"context_line":"        project_member \u003d self.setup_user_client(project_id\u003dproject_id)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        # upload file for private image - pass"},{"line_number":404,"context_line":"        image \u003d project_member.image_client_v2.create_image("}],"source_content_type":"text/x-python","patch_set":3,"id":"946413f7_d403fa19","line":401,"range":{"start_line":401,"start_character":15,"end_line":401,"end_character":22},"in_reply_to":"3e205f0a_6e6b5092","updated":"2021-03-10 16:34:35.000000000","message":"Yeah - that works. Since we don\u0027t consume system-scope yet, it\u0027s pretty easy to infer project-member.","commit_id":"609c963e90c943dedc0f20348de82c6e37eb0c5c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2e2020051ef5d0324de02c527387d193a9c06b2b","unresolved":true,"context_lines":[{"line_number":398,"context_line":"        image_data \u003d six.BytesIO(file_contents)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        project_id \u003d self.persona.credentials.project_id"},{"line_number":401,"context_line":"        project_member \u003d self.setup_user_client(project_id\u003dproject_id)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        # upload file for private image - pass"},{"line_number":404,"context_line":"        image \u003d project_member.image_client_v2.create_image("}],"source_content_type":"text/x-python","patch_set":3,"id":"3e205f0a_6e6b5092","line":401,"range":{"start_line":401,"start_character":15,"end_line":401,"end_character":22},"in_reply_to":"9ef92961_51eda5d5","updated":"2021-03-10 02:21:23.000000000","message":"member_client?","commit_id":"609c963e90c943dedc0f20348de82c6e37eb0c5c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"543d834cc050eefa201a488342c59f08ccab0945","unresolved":true,"context_lines":[{"line_number":398,"context_line":"        image_data \u003d six.BytesIO(file_contents)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        project_id \u003d self.persona.credentials.project_id"},{"line_number":401,"context_line":"        project_member \u003d self.setup_user_client(project_id\u003dproject_id)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        # upload file for private image - pass"},{"line_number":404,"context_line":"        image \u003d project_member.image_client_v2.create_image("}],"source_content_type":"text/x-python","patch_set":3,"id":"9ef92961_51eda5d5","line":401,"range":{"start_line":401,"start_character":15,"end_line":401,"end_character":22},"in_reply_to":"de849ea2_7747c4b6","updated":"2021-03-10 02:14:31.000000000","message":"Yeah - I don\u0027t have a good reason for this.\n\nI was trying to think of a convention for a variable name that would shorten things up.\n\nI felt that using `project_member` signified the returned client was a member of the project_id passed in. Whereas `project_client` is just a set of clients for a project *somewhere*. I don\u0027t think the initial protection test implementation used the terms consistently, so I was trying to fix that here.\n\nIt\u0027s a stretch. I\u0027m open to renaming this or backing it out all together.","commit_id":"609c963e90c943dedc0f20348de82c6e37eb0c5c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"543d834cc050eefa201a488342c59f08ccab0945","unresolved":true,"context_lines":[{"line_number":425,"context_line":"        self.do_request(\u0027store_image_file\u0027, image_id\u003dimage[\u0027id\u0027],"},{"line_number":426,"context_line":"                        expected_status\u003d204, data\u003dimage_data)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        project_client \u003d self.os_project_alt_member"},{"line_number":429,"context_line":"        image \u003d project_client.image_client_v2.create_image("},{"line_number":430,"context_line":"            **self.image(visibility\u003d\u0027private\u0027))"},{"line_number":431,"context_line":"        self.addCleanup(self.admin_images_client.delete_image,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ee682176_021513f5","line":428,"range":{"start_line":428,"start_character":8,"end_line":428,"end_character":22},"updated":"2021-03-10 02:14:31.000000000","message":"My use of `project_client` here is for a client that has no authoritative overlap with the persona client (self.persona, self.client, or project_member).","commit_id":"609c963e90c943dedc0f20348de82c6e37eb0c5c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2f21f1a416059c7f929adea9773bc7d51d4d1c7e","unresolved":true,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    def test_download_image(self):"},{"line_number":466,"context_line":"        project_id \u003d self.persona.credentials.project_id"},{"line_number":467,"context_line":"        project_member \u003d self.setup_user_client(project_id\u003dproject_id)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        image \u003d project_member.image_client_v2.create_image("},{"line_number":470,"context_line":"            **self.image(visibility\u003d\u0027private\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"6a2626d6_0477f248","line":467,"range":{"start_line":467,"start_character":8,"end_line":467,"end_character":22},"updated":"2021-03-09 23:32:05.000000000","message":"Same here, so I must be missing something.","commit_id":"609c963e90c943dedc0f20348de82c6e37eb0c5c"}]}