)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"e1ce64cf8dc6936cacfdbb2d771bcccedba21b71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"90c81702_2e01babe","updated":"2021-10-13 22:23:33.000000000","message":"Same nitpicks as on the other patches, otherwise lgtm.","commit_id":"9e6178bd3e947d41ccc9e709f1ecf3082b33023c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"68eaf2d452a4eb42b411a6c472980d663c47f1e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d06a27cf_0324e400","updated":"2022-04-14 07:20:20.000000000","message":"Looks good,thank you!","commit_id":"92a697f345caa249b22cff6ae75b11acf8fb3fa8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ae444005dd34c34d521159d0db539aa8612c1dd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cbee4496_d1bfdc3f","updated":"2022-05-12 16:28:09.000000000","message":"Just rebased, so +Wing","commit_id":"00aa266d9fcdae3a5b1c5d2f6353a4aed861abba"}],"glance_tempest_plugin/tests/rbac/v2/metadefs/test_tags.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5e3bfc64c9f279d5131d9f66ccd0af286290eac2","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    def test_delete_tags(self):"},{"line_number":67,"context_line":"        \"\"\"Test delete_metadef_tag policy.\"\"\""},{"line_number":68,"context_line":"        pass"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class ProjectAdminTests(MetadefV2RbacTagsTest, tempest.test.BaseTestCase,"},{"line_number":72,"context_line":"                        metaclass\u003dabc.ABCMeta):"}],"source_content_type":"text/x-python","patch_set":2,"id":"28745e31_b4686b2c","line":69,"updated":"2021-09-03 05:58:39.000000000","message":"I think create_tags_multiple and delete_tags_multiple are missing","commit_id":"98356d8dc300699cc04108febc5cc75690c13383"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"6e0b5a3ae26cc09fcdeeee4cf99f424167cb1c37","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    def test_delete_tags(self):"},{"line_number":67,"context_line":"        \"\"\"Test delete_metadef_tag policy.\"\"\""},{"line_number":68,"context_line":"        pass"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class ProjectAdminTests(MetadefV2RbacTagsTest, tempest.test.BaseTestCase,"},{"line_number":72,"context_line":"                        metaclass\u003dabc.ABCMeta):"}],"source_content_type":"text/x-python","patch_set":2,"id":"de8c208a_6600fa9b","line":69,"in_reply_to":"28745e31_b4686b2c","updated":"2022-03-01 13:39:41.000000000","message":"I have not added the seperate tests for create_multiple_tags \u0026 delete_multiple_tags, that\u0027s why not added it here.","commit_id":"98356d8dc300699cc04108febc5cc75690c13383"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a1b67a4deb13d15645fa7476fbe17544d772c06b","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        client \u003d self.tags_alt_admin_client"},{"line_number":60,"context_line":"        namespace_tags \u003d []"},{"line_number":61,"context_line":"        for ns in namespaces:"},{"line_number":62,"context_line":"            if ns[\u0027namespace\u0027].startswith(self.tags_admin_client.project_id):"},{"line_number":63,"context_line":"                client \u003d self.tags_admin_client"},{"line_number":64,"context_line":"            tag_name \u003d \"tag_of_%s\" % (ns[\u0027namespace\u0027])"},{"line_number":65,"context_line":"            namespace_tag \u003d client.create_namespace_tag("}],"source_content_type":"text/x-python","patch_set":7,"id":"ffc9f731_a3566815","line":62,"range":{"start_line":62,"start_character":42,"end_line":62,"end_character":75},"updated":"2021-10-18 14:39:45.000000000","message":"nit: self.project_id","commit_id":"b150a96dacb555c4592fa6b5e09289d131f58f93"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"6e0b5a3ae26cc09fcdeeee4cf99f424167cb1c37","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        client \u003d self.tags_alt_admin_client"},{"line_number":60,"context_line":"        namespace_tags \u003d []"},{"line_number":61,"context_line":"        for ns in namespaces:"},{"line_number":62,"context_line":"            if ns[\u0027namespace\u0027].startswith(self.tags_admin_client.project_id):"},{"line_number":63,"context_line":"                client \u003d self.tags_admin_client"},{"line_number":64,"context_line":"            tag_name \u003d \"tag_of_%s\" % (ns[\u0027namespace\u0027])"},{"line_number":65,"context_line":"            namespace_tag \u003d client.create_namespace_tag("}],"source_content_type":"text/x-python","patch_set":7,"id":"cd5c5e56_07f7c8b0","line":62,"range":{"start_line":62,"start_character":42,"end_line":62,"end_character":75},"in_reply_to":"ffc9f731_a3566815","updated":"2022-03-01 13:39:41.000000000","message":"Ack","commit_id":"b150a96dacb555c4592fa6b5e09289d131f58f93"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a1b67a4deb13d15645fa7476fbe17544d772c06b","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create_multiple_tags(self):"},{"line_number":71,"context_line":"        # Create namespace for two different projects"},{"line_number":72,"context_line":"        namespaces \u003d self.create_namespaces()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        client \u003d self.os_project_admin.namespace_tags_client"},{"line_number":75,"context_line":"        namespace_multiple_tags \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"1b6e2cac_f5894929","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":45},"updated":"2021-10-18 14:39:45.000000000","message":"I think you can modify create_tags method to create multiple tags rather than having separate method for the same.\n\nIMO there is no need to create separate namespaces for creating multiple tags.","commit_id":"8bbb004e2b307e937cad7c9b484ef083067ca545"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"6e0b5a3ae26cc09fcdeeee4cf99f424167cb1c37","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create_multiple_tags(self):"},{"line_number":71,"context_line":"        # Create namespace for two different projects"},{"line_number":72,"context_line":"        namespaces \u003d self.create_namespaces()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        client \u003d self.os_project_admin.namespace_tags_client"},{"line_number":75,"context_line":"        namespace_multiple_tags \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"d0f12d50_56d8c518","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":45},"in_reply_to":"1b6e2cac_f5894929","updated":"2022-03-01 13:39:41.000000000","message":"Done","commit_id":"8bbb004e2b307e937cad7c9b484ef083067ca545"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a1b67a4deb13d15645fa7476fbe17544d772c06b","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        namespace_multiple_tags \u003d []"},{"line_number":76,"context_line":"        tags \u003d [{\"name\": \"tag1\"}, {\"name\": \"tag2\"}, {\"name\": \"tag3\"}]"},{"line_number":77,"context_line":"        for ns in namespaces:"},{"line_number":78,"context_line":"            if ns[\u0027namespace\u0027].startswith(self.project_id):"},{"line_number":79,"context_line":"                client \u003d self.os_project_alt_admin.namespace_tags_client"},{"line_number":80,"context_line":"            namespace_tags \u003d client.create_namespace_tags("},{"line_number":81,"context_line":"                ns[\u0027namespace\u0027], tags\u003dtags)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9d0d7afb_229e5836","line":78,"range":{"start_line":78,"start_character":42,"end_line":78,"end_character":59},"updated":"2021-10-18 14:39:45.000000000","message":"I think this should be self.alt_project_id, ditto for line number 59","commit_id":"8bbb004e2b307e937cad7c9b484ef083067ca545"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"6e0b5a3ae26cc09fcdeeee4cf99f424167cb1c37","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        namespace_multiple_tags \u003d []"},{"line_number":76,"context_line":"        tags \u003d [{\"name\": \"tag1\"}, {\"name\": \"tag2\"}, {\"name\": \"tag3\"}]"},{"line_number":77,"context_line":"        for ns in namespaces:"},{"line_number":78,"context_line":"            if ns[\u0027namespace\u0027].startswith(self.project_id):"},{"line_number":79,"context_line":"                client \u003d self.os_project_alt_admin.namespace_tags_client"},{"line_number":80,"context_line":"            namespace_tags \u003d client.create_namespace_tags("},{"line_number":81,"context_line":"                ns[\u0027namespace\u0027], tags\u003dtags)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ea939a0f_9e159721","line":78,"range":{"start_line":78,"start_character":42,"end_line":78,"end_character":59},"in_reply_to":"9d0d7afb_229e5836","updated":"2022-03-01 13:39:41.000000000","message":"Done","commit_id":"8bbb004e2b307e937cad7c9b484ef083067ca545"}]}
